30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
9a42c59394
Bad hack to enforce weakly emitted RTTI for ScValidationDlg
...
...(by inlining all its virtual functions), as otherwise -fsanitize=undefined
makes sc require ScValidationDlg RTTI (to verify the cast to ScValidationDlg in
the ScValidityRefChildWin ctor in sc/source/ui/view/reffact.cxx) but which would
only be emitted in scui (against which sc cannot link).
Change-Id: Id9e2bf0719ba3bba35e5ae1f0e58190d9fdb6dd4
2014-08-20 17:02:59 +02:00
a107bdfdfc
ErrorBox->MessageDialog
...
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
5cb5c24cc6
RID_SCDLG_DAPISERVICE conversion to .ui
...
Change-Id: I4194af3033f6591c7a8ca219aebf2ef816edcd63
Reviewed-on: https://gerrit.libreoffice.org/10915
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-13 12:04:15 -05:00
a8525fe5cf
fdo#82418 prefer UTF-8 over UTF-16
...
Change-Id: Id2c990d24dc942a6d061146ea88cf53ee29a1c3d
2014-08-13 17:00:16 +02:00
f97eb186bf
coverity#735805 Explicit null dereferenced
...
Change-Id: I6641930b42f233096f4a0067ab320383ff07a72a
2014-08-07 18:00:50 +01:00
0db94ccc3f
Convert RID_SCDLG_DPSHOWDETAIL to .ui
...
Change-Id: If515e8f554f36e4ba203474d08d5ebe9caa023fa
Reviewed-on: https://gerrit.libreoffice.org/10739
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-04 19:22:05 +00:00
ab409bf7fb
Move this fucntion to ScDBDocFunc.
...
so that it could be usable from unit test.
Change-Id: Iea10cb473bc17d7e030c018fd2c84fbeccce3e47
2014-07-28 22:08:22 -04:00
a89f979dea
coverity#735805 dereference null value
...
Change-Id: I3782cffb19e45635076f19eb568fc547b9680b0d
2014-07-04 13:31:38 +02:00
d92aa2f445
remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
...
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
37e6631cc5
remove whitespace
...
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
45f533aee9
loplugin:staticcall
...
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-13 17:54:31 +02:00
bb761be472
Change SfxTabPage ctor SfxItemSet param from ref to pointer
...
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
a92e973b6d
Change SfxTabPage::Reset param from ref to pointer
...
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
4dbeadb9c1
Change SfxTabPage::FillItemSet param from ref to pointer
...
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
4c3b36073a
Bin ugly (ab)use of preprocessor in headers (final part)
...
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4
Only one is left: SC_PROGRESS_CXX
Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a
Reviewed-on: https://gerrit.libreoffice.org/9636
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-06-06 22:15:20 +00:00
cf62446302
coverity#735806 Dereference after null check
...
Change-Id: Ie7a05e694585bcc624bd69b4400d84a05fbc48fb
2014-06-06 21:28:27 +01:00
345d6dd9d9
Actually OK and Cancel is better here than Apply and Close.
...
Because the same dialog is used when creating a new pivot table, where
the Apply and Close semantic feels a bit weird. Also, some features of
the dialog were designed with Ok / Cancel in mind (like the destination
location).
Change-Id: I9ac889bca9f967cb97b34ab45ea563547b58d422
2014-05-27 11:29:25 -04:00
251507d097
Keep only "Apply" and "Close".
...
Change-Id: I963419baec24d7599ddb3e481738cbe6ec4e0a69
2014-05-21 21:35:51 -04:00
3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
e9c5f63f80
Avoid possible memory leaks in case of exceptions
...
Change-Id: I7dc862794f7f0973bd4de7b54f7a1fb15235bc3e
2014-05-15 23:45:08 +09:00
2bac61013e
fix-includes.pl: sc
...
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-11 01:55:39 +02:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
43c2f73fad
coverity#1210191 Uninitialized pointer field
...
Change-Id: I7b4161217ccd70d00bd43740719825ba19058bf7
2014-04-29 11:39:31 +01:00
4a1bcd90b9
coverity#1210194 Uninitialized scalar field
...
Change-Id: I6572f70c1c0eaa149759189c6b196281e74e218d
2014-04-29 11:39:31 +01:00
d1324645f5
coverity#1210198 Uninitialized pointer field
...
Change-Id: If72fff8b6cc7e5e55e1f395ddc34b4c5810faff3
2014-04-29 11:39:30 +01:00
37c3a1c097
const
...
Change-Id: I0ce6965f191d1455bcc7a793025282e20b7433a5
2014-04-27 17:01:46 +02:00
6dda3d45c9
sc: sal_Bool->bool
...
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-23 11:11:51 +02:00
40064f479b
clean up hrc files
...
and remove some unused stuff
Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
2dfd639916
fixincludeguards.sh: sc
...
sorry, huge one...
2014-04-19 11:10:10 +02:00
271c634e4f
coverity#1202968 Uninitialized scalar field
...
Change-Id: Ic226202bb1ce429f9dd8e13183ec64ffc9059d05
2014-04-16 11:23:13 +01:00
c28dccbf65
coverity#1202963 Uninitialized pointer field
...
Change-Id: I1cb588ce7df30886354ac0cf2bd81fb95a7e9d37
2014-04-16 11:23:13 +01:00
6994a32e2c
CID#1202973 init class members
...
Change-Id: Ib14d24970faa35ad0caf8c8a8bf7f9cef5764b89
2014-04-15 22:59:43 +02:00
141a87dd3c
Clean up function declarations and some unused functions
...
Change-Id: If2c233a8ced8815b065a72caff907f10ef6166ff
2014-04-14 15:41:27 +02:00
f767d4580e
callcatcher: update unused code
...
OAuth2Handler is from libcmis
Change-Id: Ia1986d6df7ab45580c66b4e536c5882af41f357f
2014-04-10 09:50:54 +01:00
e1bc666cda
convert data validation tab page to .ui
...
Change-Id: I1a4f1f4f06ec1ab0b28637380a8bfcb3bc64ee30
2014-04-09 11:01:53 +01:00
380d4600d7
use TriState instead of sal_Bool as there's three possibilities
...
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08 09:18:33 +01:00
c4c51709ea
whitespace cleanup in sc
...
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-06 17:19:54 +02:00
b501d837d2
coverity#708085 Uninitialized scalar field
...
Change-Id: If6aa0a955d8b80b2c1eb4d944829f46167b6fae9
2014-04-04 12:14:25 +01:00
d13f1ed261
callcatcher: remove old pivot table dialog
...
Change-Id: I9e80a0d6661c29343103a27baa752cebbc876314
2014-04-04 09:35:20 +01:00
f9636d50e6
pivot: duplicate data field handling
...
Change-Id: I3d367b8b638217f18143118df00324f21a0470f2
2014-04-03 21:40:42 +02:00
19d71217ab
pivot: Apply changes made in "Data Field" and "Data Field Options"
...
Change-Id: If8560d47c5b4e64367c441237c1e38f964cf6825
2014-04-03 12:19:37 +02:00
b53ff2865e
Fix various warnings
...
Change-Id: I78aa55539c2a3e522736bb178ba7d445300bf1f0
2014-03-31 10:22:13 +02:00
4f1f8b8e99
pivot: new pivot table layout dialog
...
This commit adds a new pivot table layout dialog which was implemented
from scratch. Instead of custom controls this one uses list boxes
for field entries which greatly reduces the code. It also fixes
some visual and behaviour bugs and adds the possibility to edit the
"Data" field.
Change-Id: I6c01252acee5a2e8910e40e65904504d00e03057
2014-03-31 09:44:44 +02:00
c08baae30c
coverity#1194918 Overflowed array index read
...
Change-Id: Ic9cec3fc6749672b30bb1e0c96159897e50a84e5
2014-03-29 21:15:21 +00:00
2e82733434
coverity#982764 Dereference null return value
...
Change-Id: Ib0f01bf529a739e5f92cd41979c18d76d7b545d1
2014-03-28 13:13:59 +00:00
a69209a415
coverity#982765 Dereference null return value
...
Change-Id: I2fd5d432aff737016948a4f7bd45888cf6f4dba2
2014-03-28 13:13:59 +00:00
