27182231ac
fdo#78555: Retain formula results when moving a range of cells.
...
* No need to re-compile RPN token array on reference change alone. We do that
when the formula contains one or more names that have been updated.
* Adjust undo code to get it to work without relying on ref undo document,
which would cause the token arrays to be unnecessarily recompiled.
* Whatever else need to be changed in order to pass all unit tests.
Change-Id: I99e86d23320aca8900fef011da23a9d34e42751e
2014-07-31 09:05:18 -04:00
1fcc305035
fdo#80846: Get the parameter order right.
...
It's column, row, tab in this order, not tab, column row.
Change-Id: I32e69a403feaf18532c7ac241fa2a98fc65a4ba7
2014-07-29 17:21:33 -04:00
300845922e
fdo#79578: Properly update formulas upon change in db collection.
...
Update it to handle formula groups correctly.
Change-Id: I009a7fcf3d3fb17ef6951c50534ca6bc1fffc259
2014-07-28 22:08:22 -04:00
14d2444432
This undo class is no longer used.
...
Change-Id: I8c53ba5bd839a6b8c8f65f05bb2b261a5bd02dbb
2014-07-13 18:34:07 -04:00
5c6ee09126
fdo#81309: Adjust references during sort.
...
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-13 18:07:14 -04:00
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
d92aa2f445
remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
...
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
37e6631cc5
remove whitespace
...
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
45f533aee9
loplugin:staticcall
...
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-13 17:54:31 +02:00
2fc4f5cd75
Register OpenGL windows to ScGridWindow upon file load.
...
Change-Id: I6fdce232ef41079f20a983dc72da032196078858
2014-05-19 16:03:28 -04:00
a93bb27aa4
fdo#78402: Adjust references of validity entries as appropriate.
...
Change-Id: I7fd62153c7267a3d606b86d74bebecf6b8d75250
2014-05-13 12:37:14 -04:00
2bac61013e
fix-includes.pl: sc
...
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-11 01:55:39 +02:00
a34a62b32d
loplugin:saloverride
...
Change-Id: I5c3b3c6212524430068e3fd8d9e9d259557bbea2
2014-05-04 12:52:54 +02:00
af7df25bcc
fdo#78062: Broadcast only on non-empty cells within deleted range.
...
We don't want to broadcast over the whole selected range, which may be
the whole sheet which is well over 1 billion cells !
Change-Id: I7c139ce5efe09312cf824e35f0efe551184032eb
2014-05-03 00:55:41 -04:00
f3816179a0
Avoid possible memory leaks in case of exceptions
...
Change-Id: Id1c7cb886a892bf0ce7be6774be5408afad44432
2014-05-02 16:40:07 +09:00
f2431c9443
add undo action for conditional formatting, cp#1000050, fdo#77381
...
Change-Id: I11db1e5824077135c4352ae43cc0e8d139244268
2014-04-24 23:39:56 +02:00
6dda3d45c9
sc: sal_Bool->bool
...
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-23 11:11:51 +02:00
1d1fbbe81b
fdo#74687: Undo & redo of format-only changes don't need broadcasting.
...
Also discovered that the undo path was broadcasting twice. Let's only
do it once.
Change-Id: I169f1659aecb1eb78be3a497e244f79c5883e50f
2014-04-16 15:22:27 -04:00
141a87dd3c
Clean up function declarations and some unused functions
...
Change-Id: If2c233a8ced8815b065a72caff907f10ef6166ff
2014-04-14 15:41:27 +02:00
52ba650bff
typo: reverese -> reverse
2014-04-14 12:32:36 +02:00
355baf5734
fdo#75741: Re-implement CompileNameFormula for formula groups.
...
Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7
2014-04-07 14:43:16 -04:00
c4c51709ea
whitespace cleanup in sc
...
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-06 17:19:54 +02:00
99809b246c
We should broadcast on reference move only when undoing move, not copy.
...
Change-Id: I8b60969312fd262ee8cd996c861e4d69f9ea3372
2014-03-15 09:39:02 -04:00
88955714d3
fdo#71491: Adjust reference during undo of drag-n-drop of cell range.
...
Also with this commit, the signature of SvtListener::Notify() changes,
by dropping the first argument which nobody uses. This change was necessary
in order to call it directly without needing to pass any broadcaster instance.
Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e
2014-03-15 00:15:06 -04:00
18909ddb30
fdo#75977: Clear sheet deleted flags for affected references when undoing.
...
This will allow formula cells to restore deleted references when they get
recalculated. With this change, SetDirty() that previosly took no argument
has been renamed to SetAllFormulasDirty(), and it now takes one argument that
stores context information.
Change-Id: If0de5dc1737a2722b6d61a87644b10a4f921edc5
2014-03-12 22:00:07 -04:00
b79fc2d0f8
coverity#1190369 Uninitialized scalar field
...
Change-Id: I4ded3314e99888d64b47814acde72cf13dd70ffe
2014-03-06 11:26:40 +00:00
84862db95a
Remove visual noise from sc
...
Conflicts:
sc/source/ui/inc/docfunc.hxx
Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8
Reviewed-on: https://gerrit.libreoffice.org/8301
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-03 11:04:44 -06:00
bf83deaeca
coverity#704711 Dereference after null check
...
Change-Id: I30e56ab58101a27acc9380031aabbac68fc74487
2014-03-02 20:08:18 +00:00
08c8ea386f
coverity#704710 Dereference after null check
...
Change-Id: I52ba4aed1dac93e3dbaa06cf70e690deac081b6e
2014-03-02 20:08:18 +00:00
c177e1cbec
Simplify ScViewFunc::DoThesaurus() with ScCellValue.
...
Change-Id: Ic5d31107aa7653cd8e3fae096888bd633696074f
2014-02-27 23:23:09 -05:00
cf70996311
Remove all uses of GetMarkRowRanges() and use GetMarkedRowSpans().
...
And ditto with its column variant. The former created a heap array of
1 million elements (=MAXROWCOUNT). There is no need for this memory
wastage.
Change-Id: I07845966c51cdcbdc676cd0d249f6420a19b9c5e
2014-02-27 21:35:02 -05:00
79d03eb090
fdo#75386: Totally fix reference update during range move.
...
It was just not working at all due to multiple reasons. The
reference update needed to be reworked for formula groups such that
the token array is adjusted only for the top cell but all formula cells
still needed to be processed afterwards. The bound check also needed
to be done against the old range prior to the move, not the new range
after the move.
During undo, the paint had to be deferred until after the two calls to
DoUndo() else the formula cells would get re-calculated before the
values were placed back to their old positions, causing them to mis-
calculate wrong values.
Change-Id: Iba66f80a413e0539cac5ab619226cd6f7a04f317
2014-02-25 22:53:39 -05:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
12f1faf7bf
svl: sal_Bool -> bool
...
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
ab5c5702ba
sal_Bool->bool
...
Change-Id: I2dad64e3d7ba90a9d2f4779697a02272b9ccad9f
2014-02-19 13:05:11 +02:00
b2460d7eef
sal_Bool->bool
...
Change-Id: I8991967ea122d73b83216573c5e014c4dd933fb9
2014-02-19 13:05:10 +02:00
37b48385d8
sal_Bool->bool
...
Change-Id: I9921d8a5d883e519f0345aedc7bc36c3e553105b
2014-02-19 13:05:10 +02:00
47f3b22854
sal_Bool->bool
...
Change-Id: I6c926b0b4dabd8c1dc0927f46ff76ff53d55920f
2014-02-19 13:05:10 +02:00
1118979789
sal_Bool->bool
...
Change-Id: I7e37926fc1e69da2b192a60df3b54807243c646f
2014-02-19 13:05:10 +02:00
45441c0a7f
sal_Bool->bool
...
Change-Id: Ibf4be192d751cbe733bbcb2855f5a4a5c6ea1644
2014-02-19 13:05:09 +02:00
e4841cd76c
sal_Bool->bool
...
Change-Id: I832d517825f5090e8b645c12075226809f7e3ffc
2014-02-19 13:05:09 +02:00
ee5a859262
sal_Bool->bool
...
Change-Id: If54ff898eab251c44901de67280e6d7fcb491966
2014-02-19 13:05:08 +02:00
1d12011d90
sal_Bool->bool
...
Change-Id: Ice620e8466c5eda76d065da1793b99ee4f94cbb1
2014-02-19 13:05:03 +02:00
e23b79e4fb
sal_Bool->bool, and remove unused parameters
...
Change-Id: I55a07cbcb7f388143f115d35b20daea96d1bed5d
2014-02-19 13:05:00 +02:00
d858c06847
sal_Bool->bool
...
Change-Id: I779608850fc81518c130e6f23d5dd1599a59fa14
2014-02-18 10:07:58 +02:00
d6d922be5e
sal_Bool->bool
...
Change-Id: Ie801378efed378a9daead57cb637a96fb51cf49a
2014-02-18 10:07:55 +02:00
575e88da27
fdo#75032: Handle note copying correctly.
...
Change-Id: I1b8fa5231b23554c856fb63b580cb13ea9223b08
2014-02-17 22:26:40 -05:00
9e49b6abe7
fdo#75032: Skip notes when copying values from undo document.
...
Notes undo redo are handled separately by the drawing layer.
Change-Id: Iae37ac86889d7a25f25e6dd0b69f724107c6798a
2014-02-17 12:24:47 -05:00
