Commit Graph

3327 Commits

Author SHA1 Message Date
8d57c90b02 WaE: unused function 'isGL3DDiagram'
Change-Id: I0af5bf5e7d36036b3f0c98d01c8549c2b8e1aa1f
2014-08-30 00:07:37 +03:00
8d509d69b4 This OpenGL window is useless
Change-Id: Ied9914c9a317dc3945c29b984d2a68957275fc52
2014-08-29 17:40:29 +02:00
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
1d1d1c62ca fdo#36772 Move the scrollbar and sheet tabs in a separate row.
Change-Id: I57d891d9f6e89dafb4840a577ba55baa734fdcc2
2014-08-25 21:34:48 +02:00
c6477b9dd1 nitpick no need for an extra indentation level
Change-Id: Id7ab390cc28e83ac0ca6b9fff1c172ca46e88a68
2014-08-25 16:20:50 +02:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
d40700d58e treat datetime as handled
Change-Id: Idc94174662eee5a75a6b467e47cbf9027e3ba224
2014-08-22 23:45:22 +02:00
0f4a999e02 current date/time hotkey inserts also if cell is in input or edit mode
Change-Id: Ib3caed607a5ca1b5ce82de0472223c7bdc8f7f54
2014-08-22 23:45:21 +02:00
e45001fad0 InsertCurrentTime: don't fiddle with the cell while editing
Change-Id: Ia12b10a44b7d90344a009753ddae801b7d58dddf
2014-08-22 23:45:21 +02:00
893d5f9973 Clean up line splicing and indentation
Change-Id: I2b9725052aeaeebef84ec9aedba639f6dda537ff
2014-08-20 15:44:59 +02:00
fdb7429bf5 update input bar with new value
If setting the number format isn't called we need to explicitly update
the input bar.

Change-Id: I60c4808ce86eb659d3faf92d368c5118ee9673b2
2014-08-20 13:43:33 +02:00
32e8c47df8 refine current date/time hotkey handling
Nearing the "do what I mean" principle..

* key date on time cell  =>  current date + time of cell  =>  date+time formatted cell
  * unless time cell was empty or 00:00 time  =>  current date  =>  date formatted cell
* key date on date+time cell  =>  current date + 00:00 time  =>  date+time formatted cell
  * unless date was current date  =>  current date  =>  date formatted cell
* key date on other cell  =>  current date  =>  date formatted cell
* key time on date cell  =>  date of cell + current time  =>  date+time formatted cell
  * unless date cell was empty  =>  current time  =>  time formatted cell
* key time on date+time cell  =>  current time  =>  time formatted cell
  * unless cell was empty  =>  current date+time  =>  date+time formatted cell
* key time on other cell  =>  current time  =>  time formatted cell

Change-Id: I5025e0d0ea9ac83d1b9e0b130262df6db4693a56
2014-08-20 13:43:31 +02:00
a1a480f91e Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
2014-08-20 09:01:41 +03:00
5a05115ee2 more flexible handling of current date/time hotkeys
Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa
2014-08-19 21:54:46 +02:00
11f145d90f a date is a date, without time
And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b
2014-08-19 21:54:44 +02:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
6e53a179bb fix wrong calculation for text size, fdo#81499
Change-Id: Ifd9e09dd9e1d843728e1874c48efdd127bffe11e
2014-07-30 14:06:22 +02:00
190a4ee599 Revert "it makes no sense to use the second column as well, fdo#81499"
This reverts commit 14277af57b397b03b753a61c22cc5211e43a5f82.

There is a reason why we do this, to allow misspelled word outside the
cell area to be right-clickable.
2014-07-29 13:45:42 -04:00
5021f29841 Remove some unused code
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 14:20:36 +00:00
300845922e fdo#79578: Properly update formulas upon change in db collection.
Update it to handle formula groups correctly.

Change-Id: I009a7fcf3d3fb17ef6951c50534ca6bc1fffc259
2014-07-28 22:08:22 -04:00
ab409bf7fb Move this fucntion to ScDBDocFunc.
so that it could be usable from unit test.

Change-Id: Iea10cb473bc17d7e030c018fd2c84fbeccce3e47
2014-07-28 22:08:22 -04:00
20f6cf0377 Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-26 14:25:33 +02:00
cc827ab81d Revert "opengl charts: Move the init from sc to chart2 ...
This reverts commit 46cea34638b371570073c0e86f79969753c543ed.

Conflicts:
	chart2/source/view/charttypes/GL3DBarChart.cxx

Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-23 22:19:58 +02:00
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
14277af57b it makes no sense to use the second column as well, fdo#81499
Change-Id: If5990d41f444a2d051c9b9029d61ffd8b8cf377e
2014-07-20 23:05:41 +02:00
46698bfa03 that was just a complex way to describe that the whole range is in it
Change-Id: Ib204b6ab39872280c8889615170735ed8c1fc811
2014-07-20 23:05:40 +02:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
1e6ff8f7f8 XFillStyle -> css::drawing::FillStyle
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-19 00:30:37 +02:00
1aba46ee67 coverity#1226486 Dereference null return value
Change-Id: I9157f1844923e3e6ac360e859ee2cd97c33512ba
2014-07-18 15:36:20 +01:00
642d64d8fe scrolling very slow in calc
even on a short spreadsheet scrolling up and down leaves
the first/last row (depending on the direction of scroll)
unchanged until the scrolling stops.

http://people.freedesktop.org/~mst/calc_4.2_scrolling.webm

On larger document there are rendering artifacts during scrolling which go away
after scrolling for me and mstahl, but a bunch of people can show us piles of
horribly broken spreadsheets after scrolling, esp wheel scrolling

Revert "fdo#75026: Sometimes we need to update grid view...

while not being active."

This reverts commit 52cc88d6191ba0c4b6477e5c4b9c5d0f0228030d.

Revert "fdo#68961: Check visible range during scrolling, and re-paint if necessary."

This reverts commit e36c8a674845ab19577fc06d44b780549757e1e7.

Revert "Repaint grid view when the visible area changes."

This reverts commit b54c1a53b4d400b1c2d282c186af1fa8f151894e.

Conflicts:
	sc/source/ui/app/scmod.cxx

Revert "Update visible ranges when updating the scroll bars."

This reverts commit 391a57ef65687f2e373bac8d410e551aafa780ec.

Change-Id: Ie170308cba18a9a74c7c72daf07dfa0a4ef7bd13
Reviewed-on: https://gerrit.libreoffice.org/10350
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-17 13:05:21 +00:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
4ce9e4a68f Head cleanup - use forward declarations.
Change-Id: Icc4fa0acad77d61200eb77cc70e21866590b658e
2014-07-10 14:13:57 -04:00
902b7e9f19 draw white border around note marks for fdo#81032
also translate the mark to make cell border visible

Change-Id: Ifa9f3befd1e25a66cc3443a3f33255603feea6a6
Reviewed-on: https://gerrit.libreoffice.org/10135
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-08 11:05:57 +00:00
4228f08d60 use assert when followed by deref
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
b382f5df84 coverity#705845 Dereference before null
Change-Id: I4aecc132ca45abd45183455c87be4c4a3749d983
2014-07-01 16:20:01 +02:00
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
5da5882df4 Add tiled rendering outline to Calc.
(No real implementation yet.)

Change-Id: I67b84b554dbb29db449d8c190ef816645a8bff07
2014-06-25 13:04:33 +01:00
37e6631cc5 remove whitespace
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
b8d84a3bf5 Resolves fdo#76160 Calc invalid image position on zooming
Change-Id: Idd268a3378a902c173dc4d75d879714c2e919b2d
Reviewed-on: https://gerrit.libreoffice.org/9792
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-06-24 21:25:40 +00:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
45f533aee9 loplugin:staticcall
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-13 17:54:31 +02:00
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00