Commit Graph

842 Commits

Author SHA1 Message Date
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
aa1d3d5eea Partial revert of d4cf8c2518c77631f91db8564bf3a506f0ab8e70
"Generally better to have DLLPUBLIC class with some DLLPRIVATE members."  MSVC
over-eagerly also treats the SdStyleSheetPoolBase template specialization as
dllexport and fails to generate code for the ImplInheritanceHelper4() ctor
because the SfxStyleSheetPool base class has no default ctor.

Change-Id: I656c898ebd3d4ca58785084c5aeed4fa670cb7e0
2014-08-18 15:31:41 +02:00
d4cf8c2518 Generally better to have DLLPUBLIC class with some DLLPRIVATE members
...in the same vein as 80a1a2599e04142683d2286d0e32d0e13fb45de3.

Change-Id: I330665957aec2c9b98c7aff7fa7f25525e4cdf7d
2014-08-18 14:14:47 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
4347d84464 fdo#75757: remove inheritance to std::vector
Change-Id: I5781799bbd8cc321ff7f659013c6cf68b3253989
Reviewed-on: https://gerrit.libreoffice.org/10868
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12 02:58:54 -05:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
6216eee4b9 Impress Remote: allow removal of authorised remotes.
Previously authorising a device meant that it would have access
forever -- we now list previously authorised remotes in the remote
dialog, along with controls to allow removal of such remotes.

Change-Id: I4179739f3a2ba0a8fe19c2a0cd0cbbece9cb4352
2014-06-30 07:45:17 +02:00
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
43b0a48596 can't have bare english strings in .cxx
Change-Id: I1a14e37f3362c082bc460895ffd0b949c636b8ea
2014-06-23 14:12:43 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
448c62835b SdStyleSheetPool::GetBulletFont can be static
...that's why the problem fixed in 0466c0dcddd3b5af02c711794e8cd4c3c6c12993 "Set
mxStyleSheetPool before using it" had never caused trouble in practice (and its
change to SdDrawDocument ctor can be reverted again)

Change-Id: I662995ab4fcaa7ae461cb9575666825d8a869735
2014-06-13 18:09:20 +02:00
8a5b397105 Resolves: fdo#78151 change style on toggling bullets on master page outliners
"do what I mean"

In master pages prior to this if we toggle bullets on and off the that changes
the *level* of the paragraph. And because the paragraph is effectively a
preview of the equivalent style level, changing the level disconnects it from
the style which is useless for us.

So instead turn the numbering off at the given outline level. In order to
toggle the numbering back split the defaults-setting into a reusable piece that
sets the numbering indent which we can call to toggle numbering back on

Also split out the broadcast style change *and explicit child* broadcast code
into a reusable method, the absence of which left me stumped for well over an
hour as to why my changes only worked on level 1

Change-Id: I311c7f35f1ca7dff1d151c6141ff5faa7f15c5a2
2014-06-13 17:06:06 +01:00
b9daf7cacd coverity#735840 Unchecked dynamic_cast
Change-Id: I3c772ec30360103f569b34e7c83f65b469eb5be8
2014-06-12 14:12:03 +01:00
efd6106f09 de-virtualize these stringify methods, nothing overrides them
Change-Id: Id523ae3f50147fd778a1576c2851d01e1ea8c3ae
2014-06-09 16:24:40 +01:00
1817366cb5 gbuild: remove config_libraries.h and gb_Helper_generate_config_libraries
This much ugly complexity, generating a header on every gbuild startup
etc. is really not warranted for 6 callers of the generated macros.
Also, the Win32 make has problems with the quoting.

Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
2014-06-09 17:05:50 +02:00
7e600aca08 Related: fdo#78151 force outliners in master view to be read-only text
because these contain place-holder text and it doesn't make sense
to be able to edit them (unless some-day we support custom place-holder
prompts)

because they are now read-only add a pair of "show next level" and "hide
last level" features so on right clicking the last outline paragraph
you can make the next one visible, or make the last one invisible

Change-Id: Iea24d810f298156cfe2f32aa53d0515da45e08eb
2014-06-09 09:23:58 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
1f0b7e5dc4 coverity#704728 Unchecked dynamic_cast
Change-Id: I2db2d6ffdca1775f21969b523ede56b3fb3fd682
2014-05-30 11:48:59 +01:00
5e62d30fa2 update_pch
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28 15:53:10 +02:00
05e2fd162e Related: fdo#79142 make SetName default to Reindexing
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28 13:25:12 +01:00
91e8185802 coverity#983778 Uncaught exception
Change-Id: I27ebb40f21a15c7e1696217a53d8c07e1d1161ad
2014-05-26 15:51:54 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
584b415924 Keep only one class for toolbox color controls
instead of 5 (mostly identical) classes.

Also the following bugs were fixed:

* All pickers now use split buttons. (fdo#45671)
* Color palette now indicates the current color. (fdo#73891)
  (Previous changes related to that bug are reverted as part
  of this commit.)
* Selecting a color from a float panel now updates the
  button. (fdo#77683)
* For Font color/background color in Writer, the color
  that is shown on the button, is always the one that's
  actually used. (Can be a different color after hiding
  the toolbar.)
* For Font color/background color in Writer, the button
  now indicates when we're in the format paintbrush mode.
  (Removed in 085e8a07e61ef2d3a82e11094d8773ab17cfdb3c
  for some reason.)

Change-Id: Idb4829552240c52fb0882aca627c8177bbe2f839
2014-05-14 12:39:42 +03:00
569ff6727e update_pch: add a bunch of pch files
I had to fix some source files because of macro redefinitions and such stuff.

Small modules like basic have a great win, too:

make basic.clean && time make basic:

                with    w/o
                 pch    pch
accessibility    23s  1m59s
basctl           30s  1m42s
basic            56s  1m35s
comphelper       23s    51s
editeng          48s  2m04s
forms            40s  1m40s
unotools         19s    38s
sd             3m37s  4m33s

Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09 19:50:42 +00:00
e6ac6cbccf automaticly -> automatically.
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
2014-04-27 01:28:55 +02:00
b45a12c37d sd: sal_Bool->bool
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-04-24 10:53:17 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
29d5ce2d88 sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-18 22:51:06 +02:00
fe51a3aa9e Fix symbol visibility
Change-Id: I3d25b1363ea49dc65a1cae0925504b8c442f6e65
2014-04-15 09:27:04 +02:00
8f7a1111ab update_pch
Change-Id: I099bff66a7796a5cf18e37e445467bdfb33de602
2014-04-14 20:21:10 +02:00
1531b523bf Clean up function declarations and some unused functions
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14 17:55:32 +02:00
28c2c28941 typo: givin -> given 2014-04-14 12:32:15 +02:00
5452e86cd9 typo: wraper -> wrapper 2014-04-14 12:32:14 +02:00
7de86e695a typo: caling -> calling 2014-04-14 12:32:14 +02:00
39b26e4466 typo: ommit -> omit 2014-04-14 12:32:13 +02:00
7328e577e2 typo: stoped -> stopped 2014-04-14 12:32:12 +02:00
e5a05de950 typo: iteratioin -> iteration 2014-04-14 12:32:11 +02:00
74f343e94d typo: reassings -> reassigns 2014-04-14 12:32:11 +02:00
bb667fc1b9 typo: arround -> around 2014-04-14 12:32:10 +02:00
52a41a0b74 typo: desribes -> describes 2014-04-14 12:32:09 +02:00
12a881ec05 typo: inidcates -> indicates 2014-04-14 12:32:08 +02:00
c650d61135 typo: candiate -> candidate 2014-04-14 12:32:08 +02:00
90f80fd66b typo: remebers -> remembers 2014-04-14 12:32:07 +02:00
2a7f68c776 typo: deppending -> depending 2014-04-14 12:32:06 +02:00
e8836a3de8 typo: direclty -> directly 2014-04-14 12:32:06 +02:00
f75aa26620 typo: hierarchie -> hierarchy 2014-04-14 12:32:05 +02:00