Commit Graph

1170 Commits

Author SHA1 Message Date
5b63c12ace n#708518: sd: check that master page matches when setting parent style
In ODF import it happened that the parent style of "outline2" etc.
was always set to the "outline1" style of the first master page in
the document, but it should be the "outline1" style of the same master
page as the "outline2".

(regression from e955433c3574cb602dedba96bc645898f97858bf)

Change-Id: Ie563d5ee5c2040aeb6ca5c8bb25b195e15ea964e
2014-08-29 19:18:42 +02:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
f47baab6d3 Resolves: fdo#82355 crash on loading ppt
regression probably triggered by...

commit 2e3c45afc6c5ea74f1f8b4a7dce806e537870546
Date:   Fri Mar 4 07:38:16 2011 -0800
Remove usage of deprecated List container.

but that just stopped at the first NULL by chance

Change-Id: I767e3bc3130d99cedceb4172857d1741c677b19b
2014-08-19 20:49:17 +01:00
759f5d24b0 Consistency around XColorItem in svx/sdshcitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18 18:18:08 +02:00
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
a51c423743 Consistency around SdrMetricItem in svx/sdsxyitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-18 10:55:36 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
6ec885c9ff warning C4245 signed/unsigned mismatch
Turns out that mnVisiblePageCount is actually never read.

Change-Id: I6bded733bb551525a6143976ad4c4447a5a56773
2014-08-13 23:12:48 +02:00
5ecec388bb Consistency around SdrYesNoItem in svx/sxmsuitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
2014-08-07 11:27:26 +02:00
7627008b06 Clear() an SdPage while it is still an SdPage
... because when Clear() is later called in the SdrObjList sub-object dtor,
freed SdrObject dtors may call back via SdrObject::SendUserCall into this
virtual SdPage::Changed, but then this is only an SdrObjList, causing undef
behavior.

Change-Id: I09a2d1445a51a70e8f795ff869027899ad0f528b
2014-08-05 14:17:22 +02:00
8d023edc18 Consistency around SdrOnOffItem in svx/sdshitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-05 08:59:37 +02:00
151fbebf8c Consistency around SdrOnOffItem in svx/sdtagitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04 19:22:55 +02:00
768d32cf5b Consistency around SdrMetricItem in svx/sdtditm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-04 11:29:51 +02:00
68969cc61a Consistency around SdrMetricItem
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31 15:57:12 +02:00
798379313d fdo#76754 Speed up registration of new listeners to SfxBroadcaster
Also change behavior for the GetListenerCount() method which now
returns the count of listeners.

The previous behavior is available in method GetSizeOfVector().

Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89
Reviewed-on: https://gerrit.libreoffice.org/10344
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22 06:26:06 +00:00
1e6ff8f7f8 XFillStyle -> css::drawing::FillStyle
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-19 00:30:37 +02:00
61cf536f04 fdo#80020 Fix regression for style sheet inheritance
The inheritance relationship of styles in Draw was lost when writing files.

Change-Id: I81588a031bf4c649338fad9b7342fbbe11df9aef
Reviewed-on: https://gerrit.libreoffice.org/10309
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-15 09:24:37 +00:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
22f244ae45 Background color in defaults for named presentation layout
Change-Id: I0f65476a545cdd080768e00161ab4a7682acc359
(cherry picked from commit 3ae8a7302c2c145867ae2072f3ba477ba1b3e0a4)
2014-06-30 22:54:41 +02:00
6216eee4b9 Impress Remote: allow removal of authorised remotes.
Previously authorising a device meant that it would have access
forever -- we now list previously authorised remotes in the remote
dialog, along with controls to allow removal of such remotes.

Change-Id: I4179739f3a2ba0a8fe19c2a0cd0cbbece9cb4352
2014-06-30 07:45:17 +02:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
533c6cb6ba fixes for up-casting to Reference<XInterface>
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
229b8f9122 Resolves: #i125090# The values of upper and lower spacing...
for default paragraph did the complete opposite.

(cherry picked from commit 75f191b09f25e4dd357f42fdf80c2b0252d1c410)

Conflicts:
	sd/source/core/stlpool.cxx

Change-Id: Idd44f7f1e4ad6acbde2733240fd357e628ac1f28
2014-06-24 10:52:20 +01:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
32294e11a0 coverity#706052 Unintended sign extension
Change-Id: I5e9b8a8809f9736038f20493d1a24bbbd8846dbd
2014-06-19 10:26:47 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
448c62835b SdStyleSheetPool::GetBulletFont can be static
...that's why the problem fixed in 0466c0dcddd3b5af02c711794e8cd4c3c6c12993 "Set
mxStyleSheetPool before using it" had never caused trouble in practice (and its
change to SdDrawDocument ctor can be reverted again)

Change-Id: I662995ab4fcaa7ae461cb9575666825d8a869735
2014-06-13 18:09:20 +02:00
8a5b397105 Resolves: fdo#78151 change style on toggling bullets on master page outliners
"do what I mean"

In master pages prior to this if we toggle bullets on and off the that changes
the *level* of the paragraph. And because the paragraph is effectively a
preview of the equivalent style level, changing the level disconnects it from
the style which is useless for us.

So instead turn the numbering off at the given outline level. In order to
toggle the numbering back split the defaults-setting into a reusable piece that
sets the numbering indent which we can call to toggle numbering back on

Also split out the broadcast style change *and explicit child* broadcast code
into a reusable method, the absence of which left me stumped for well over an
hour as to why my changes only worked on level 1

Change-Id: I311c7f35f1ca7dff1d151c6141ff5faa7f15c5a2
2014-06-13 17:06:06 +01:00
c6eb208473 loplugin:staticcall
Change-Id: I502702dfd04405748a314bd171e6298850777c0a
2014-06-13 17:54:31 +02:00
0466c0dcdd Set mxStyleSheetPool before using it
Change-Id: Id5ce3555c487aa7abcf97855a036663c91dd28b1
2014-06-13 12:08:04 +02:00
b9daf7cacd coverity#735840 Unchecked dynamic_cast
Change-Id: I3c772ec30360103f569b34e7c83f65b469eb5be8
2014-06-12 14:12:03 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
1e9ce046a3 coverity#705215 Missing break in switch
Change-Id: I52cf32e9349e547e3445fbb266a74495d69aaa3f
2014-06-05 13:35:50 +01:00
1f0b7e5dc4 coverity#704728 Unchecked dynamic_cast
Change-Id: I2db2d6ffdca1775f21969b523ede56b3fb3fd682
2014-05-30 11:48:59 +01:00
05e2fd162e Related: fdo#79142 make SetName default to Reindexing
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28 13:25:12 +01:00
91e8185802 coverity#983778 Uncaught exception
Change-Id: I27ebb40f21a15c7e1696217a53d8c07e1d1161ad
2014-05-26 15:51:54 +01:00
957ad07e6b Remove redundant checks
Change-Id: I4357e425e0459c9cc8873eba8a8ed1c5a34e9327
2014-05-24 22:09:08 +02:00
f4166f967b sal_uInt16 to size_t
Change-Id: I46d85e82376a3135408ab77ad31b76a5edbe9ce7
2014-05-24 22:09:08 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
227af32d8c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
c47f9cc187 coverity#705853 Dereference before null check
Change-Id: I0ef6645725699004d3ec93737135fe18640b1079
2014-05-11 21:06:01 +01:00
00c6053bd3 coverity#736795 Dereference before null check
Change-Id: Ic96095d6c8bf6a0ecb05452f2411d025e3965a57
2014-05-11 21:06:00 +01:00
2241dd8d83 SdStyleSheetPool: de-dent that
Change-Id: Ifce20de3068e12c42bfcd115ad852371f97b971c
2014-05-10 23:14:19 +02:00
3440766f0a SdStyleSheetPool: fix numerous regressions when copying in Draw...
... from commit 0c17ccc493d0c7a80f37600dae76a09a119bef78.

Change-Id: Ib0848da26091899961c5ed95879f9306b13653dd
2014-05-10 23:14:18 +02:00
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-10 06:19:42 +02:00
df71f13b80 rhbz#1071604 don't crash if slide layout configs are missing
Change-Id: I5cbf4ed0683cc5736a45fb980827b1b56bd0c74c
2014-05-09 13:09:52 +02:00
76e8779787 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part6
Change-Id: Ib523206d67ad13416557be1b37a58ba7a9791ca5
2014-05-08 18:12:58 +02:00