Commit Graph

11415 Commits

Author SHA1 Message Date
4dbd58abb4 Partially revert: fixincludeguards.sh: sd
Doesn't look this sane...

 commit 3b58ababc566adef48d8ab600489e554c4585b1d
 Author: Thomas Arnhold <thomas@arnhold.org>
 Date:   Wed Oct 23 22:38:46 2013 +0200

    fixincludeguards.sh: sd

Change-Id: Ia6836deaa1982febf71cd8abd89e93ea0a844721
2014-09-01 23:08:48 +02:00
9f6018bb64 Consistency around SfxBoolItem in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
2014-09-01 14:46:50 +02:00
bebe30e917 Consistency around SfxUInt32Item in svx/svx3ditems.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3
2014-09-01 13:37:27 +02:00
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
e0c2ea6bde Consistency around SdrMetricItem in svx/sderitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I4a0715b18bc3aa032779252cad2450c905a467a4
2014-08-25 17:25:40 +02:00
57a4337e25 set names on a bunch more threads...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
7b31e45ec7 Make Draw use paper size when printing - fdo#63905
Previously, Draw/Impress use the default size from the printer.
Now Draw uses the paper size (specified in page formatting).
Impress still uses the old method - not sure if this is correct
but printing handouts etc probably complicate print/paper size.

Change-Id: If90bae4ac59cd95dd50fcd8deb25fd900756193e
Reviewed-on: https://gerrit.libreoffice.org/9866
Reviewed-by: Matúš Kukan <matus.kukan@collabora.com>
Tested-by: Matúš Kukan <matus.kukan@collabora.com>
2014-08-19 03:34:34 -05:00
fd63ba4574 Fix Insert 3D Model file dialog's "All supported formats" filter
It seems on some system the file dialog does not like spaces
between the formats.

Change-Id: Ifa69f4f210061209f7f0aa9223417d06b06b577a
2014-08-19 10:09:37 +02:00
8957c9419a error C2296: '<<' : illegal, left operand has type 'const char [28]'
Change-Id: Ibc25771002bd8ac9b4a2aca9f3c2965b8da9014e
2014-08-19 07:34:51 +02:00
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
7ebdd05613 SD_TOOLBOX is never defined outside toolbox2_tmpl.src
Change-Id: Ie6d05762baae87794e9320a6b123ef326289e4c1
2014-08-18 05:01:41 +02:00
e50bcaf729 STRING -> String
Change-Id: I084d99fdd1a34842178b59c17ab108750f7bd11d
2014-08-18 04:31:05 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
d7e5ad0bb2 warning C4189 local variable initialized but not referenced
Change-Id: I6047e0fc10bb6de0009da40855a97df89904cb0c
2014-08-13 23:43:36 +02:00
3b9e7f49ef Ignore exception when service ScannerManager is unavailable
Exception from an unavailable service ScannerManager propagated to
the top. This caused that presentations in android crashed
(DrawViewShell wasn't initialized).

Change-Id: I485d0cdad05e4d2d6096042e5762c0350a8339a9
2014-08-13 09:27:47 +02:00
8a1ad93aa4 reduce code duplication
Change-Id: Ie5910239d7a54a29262e556af779bda9fa2dddca
2014-08-13 09:27:47 +02:00
904fdac93b fdo#81933 do not select 1st slide unconditionally
This is a regression from commit
ad0c4bf5790546242884da0c2ec281f2db9e14a0 . But I do not see why this
code would be needed for that either.

Change-Id: Ied3a5d25b2bec9542aa83c4d7fa36ed5313fc797
2014-08-11 16:47:49 +02:00
ba7578401b LOKit: ensure DrawViewShell is available (prevent crash)
Change-Id: Id143f5fabdcb8b7451d750563c76b77f9c3787a3
2014-08-10 23:00:46 +02:00
16b1b63f2e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Ib769dbbcb78e9440805aee40019ab98cd52e8477
2014-08-08 15:11:05 +02:00
155026bfc4 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I610172167c49afa3989aa1626b10b8aaa1f91578
2014-08-08 14:49:40 +02:00
6aed6cbd4a Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Icb959b7e2e8558f251d4bfd3b21124ca31132183
2014-08-08 14:07:22 +02:00
47999a4304 cppcheck: va_list 'args' was opened but not closed by va_end()
Change-Id: Id7602dd19ac142dbe2680ddf7eab308a087e971a
2014-08-07 20:36:26 +02:00
191f0944fd Handle collada libraries seperately: --disable-collada
Depends on gltf support.

Change-Id: Ief0452da3d03b0ddbca45272e5f5cd268691aeca
2014-08-07 15:42:57 +02:00
14ac70c74a Consistency around SdrMetricItem in svx/sxelditm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

(SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly
---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing
SdrEdgeLine1DeltaItem::Clone override" before
3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue
are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless
derivation of SdrMetricItem.)

Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
2014-08-06 12:54:53 +02:00
42172ea647 Let GetObjectItemPool return a reference
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
2014-08-05 23:04:07 +02:00
3c57701cf0 fdo#81552 Fail nicely if avahi doesn't let libreoffice publish items
Change-Id: Ie264a032a71bda336158e18bd2b14c569f23f42d
Reviewed-on: https://gerrit.libreoffice.org/10735
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-05 18:42:59 +00:00
927da5e017 GetPage requires mpPage to be an SdPage
...which is apparently not always the case; at least observed that during
CppunitTest_sd_html_export_tests.

Change-Id: If3d73249845adfa6b489e783693768e755033f4a
2014-08-05 13:33:58 +02:00
c05105151b Avoid undef out-of-range value -1 for XPropertyListType enum
Change-Id: If2dedafe6d8517eba4dd4921d15dd2d969d181dd
2014-08-05 12:10:11 +02:00
151fbebf8c Consistency around SdrOnOffItem in svx/sdtagitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04 19:22:55 +02:00
02f0102b8b prevent memory leak
Found by Lsan.

Returning this or a heap allocated object asks for trouble. Let the
caller handle it and return null instead of this.

Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467
Reviewed-on: https://gerrit.libreoffice.org/10716
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-04 12:49:59 +00:00
768d32cf5b Consistency around SdrMetricItem in svx/sdtditm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-04 11:29:51 +02:00
a24e9c29d5 bnc#862514: Handle corner case in slide sorter correctly.
We should never return -1 when bIncludeBordersAndGaps is true; but that could
have happened in a corner case:

* export SAL_USE_VCLPLUGIN=gen
* start LibreOffice
* open a presentation with many slides
* resize the window so that it shows the slides _exactly_, no slide is cut
  off in the slide sorter
* point the mouse pointer into the left "Slides" sidebar (slide sorter) so
  that it does not cause any mouse-over effect (somehow between the left
  border, and the slides - there is space that can do this)
* turn the mouse wheel all the way down so that the last slide is at the
  bottom
* turn the mouse wheel up _once_
* turn the mouse wheel down _once_ - it will look like the view does not
  change (the last but one is still at the bottom), but you can see the
  scrollbar jump to the top
* and now you can again start turning the wheel all the way down to repeat
  the procedure :-)

Change-Id: I0253c89513222a1f2eb3263068997d10eea0f130
2014-08-01 21:18:00 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
53e4b24c9e WaE: 'aPageKind' may be used uninitialized in this function
Change-Id: Idb44259f11715b1d2c769bfebca7300cc397b7cf
2014-07-31 21:16:54 +03:00
68969cc61a Consistency around SdrMetricItem
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31 15:57:12 +02:00
7e0e581c16 cleanup usage of MapUnit enum
some places were using the wrong enum constant, and some places were
unnnecessarily converting to sal_Int16

Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31 11:38:48 +02:00
65803ad94c fix some dodgy FieldUnit conversions
the FieldUnit enum was being converted in some dodgy ways and
in some places the MapUnit enum values were being used.

Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-31 11:38:47 +02:00
b3375a273e Impress/Tiled Rendering: implement setPartMode.
Change-Id: I831953ac3fa1d0a15b64aa008cc3bfb79e72575a
2014-07-30 12:44:04 +02:00
0dc6db6faf Impress/Tiled Rendering: return correct number for getPart.
It looks like page ids begin with 1.

Change-Id: I367285b8cfa1fcc9b8f22a9bb3c679d7e9579099
2014-07-30 12:44:03 +02:00
a965dfd7ea Impress: Implement getPartName.
Change-Id: I614838505fef901fc37e8d3906bb59c60b034453
2014-07-30 12:44:02 +02:00
551f76f410 Drop unnecessary SfxApplication::CreateResManager wrapper
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-29 14:27:43 +02:00
7ce763089b coverity#704759 Dereference after null check
Change-Id: I1f41d2bc43391175a4587f501f02775adc43bc8e
2014-07-26 21:25:19 +01:00
a01783051a coverity#704753 Dereference after null check
Change-Id: I4886995b925e3332e67d08a60e53a251be9f81e5
2014-07-26 21:25:18 +01:00
c8bb0b2416 coverity#704748 Dereference after null check
Change-Id: I88552b40658df85bbfbf0848e94085aa8eb649b6
2014-07-26 21:25:18 +01:00
20f6cf0377 Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-26 14:25:33 +02:00