Commit Graph

1064 Commits

Author SHA1 Message Date
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
7ebdd05613 SD_TOOLBOX is never defined outside toolbox2_tmpl.src
Change-Id: Ie6d05762baae87794e9320a6b123ef326289e4c1
2014-08-18 05:01:41 +02:00
e50bcaf729 STRING -> String
Change-Id: I084d99fdd1a34842178b59c17ab108750f7bd11d
2014-08-18 04:31:05 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
16b1b63f2e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Ib769dbbcb78e9440805aee40019ab98cd52e8477
2014-08-08 15:11:05 +02:00
551f76f410 Drop unnecessary SfxApplication::CreateResManager wrapper
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-29 14:27:43 +02:00
b55b96589f sd: stop calling graphics styles "Image Styles"
(regression from a71a562a9958fc58a5fb914bcf7f8056a353f618)

Change-Id: Ie3a44a80c720f59831bc2b1da91792fb8aa24d62
2014-07-14 18:57:45 +02:00
4523dd0544 Called C++ object pointer is null
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
7e600aca08 Related: fdo#78151 force outliners in master view to be read-only text
because these contain place-holder text and it doesn't make sense
to be able to edit them (unless some-day we support custom place-holder
prompts)

because they are now read-only add a pair of "show next level" and "hide
last level" features so on right clicking the last outline paragraph
you can make the next one visible, or make the last one invisible

Change-Id: Iea24d810f298156cfe2f32aa53d0515da45e08eb
2014-06-09 09:23:58 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
205801782d sd: Use correct SID instead of 0
Change-Id: I181519578b2984463ad20f4b028917bcb49ba4d0
2014-05-18 14:50:57 +03:00
584b415924 Keep only one class for toolbox color controls
instead of 5 (mostly identical) classes.

Also the following bugs were fixed:

* All pickers now use split buttons. (fdo#45671)
* Color palette now indicates the current color. (fdo#73891)
  (Previous changes related to that bug are reverted as part
  of this commit.)
* Selecting a color from a float panel now updates the
  button. (fdo#77683)
* For Font color/background color in Writer, the color
  that is shown on the button, is always the one that's
  actually used. (Can be a different color after hiding
  the toolbar.)
* For Font color/background color in Writer, the button
  now indicates when we're in the format paintbrush mode.
  (Removed in 085e8a07e61ef2d3a82e11094d8773ab17cfdb3c
  for some reason.)

Change-Id: Idb4829552240c52fb0882aca627c8177bbe2f839
2014-05-14 12:39:42 +03:00
d6f5d4ee2c add a status bar icon to fit slide to window
Change-Id: I2c1d1fc7425b0aaad2a2445e0ac71ddc38410fdb
2014-05-08 14:48:22 +01:00
d386da8bb3 coverity#735832 Explicit null dereferenced
Change-Id: Ifcce7f0d75cb595add30a4403e5c42348043137b
2014-05-07 15:47:25 +01:00
b45a12c37d sd: sal_Bool->bool
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-04-24 10:53:17 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
e735b48e21 Resolves: #i63399# add to clipboard as URL only when...
no fill and no line style, just a simple URL

(cherry picked from commit a91b5943b2c971ff1e69f5c2da45b8a647562676)

Change-Id: Ic8bd02c81663575355a0ca79e4987b5ef0e4a445
2014-04-23 11:22:49 +01:00
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18 22:51:06 +02:00
8c3ab6093a sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
2014-04-18 22:51:06 +02:00
0fcab91da2 Counting is hard (thanks to -fsanitize=address for pointing it out)
Change-Id: I665125d61c4bae5cb52b29cfa3af1e3c4b6d4333
2014-04-16 12:38:23 +02:00
1531b523bf Clean up function declarations and some unused functions
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14 17:55:32 +02:00
e4181d9a0a typo: ULR -> URL 2014-04-14 12:32:30 +02:00
aa0493be8c typo: puposes -> purposes 2014-04-14 12:32:29 +02:00
13943b18b7 typo: controlls -> controls 2014-04-14 12:32:29 +02:00
74fdda0cd4 sfx2: sal_Bool->bool
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-04-07 13:53:50 +02:00
7ebc595595 coverity#708129 Uninitialized scalar field
Change-Id: I88e166a8fd055ebae5a5d2e839c7fddba4ae5ec3
2014-04-04 12:14:25 +01:00
19bbfc0b39 tools: allow 64-bit positions on SvLockBytes
Bump stream positions to 64 bits on:

SvLockBytes::ReadAt()
SvLockBytes::WriteAt()
SvAsyncLockBytes::m_nSize
SvOpenLockBytes::Seek()
SvOpenLockBytes::Tell()
SvOutputStreamOpenLockBytes::m_nPosition
OInputStreamHelper::m_nActPos

Change-Id: Ica3b674e0ab23a756260a51475e97a5396ecdddb
2014-03-29 02:03:07 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
b5e11641a7 svtools: sal_Bool->bool
Change-Id: I90320997ed79be2556eafa4c35af6b968b378454
2014-03-25 14:32:56 +02:00
e262050a52 fdo#69878: Add [sub|super]script entry to text style context submenu
Make Impress consistent with Writer in this regard

Change-Id: Ib01472d88c20f05a375b57d8a79576fc447cc250
Reviewed-on: https://gerrit.libreoffice.org/8684
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-21 11:24:14 +00:00
ac01de882d sfx2: sal_Bool->bool
Change-Id: I87c5a180566e9da185c2992844e6522e82c17747
2014-03-18 11:27:38 +02:00
399724aba4 sfx2: sal_Bool->bool
Change-Id: I128430fe446eb517b42a109a868b88d49bbc4eaa
2014-03-18 11:26:05 +02:00
cc2700245d sd: prefer passing OUString by reference
Change-Id: Ide21e1f51284fb2d4c7aaaa358417c6080b2fdde
2014-03-17 13:30:51 +02:00
684baef506 sal_Bool to bool
Change-Id: Ib19ecab287396dc6d6cf4a77dcf7072c5c4c84f8
2014-03-16 09:39:12 +01:00
c2324940d3 sfx2: sal_Bool->bool
Change-Id: If960d94f867a1988ace83975cf16441c6f8866b0
2014-03-14 07:50:33 +02:00
4bdf7bf87c sfx2: sal_Bool->bool
Change-Id: I3a266e0c0de413fd0e160dc089f494393cf5e438
2014-03-14 07:50:32 +02:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
eeae5cf043 svx: sal_Bool->bool
Change-Id: I799d547cb3f81aeae19d0c8b6a2161b3064539f0
2014-03-11 08:18:19 +02:00
4e93f0f507 coverity#704738 Dereference after null check
Change-Id: I2fa3495a12adeb760bb9dd94fdb5859f011f11b9
2014-03-02 20:08:21 +00:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2ef9df8aee Remove visual noise from sd
Change-Id: I0957cabd66ddc4e25c7e6ff54ec2a555eda0792c
Reviewed-on: https://gerrit.libreoffice.org/8306
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:53:03 -06:00
66c8930012 coverity#704737 Dereference after null check
Change-Id: Icf30f9acf70c0dd367bad3f5711e71d9ab125ce9
2014-02-23 14:47:18 +00:00