Commit Graph

332 Commits

Author SHA1 Message Date
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
16b1b63f2e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Ib769dbbcb78e9440805aee40019ab98cd52e8477
2014-08-08 15:11:05 +02:00
15a3cd62b0 coverity#1209589: Dereference after null check
Change-Id: I75d26707a7a3c0febef11b7e1c2218b8abfb7832
2014-07-06 06:58:05 +02:00
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
2fc3b4173f coverity#1078582 Dereference after null check
Change-Id: I3b972510871f36a3c7877b38d3a012aa88acf4c5
2014-05-23 14:16:13 +01:00
5c2ab70cc2 cp#1000077: Set 'modified' document property more consistently.
Update document info at one place, so that it works for other formats
like .doc, .docx, ... too.

Change-Id: If71799b491d2210f0d3bdbdb05f91f26c986a260
2014-05-22 13:55:53 +02:00
018e2f629e Avoid possible memory leaks in case of exceptions
Change-Id: I61fe5f5fff157531de9962a2dd4e6e0431e8601c
2014-05-19 22:28:31 +09:00
fb4b9fe3d8 coverity#735483 Logically dead code
Change-Id: I4cb153338f1a00d9439dcfa9c43ee96235584e4a
2014-05-09 10:44:22 +01:00
9c66d0312f eliminate unnecessary temporary SvtLanguageTable instance
Change-Id: I64fba0071523af67eef72a4b92970cd7052b5c2e
2014-05-06 14:06:20 +01:00
b45a12c37d sd: sal_Bool->bool
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-04-24 10:53:17 +02:00
0833f4046a fdo#64047: n#863021: Add set-all language menu.
Problems:
* Doesn't reset the spell error markers
* Modifies only at object level
* Currently has only setting for 'all text'
* Maybe provide a current slide only option?

Change-Id: I4695423fed3ed9422185b23803eedd12ef434bea
2014-04-23 18:36:38 +05:30
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18 22:51:06 +02:00
f4d61eca61 sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro.
Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
2014-04-18 22:51:04 +02:00
8fbbd1bd98 fix hacked bool in SfxDispatcher::SetSlotFilter
The bEnable flag was being passed an extra value.
Make this explicit now using an enum.

Change-Id: I292aca44e8592c9f3c1497c24c41140c8c3b5452
2014-04-15 09:02:32 +02:00
1531b523bf Clean up function declarations and some unused functions
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14 17:55:32 +02:00
b1de52241c svtools: sal_Bool->bool
Change-Id: Iaa489318f25107e91fc8133523fbd9d724493314
2014-03-24 08:12:08 +02:00
c3e3f46657 sfx2: sal_Bool->bool
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-18 11:27:39 +02:00
ac01de882d sfx2: sal_Bool->bool
Change-Id: I87c5a180566e9da185c2992844e6522e82c17747
2014-03-18 11:27:38 +02:00
0e5c02da6e Fix indentation
Change-Id: I768699854c4e657e2d1b67d1a9b5ca5a925a05bd
2014-03-16 09:39:13 +01:00
684baef506 sal_Bool to bool
Change-Id: Ib19ecab287396dc6d6cf4a77dcf7072c5c4c84f8
2014-03-16 09:39:12 +01:00
c2324940d3 sfx2: sal_Bool->bool
Change-Id: If960d94f867a1988ace83975cf16441c6f8866b0
2014-03-14 07:50:33 +02:00
6c97bc4717 svx: sal_Bool->bool
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-11 08:18:24 +02:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
608953c425 bool improvements
Change-Id: Icac34936bdb551ad517170fd497212513719d2aa
2014-01-28 20:26:23 +01:00
3e5ff1f8d4 Be explicit when using bool as integral value (as Link return value)
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17 18:45:14 +01:00
fb84710151 simplify - use OUString::startsWith where possible
Convert code like
   if( !aStr.isEmpty() && aStr[0] == 'x' )
to
   if( aStr.startsWith("x") )

Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12 13:15:24 +02:00
c5138cad87 fdo#68724: sw: fix crash on Insert->File with Hybrid PDF
This is an unfortunate combination of 2 special cases:
- the Hybrid PDF has its own XFilter implementation to extract the
  embedded ODF document
- Writer needs to create a SwReader with SwPaM for Insert

Since the PDF XFilter uses a special service in sfx2 to implement
the import, handling this requires a new method in SfxObjectShell
that calls back into Writer to create the properly setup SwReader.

Change-Id: Ie85f3bfa322bfe883c479e1cb198a8bf0cbbac23
2013-12-05 13:00:27 +01:00
3b2f956ba6 Drop duplicate #include
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-12-02 01:02:06 +09:00
cc5518ca61 Integrate branch of IAccessible2
Change-Id: Ibf3be46e8619c2dce9636e8a90a6703f3e28ba33
2013-11-28 13:32:30 +00:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
5084e2b313 fix some further include guard foo
Change-Id: I949533327ec101a2baef6e6f66e79677a62c3d9f
2013-11-05 09:28:55 +01:00
1d3661cf91 Unwind FunctionReference typedef
Change-Id: Iaf1b041adf2220d6b0220a86d8ac0db38b3b8ebc
2013-10-25 15:42:11 +02:00
9de3cff361 String to OUString
Change-Id: I5ff57ede2217f1464571fb2beaa62a34425064ae
Reviewed-on: https://gerrit.libreoffice.org/5826
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-09-08 03:06:32 +00:00
bcbb20b0ef Print images in grayscale when printing using the "Black & White".
Black and white color option found in Impress at
File-->Print-->Libreoffice Impress tab

Before change, images are printed in pure white, and hence
missing from the printouts.

Should resolve bug 62838, and is contributed under the LGPLv3+ / MPL.

Change-Id: I29e291c2f2baf95b5725b862625f6a206e4cb8ba
Reviewed-on: https://gerrit.libreoffice.org/5798
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-04 09:22:08 +00:00
4c8fd5abdf convert DrawDocShell to OUString
Change-Id: I09e6f284024d00dbbc8a1c7b33684f4c23a650a8
2013-08-24 22:23:19 +04:00
3906f30371 cppcheck: fix reassigned value + fix indentation
Change-Id: I92ce0ce983b87528860fd56714e29338483b62ca
2013-08-23 07:32:02 +02:00
1edb495a45 convert GetName/Title/Description methods to OUString
Change-Id: Id16a2b29b1d6cf02b94cc6c423e2475a9cbeb8a3
2013-08-15 16:56:46 +04:00
197010643e remove some more SfxObjectShell methods that only call each other
Change-Id: I71807adff43ce2cfb748764edcc5880cdbba746f
2013-07-27 00:45:20 +02:00
c0eb5e7772 Resolves: #i121448# Aligned default fill color/line style for all apps
(cherry picked from commit 81664c037c8d6094b66c1660b6eee9693eadf401)

Conflicts:
	sc/inc/document.hxx
	sc/source/core/data/documen2.cxx
	sc/source/core/data/documen3.cxx
	sc/source/core/data/documen9.cxx
	svx/inc/svx/svdmodel.hxx
	svx/source/svdraw/svdmodel.cxx
	sw/inc/doc.hxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docnew.cxx
	sw/source/ui/app/docshini.cxx

Change-Id: Id0f62f0cd5b83794e2dbaee4e8b6afa704a0c23a
2013-06-06 21:04:07 +01:00
4da833308a Resolves: #i119902# Rename all master pages in a template...
not only the first one.

Patch by: Ma Bingbing
Review by: Andre Fischer
(cherry picked from commit 7daa651fbc74a6fc08d713282b9e25cda14e39e9)

Change-Id: Ibd8bf8c6f04785c93b7dae70b57fd9eb14623aaf
2013-05-12 16:28:12 +01:00
8546c324ff Remove pass-through header file sot/inc/sot/clsids.hxx
Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Reviewed-on: https://gerrit.libreoffice.org/3490
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 14:55:56 +00:00
3af6366dee Remove pass-through header files sd/inc/eetext.hxx and sd/inc/app.hxx
Change-Id: Iaccc7c9d81b55ef3a039cb90c4e089ebfc7fe337
Reviewed-on: https://gerrit.libreoffice.org/3487
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 12:45:37 +00:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
38d3e115c1 vcl: make Region ctors explicit to prevent overloading desasters
Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0
2013-03-13 22:29:46 +01:00
f16d3484a7 Translation and cleanup of comments in sd/source/ui/docshell/
Change-Id: I714b2d1ccdd5392a3ebc32788b203a8484c6cf0b
2013-03-12 20:28:30 +01:00
0af31660ea sd: translate debug messages
Change-Id: I8a50173babdd441c8247867fce0fdfbedaf0bc02
2013-03-11 22:51:53 +01:00
10bb5b8e24 fdo#38838, replacement of String with OUString
Replaced String with OUString in mediawindow.cxx, basdoc.cxx,
basdoc.hxx and bastype3.cxx. In other files I only replaced,
what was necessary for the changes in basdoc to work.

Change-Id: I1ad0e7e262f8becdf57f182853aaa914a88895a4
Reviewed-on: https://gerrit.libreoffice.org/2554
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
2013-03-05 12:48:36 +00:00