Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
This reverts commit 7ce2a89f4f8fa84232896766276cb3433ada239c.
Change-Id: I53f572777e84f66fd4c3d18fb686dac09095804a
revert d38cb53e3bcf3fd95a75e03b01c3b7a209d07b46
Change-Id: I5b243b69e50084316aaeab250d6b01079c12b718
Revert "sidebar: disable impress task pane if sidebar is enabled."
This reverts commit ee1726bfdba483623d496a3bcc09089e8b55cd65.
revert 54d820a7815af03a248c1aa424fae9bf9a4881f4
Change-Id: Ie7c83d88f5427a7e42fa50879280a0c4a7c2cdd1
Revert "Only register and use the Sidebar if it is globally enabled."
This reverts commit 66a5cc468cef0c6db8b42b7f25367f04208e6f2e.
Conflicts:
sfx2/source/view/viewfrm.cxx
Change-Id: I17fe702996c4adf7f387573d36ea993f8cc32c96
Revert "disable sidebar menu option if it is disabled."
This reverts commit 05f0eb57618d090fa45011120a907a3b1157accb.
Revert "finally get the taskpane rendering again"
This reverts commit 228bb7ffe0d404ba1225f7b4d26ca71e098577d9.
Conflicts:
officecfg/registry/data/org/openoffice/Office/Impress.xcu
sd/source/ui/framework/factories/TaskPanelFactory.cxx
sd/source/ui/framework/tools/FrameworkHelper.cxx
Change-Id: I248cc9a769695cde19e78774d42ce666dc685599
Revert "don't throw up the sidebar on start."
This reverts commit 645db9a2bd9b1eec381de60c491e6b7f9ee7a7b4.
Conflicts:
officecfg/registry/data/org/openoffice/Office/Views.xcu
Change-Id: I911859757e2e019836e8ed5213d2ba69ff82aec8
Revert "update to the right service name for new URLs."
This reverts commit 55f49970f4085e3a1498961edabd5303bd6bea6c.
Conflicts:
sd/source/ui/framework/tools/FrameworkHelper.cxx
Change-Id: I1ba2762a4c969a9125ff8354a9b6035813290021
Revert "tentatively restore more UNO / task-pane goo ..."
This reverts commit 052ac10a6f9b28b9b06884dd3ed41879722be6c9.
Conflicts:
officecfg/registry/data/org/openoffice/Office/Impress.xcu
Change-Id: I7e62f27329af033df811549436718648a6447dea
Revert "more reverts, first cut at making sidebar optional."
This reverts commit a65a423e22fc03d0b7850bbf20dfc30f6cfa34dd.
Revert "add experimental option for sidebar to 'Advanced' pane."
This reverts commit 54d820a7815af03a248c1aa424fae9bf9a4881f4.
Conflicts:
cui/source/options/optjava.cxx
sd/source/ui/framework/module/ImpressModule.cxx
Change-Id: I09a6c0f7834c8ef330d05a014505aaaf09ae096f
Revert "Restore FrameworkHelper taskpane URLs."
This reverts commit e9c2d5b26b1e1b52bdf87192a76314b7362fa80c.
more foo
Change-Id: I2eaa2fbd74dc7a2f7ba937d310472cee6b5a0b57
really go to town on it
Change-Id: I885dc03cd0286bbfdf05c05da9f0bbea2b78bcf4
