72f4f0e9e7
Resolves: fdo#83137 NULL pAction
...
Change-Id: I74c4e32aae1e3aa74d197f132c900627062b6d01
2014-08-27 15:43:58 +01:00
30541352a1
fix string out-of-bounds assert on rhbz496762-1.pdf
...
Change-Id: I224e3c9befd1a9ab3ba0cc2676cd6b4ba51214c8
2014-08-20 09:49:46 +01:00
787ed0a267
avoid memory leak
...
Change-Id: I9ac97c4e5c7b01b5e05cb1132c0d245f5843799e
2014-08-01 10:21:31 +02:00
e644bb59ff
fix parsing of cmdline args
...
Change-Id: I4005c08d4163d5d26f227e01c2520379f717343a
2014-08-01 10:21:31 +02:00
4a32ef9c3f
Improve test code
...
(never call CPPUNIT_ASSERT etc., which work by throwing exceptions, from a dtor)
Change-Id: I293d54eb40c2ad9205d485ccff0ffd2161257142
2014-07-03 13:11:58 +02:00
44565f46b2
Check exit code of spawned xpdfimport
...
Change-Id: I4bea1ebe5c9915ad5e3a4f8fecb516bc056d060d
2014-07-03 13:11:58 +02:00
f8018266cc
Remove double assignment
...
The semantic match that finds this problem is follows:
(http://coccinelle.lip6.fr/ )
// <smpl>
@r@
expression i,f;
position p1,p2;
@@
(
(<+...i++...+>) = ...;
|
(<+...++i...+>) = ...;
|
(<+...i--...+>) = ...;
|
(<+...--i...+>) = ...;
|
i = <+...f(...)...+>;
|
i@p1 = ...;
(
i = <+...i...+>;
|
i = <+...f(...)...+>;
|
i@p2 = ...;
)
)
@@
expression i;
position r.p1,r.p2;
@@
* i@p1 = ...;
i@p2 = ...;
// </smpl>
Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f
Reviewed-on: https://gerrit.libreoffice.org/9968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-06-30 07:06:29 +00:00
e48a233960
loplugin:unreffun: also warn about redundant redeclarations
...
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
0c7c8aa5f6
prevent invalid memory access
...
e.g. fdo26139-1.pdf
Change-Id: Ic5854e2056c246d48e2962dfe0a91f67c2c30c04
2014-06-21 04:21:39 +02:00
1d241f445a
loplugin:staticcall
...
Change-Id: Iacd3efa9e5d6103ad92e15884e8aa010d7b2ae93
2014-06-13 17:54:31 +02:00
7e4a51ee50
Use boost::hash_value to avoid undef conv of neg/large floating -> size_t
...
Change-Id: I85853ffc6083d46c02c08f14d5d3321803c31301
2014-06-02 14:46:04 +02:00
3b24dcc8a8
Remove unnecessary semicolons
...
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/ )
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-27 01:19:00 -05:00
be7ec1384e
fdo#78689 PDF Import: get font's ascent value from different source
...
Change-Id: I19018d25ef53bbea225bb5a9ef806ce5c1b4adc7
Reviewed-on: https://gerrit.libreoffice.org/9410
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-05-20 06:55:32 -05:00
0ff4909a55
coverity#984442 Use after free
...
Change-Id: I28822f6b74cbf8ace8f7a194248840cb401679be
2014-05-16 16:42:52 +01:00
a050856a67
fdo#78549 PDF Import: fix incorrect transformation matrix writing
...
Change-Id: I60d77e01ea7774c234d1ad1b81b90a7db3461e22
Reviewed-on: https://gerrit.libreoffice.org/9310
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-05-15 11:48:33 +00:00
b81ec527f0
use our css prefix to make this readable
...
Change-Id: I360832edafcfcff7e63fd3b185c2575165c2d728
2014-05-14 18:03:20 +02:00
e0bde4c53b
fdo#78427 PDF Import: Improve detection of bold italic font
...
(Bug #78427 is fixed only partially by this commit)
Change-Id: I080dca98a77a645c4c5ae19a9bbcae7d54179d3c
Reviewed-on: https://gerrit.libreoffice.org/9276
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-05-08 09:04:12 +00:00
d7fc306cd7
fdo#78382 PDF Import: add opacity support for fill and stroke
...
Change-Id: I76375280ee4726c1d497858165f38f4e8b4224cb
Reviewed-on: https://gerrit.libreoffice.org/9268
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-05-07 12:35:48 +00:00
0ece50a4ce
fix build problem
...
Change-Id: Ia6a54d86d4f283c7220a88b6bc68f0fb47ed3014
2014-05-06 16:12:40 +01:00
b27fca822c
fdo#78241 PDF Import: add dashes support
...
Change-Id: Ifd9fbce44c7d18114d5be466bfb9d92192573205
Reviewed-on: https://gerrit.libreoffice.org/9246
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-05-06 15:07:59 +00:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
c625058886
coverity#1210167 Uninitialized scalar field
...
Change-Id: Ibc314d95e2b673995a4c089f6e132a43c3706e9b
2014-04-30 11:43:28 +01:00
6f945d6dc7
fdo#78075 PDF Import: Use absolute positions in svg:d parameter
...
Change-Id: I55ddf92c43f849524be72bd10b3beb41e728f951
Reviewed-on: https://gerrit.libreoffice.org/9199
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-30 09:47:06 +00:00
1e2c8cf578
sdext: sal_Bool->bool
...
Change-Id: Ib505866047da2cbe0b00d99aa5d7050199b45e1c
2014-04-30 08:43:40 +02:00
8b451b41d6
No need to set LD_LIBRARY_PATH for xpdfimport
...
...at least since this is now bundled code where xpdfimport resides in the
program dir and has a proper RPATH to find the URE libs.
Change-Id: I7103af2b13d7f38fd1e864cbc4d2719391e93e94
2014-04-23 09:44:59 +02:00
ef141bb147
Do not drop existing LD_LIBRARY_PATH
...
Change-Id: I5b3599596dc40d1f88c075257c466b56ed73e795
2014-04-22 18:21:53 +02:00
f61cdf6fa8
fdo#71217 PDF Import: Fix importing of JPEG images
...
Change-Id: Ic0902a3f9340d2d05be05d13d98f168879b4c3e3
Reviewed-on: https://gerrit.libreoffice.org/9120
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-22 16:08:01 +00:00
16b81b0dbf
Fix order of CPPUNIT_ASSERT_EQUAL arguments
...
Change-Id: Ib341ed33e98c31e296bb5ee6bff5789cf2459113
2014-04-22 17:21:42 +02:00
efaa53bc98
fdo#69051 fdo#72028 PDF Import: text fixes
...
1. Set font size not only on text span, but also on text frame.
2. Some copy-paste from Draw import code to Writer import code:
2.1. Set frame's auto-size properties.
2.2. Set correctly line joins and caps.
Change-Id: I6beecfb50aa7f45d20cc3cb3740e415172394638
Reviewed-on: https://gerrit.libreoffice.org/9091
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-18 09:20:49 +00:00
c79a5f87b1
remove executable bit
...
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-17 15:11:14 +02:00
8a3eeff238
Clean up function declarations and some unused functions
...
Change-Id: I80d15f503bb5714340c051cc1c4890a445e44d56
2014-04-13 23:50:17 +02:00
54b8eb252a
fdo#35064 PDF Import: Add support for simple text scaling
...
Change-Id: I81ff611f5f326c7ef97a75011cec4f4144d2cca4
Reviewed-on: https://gerrit.libreoffice.org/8916
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-11 11:13:52 +00:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
a20e145cf9
fdo#45001 fdo#77105 PDF Import: rotated text fixes
...
1. Fix 180 degrees text rotation;
2. Make rotated text fully editable.
Change-Id: Ie937f29031bbd0146207ce83678db351b65d2f8d
Reviewed-on: https://gerrit.libreoffice.org/8890
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-08 14:50:13 +00:00
453ee351f3
fdo#43157 : clean up more OSL_POSTCOND
...
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-04-04 07:23:43 -05:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
2498e4725e
fdo#49431 PDF Import: Improve line and space detection algorithm
...
Change-Id: Ia0d53e90f49fa020e0738e295a4584254e2b474e
Reviewed-on: https://gerrit.libreoffice.org/8800
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-31 15:19:06 +00:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
7fce0e3fe7
coverity#982469 Unchecked dynamic_cast
...
Change-Id: I6fa95fbd64f69cca1837b57f9c632f0bdbaec1d0
2014-03-25 17:03:50 +00:00
356263dcdb
coverity#982468 Unchecked dynamic_cast
...
Change-Id: Ie98fa4199ebfa96495bdb7fa4582b09926fac8f1
2014-03-25 17:03:49 +00:00
53cbca6ee1
fdo#44710 PDF Import: Correction of position of rotated text
...
Change-Id: Ie53b25a6cec88c07a317c50bd0965282fac64ff0
Reviewed-on: https://gerrit.libreoffice.org/8725
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-23 11:42:39 +00:00
7963d2b0f6
fdo#40513 PDF Import: Hack: Replace incorrect values of font's ascent property
...
Change-Id: Ib7bd6e15fff5213b5d935c6f03f2c65ea3f6ca50
Reviewed-on: https://gerrit.libreoffice.org/8416
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-03 09:20:24 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e6bd9d718d
Remove visual noise from sdext
...
Change-Id: I792249b9e92db9af4daee0bd835e04044d29bca5
Reviewed-on: https://gerrit.libreoffice.org/8308
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 08:19:03 -06:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
7f8e774119
fdo#75195 PDF import: Revert commit 128adf7e5c06fff378c8d72b44ec4be1e462984f
...
Change-Id: Icb03088809e57a388317f98046f9de3197772a41
Reviewed-on: https://gerrit.libreoffice.org/8126
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 14:03:34 +00:00
97a185d8b9
cid#983380 Dereference before null check
...
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
2014-02-20 09:31:11 +02:00
988b695bcc
fdo#37246 PDF Import: Color to string conversion fix
...
Change-Id: I5ec9f0246f6c2d1b12a389906d04133b2f5a6f9f
Reviewed-on: https://gerrit.libreoffice.org/8106
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-18 20:19:17 +00:00
9616b786ad
fdo#45003 PDF import: Implementing linejoin and linecap properties
...
Change-Id: I4b09cd7b970d5aca4500ae333edef0e4c2f618b9
Reviewed-on: https://gerrit.libreoffice.org/8009
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-12 10:48:51 +00:00
9db3b5585c
fdo#35143 PDF import: Reimplementation of whitespace detection function
...
Change-Id: I5b230aaebf72b70bbb7e206414a5ac0e01f01f86
Reviewed-on: https://gerrit.libreoffice.org/7564
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-04 15:13:15 +00:00