Commit Graph

157 Commits

Author SHA1 Message Date
240ea11fe8 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I786e07caf28b2f5f898b50fc2a46247d821248cf
2014-08-28 15:42:41 +02:00
6a39fdf81f callcatcher: update unused code
Change-Id: I6cb74836f98d7507359f39e1fd03a1462b2e0c31
2014-08-28 09:50:33 +01:00
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
c499b2ccdf Sidebar: Ensure Deck is open, if we choose an element from the Deck popup menu.
Otherwise the Deck will be changed, but not shown...

Change-Id: I4be7756542a8c21a616e7615ef40535e7310b90c
2014-08-24 05:27:26 +02:00
04e96b6d6e fdo#67627 Clicking on icons of the sidebar should both open and close Decks
Change-Id: I921a8a0b749df62c50f0ae8cb2de85f6cb459784
2014-08-24 05:27:25 +02:00
d3ebe3e3dc Sidebar: Use proper default value for Deck
gsDefaultDeckId is "PropertyDeck". Deck "default" does not exist
and triggers a fallback, which is the first Deck in the list, which is
"PropertyDeck", too.

Change-Id: If2daa53d002c6547cc5f6fbed1408719c10b149d
2014-08-24 05:27:24 +02:00
3156948d81 Sidebar: Remove hightlight from TabBar after Deck close
After clicking on "Close Sidebar Deck" the highlighted icon
will now lose its highlight.

Change-Id: Iee947641343d46c84af7afb93cd52101e39149f7
2014-08-24 05:27:24 +02:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
7dda48d56f Related: fdo#80633 cache optimal size
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01 16:43:05 +01:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
df630b8f8c Related: fdo#65634 make sidebar react to resizes when floating
the parent isn't a SfxSplitWindow in this case, but it should
still react to the resize

Change-Id: Ia298d45b33fc272d6169df12cf2c58a881255163
2014-06-27 15:53:30 +01:00
641154c259 Resolves: fdo#65634 improve wheel-scrolling sidebar panels
Change-Id: I213d85a1e2bbd2377f6f0326433ddd57dc346721
2014-06-27 14:42:19 +01:00
ffa9a802ea coverity#1028261 Uncaught exception
Change-Id: I7dd08c182657084ffa635e1960f4d0def6d7a6bb
2014-06-18 11:12:11 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
0721f167a1 -Werror,-Wtautological-undefined-compare
Change-Id: I2e05bcf91c534d2aed6e296fe03d367c4c1b7212
2014-06-10 11:49:41 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
f3c9e8471a Resolves: fdo#79161 sidebar crash on deactivating
Change-Id: I0d559bd8c16243fdc398f6bff0aa915a83a29dff
2014-05-25 16:10:51 +01:00
1e6ccc7f7e cppcheck: Function parameter 'aFocusLocation' should be passed by reference
Change-Id: I2d2b9ae3ea81bd725be2af460f6c57bd0897883c
2014-05-22 12:50:50 +02:00
227af32d8c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
8d54796bf1 enhance pass-by-ref plugin to detect large arguments
Detect arguments larger than 64 chars passed by value.

Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-20 11:17:22 +02:00
93f5d5a919 The opaque PostUserEvent IDs are actually pointers
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
09abd826a0 remove uncompiled source files
how to find possible candidates:

find . -name *.cxx | grep -v compilerplugins > cxx.list
for i in `cat cxx.list`; do basename $i .cxx; done > cxx.base.list
for i in `cat cxx.base.list | sort -u`; do echo $(git grep -w $i -- '*.mk' | wc -l) $i; done > cxx.count

Change-Id: I15c6cc7195e58d79967388850a0c90b915b001b7
2014-05-06 18:12:28 +02:00
5e80dd672f Move a few more headers that are included only in sfx2 to sfx2
Change-Id: I8bd81a45f5ef1b76fce1563b06e05a4eefcff0ec
2014-05-06 15:01:31 +03:00
1d25e1de0b Clean up function declarations and some unused functions
Change-Id: I9d6e9df0b686c61597aaa0e194ab321445671a20
2014-04-10 09:31:46 +02:00
74fdda0cd4 sfx2: sal_Bool->bool
Change-Id: I48ae51781f64e60deb0c03352087100729c8c3cd
2014-04-07 13:53:50 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
9afdc72df6 callcatcher: update unused code
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
2014-03-24 12:12:22 +00:00
a8f721ff96 sfx2: sal_Bool->bool
Change-Id: I626371bac4fbd9c6a2cdc5a57a3022f8b6ac55b2
2014-03-14 07:50:34 +02:00
8ad74d8866 Related: #i124392# fill in SidebarDockingWindow::DoDispose
(cherry picked from commit 952f581cb77f52e9aaa974496dc8d86b335cb424)

Conflicts:
	sfx2/inc/sfx2/sidebar/SidebarChildWindow.hxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/inc/templdgi.hxx

Change-Id: Idf06437dfc45e02d9e2303df84d52ba0837de108
2014-03-13 11:35:13 +00:00
17b0d011da coverity#1027775 Dereference null return value
Change-Id: I27dc7645969e6311bc6c0a3d593924ea41dfdf5d
2014-03-12 11:02:17 +00:00
7b2c8b9771 remove unused code in sfx2::sidebar
sfx2::sidebar::ContextList::IsEmpty()
sfx2::sidebar::Deck::PrintWindowTree(std::vector<sfx2::sidebar::Panel*> > const&)
sfx2::sidebar::EnumContext::EvaluateMatch(sfx2::sidebar::EnumContext const&) const
sfx2::sidebar::EnumContext::GetContext() const
sfx2::sidebar::Paint::Set(sfx2::sidebar::Paint const&)
sfx2::sidebar::Panel::PrintWindowTree()
sfx2::sidebar::SidebarDockingWindow::GetChildWindow()

Change-Id: I285567320677a831b2b786f4f73b000eed39987b
2014-03-03 08:58:59 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
c7c40687f6 Remove visual noise from sfx2
Change-Id: I0f556a386ce64d154b695c2a35f808c94b9f0b7a
Reviewed-on: https://gerrit.libreoffice.org/8310
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 08:12:10 -06:00
d7f3dced12 remove unused code in sfx2::sidebar
removes these methods:
sfx2::sidebar::Context::EvaluateMatch(std::vector<sfx2::sidebar::Context>)
sfx2::sidebar::EnumContext::EvaluateMatch(std::vector<sfx2::sidebar::EnumContext>)

Change-Id: I14314d526a5306530d0381ca8bf6ab150d3dd5a0
2014-02-26 08:54:53 +02:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
d13545987a callcatcher: update unused code lists
Change-Id: Ie975f8a970eec63b593933ebb2394db76d537c51
2014-02-18 10:10:01 +00:00
19e16083c6 Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30 10:48:25 +01:00
e9a23fd78c Introduce com.sun.star.ui.theUIElementFactoryManager singleton.
To replace single-instance com.sun.star.ui.UIElementFactoryManager
service.

Change-Id: I4262909c4396e3907d271a56696a06903168a58d
2014-01-29 11:46:10 +01:00
af1c0ef8d3 Introduce com.sun.star.frame.ControllerFactory singletons:
com.sun.star.frame.thePopupMenuControllerFactory
com.sun.star.frame.theStatusbarControllerFactory
com.sun.star.frame.theToolbarControllerFactory

To replace their single-instance service variants.

Change-Id: I00586d0d61e63f9482cb659071e88aa9cf02d5b5
2014-01-29 11:46:10 +01:00
c35616dd73 bool improvements
Change-Id: I4a09bffccc0049d81ea3113e79184f64b026a4ba
2014-01-28 20:24:40 +01:00
b777130dba Fix apparently broken OSL_ASSERTs (that would have never fired)
Change-Id: I10c5152ca09be49625f960e6dc3228ec2284ce58
2014-01-28 20:24:37 +01:00
ba8413d262 Introduce com.sun.star.frame.theUICommandDescription singleton.
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28 18:52:22 +01:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
ae37972cd2 hidpi: Sidebar, fontwork, autoformat and other improvements.
This is a second batch of HiDPI changes. It fixes the following areas:

Sidebar
* Impress Master pages preview
* deck title height
* tab (icon) bar
* valueset dropdown control
* wider maximum width
* Draw and other misc. buttons which didn't get fixed by earlier
   change to Toolbar.SetItemImage
There are several more sidebar issues, but it is much improved.

Other changes
* Writer and Calc auto-format dialog text
* file-properties document image
* fontwork gallery preview size
* Calc table border control

Change-Id: I95a0169a3b011836b1c75b3dcacb2733c9567ef3
2014-01-04 13:01:52 +01:00
b0926378ac Clean up includes of comphelper/stl_types.hxx
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
c78f7d85ab Get rid of DECLARE_STL_MAP
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
2013-12-06 10:37:50 +01:00
3b2f956ba6 Drop duplicate #include
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
2013-12-02 01:02:06 +09:00