83ac0fd7bd
Fix *_component_getFactory function type
...
Change-Id: I406e0b659f551f347a8fa9ae2a57ec7965ba7ea0
2014-08-28 17:35:03 +02:00
5253732ca6
Fix some *_component_getFactory function types
...
Change-Id: I8e7cc2d26df27e2eb48ddec53ea0a4f1d1381e23
2014-08-28 16:40:02 +02:00
e99535df4d
remove executable bits
...
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-17 05:50:13 +02:00
578d3fc5e6
warning C4505: unreferenced local function has been removed
...
Change-Id: I2b9b43c40a467dd369f1eeb3623be388c51d3b4d
2014-08-13 10:10:46 +02:00
a445eb4356
warning C4189: local variable is initialized but not referenced
...
Change-Id: I83493466051649c9786cead0486e3112bf1eb5a4
2014-08-13 10:10:44 +02:00
4469c60ad8
warning C4296: '<' : expression is always false
...
sread doesn't return negative values
Change-Id: I72caa9abe7081b7d88e412510d70ec3810634af1
2014-08-13 10:10:33 +02:00
a59e2d4f05
fdo#82038: Make sending email from LO work again on OS X
...
Do build the cmdmail library, the uri-encode executable and do install
the senddoc script for OS X, too.
Note that in order for it to work, one needs to set the "E-mail
program" in Preferences:Internet:E-mail to /Applications/Mail.app. (Or
possibly some other application and/or executable.)
Change-Id: I5764c9891865983d46081edc854e321643c296cc
2014-08-11 12:24:01 +03:00
e395aa09a4
match va_start() with va_end()
...
Change-Id: I5c3c2570d6311f49da95bb80c0f9850f89970235
2014-08-08 21:48:28 +09:00
38e2ef8120
Fix FTBFS with TDE support enabled
...
Change-Id: Ib85371542c5d79ef69bc76f6aa388acdfd9dd849
Reviewed-on: https://gerrit.libreoffice.org/10348
Reviewed-by: Timothy Pearson <kb9vqf@pearsoncomputing.net >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-07-17 10:09:31 +00:00
7182db5a67
Include <algorithm> for std::min() and max()
...
Change-Id: I6a46e6466ab56aea14e16902cb51f9c3f088f30e
2014-07-08 02:37:34 +03:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
a15715c343
-Wstrict-prototypes
...
...no reason to not have it enabled for URE C include files and what
little real C code is still left. (But note that Clang ignores that
warning.)
Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6
2014-06-17 15:51:54 +02:00
5a37986b4c
the BSD family also uses gio
...
Change-Id: I75fb934e52beb2ab752df4c969aa2e10d4f5966e
Reviewed-on: https://gerrit.libreoffice.org/9733
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-11 09:36:08 +00:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
c2034f3993
fixincludeguards: fix include guards
...
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-06-06 19:16:40 +00:00
8e115c6008
fdo#68849: Add header guards to all include files
...
added header guards for directories basebmp/, chart2/, cppuhelper/,
include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/
Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6
Reviewed-on: https://gerrit.libreoffice.org/9615
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-06-02 08:46:30 +00:00
ebc0a15515
remove more unnecesary OUString constructor use
...
when throwing exceptions
Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
f0ae48b684
remove unnecessary NULL parameter passed to UNO Exception
...
.. now that we have a default value for that parameter
Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
01443bb1bc
cppcheck: Variable 'i' is assigned a value that is never used
...
Change-Id: I02e0f878e743576ebb3c80e3120fa1dc54e379ed
2014-05-22 12:50:48 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
8fd54c107a
Related fdo#60338: Do not use umask(3) in a MT program
...
Change-Id: Ie515201e44ad58faf623a04981e891c0b3f4a19d
2014-05-13 11:39:30 +02:00
096d1d6e7c
This code is not linked against sal
...
Change-Id: I7f44cd54732a60e9655f0bbb90615f3d3988ce58
2014-05-12 12:32:56 +02:00
70e744b215
fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF
...
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-05-12 11:32:38 +02:00
c327acab9e
remove globally disabled warnings from source files
...
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
2014-05-10 13:03:20 +02:00
9037e2289d
remove presys.h and postsys.h
...
Both files are nearly identical to prewin.h and postwin.h
Change-Id: I1f45e46dfcc00043a9e2df82e0070cd1b976c4af
Reviewed-on: https://gerrit.libreoffice.org/9294
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-09 18:17:19 +00:00
177d32b6b8
shell: sal_Bool->bool
...
Change-Id: I4313819fa40885a3cfa4a137888ae457d8d839a8
2014-04-30 08:43:41 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
d59fe933fe
Use boost::noncopyable
...
Change-Id: I1cd2ad1284f2fb9f6847cdb9175a5872a66726cd
2014-04-03 08:20:19 +02:00
6a3b0b7cc4
Explicitly mark overriding destructors as "virtual," Mac OS X redux
...
Change-Id: Ib7ab02bc3cdadbdfe0e0787560d1dd562eb85be9
2014-04-01 21:30:38 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
5eb733cf67
loplugin:saloverride
...
Change-Id: I028d6da250bad64cca2d85c8bbf4a3b5a1300f1b
2014-03-30 21:55:17 +02:00
22a7f8b1f5
coverity#982766 Dereference null return value
...
Change-Id: Ic9efce80ea2c2489e3ef070ac4c6106c811e9889
2014-03-28 13:13:59 +00:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
bc13d935e6
coverity#708176 Uninitialized scalar field
...
Change-Id: I1d7b005c563a17b31a3bf565dd27d43868b3129c
2014-03-22 20:56:28 +00:00
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
c84f0dae40
Blind Windows build fix
...
Change-Id: Ib8403f199057bec926fe1da1bac5738046ccb245
2014-03-07 10:32:45 +02:00
ff3f66d4be
Simplify
...
Change-Id: Id6dc46c8b24441481d950ef0423da800a0f2ed9d
2014-03-07 10:17:19 +02:00
ee39446353
Why would we need GNOME and KDE scripts on OS X?
...
Also, the senddoc script seems fairly AIX/Linux/X11-specific.
Change-Id: I06c417df3256204d2b8b29b3978f89b00c15f6f0
2014-03-07 10:12:29 +02:00
42c9f35da2
shell: get rid of separate Library_syssh_win.mk
...
Change-Id: I12f38bab6ea7207b79994556f0ab6798d2d1d9da
2014-03-03 23:44:11 +01:00
72ef2d526b
std::exception retrofit sequel
...
Change-Id: I7461c320e98b9a3605db26f4d58200789e1477df
2014-02-27 08:39:31 +01:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e44a7eefb7
KDE: don't throw on TemplatePathVariable
...
This is required after commit
838b77f5f3d6d8fd98891e99a23ff78a6a357cb2.
Actual functionality is still missing.
Change-Id: Ib94d8a982609de730d9c61bf7bf9886093c51f5b
Reviewed-on: https://gerrit.libreoffice.org/8367
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 09:09:40 -06:00
d18a2753d5
Remove visual noise from shell
...
Change-Id: I1857fd7a9aeda38cb8ef2a0eda7783203b7658ed
Reviewed-on: https://gerrit.libreoffice.org/8311
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 07:55:24 -06:00
838b77f5f3
Resolves: rhbz#1065807 use xdg ~/Templates for default Template location
...
(if it exists)
Change-Id: I98fc9fd54d1f56c8bed24ce4d2ebf53756ded2cc
2014-02-25 10:45:27 +00:00
5673bac9a7
Revert partially "Replace deprecated std::auto_ptr with boost::scoped_ptr"
...
This reverts partially commit 4a9347fa320d892b60fd03082925f63a1d69cfb9.
Change-Id: Ibbc626f8d30de040fe9e809b44d5ffc9513720fb
2014-02-25 16:55:00 +09:00
4a9347fa32
Replace deprecated std::auto_ptr with boost::scoped_ptr
...
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
2014-02-25 16:33:15 +09:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
eeee164f67
cppcheck: redundantAssignment
...
Let's not forget the result of RegDeleteValueA call
Change-Id: I9458040bc3a8960ab740ee3c5211eaa9ba24b1aa
Reviewed-on: https://gerrit.libreoffice.org/7772
Tested-by: David Tardon <dtardon@redhat.com >
Reviewed-by: David Tardon <dtardon@redhat.com >
2014-02-16 10:45:43 +00:00
5c8a3bfc7e
Don't call pclose(NULL)
...
Change-Id: I6540ec2b900e82745d5e661dfa920f85db6c0ff2
2014-02-10 11:23:45 +01:00
f669e7907b
Properly encode cmd line for popen
...
Change-Id: I1f7799920b6732a6cd128143dfa7ce282bad25c6
2014-02-10 11:23:45 +01:00
