Commit Graph

652 Commits

Author SHA1 Message Date
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
46e03df0a7 fdo#81835 Don't prefer GDI Metafiles to RTF/HTML -- correctly.
Was first introduced by 538c13f3d1756f2d105115f64ab1bc0b7426eebc

We should process clipboard formats in order of descriptive-/
usefulness -- however png/bmp are special cases (as browsers
will add an html equivalent to their clipboard when copying raw
images, with the raw image being the preferred target format)
and were therefore moved up in the paste-preference list,
mistakenly it was assumed that GDI Metafiles should be subject
to the same treatment, but it appears that Word (and Wordpad?)
will provide both RTF (preferred) and GDI for formatted text.

Change-Id: I731986fc9d70e7aeb64e53764e32cfec3e27eca1
2014-08-06 16:01:04 +02:00
95cad2e05f Revert "fdo#81835 Don't prefer GDI Metafiles to RTF/HTML"
Accidentally removed GDI metafiles from calc too.

This reverts commit a96a7ce51aa98fb9ee97ea3803e2b7e648611008.
2014-08-06 16:01:04 +02:00
a96a7ce51a fdo#81835 Don't prefer GDI Metafiles to RTF/HTML
Was first introduced by 538c13f3d1756f2d105115f64ab1bc0b7426eebc

We should process clipboard formats in order of descriptive-/
usefulness -- however png/bmp are special cases (as browsers
will add an html equivalent to their clipboard when copying raw
images, with the raw image being the preferred target format)
and were therefore moved up in the paste-preference list,
mistakenly it was assumed that GDI Metafiles should be subject
to the same treatment, but it appears that Word (and Wordpad?)
will provide both RTF (preferred) and GDI for formatted text.

Change-Id: I731986fc9d70e7aeb64e53764e32cfec3e27eca1
2014-08-05 19:22:57 +02:00
73f961ecf7 Include <algorithm> for std::min
Change-Id: I6d73e4d732da36bcd446b1d10273d88d941b9c1a
2014-07-29 18:21:04 +03:00
067207f02d coverity#707195 Uncaught exception
Change-Id: Idaeb36f01632cc91cc9fc3d5febd249e39e44ae2
2014-07-21 13:59:35 +01:00
1bae012c99 Avoid possible memory leaks in case of exceptions
Change-Id: Id0304366c4e6191db85527935f5bc5cdb0aeb8d8
2014-07-12 23:10:34 +09:00
0ae79a1368 use SimpleReferenceObject in StgPage
to replace hand-rolled version

Change-Id: I5301ef1df786b08b3c5d585a366d95722506f220
2014-07-10 11:04:13 +02:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
a8b32cc97a OSL_ENSURE->assert
Change-Id: Ib8ba49e89d03eaf3b3aae94dbbf121898ba9e8de
2014-06-26 16:29:14 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
538c13f3d1 fdo#78801 fdo#52547 Paste preference is image, then html, then text.
c47db038f98aaf7aec3cbe57c4e5683591afa23e was an attempt to fix fdo#52547,
i.e. to make sure that the actual image data was stored if an image was
being pasted from a browser (where the clipboard contains both image data,
but also an html construct which would instead embed the image from the
web). However the new ordering inadvertently meant that strings would
be preferred to html -- i.e. copying a mixture of text+image from a
webpage would result in only the text being stored.

The new ordering causes images copied from the browser to still have
the actual image data stored (rather than a link in the case of the
html being stored), but html is still preferred to plaint text.

(This is primarily as a result of Firefox (and possibly other browsers)
changing their clipboard to contain an html construct which links to the
original image, in addition to the raw image data-- and html previously
being preferred to images in the paste ordering meant that the linked
version would be pasted by default, which is not the expected result
when copying an image.)

Change-Id: Ice9b37cf3dd25d8cdb0e04f19a6b2f3661018564
2014-05-28 18:43:58 +01:00
1d203f2d3f Avoid undefined signed integer overflow
Change-Id: Idbb8109c36dfe1c8ed4acb8dff1a1538e386abd8
2014-05-28 08:55:11 +02:00
6757761706 coverity#441341 Dereference after null check
Change-Id: I7c3df9438d9b81e0f50f8143772b997672ca7abb
2014-05-24 16:11:02 +01:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
820a29950b Many spelling fixes: directories r* - z*.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.

(cherry picked from commit 28206a7cb43aff5adb10f8235ad1680c3941ee3e)

Conflicts:
	include/osl/file.hxx
	include/osl/pipe_decl.hxx
	include/osl/socket.h
	include/osl/socket_decl.hxx
	include/sal/main.h
	include/svx/dbaexchange.hxx
	include/svx/dlgctrl.hxx
	include/svx/msdffdef.hxx
	include/svx/sdr/contact/objectcontactofpageview.hxx
	include/svx/svdpntv.hxx
	include/ucbhelper/content.hxx
	include/ucbhelper/interceptedinteraction.hxx
	include/ucbhelper/resultsethelper.hxx
	include/unotools/sharedunocomponent.hxx
	include/unotools/viewoptions.hxx
	include/vcl/pdfwriter.hxx
	include/xmloff/txtparae.hxx
	include/xmloff/uniref.hxx
	rhino/rhino1_7R3.patch
	rsc/inc/rscrsc.hxx
	sal/inc/osl/conditn.h
	sal/inc/osl/security.h
	sal/inc/osl/semaphor.h
	sal/inc/osl/semaphor.hxx
	sal/inc/rtl/string.hxx
	sal/inc/rtl/tres.h
	sal/inc/systools/win32/StrConvert.h
	sal/osl/os2/file_path_helper.h
	sal/osl/os2/file_path_helper.hxx
	sal/osl/os2/file_url.cxx
	sal/osl/os2/file_url.h
	sal/osl/os2/makefile.mk
	sal/osl/os2/pipe.cxx
	sal/osl/os2/process.c
	sal/osl/os2/profile.c
	sal/osl/os2/socket.c
	sal/osl/os2/system.h
	sal/osl/unx/asm/interlck_sparc.s
	sal/osl/unx/file_url.cxx
	sal/osl/unx/signal.c
	sal/osl/unx/system.h
	sal/osl/w32/MAKEFILE.MK
	sal/osl/w32/interlck.c
	sal/osl/w32/module.cxx
	sal/osl/w32/security.c
	sal/qa/buildall.pl
	sal/qa/osl/file/osl_File.cxx
	sal/qa/osl/module/osl_Module_Const.h
	sal/qa/osl/mutex/osl_Mutex.cxx
	sal/qa/osl/pipe/osl_Pipe.cxx
	sal/qa/osl/process/osl_Thread.cxx
	sal/qa/osl/socket/osl_StreamSocket.cxx
	sal/qa/osl/socket/sockethelper.cxx
	sal/qa/rtl_strings/rtl_OUString.cxx
	sal/rtl/source/unload.cxx
	sal/systools/win32/kill/kill.cxx
	sal/systools/win32/uwinapi/MoveFileExA.cpp
	sal/test/bootstrap.pl
	sal/typesconfig/typesconfig.c
	sal/workben/tgetpwnam.cxx
	sax/inc/sax/parser/saxparser.hxx
	sc/addin/datefunc/dfa.cl
	sc/addin/datefunc/dfa.src
	sc/addin/rot13/rot13.cl
	sc/addin/rot13/rot13.src
	sc/inc/attarray.hxx
	sc/inc/chgtrack.hxx
	sc/inc/column.hxx
	sc/inc/compressedarray.hxx
	sc/inc/document.hxx
	sc/inc/table.hxx
	sc/source/core/data/column.cxx
	sc/source/core/data/dptablecache.cxx
	sc/source/core/data/dptabres.cxx
	sc/source/core/data/dptabsrc.cxx
	sc/source/core/data/global.cxx
	sc/source/core/tool/chgtrack.cxx
	sc/source/core/tool/compiler.cxx
	sc/source/filter/excel/xestyle.cxx
	sc/source/filter/excel/xichart.cxx
	sc/source/filter/inc/fapihelper.hxx
	sc/source/filter/inc/xistyle.hxx
	sc/source/filter/xml/xmlsubti.cxx
	sc/source/ui/Accessibility/AccessibleCell.cxx
	sc/source/ui/Accessibility/AccessibleContextBase.cxx
	sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx
	sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
	sc/source/ui/Accessibility/AccessibleEditObject.cxx
	sc/source/ui/Accessibility/AccessiblePreviewCell.cxx
	sc/source/ui/app/inputwin.cxx
	sc/source/ui/docshell/docfunc.cxx
	sc/source/ui/drawfunc/fupoor.cxx
	sc/source/ui/miscdlgs/linkarea.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	sc/source/ui/unoobj/nameuno.cxx
	sc/source/ui/vba/vbacharacters.hxx
	sc/source/ui/vba/vbarange.cxx
	sc/source/ui/vba/vbawindow.cxx
	scaddins/source/analysis/analysishelper.cxx
	scaddins/source/analysis/analysishelper.hxx
	scaddins/source/datefunc/datefunc.cxx
	scripting/examples/python/Capitalise.py
	scripting/source/pyprov/officehelper.py
	sd/source/filter/eppt/eppt.cxx
	sd/source/filter/eppt/epptso.cxx
	sd/source/ui/dlg/prltempl.cxx
	sd/source/ui/dlg/tpoption.cxx
	sd/source/ui/func/fuediglu.cxx
	sd/source/ui/func/fupoor.cxx
	sd/source/ui/func/fusel.cxx
	sd/source/ui/func/smarttag.cxx
	sd/source/ui/inc/OutlinerIteratorImpl.hxx
	sd/source/ui/inc/SlideViewShell.hxx
	sd/source/ui/inc/fuediglu.hxx
	sd/source/ui/inc/fusel.hxx
	sd/source/ui/slideshow/slideshowimpl.cxx
	sd/source/ui/slidesorter/cache/SlsQueueProcessorThread.hxx
	sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx
	sd/source/ui/slidesorter/controller/SlsSelectionCommand.hxx
	sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
	sd/source/ui/slidesorter/view/SlsButtonBar.cxx
	sd/source/ui/view/Outliner.cxx
	sd/source/ui/view/drviewsh.cxx
	sd/source/ui/view/frmview.cxx
	sdext/source/presenter/PresenterFrameworkObserver.hxx
	sdext/source/presenter/PresenterSlideShowView.cxx
	setup_native/scripts/deregister_extensions
	setup_native/scripts/register_extensions
	setup_native/source/opensolaris/bundledextensions/README
	setup_native/source/opensolaris/bundledextensions/svc-ooo_bundled_extensions
	setup_native/source/win32/customactions/patch/swappatchfiles.cxx
	setup_native/source/win32/customactions/reg4msdoc/registrar.cxx
	setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx
	sfx2/inc/sfx2/sfxbasemodel.hxx
	sfx2/qa/complex/sfx2/DocumentProperties.java
	sfx2/source/appl/appopen.cxx
	sfx2/source/appl/appquit.cxx
	sfx2/source/appl/appserv.cxx
	sfx2/source/bastyp/sfxhtml.cxx
	sfx2/source/dialog/dockwin.cxx
	sfx2/source/doc/docfile.cxx
	sfx2/source/doc/docvor.cxx
	sfx2/source/doc/graphhelp.cxx
	sfx2/source/doc/objcont.cxx
	sfx2/source/doc/objserv.cxx
	sfx2/source/doc/objstor.cxx
	sfx2/source/doc/objuno.cxx
	sfx2/source/doc/objxtor.cxx
	sfx2/source/doc/printhelper.cxx
	sfx2/source/doc/sfxbasemodel.cxx
	sfx2/source/notify/eventsupplier.cxx
	sfx2/source/view/frmload.cxx
	sfx2/source/view/sfxbasecontroller.cxx
	shell/qa/zip/ziptest.cxx
	shell/source/backends/wininetbe/wininetbackend.cxx
	shell/source/win32/shlxthandler/util/utilities.cxx
	solenv/bin/build.pl
	solenv/bin/build_release.pl
	solenv/bin/cws.pl
	solenv/bin/download_external_dependencies.pl
	solenv/bin/make_download.pl
	solenv/bin/make_installer.pl
	solenv/bin/modules/Cws.pm
	solenv/bin/modules/ExtensionsLst.pm
	solenv/bin/modules/installer/control.pm
	solenv/bin/modules/installer/downloadsigner.pm
	solenv/bin/modules/installer/javainstaller.pm
	solenv/bin/modules/installer/packagepool.pm
	solenv/bin/modules/installer/patch/InstallationSet.pm
	solenv/bin/modules/installer/scriptitems.pm
	solenv/bin/modules/installer/windows/feature.pm
	solenv/bin/modules/installer/windows/msiglobal.pm
	solenv/bin/modules/installer/windows/sign.pm
	solenv/bin/modules/installer/worker.pm
	solenv/bin/modules/installer/xpdinstaller.pm
	solenv/bin/modules/osarch.pm
	solenv/bin/modules/packager/work.pm
	solenv/bin/modules/pre2par/parameter.pm
	solenv/bin/patch_tool.pl
	solenv/bin/transform_description.pl
	solenv/doc/gbuild/doxygen.cfg
	solenv/gbuild/LinkTarget.mk
	solenv/gbuild/gbuild.mk
	solenv/inc/os2gcci.mk
	solenv/inc/settings.mk
	solenv/inc/startup/Readme
	solenv/inc/target.mk
	solenv/inc/tg_compv.mk
	solenv/inc/tg_javav.mk
	solenv/inc/unitools.mk
	solenv/inc/unxbsdi.mk
	solenv/inc/unxbsdi2.mk
	solenv/inc/unxbsds.mk
	solenv/inc/unxfbsd.mk
	solenv/inc/unxlng.mk
	sot/source/sdstor/stg.cxx
	sot/source/sdstor/stgelem.cxx
	sot/source/sdstor/ucbstorage.cxx
	starmath/inc/toolbox.hxx
	starmath/source/mathmlexport.cxx
	starmath/source/node.cxx
	starmath/source/toolbox.cxx
	starmath/source/view.cxx
	stoc/source/bootstrap/bootstrap.xml
	stoc/source/corereflection/criface.cxx
	stoc/source/invocation/invocation.cxx
	stoc/source/security/access_controller.cxx
	stoc/source/servicemanager/servicemanager.cxx
	stoc/source/tdmanager/tdmgr.cxx
	stoc/test/javavm/testjavavm.cxx
	stoc/test/testconv.cxx
	stoc/test/testcorefl.cxx
	stoc/test/testintrosp.cxx
	svl/inc/svl/inettype.hxx
	svl/inc/svl/urihelper.hxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.cxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.hxx
	svl/source/config/itemholder2.hxx
	svl/source/items/itemset.cxx
	svl/source/numbers/zforlist.cxx
	svl/source/numbers/zformat.cxx
	svl/source/numbers/zforscan.cxx
	svtools/bmpmaker/bmp.cxx
	svtools/inc/svtools/helpagentwindow.hxx
	svtools/inc/svtools/menuoptions.hxx
	svtools/inc/svtools/miscopt.hxx
	svtools/inc/svtools/optionsdrawinglayer.hxx
	svtools/inc/svtools/stringtransfer.hxx
	svtools/inc/svtools/svlbitm.hxx
	svtools/inc/svtools/svtdata.hxx
	svtools/inc/svtools/valueset.hxx
	svtools/source/brwbox/editbrowsebox.cxx
	svtools/source/config/itemholder2.hxx
	svtools/source/contnr/contentenumeration.hxx
	svx/inc/svx/fmsrcimp.hxx
	svx/inc/svx/svdobj.hxx
	svx/inc/svx/xtable.hxx
	svx/source/accessibility/DGColorNameLookUp.cxx
	svx/source/accessibility/svxrectctaccessiblecontext.cxx
	svx/source/dialog/pfiledlg.cxx
	svx/source/fmcomp/fmgridcl.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/fmcomp/gridctrl.cxx
	svx/source/form/filtnav.cxx
	svx/source/form/fmPropBrw.cxx
	svx/source/form/fmshimp.cxx
	svx/source/form/fmsrcimp.cxx
	svx/source/gallery2/galtheme.cxx
	svx/source/inc/docrecovery.hxx
	svx/source/sdr/event/eventhandler.cxx
	svx/source/svdraw/svdedtv2.cxx
	svx/source/svdraw/svdedxv.cxx
	svx/source/svdraw/svdhdl.cxx
	svx/source/svdraw/svdobj.cxx
	svx/source/svdraw/svdograf.cxx
	svx/source/svdraw/svdoole2.cxx
	svx/source/svdraw/svdotxtr.cxx
	svx/source/svdraw/svdundo.cxx
	svx/source/svdraw/svdxcgv.cxx
	svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
	sw/inc/SwNumberTree.hxx
	sw/inc/ndnotxt.hxx
	sw/source/core/access/acccell.cxx
	sw/source/core/access/acccell.hxx
	sw/source/core/access/accframebase.cxx
	sw/source/core/access/accframebase.hxx
	sw/source/core/access/accmap.cxx
	sw/source/core/access/accpage.cxx
	sw/source/core/access/accpage.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/access/accpara.hxx
	sw/source/core/bastyp/swrect.cxx
	sw/source/core/crsr/findtxt.cxx
	sw/source/core/doc/docdde.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/docnode/section.cxx
	sw/source/core/draw/dcontact.cxx
	sw/source/core/edit/edlingu.cxx
	sw/source/core/inc/anchoredobjectposition.hxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/layout/tabfrm.cxx
	sw/source/core/layout/trvlfrm.cxx
	sw/source/core/ole/ndole.cxx
	sw/source/core/text/atrstck.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/itratr.cxx
	sw/source/core/text/itrform2.cxx
	sw/source/core/text/itrform2.hxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/uibase/dochdl/swdtflvr.cxx
	sw/source/core/uibase/docvw/PostItMgr.cxx
	sw/source/core/uibase/docvw/SidebarWin.cxx
	sw/source/core/uibase/docvw/edtwin.cxx
	sw/source/core/uibase/envelp/labimg.cxx
	sw/source/core/uibase/uiview/pview.cxx
	sw/source/core/uibase/uno/unomailmerge.cxx
	sw/source/core/undo/unattr.cxx
	sw/source/core/undo/untbl.cxx
	sw/source/core/unocore/unochart.cxx
	sw/source/core/view/vdraw.cxx
	sw/source/core/view/vnew.cxx
	sw/source/filter/basflt/fltini.cxx
	sw/source/filter/html/wrthtml.cxx
	sw/source/filter/inc/wwstyles.hxx
	sw/source/filter/rtf/rtffly.cxx
	sw/source/filter/rtf/swparrtf.cxx
	sw/source/filter/ww8/docxattributeoutput.cxx
	sw/source/filter/ww8/dump/msvbasic.cxx
	sw/source/filter/ww8/dump/ww8scan.cxx
	sw/source/filter/ww8/dump/ww8scan.hxx
	sw/source/filter/ww8/dump/ww8struc.hxx
	sw/source/filter/ww8/wrtww8.cxx
	sw/source/filter/ww8/ww8graf.cxx
	sw/source/filter/ww8/ww8par.cxx
	sw/source/filter/ww8/ww8par2.cxx
	sw/source/filter/ww8/ww8par2.hxx
	sw/source/filter/ww8/ww8par3.cxx
	sw/source/filter/ww8/ww8par6.cxx
	sw/source/filter/ww8/ww8scan.cxx
	sw/source/filter/ww8/ww8scan.hxx
	sw/source/ui/dbui/dbinsdlg.cxx
	sw/source/ui/inc/tablemgr.hxx
	sw/source/ui/inc/uitool.hxx
	sw/source/ui/lingu/olmenu.cxx
	sw/source/ui/uiview/viewport.cxx
	sysui/desktop/productversion.mk
	sysui/desktop/slackware/makefile.mk
	testgraphical/source/CallExternals.pm
	testgraphical/source/fill_documents_loop.pl
	testgraphical/ui/java/ConvwatchGUIProject/src/IniFile.java
	toolkit/doc/layout/notes.txt
	toolkit/doc/layout/oldnotes.txt
	toolkit/source/awt/vclxtabcontrol.cxx
	toolkit/src2xml/source/srcparser.py
	toolkit/workben/layout/editor.cxx
	tools/inc/tools/simplerm.hxx
	tools/inc/tools/solar.h
	tools/source/communi/geninfo.cxx
	tools/source/fsys/dirent.cxx
	tools/source/fsys/filecopy.cxx
	tools/source/fsys/os2.cxx
	tools/source/inet/inetmime.cxx
	tools/source/rc/resmgr.cxx
	ucb/source/core/ucbcmds.cxx
	ucb/source/ucp/file/filglob.cxx
	ucb/source/ucp/odma/odma_content.cxx
	ucb/source/ucp/tdoc/ucptdoc.xml
	ucb/source/ucp/webdav/makefile.mk
	ucbhelper/inc/ucbhelper/simplecertificatevalidationrequest.hxx
	ucbhelper/source/client/content.cxx
	ucbhelper/source/client/interceptedinteraction.cxx
	udkapi/com/sun/star/beans/XPropertiesChangeListener.idl
	udkapi/com/sun/star/io/ObjectOutputStream.idl
	udkapi/com/sun/star/io/XMarkableStream.idl
	udkapi/com/sun/star/io/XTextOutputStream.idl
	udkapi/com/sun/star/reflection/CoreReflection.idl
	udkapi/com/sun/star/reflection/XTypeDescriptionEnumerationAccess.idl
	udkapi/com/sun/star/test/XSimpleTest.idl
	unodevtools/source/skeletonmaker/skeletoncommon.cxx
	unodevtools/source/skeletonmaker/skeletoncommon.hxx
	unotools/inc/unotools/cacheoptions.hxx
	unotools/inc/unotools/cmdoptions.hxx
	unotools/inc/unotools/dynamicmenuoptions.hxx
	unotools/inc/unotools/extendedsecurityoptions.hxx
	unotools/inc/unotools/fontoptions.hxx
	unotools/inc/unotools/historyoptions.hxx
	unotools/inc/unotools/idhelper.hxx
	unotools/inc/unotools/internaloptions.hxx
	unotools/inc/unotools/localisationoptions.hxx
	unotools/inc/unotools/moduleoptions.hxx
	unotools/inc/unotools/printwarningoptions.hxx
	unotools/inc/unotools/securityoptions.hxx
	unotools/inc/unotools/startoptions.hxx
	unotools/inc/unotools/workingsetoptions.hxx
	unotools/source/config/cmdoptions.cxx
	unotools/source/config/compatibility.cxx
	unotools/source/config/configitem.cxx
	unotools/source/config/configmgr.cxx
	unotools/source/config/dynamicmenuoptions.cxx
	unotools/source/config/fontcfg.cxx
	unotools/source/config/itemholder1.hxx
	unotools/source/config/moduleoptions.cxx
	unotools/source/config/pathoptions.cxx
	unotools/source/config/viewoptions.cxx
	unotools/source/misc/sharedunocomponent.cxx
	uui/source/fltdlg.cxx
	uui/source/iahndl-filter.cxx
	vbahelper/inc/vbahelper/collectionbase.hxx
	vbahelper/source/msforms/vbacontrol.cxx
	vbahelper/source/vbahelper/collectionbase.cxx
	vcl/aqua/source/gdi/atsfonts.cxx
	vcl/inc/aqua/salmathutils.hxx
	vcl/inc/graphite_cache.hxx
	vcl/inc/jobset.h
	vcl/inc/os2/salgdi.h
	vcl/inc/osx/saldata.hxx
	vcl/inc/salgdi.hxx
	vcl/inc/salwtype.hxx
	vcl/inc/unx/wmadaptor.hxx
	vcl/inc/vcl/print.hxx
	vcl/inc/vcl/strhelper.hxx
	vcl/os2/source/app/salinst.cxx
	vcl/os2/source/app/saltimer.cxx
	vcl/os2/source/gdi/salgdi2.cxx
	vcl/osx/salframeview.mm
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/dndtest.cxx
	vcl/source/app/dbggui.cxx
	vcl/source/control/ilstbox.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/outdev4.cxx
	vcl/source/gdi/outdev6.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/pdfwriter_impl2.cxx
	vcl/source/gdi/print.cxx
	vcl/source/gdi/print2.cxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/source/window/printdlg.cxx
	vcl/source/window/tabdlg.cxx
	vcl/source/window/window.cxx
	vcl/source/window/winproc.cxx
	vcl/unx/generic/app/saldisp.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/gtk/app/gtkdata.cxx
	vcl/win/source/gdi/salgdi2.cxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/window/salframe.cxx
	vos/inc/vos/pipe.hxx
	vos/inc/vos/process.hxx
	vos/inc/vos/signal.hxx
	vos/inc/vos/socket.hxx
	vos/inc/vos/thread.hxx
	vos/source/pipe.cxx
	vos/source/socket.cxx
	wizards/com/sun/star/wizards/agenda/AgendaTemplate.java
	wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java
	wizards/com/sun/star/wizards/agenda/TopicsControl.java
	wizards/com/sun/star/wizards/web/FTPDialog.java
	wizards/com/sun/star/wizards/web/ImageListDialog.java
	wizards/com/sun/star/wizards/web/Process.java
	wizards/com/sun/star/wizards/web/ProcessStatusRenderer.java
	wizards/com/sun/star/wizards/web/TOCPreview.java
	wizards/com/sun/star/wizards/web/WWD_Startup.java
	wizards/com/sun/star/wizards/web/data/TypeDetection.java
	wizards/com/sun/star/wizards/web/export/ImpressHTMLExporter.java
	writerfilter/inc/doctok/WW8Document.hxx
	writerfilter/source/dmapper/DomainMapper.cxx
	writerfilter/source/dmapper/NumberingManager.cxx
	writerfilter/source/dmapper/PropertyMap.cxx
	writerfilter/source/dmapper/StyleSheetTable.cxx
	writerfilter/source/doctok/WW8StructBase.hxx
	writerfilter/source/doctok/resources.xmi
	writerfilter/source/ooxml/README.efforts
	xmerge/source/activesync/XMergeFilter.cpp
	xmerge/source/minicalc/java/org/openoffice/xmerge/converter/xml/sxc/minicalc/SxcDocumentDeserializerImpl.java
	xmerge/source/palmtests/qa/comparator/pdbcomparison.java
	xmerge/source/palmtests/qa/test_spec/convertor_test_spec.html
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java
	xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDescriptor.java
	xmerge/workben/jstyle.pl
	xmlhelp/source/cxxhelp/provider/databases.hxx
	xmlhelp/source/cxxhelp/provider/provider.cxx
	xmlhelp/source/treeview/tvread.cxx
	xmloff/inc/txtfldi.hxx
	xmloff/inc/xmloff/xmlmultiimagehelper.hxx
	xmloff/inc/xmloff/xmluconv.hxx
	xmloff/source/core/xmlexp.cxx
	xmloff/source/draw/shapeexport2.cxx
	xmloff/source/draw/shapeexport3.cxx
	xmloff/source/meta/xmlversion.cxx
	xmloff/source/style/impastp4.cxx
	xmloff/source/style/xmlaustp.cxx
	xmloff/source/text/XMLSectionExport.cxx
	xmloff/source/text/txtflde.cxx
	xmloff/source/text/txtimp.cxx
	xmloff/source/text/txtparae.cxx
	xmloff/source/text/txtparai.cxx
	xmloff/source/text/txtvfldi.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx

Change-Id: Ie072e7c3a60c5dae16a67ac36d1f372c5065c99c
2014-05-01 08:59:14 +01:00
dfeadd06ce coverity#705538 Unintentional integer overflow
Change-Id: I50f0701bea8f2f2e00a6b1396ba7cfbf5e0bd00c
2014-04-20 20:40:19 +01:00
8bb2ce61c0 fixincludeguards.sh: some smaller dirs
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-19 11:10:13 +02:00
8144550c12 Remove unused functions
Change-Id: Ifa8fad734c716deeed32137f09cbe88378d11faf
2014-04-07 12:40:21 +02:00
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
4e3cf9cd8e MSVC helpfully provides warning C4310: cast truncates constant value
Change-Id: I985216d7bade6cbb3a037b07fe44438543d63ba0
2014-03-30 23:08:54 +02:00
a6f0f4156e sot: convert that to SAL_INFO
Change-Id: Iaf2de623c0893b0f500d54ce6558bf40af6e655b
2014-03-30 22:41:49 +02:00
ba46f32c80 deploy some asserts to detect truncated STREAM_SEEK_TO_END
Since STREAM_SEEK_TO_END is now 64 bits it could happen that some
existing code uses it in some indirect manner and it gets truncated to
32 bits somewhere (on 32 bit platforms); try to detect that with asserts.

Of course the checked value is now a valid stream position, so
perhaps the checks should eventually be removed.

Change-Id: I4248c00d758220bdc3ee94c7aa7a7bd4c86c57f0
2014-03-30 22:41:48 +02:00
1b40966fd0 sot: fix some bizarre resize code that creates 4G temp files on 32bit
StgTmpStrm::SetSize(): the nEndOfData - 1 may underflow if nEndOfData=0
which happened to be the same value of STREAM_SEEK_TO_END before
but not any more; also it's a mystery to me why the last byte in the
buffer would need to be overwritten with 0 here.

This also fixes the failure of ww8_export test.

Change-Id: Iefe5a22c667ee83fbc315d772f357b913105ad93
2014-03-30 22:41:48 +02:00
3e71c1068a Fix some types in virtual methods to properly override.
Thanks to SAL_OVERRIDE!
Adapting to 1258b576aef2ff3cdd4f44e1c03edb8c862a79f6

Change-Id: Iafc9660312ad33f6136c15170c35a59e61c76b26
2014-03-29 11:50:30 +01:00
1258b576ae tools: support 64-bit file positions in SvStream
Bump stream positions to 64 bits on:

SvLockBytes::SetSize()
SvStream::SeekPos()
SvStream::SetSize()
SvStream::SetStreamSize()
SvStream::Seek()
SvStream::SeekRel()
SvStream::Tell()
SvStream::remainingSize()
SvStream::nActPos
SvStream::nBufFilePos

Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919
TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
2014-03-29 02:03:07 +01:00
47bf12afa0 coverity#1078520 Logically dead code
Change-Id: I91ff819bbbca9f74236bcec725b98f8065a84a50
2014-03-28 15:35:52 +00:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-26 11:54:55 +01:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
0654c95af1 debug only code SotFactory::Find(SvGlobalName const&)
Change-Id: Ia7e94a0580a26dad874b2f53b4bc17d5c4b6d115
2014-03-05 09:17:49 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
614e1a6cf8 Remove visual noise from sot
Change-Id: I731691d4cac8567938407a514a25e13b2baa7958
Reviewed-on: https://gerrit.libreoffice.org/8314
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:12:25 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
91e7943cac cid#1078823 Dereference before null check
Change-Id: If1a3f54ee38cd97693cebaea680b46ba846b2e71
2014-02-20 09:31:12 +02:00
81a2fc7867 sot: sal_Bool -> bool fixup
Change-Id: I53777b6f72f5ff60228e40e9ec2a0e909e059fcf
2014-02-19 14:05:37 +01:00
da2efb3e14 Perhaps it's better to use nMaxLegalStr here than using hardcoded 32.
Change-Id: Idee4667f5ef9aa71af05139b6fc7ee8a5166b398
2014-02-12 14:46:47 -05:00
b2878af322 more SvStream:operator>> conversion
Convert the template based read_lenPrefixed methods to regular
methods.

Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:32:11 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
c47db038f9 fdo#52547 SOT: Prefer embedding image data to embedding linked image.
When copying an image from e.g. Firefox or Chromium the clipboard
will contain both the image itself, and the url of the image --
presumably it makes more sense to store the image data itself if
it is available -- the order of the items in the *_FREE_AREA_Copy
defines the order of preference for which data in the clipboard
should be used.

Change-Id: Id8b862a9f2fce3a34adbb16509e9b7372500a239
Reviewed-on: https://gerrit.libreoffice.org/7928
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-12 11:07:47 +00:00
8a0298fc1f remove commented code
Change-Id: Ibc04f08b52d754263151ee66d03b58abe2f4e4ee
2014-02-10 23:42:56 +01:00
b362180221 fix crash during xls import, related fdo#36580
Looks like a possibly invalid xls file but let us just do the right
thing and not crash.

Change-Id: Id96db06798cd19d96938ca84956046e5a5e5b529
2014-02-10 23:42:56 +01:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
90d39a8a22 Resolves: #i124085# disabled CF_DIBV5...
(no advantages but some problems), increased png support

(cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81)

Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-30 09:21:30 +00:00
41b0357fb7 bool improvements
Change-Id: Ia8d1f04a78dfd1b7fd6a3bd1e23f643b4bb7911f
2014-01-28 20:26:22 +01:00
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
35a45cd2b2 Removed unused solar.h reference in sot
Change-Id: If49a8b583c8805e31abe158c31b3d2c9c79e6e27
Reviewed-on: https://gerrit.libreoffice.org/7518
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20 21:32:46 +00:00