Commit Graph

1446 Commits

Author SHA1 Message Date
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
2d700944b5 java: remove unused imports
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
e7a474b29a java: remove unused variables
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
e80c3152fd Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I004905375489fa5533ab4af13ebba439ba792384
2014-08-07 18:40:17 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
f124688cfd java: remove various unused variables
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-08-05 11:31:49 +02:00
1d36d91d0a use BOOST_STATIC_ASSERT for sizeof check
Change-Id: Iad00aa47ef65fe163eff407549c26eb3590ab132
2014-07-24 00:34:49 +02:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
266fa9f4f7 fVal->nVal
Change-Id: Ia5b041094f29e42cb60f2c83888cace42b91cc13
2014-06-24 12:05:20 +01:00
a1b89677b7 coverity#982255 Operands don't affect result
fVal started out as a double, but is now a sal_Int64 since

 commit 353607df2ed59f00ad67a74de29b3db662ea960a
 Author: Lars Langhans <lla@openoffice.org>
 Date:   Mon Oct 9 13:21:27 2000 +0000
    #79269# convert to hyper doesn't use toDouble any longer

so the comparison is always false

Change-Id: Ib0b0a78ba3763fb6564219e69111de13b5afc870
2014-06-24 12:05:20 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
a8d5b0c815 stoc: remove SAL_THROW macro
Change-Id: I7443c855a7145837621887030b0d3d01cca2a5ac
2014-06-05 08:17:51 +02:00
57217e1e9f fdo#68849: Add header guards to all include files
Added header guards to files in directories stoc/, and svtools/

Change-Id: Ib6691b0e3fa09d71696ab947d357e489eb35df66
Reviewed-on: https://gerrit.libreoffice.org/9584
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:13:05 +00:00
ebc0a15515 remove more unnecesary OUString constructor use
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
0f2824b117 remove more unnecessary use of OUString constructor
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
6da59e247a cppcheck: redundantAssignment
Change-Id: Ic4a2738aeba8e0446ea2428d5adab3dd11f72928
2014-05-24 15:46:41 +02:00
b36ccf5843 get stoc to build again
Change-Id: Ie4f04f8d5daf4af66057ec1ead4372c2ef0e7056
2014-05-23 21:37:47 +01:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
dffc29614f cppcheck: fprintf format string requires 1 parameter but only 0 are given
Change-Id: I31a5a4e2bad79cfc425fb712688794a4a1dc4f60
2014-05-22 12:50:48 +02:00
e01f3e4559 stoc: fix includes
Change-Id: I0809bfa6897d469e63d6e84898f60aae16a14862
2014-05-22 12:50:47 +02:00
c38678e140 stoc: convert TEST_LIST_CLASSES case also
Change-Id: Ib7b00f052c5b907ccc9b0aba924ada41ff1db023
2014-05-22 12:50:47 +02:00
e856f23232 stoc: make use of css alias
Change-Id: I1dd85a7b1236cfebd5e653fe6d329968e556364b
2014-05-22 12:50:47 +02:00
b2d99944c5 stoc: remove using namespace from headers
Change-Id: I1bee29ddcef66cb38ef2619507ad66c886f6f20d
2014-05-22 12:50:47 +02:00
8d54796bf1 enhance pass-by-ref plugin to detect large arguments
Detect arguments larger than 64 chars passed by value.

Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-20 11:17:22 +02:00
638848d5ea idl: remove external header guards
Change-Id: I78661f0750e4213a20dd2341580cbb181897f3ba
2014-05-16 14:37:28 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
c288b17cc5 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-14 23:18:57 +02:00
2d6b33baed coverity#708240 Uninitialized pointer field
Change-Id: I82bb1587d74f7b1f012ff01d0f68ea8cffd16112
2014-05-10 21:12:59 +01:00
1417061d1b stoc: sal_Bool->bool
Change-Id: Id5aaa3ddfe2cfacbe1bddcdeccb9e775ad84d858
2014-04-30 08:43:41 +02:00
da1425650b add missing modelines to idl files
Change-Id: If52651c70ee659c83ef127da4fe5e266cfe7eec2
2014-04-24 11:58:14 +02:00
3f65d353a6 Clean up function declarations
Change-Id: Ife3cb18d22c57c9c2e59317b68cf11a4bf94a40a
2014-04-09 09:53:01 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
c04f4393f5 Unused declaration
Change-Id: Ib753cacf91baa6a761ac8f971b67c0f5ade555b6
2014-04-03 08:20:19 +02:00
5cd46e2b3b Use boost::noncopyable
Change-Id: I9cba1299c54f196a5a7b35384f4c15bbbea273bb
2014-04-03 08:20:19 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
288efb1b48 Remove unused inline function
Change-Id: Ieafdefb5a6981ee2f375cb9ba852de7b21688b42
2014-04-01 09:22:21 +02:00
a3b0d947b0 Work around MSC "'override' cannot be used with 'inline'" bug
Change-Id: If736316402c49153d4c8552672c90552548f90b8
2014-03-26 17:27:01 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
7bb5f9e1a2 Adapt to sal/log.hxx
Change-Id: Ic197b0fc962ff33b0f0a3c7f04d8208ea9123094
2014-03-25 16:17:09 +01:00
9ed5d36981 Use cppu::BaseMutex instead of plain osl::Mutex as base
Change-Id: Ib4fa4669adb217be810840b3f8e4f0e2dda0f7c5
2014-03-18 13:29:14 +01:00
db9d30a8ee Use cppu::BaseMutex instead of plain osl::Mutex as base
Change-Id: Ic7bd99f920fc954e2eeb734e324d15b1af01e30d
2014-03-18 13:29:14 +01:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
85543a2700 coverity#708238 Uninitialized pointer field
Change-Id: I83552efc825d54da9e00d4a9a637118565bd30ca
2014-03-14 15:58:27 +00:00
a5cbf154df coverity#708240 Uninitialized pointer field
Change-Id: I127cfc84412984e9c190f3e5b2e37cf76ebf82f1
2014-03-14 15:58:26 +00:00
0a87796793 No need for Invocation_Impl::setMaterial to be virtual
Change-Id: I5f78d97bcd55c0db71d7c5e3383678586c2cf392
2014-03-12 16:24:43 +01:00
5bce6e34cd stoc: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I57eca2dcf316232c26c528015c4ba18ba3c4760d
2014-03-10 17:39:58 +01:00
25d154bbf9 Use getTypes instead of getImplementationId as cache key
so we can hopefully deprecate getImplementationId and make all implementations
return an empty sequence.

Change-Id: I161b5fce727541ea2c8303b5d228dbc4939a55b6
2014-03-07 16:19:56 +01:00
524bebc924 Clean up introspection caches
Change-Id: Ied10da0f491e7723245056a4c98540f8b56ffe5d
2014-03-07 16:19:56 +01:00