wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
359,769 Commits 5 Branches 0 Tags
67cba3af55e94debe8eb6392bc8d0b2f00a7a199
Commit Graph

210 Commits

Author SHA1 Message Date
Chris Laplante
b0e02e72c2 svl: Remove ASCII art and pointless comments 
Change-Id: Idd8ea0cb7e7d58a29dbfcae084558320efe5fe43
Reviewed-on: https://gerrit.libreoffice.org/10945
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-08-16 22:19:55 -05:00
Philipp Weissenbacher
a120f1da67 fdo#39468 Make svl/ German comment clean 
I went through all files manually and checked with the tool.

Change-Id: I2eba5e61a0814dd88d7c2c001cd85db8032f1b9f
Reviewed-on: https://gerrit.libreoffice.org/10545
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2014-07-25 17:10:49 +00:00
Kohei Yoshida
b2bbd5375a Initialize it with empty OUString instances. 
Since we only store strings the matrix.

Change-Id: Ie30e9ce0235810b3082ba13ac17c7d1b3c19375a
 2014-06-26 13:37:18 -04:00
Kohei Yoshida
f15e440d14 Move SheetPrinter to svl and rename it to GridPrinter. 
I need to use this outside of sc.

Change-Id: I153863d6c5c31e5ab5f25da2dba81bd4d4b6d3fe
 2014-06-26 13:35:33 -04:00
Kohei Yoshida
8c717ff5d7 Revert needless inlining of methods for publicly exposed class. 
Keep the method implementations unexposed please.

Change-Id: Ic9b1f8654e6ebef428d4182782c1aa4962934c6a
 2014-06-26 11:26:16 -04:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold
3db8d606d5 hrc and src files: squeeze multiple newlines 
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
 2014-05-19 20:04:22 +02:00
Thomas Arnhold
9081583e59 fix-includes.pl: svl 
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
 2014-05-15 10:01:24 +02:00
Noel Grandin
248145f99e Find places where uno::Sequence is passed by value. 
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-14 08:10:22 +00:00
Caolán McNamara
0b799c7a2d coverity#738855 Uninitialized pointer field 
Change-Id: If45c6b7399e19e9414a5ba24a1f6d2e5bb3f82a8
 2014-05-10 21:12:59 +01:00
Chr. Rossmanith
2c9d68ff56 move INetContentTypes::scan() to INetMIME::scanContentType() 
to avoid circular dependencies between svl and tools when using
INetContentType::scan functionality for future handling of data urls in
urlobj.cxx

Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-05-09 16:01:30 +02:00
Stephan Bergmann
2addd7f17a Clean up function declarations and some unused functions 
Change-Id: Id7ecd49ea03f225fc350a31437c32b4a738d7199
 2014-04-07 13:46:19 +02:00
Norbert Thiebaud
ac13f88b5d coverity#708257: Unitialized scalar field 
Change-Id: Ib46e6f5cb52cd47c4c9914b2f15633f5e6af1fe6
 2014-04-06 13:11:27 -05:00
Caolán McNamara
01b0201436 coverity#738855 Uninitialized pointer field 
Change-Id: I3c1528f2dd8e3bde2672ebc153c9cb5c5c0a13fd
 2014-04-04 16:24:37 +01:00
Stephan Bergmann
ac1e33b069 Remove unused inline function 
Change-Id: Ib1e05194fd51b914da45cbdfb75e142be5d852fe
 2014-04-01 09:23:08 +02:00
Michael Stahl
4e3cf9cd8e MSVC helpfully provides warning C4310: cast truncates constant value 
Change-Id: I985216d7bade6cbb3a037b07fe44438543d63ba0
 2014-03-30 23:08:54 +02:00
Michael Stahl
ba46f32c80 deploy some asserts to detect truncated STREAM_SEEK_TO_END 
Since STREAM_SEEK_TO_END is now 64 bits it could happen that some
existing code uses it in some indirect manner and it gets truncated to
32 bits somewhere (on 32 bit platforms); try to detect that with asserts.

Of course the checked value is now a valid stream position, so
perhaps the checks should eventually be removed.

Change-Id: I4248c00d758220bdc3ee94c7aa7a7bd4c86c57f0
 2014-03-30 22:41:48 +02:00
Caolán McNamara
fac0a3b952 coverity#704312 Logically dead code 
Change-Id: Iba394b382ad072593e2b646f1243169bced82ddf
 2014-03-29 18:12:06 +00:00
Michael Stahl
15006df5bd tools: remove unused SvStream::IsA() and associated ID_*STREAM macros 
Change-Id: I6ed0991fb5bd1d5085ee1b93323b57b1afc69860
 2014-03-29 02:03:07 +01:00
Michael Stahl
1258b576ae tools: support 64-bit file positions in SvStream 
Bump stream positions to 64 bits on:

SvLockBytes::SetSize()
SvStream::SeekPos()
SvStream::SetSize()
SvStream::SetStreamSize()
SvStream::Seek()
SvStream::SeekRel()
SvStream::Tell()
SvStream::remainingSize()
SvStream::nActPos
SvStream::nBufFilePos

Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919
TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
 2014-03-29 02:03:07 +01:00
Michael Stahl
19bbfc0b39 tools: allow 64-bit positions on SvLockBytes 
Bump stream positions to 64 bits on:

SvLockBytes::ReadAt()
SvLockBytes::WriteAt()
SvAsyncLockBytes::m_nSize
SvOpenLockBytes::Seek()
SvOpenLockBytes::Tell()
SvOutputStreamOpenLockBytes::m_nPosition
OInputStreamHelper::m_nActPos

Change-Id: Ica3b674e0ab23a756260a51475e97a5396ecdddb
 2014-03-29 02:03:07 +01:00
Stephan Bergmann
c36daa01f4 Introduce INetContentType::scan 
...for use in <https://gerrit.libreoffice.org/#/c/8737/> "new methodINetURLObject::getData()
for data urls."

Change-Id: Id381d7c328153fbea44c0efb80532b2961c6c2b7
 2014-03-27 18:06:27 +01:00
Takeshi Abe
fc8b8033c6 Avoid possible resource leaks by boost::scoped_array 
Change-Id: I4287fa05e35c132fb6e11d95dd17c3d3bf29defc
 2014-03-21 19:17:27 +09:00
Noel Grandin
e395801fd2 remove unused code svl::SharedStringPool::SharedStringPool() 
Change-Id: I497cb89d0b204b9de9c31f86837664d107e55033
 2014-03-03 08:58:59 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
31ea60c882 Remove visual noise from svl 
Change-Id: Ib914ec8d161e24f4e3e1fb8e7684a780d3ae6209
Reviewed-on: https://gerrit.libreoffice.org/8319
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2014-02-25 21:20:26 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Noel Grandin
66e173eb44 Fix typo in my commit 
Fix typo in my commit 82625bb98e256b83351328d3bf2a14e3dd244eef
"remove unnecessary sal_Unicode casts in OUStringBuffer::append calls"

Change-Id: I593c6a8ce5be3d4e2783acd3800626d7eb9a0480
 2014-01-07 10:04:50 +02:00
Noel Grandin
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls 
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
 2014-01-07 09:43:37 +02:00
Noel Grandin
fb84710151 simplify - use OUString::startsWith where possible 
Convert code like
   if( !aStr.isEmpty() && aStr[0] == 'x' )
to
   if( aStr.startsWith("x") )

Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
 2013-12-12 13:15:24 +02:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Kohei Yoshida
7045802f27 Add mutex to guard the shared string pool content. 
Change-Id: I0eb97d0fbeaefd8a1c86d240ed8bd7f208fb662e
 2013-11-06 20:40:22 -05:00
Samuel Mehrbrodt
a71a562a99 fdo 70998: Termchange: Graphics->Image 
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38
Reviewed-on: https://gerrit.libreoffice.org/6524
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-11-04 07:49:45 -06:00
Thomas Arnhold
d15f68087b fixincludeguards.sh: svl 
Change-Id: I70ef44216fb7ddb4e12b9d90406b45cc594279f0
 2013-10-28 15:16:19 +01:00
Noel Grandin
8396cce9b5 clean up places accessing the NULL at the of an OUString 
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.

Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
 2013-10-23 13:12:55 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Kohei Yoshida
78e0d07b62 Compare by pointers first. 
Change-Id: Iec697f7100c06da37158e564ac64f0248f923638
 2013-10-11 15:48:52 -04:00
Kohei Yoshida
19ea624c6d Fix equality operator for SharedString & write test for it. 
Change-Id: Ib592ca2fe359293da6c10aa9e1535a91627cfc43
 2013-10-11 12:14:28 -04:00
Kohei Yoshida
7333881bb7 Formula tokens, formula cells and formula interpreters to use shared strings. 
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
 2013-10-11 12:14:27 -04:00
Kohei Yoshida
0eabc71b59 Import shared formulas from xlsx without crashing. 
The key here is to only use the shared formula ID's and ignore the ref
range. The ref ranges are not correct half the time.

Change-Id: If65f9b1b44ab6239db37977b6dfe3f822a9cf67e
 2013-10-11 12:14:24 -04:00
Kohei Yoshida
cff2f333ae Add isEmpty() to SharedString. This simplies a lot of its call sites. 
Change-Id: I0ebc43abe59ac317c053a4f606dbe376d85c03b0
 2013-10-11 12:14:24 -04:00
Kohei Yoshida
3786609a15 No more getIdentifier*() calls because they are not efficient. 
They shall never be used.

Change-Id: I019c88b1511a67175d782777cd41e0ec0434f497
 2013-10-08 15:48:12 -04:00
Kohei Yoshida
658fc68d57 Store svl::SharedString in document cell storage instead of OUString. 
With this, both ScColumn and ScMatrix store svl::SharedString as their
string values, instead of OUString.

Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
 2013-10-08 15:48:10 -04:00
Kohei Yoshida
ee8fad644e ContentInfo to store svl::SharedString instead of OUString. 
Change-Id: I633e3bb633317eeb61cd804faf20e79312f569f7
 2013-10-08 15:44:34 -04:00
Kohei Yoshida
f4bda54cda Re-implement interning in order to return both string arrays. 
One is for the cased string and the other one for the non-cased one.

Change-Id: I798687f2efecaaea73a09e0b3348f85a9d9e8c07
 2013-10-08 15:44:33 -04:00
Kohei Yoshida
3ff650d565 Rename StringPool to SharedStringPool because that's what it is. 
Change-Id: I2fc3ce4f0c2291d402cb470346d5561373fb51e7
 2013-10-04 19:15:26 -04:00
Kohei Yoshida
4aa4116742 Let's just use sal_uIntPtr straight. 
So that the user of this class won't have to include the header just
to get the string ID type.

Change-Id: I0ccbc18fe02644f69701f57b0b1b9c30fd141d83
 2013-10-04 19:15:24 -04:00
Kohei Yoshida
00d08001da No need to intern strings here; all OUString's are ref-counted. 
Calling intern() simply moves it to a global hash storage.  Now
the test passes.

Change-Id: I0a93420abce1c3adaaa61d469dff5f359dd5ada4
 2013-10-04 19:15:23 -04:00