30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
8c95c0e71a
first delete, then nullify
...
Otherwise an unreachable can happen.
Change-Id: I04f03fc97aa73eb0bf75ad71ca8a1cf2d3729c08
Reviewed-on: https://gerrit.libreoffice.org/10047
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-07-04 18:54:04 +00:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
94e2459cd8
coverity#705245 Missing break in switch, assuming intentional
...
Change-Id: I2ac6acde603c89c5b7736ec7f1a1b42b28726827
2014-06-05 21:14:21 +01:00
0017cafc9d
coverity#705243 Missing break in switch, assuming intentional
...
Change-Id: I4882ba5028e45528cafc1170bc4de6c3a2ea7a12
2014-06-05 21:14:20 +01:00
c24aa2139f
coverity#705247 Missing break in switch
...
Change-Id: Idc647ef41b3a01d89216c3fe74e3fa5af02f7525
2014-06-04 12:48:04 +01:00
3c1e30b77d
Correct common misspellings, and remove some ASCII art along the way.
...
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
2014-05-17 12:38:38 +00:00
0727c09e24
BrowseBoxCheckInvariants appears to be unused [loplugin:unreffun]
...
Change-Id: Ie6c546ee085b20bd3eb39cdfb7b38394c0a35b67
2014-05-13 16:01:43 +02:00
bf30c8b16d
use new VCL IsValueChangedFromSaved method
...
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963
"RFC: add IsValueChangedFromSaved to VCL button and listbox"
Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08 14:55:12 +02:00
b7d30cb50e
svtools: sal_Bool->bool
...
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
dcfbd7bc4e
coverity#704316 odd pDtorNotify hackery
...
Change-Id: I9faa61bb85ec6d89c6f5c9829d137fabb3e98c4a
2014-03-29 18:12:06 +00:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
f661ac03e0
svtools: sal_Bool->bool
...
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
2014-03-24 08:12:09 +02:00
1a1fe47731
svtools: sal_Bool->bool
...
Change-Id: I0c2e9314d85860831b29db76c89c8776c1b071b9
2014-03-24 08:12:08 +02:00
9f12e4a351
svtools: sal_Bool->bool
...
Change-Id: Ic765d1a28960dbeca9501852b5e84cfdfe6ac47e
2014-03-24 08:12:07 +02:00
60211f44fd
coverity#708277 Uninitialized pointer field
...
Change-Id: I9877ef518b68afada1abaf47ebb167fcaf7bda16
2014-03-19 15:37:59 +00:00
68ec95b3f8
made ListBox handle more than 64k elements, fdo#61520 related
...
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.
Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2014-03-05 07:31:19 -06:00
0feaf45541
SVTOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: I83e39d69deaf2aa1c5ca455c92d070a2d33def3f
Reviewed-on: https://gerrit.libreoffice.org/8421
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-03-03 09:19:11 -06:00
bee1cc83ec
Remove visual noise from svtools
...
Change-Id: I7c2b74a449fb20aae5bc643e24a22cf6f732136d
Reviewed-on: https://gerrit.libreoffice.org/8320
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-25 21:14:09 +00:00
ee120240f7
BrowseBox::bHideCursor misuses sal_Bool for TriState
...
(TRISTATE_INDET == "smart" is probably obvious enough to not warrant an extra
enum.)
Change-Id: I5fde5294c83c9f805d9df645089665b9dbcfec96
2014-02-25 12:44:37 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
e8f8f24c84
vcl: sal_Bool -> bool
...
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545
Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
...
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-20 16:22:17 +00:00
14a502e498
coverity#738857 Uninitialized scalar field
...
Change-Id: Ic82e559e9b7ca31fa6d9b5ff1d1fc5ae3fac9b88
2014-02-19 13:06:17 +00:00
27fae00bf2
coverity#441136 Dereference after null check
...
Change-Id: I81a1a70094ae6b4ed685ae3fe88c645b160955bf
2014-02-12 14:26:47 +00:00
c25ebf75e0
MultiSelection::GetRangeCount() returns size_t
...
Change-Id: Ief072cef486556c9b43364e108a021510781f7c6
2014-02-03 22:56:54 +01:00
bd9581d46d
bool improvements
...
Change-Id: I23e29995bc7af791067de4996923b6279f7f8892
2014-01-28 20:24:40 +01:00
bbd9668d5f
bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
...
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
101e5cc49c
bool improvements
...
Change-Id: I85faf4e3fcab6763af11eb6a4082820e88bea1ca
2014-01-21 18:24:03 +01:00
602c87b425
Window::PreNotify should return bool
...
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
04683f1488
Window::Notify should return bool
...
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
6036ae611e
fdo#51180 reset (Multi)Selection on Clear()
...
Change-Id: I06dde63093eab4e5e1c692f6363aca70b89de96a
2014-01-14 18:54:09 +01:00
455b403aaf
translated German comments
...
Change-Id: I75c7611c36c15fb36e00de239f5b322adb182e73
Reviewed-on: https://gerrit.libreoffice.org/7273
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-01-05 19:06:44 +00:00
151887a955
Fix other typos
...
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
b755fb8c0f
Integrate branch of IAccessible2
...
Change-Id: I3b5936bb92bb258f9e9e76402dd2b55f29aa686a
2013-11-25 16:52:36 +00:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
c91d7e9759
fixincludeguards.sh: svtools
...
Change-Id: I7db0d4a7bd948204ff6efd7e61c80efd413967cd
2013-11-05 09:28:53 +01:00
075d472a9d
Use std::auto_ptr::reset where applicable
...
(avoids warnings about std::auto_ptr ctor being deprecated)
Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
2013-10-02 16:49:49 +02:00
81e0c2c38c
WaE: OUString::valueOf in higher debug levels
...
Change-Id: I2aed7907c79905158714dc1b26ae1aefc1fcccc6
2013-08-26 12:36:36 +01:00
c758c9cda0
convert svtools/source/brwbox/datwin.hxx from String to OUString
...
Change-Id: I6fe337f7bce4edcd7e9b2225bfe0b3e952ae010e
2013-08-22 10:49:29 +02:00
99960ec555
convert include/svtools/brwbox.hxx from String to OUString
...
Change-Id: I21bfd9ff242318a0cb5b589df9f59a20fc5c3730
2013-08-22 10:49:26 +02:00
823a6cb825
convert include/svtools/edit*.hxx from String to OUString
...
Change-Id: Iae86236aa3af31b09cddeca0a9725b4f5e125d6c
2013-08-22 10:49:25 +02:00
81aa4049d1
XubString->OUString
...
Change-Id: I0b7c2753fd6974e0db88cc47156156a37cd92987
2013-08-18 20:23:02 +01:00
fa96ed925f
Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/"
...
This reverts commit 1cbdcc31b8a921c508f2fdf09847f64d004a7faa.
Sadly this was going in the wrong direction...
2013-08-15 17:19:01 +02:00
1cbdcc31b8
fdo#63926 - remove extra include paths in svtools/ and sfx2/
...
- removed some paths from include
- more of this kind wil follow
Change-Id: I0255d8dd338d82dfd4ac3027c34cddea493f105d
Reviewed-on: https://gerrit.libreoffice.org/5281
Reviewed-by: Miklos Vajna <vmiklos@suse.cz >
Tested-by: Miklos Vajna <vmiklos@suse.cz >
2013-08-05 10:22:35 +00:00
cf6a74af53
XubString->OUString
...
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
2013-07-11 14:31:44 +01:00
662d96bc62
vcl: all EnableAutoSize methods take a bool.
...
Change-Id: I6f974d6b82f6bb77996d20219b5c0ceb78596c5c
2013-05-20 12:18:03 +01:00
5630b30168
cppcheck: variables reassigned before using old value
...
Change-Id: I5108253859eac682ab423843f8812c8c8c6ce9fa
2013-05-08 20:17:22 +02:00
