Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.
Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
Renamed functions:
+ supportsOperation -> SupportsOperation
For consistency
+ DrawAlphaBitmap -> DrawDeviceAlphaBitmap
I want to make it more clear that these are the functions that call
on mpGraphics to actually draw on the graphics device
Change-Id: Ic4951bfcc0ac0c09fe5b6908dfdf1f699a634265
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
which means that icons suddenly reappeared in the menus when the gtk
theme had disabled them
ref e8f8f24c8415898c787bbfb629247ed62e73a2b9
Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
...seen CppunitTest_dbaccess_dialog_save fail with
> abort
> __assert_rtn
> ImplDbgTestSolarMutex at vcl/source/app/dbggui.cxx:1678
> DbgFunc at tools/source/debug/debug.cxx:1123
> DbgTestSolarMutex at debug.hxx:286
> OutputDevice::ImplGetGraphics at vcl/source/gdi/outdev.cxx:525
> OutputDevice::GetFontCharMap at vcl/source/gdi/outdev3.cxx:7740
> OutputDevice::HasGlyphs at vcl/source/gdi/outdev3.cxx:7810
> Window::ImplCheckUIFont at vcl/source/window/window.cxx:447
> Window::ImplUpdateGlobalSettings at vcl/source/window/window.cxx:471
> Application::MergeSystemSettings at vcl/source/app/svapp.cxx:495
> SvtMiscOptions_Impl::SetIconTheme at svtools/source/config/miscopt.cxx:592
> SvtMiscOptions_Impl::SetIconThemeAutomatically at svtools/source/config/miscopt.cxx:934
> SvtMiscOptions_Impl::Load at svtools/source/config/miscopt.cxx:514
> SvtMiscOptions_Impl at svtools/source/config/miscopt.cxx:299
> SvtMiscOptions_Impl at svtools/source/config/miscopt.cxx:425
> SvtMiscOptions at svtools/source/config/miscopt.cxx:753
> SvtMiscOptions at svtools/source/config/miscopt.cxx:756
> connectivity::DriversConfigImpl::Load at connectivity/source/commontools/DriversConfig.cxx:106
> connectivity::DriversConfigImpl::getInstalledDrivers at DriversConfig.hxx:53
> connectivity::DriversConfig::getURLs at connectivity/source/commontools/DriversConfig.cxx:243
> ODsnTypeCollection at dbaccess/source/core/misc/dsntypes.cxx:60
> ODsnTypeCollection at dbaccess/source/core/misc/dsntypes.cxx:71
> DatasourceURLListener at dbaccess/source/filter/xml/xmlfilter.cxx:183
> DatasourceURLListener at dbaccess/source/filter/xml/xmlfilter.cxx:183
> dbaxml::ODBFilter::implImport at dbaccess/source/filter/xml/xmlfilter.cxx:451
> dbaxml::ODBFilter::filter at dbaccess/source/filter/xml/xmlfilter.cxx:404
> non-virtual thunk to dbaxml::ODBFilter::filterat dbaccess/source/filter/xml/xmlfilter.cxx:415
> dbaccess::ODatabaseDocument::impl_import_nolck_throw at dbaccess/source/core/dataaccess/databasedocument.cxx:520
> dbaccess::ODatabaseDocument::load at dbaccess/source/core/dataaccess/databasedocument.cxx:585
> non-virtual thunk to dbaccess::ODatabaseDocument::loadat dbaccess/source/core/dataaccess/databasedocument.cxx:602
> dbaxml::DBContentLoader::load at dbaccess/source/filter/xml/dbloader2.cxx:484
> non-virtual thunk to dbaxml::DBContentLoader::loadat dbaccess/source/filter/xml/dbloader2.cxx:553
> framework::LoadEnv::impl_loadContent at framework/source/loadenv/loadenv.cxx:1177
> framework::LoadEnv::startLoading at framework/source/loadenv/loadenv.cxx:401
> framework::LoadEnv::loadComponentFromURL at framework/source/loadenv/loadenv.cxx:172
> framework::Desktop::loadComponentFromURL at framework/source/services/desktop.cxx:603
> non-virtual thunk to framework::Desktop::loadComponentFromURLat framework/source/services/desktop.cxx:604
> unotest::MacrosTest::loadFromDesktop at unotest/source/cpp/macros_test.cxx:43
> DialogSaveTest::test at dbaccess/qa/extras/dialog-save.cxx:73
> CppUnit::TestCaller<DialogSaveTest>::runTest at TestCaller.h:166
> CppUnit::TestCaseMethodFunctor::operatorat TestCase.cpp:32
> (anonymous namespace)::Prot::protect at unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> (anonymous namespace)::Prot::protect at unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:64
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> CppUnit::DefaultProtector::protect at DefaultProtector.cpp:15
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> CppUnit::ProtectorChain::protect at ProtectorChain.cpp:77
> CppUnit::TestResult::protect at TestResult.cpp:181
> CppUnit::TestCase::run at TestCase.cpp:91
> CppUnit::TestComposite::doRunChildTests at TestComposite.cpp:64
> CppUnit::TestComposite::run at TestComposite.cpp:23
> CppUnit::TestComposite::doRunChildTests at TestComposite.cpp:64
> CppUnit::TestComposite::run at TestComposite.cpp:23
> CppUnit::TestRunner::WrappingSuite::run at TestRunner.cpp:47
> CppUnit::TestResult::runTest at TestResult.cpp:148
> CppUnit::TestRunner::run at TestRunner.cpp:96
> (anonymous namespace)::ProtectedFixtureFunctor::run at sal/cppunittester/cppunittester.cxx:150
> sal_main at sal/cppunittester/cppunittester.cxx:242
> main at sal/cppunittester/cppunittester.cxx:166
Change-Id: I217499b41027449df634945c4b260aafdfc4bff4
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory
Conflicts:
include/vcl/settings.hxx
vcl/source/app/settings.cxx
vcl/source/window/window.cxx
Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The name Application::SystemSettingsChanging implies that the app is
being notified that system settings are being changed. This is not
what the function does - in fact, SystemSettingsChanging overrides
a settings object with user defined settings
Change-Id: Ibbf821ff3c7ec5b38e2e79751058494c749b6428
Reviewed-on: https://gerrit.libreoffice.org/7629
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This took a bit of code archaelogy for me to track down. It turns out that
as part of an effort to optimize startup, the line of code in this function
was commented out, presumably to be rewritten later. This happened in
commit ee3351d78c in July 2001 (!).
About three years later, in February 2004, the function was rewritten in
commit 189c2388d80. As it turns out, the only two functions that used
the Window parameter were vcl/source/window/window.cxx (which passed
itself in, but of course this did nothing) and
vcl/source/window/winproc.cxx. Furthermore, winproc only ever passed in
the first frame, so it didn't really do anything either.
Consequently, the function as it stands *now* only notifies the
application that system settings have been changed. It doesn't care
which window it tells.
Therefore, I have excised this parameter from the function. I don't
think it made sense when it was implemented anyway, so there is no net
loss.
After removing the unneeded parameter, I was also able to remove the
Window parameter from winproc.cxx's ImplHandleSalSettings function as
it was only ever used to set the top level window, which is now
irrelevant.
Change-Id: I84f2c5c5ff8969387da3af81e4a9c7f9ac6237e1
Reviewed-on: https://gerrit.libreoffice.org/7541
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
note that the autodetect HC option is somewhat broken anyway:
it resets the icon theme hard, so there are not simple roundtrips
enableing/disabling it for that, but those havent been there before
either.
Change-Id: Ia35a41717224dfb7437054bb885c61d7e0b189d7
- dark theme default to high contrast
- as per fdo#35365, having a dark document background is inconvenient
for non-a11y endusers
- a11y standard require the (rather ugly) background for a11y
- thus, when "automatically detect high contract mode of operating
system"
in Tools->Options->a11y is enabled, use the dark document
background
by default, otherwise use a white default
Change-Id: Id8ad1eb3d57b3708ac5a241092208e3a8d98ade0
