a6f78bf8fd
Treeview may lose focus when left/right arrow is used
...
In a treeview, for example the hierarchal view of the
styles and formatting panel, if your not on a node that is
expandable or collapsable when you press the left or right
arrow key, the focus will move away from the tree view in
a very awkward way. This patch makes the control work more
like a native treeview.
At this point I don't feel confident about the surrounding
code to avoid the code duplication that this patch adds.
Change-Id: Ibd04cf5329b4d226aac102d214a45e45811982e7
Reviewed-on: https://gerrit.libreoffice.org/10956
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 11:36:48 -05:00
6a39fdf81f
callcatcher: update unused code
...
Change-Id: I6cb74836f98d7507359f39e1fd03a1462b2e0c31
2014-08-28 09:50:33 +01:00
c6542e4f7a
WaE: macro is not used
...
Change-Id: I37ec7e6104dc9526b1792f163fe58ec8673274c2
2014-08-27 13:26:11 +03:00
93b35682c4
WaE: Unreferenced function definitions
...
Change-Id: I8c21bfd70e5afb6d4f9a0a57f9946074c1b16a52
2014-08-27 13:26:10 +03:00
53617c8651
callcatcher: update unused code
...
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
fe7d0ea643
convert sw use of template manager to new manager
...
this completes the conversion of resource hosted
dialogs and tabpages to .ui gtkbuilder format
Change-Id: Ic1b49d5560bfa47f287e04918c01daeebba28163
2014-08-26 15:36:52 +01:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
b3d9852309
Remove more useless includes of tools/debug.hxx
...
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-20 09:10:01 -05:00
e1683c2d13
callcatcher: update unused code
...
lots of ResID stuff going away now
Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
6a393f7843
pass by reference
...
Change-Id: I44e8f40935a19f8023bb23f53c5fb458eb28a3dc
2014-07-12 14:25:04 +02:00
bfdacadec9
Convert DLG_TEMPLATE_INFORMATION to .ui
...
Change-Id: I66469c17a46c1157b8e3801c0dc2b252c569a4bd
Reviewed-on: https://gerrit.libreoffice.org/10213
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-07-11 15:05:36 +00:00
0d78ad871e
DBG_ASSERT->assert when followed by dereference
...
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
55aa83da68
coverity#706073 Unintended sign extension
...
Change-Id: I13272490bf8a08cbfb1ffc37828fb30fb92f9139
2014-07-06 15:15:12 +01:00
d9f585b89b
coverity#706065 Unintended sign extension
...
Change-Id: If482c75af5128778a176c40e38000b78f2087131
2014-07-06 15:15:12 +01:00
f38bf4c6c2
Avoid possible memory leaks in case of exceptions
...
Change-Id: I04a0a2c296206f155ee4916b15b853a7f10c2c2a
2014-07-04 10:49:10 +09:00
c061cb94c0
Drop unused #includes
...
Change-Id: Ief545db58a0dbb26ba293aa71debc816a8925b6c
2014-07-04 10:49:10 +09:00
d1f9507ff8
coverity#706077 Unintended sign extension
...
Change-Id: I3a5d8a946b5134b4cd58694283bea0fac59a043a
2014-07-03 14:52:28 +01:00
a5cc3ce566
Convert DLG_COLLECTION_VIEW to .ui
...
Conflicts:
include/svtools/fileview.hxx
svtools/source/contnr/fileview.cxx
Change-Id: I78b590410ec4e55eeecd2da8ab79738f05e403b5
Reviewed-on: https://gerrit.libreoffice.org/9981
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-07-02 08:47:13 +00:00
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
f90eb33a26
DLG_FPICKER_EXPLORERFILE conversion to .ui
...
Change-Id: I5d8f5d0182fb6af5111b60caa29912d313c2efa0
2014-06-30 16:31:47 +01:00
4523dd0544
Called C++ object pointer is null
...
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
daa6898578
clang: Dead initialization
...
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
9191f44fed
coverity#706069 Unintended sign extension
...
Change-Id: I605adc70d054fe3d5aea3bf1984348aae0e7fc28
2014-06-19 10:26:50 +01:00
3daec14fd6
sizeof(bool) is not required to be 1
...
Change-Id: I19ba4e27a4403d2c17d0bbf3f29c42e4745e4c41
2014-06-19 10:26:49 +01:00
6194080c53
coverity#706067 Unintended sign extension
...
Change-Id: I7b1ace9726c38eafd063e7bd87f463b23fe9d74a
2014-06-19 10:26:49 +01:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
30069114fe
loplugin:staticcall
...
Change-Id: If7b285a2214bc878e8464a986538d0445078fcb3
2014-06-13 17:54:34 +02:00
6f2edd4514
new loplugin: inlinesimpleaccessmethods
...
Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.
Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-04 14:49:08 +02:00
cc25f70ef1
compareTo -> equals
...
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate
Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
177903cf0f
p is for pointers.
...
Change-Id: I7df56e7549e8ccccdfa9ca1b88f85e8c81e4a946
2014-05-15 12:57:59 -04:00
71417f2b72
Actually this empty() check here is redundant.
...
ResortChildren() does that at the very beginning.
Change-Id: I696c9d796cc6631048fb3d9409d6eda1085a7612
2014-05-15 11:24:54 -04:00
b79b8d2c61
Sort ptr_vector using its own sort() method.
...
This also fixes memory leak via nested calls of release().
Change-Id: I3ba90901366319bb3ee870903130042b375f733c
2014-05-15 09:58:01 -04:00
a325ce63db
fix-includes.pl: svtools
...
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
261b1ad80a
'!= false' is redundant, and confusing - kill it.
...
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09 22:28:44 +02:00
b7d30cb50e
svtools: sal_Bool->bool
...
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
93f5d5a919
The opaque PostUserEvent IDs are actually pointers
...
...so declare them as such. This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.
While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent. And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.
Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
5d0272772a
consistent percent sign in comments
...
Change-Id: I9906b4e58fd8672e51f6aa2e56ec68bb28772500
2014-05-06 07:19:08 +02:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
0b03f7ed57
fdo#75058: Optimize autofilter item filling for non-tree items.
2014-04-29 21:30:54 -04:00
c11790bb67
remove OV* debug stuff
2014-04-14 12:31:49 +02:00
fa72a0e94d
Remove unused code
...
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
7077fa3b0d
coverity#708288 Uninitialized scalar field
...
also coverity#708289 Uninitialized scalar field
Change-Id: I7fe8fb8073af6e66fc548e1e10969ca555ea9bab
2014-04-08 12:18:53 +01:00
380d4600d7
use TriState instead of sal_Bool as there's three possibilities
...
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08 09:18:33 +01:00
8aba3a25dd
coverity#984147 Uninitialized pointer field
...
the original SvLBoxEntry::Clone did...
pUserData = ((SvLBoxEntry*)pSource)->GetUserData();
nEntryFlags = ((SvLBoxEntry*)pSource)->nEntryFlags;
so presumably this is what we want to do here
Change-Id: Icaafb1f5c62847167886a230391efa5f7a3fca99
2014-04-04 16:24:36 +01:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
436cd90095
svtools: sal_Bool->bool
...
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
c849d750eb
svtools: sal_Bool->bool
...
Change-Id: I05dd992f332ab2f3dbcc65aed6dac909872168d4
2014-03-25 14:32:55 +02:00
