Commit Graph

1152 Commits

Author SHA1 Message Date
aa906f3e8a Typo: childs->children
Change-Id: Ib27b3e125581884b90efc9cc33b6b2aadab73851
2014-08-31 21:36:08 +02:00
d54b2bd8dc Resolves: fdo#83068 ignore spaces in font-size unit detection
Change-Id: Id9a5c2ee576bd533d8b0a2b4356e319354abbbac
2014-08-29 09:27:38 +01:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
b3d9852309 Remove more useless includes of tools/debug.hxx
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 09:10:01 -05:00
ef4fb3976a svtools: show spin for FormattedField
User can increase / decrease values in FormattedField with scrolling
with the mouse, so there is no reason to hide the spin buttons.

Change-Id: Ie342f456cdb45c1d7287df70faa786c0e7dc2425
2014-08-17 10:41:12 +02:00
e1683c2d13 callcatcher: update unused code
lots of ResID stuff going away now

Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
086611d2ce coverity#1202783 Division or modulo by zero
Change-Id: I17892b9daa3be450001ac88239008d0d27f4a01f
2014-08-07 18:00:49 +01:00
b0cdd038ee fdo#51534 - rulers should have app-background by default (apparently).
Change-Id: I981febb02074ed323732ef7c19e89f1e946604f1
2014-07-24 14:26:54 -04:00
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
ebdb4a00fa coverity#1202783 Division or modulo by zero
Change-Id: Ida169195697d3976500a16e3cced40b25664a02e
2014-07-18 15:36:17 +01:00
b43fdc54e5 cid#1194925 Resource leak
add an assert so that coverity knows the leak can't happen

Change-Id: I0109309ccc53b1b22420cbf9ac497d8d677a4ea7
2014-07-14 11:07:47 +02:00
f38bf4c6c2 Avoid possible memory leaks in case of exceptions
Change-Id: I04a0a2c296206f155ee4916b15b853a7f10c2c2a
2014-07-04 10:49:10 +09:00
cfdf9a6c5a coverity#706081 Unintended sign extension
and

coverity#706080 Unintended sign extension

Change-Id: Ieb5bd639567767b4c6b2957a9e628eb841713198
2014-07-03 14:52:27 +01:00
bca68c4a34 coverity#736898 Unintended sign extension
Change-Id: Ie09d25b2f9993435ebffc52c7257cd9396672c8f
2014-07-03 14:52:24 +01:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
78bea877ff OSL_ENSURE->assert where guaranteed deref follows
Change-Id: I6e007cc3a9fd222c1c1381c8b4f890966c05cbab
2014-06-27 17:22:09 +01:00
358c1fa7fa coverity#736899 Unintended sign extension
Change-Id: I4fcd7df318cec8dccd1516c6d52b7d0c67885a6c
2014-06-18 11:12:09 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7eceffef49 Resolve fdo#79913 by checking index bounds
Change-Id: I023a625d73724332245d612a61cb786acefc4cf2
Reviewed-on: https://gerrit.libreoffice.org/9791
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-16 10:54:37 +00:00
30069114fe loplugin:staticcall
Change-Id: If7b285a2214bc878e8464a986538d0445078fcb3
2014-06-13 17:54:34 +02:00
6f2edd4514 new loplugin: inlinesimpleaccessmethods
Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.

Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-04 14:49:08 +02:00
f634cda2a2 avoid problems with poppler's and vcl's FontInfo during runtime
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04 07:49:15 +02:00
0d20725fcc remove whitespace
Change-Id: Iae0f6b9818f84a92c46b24f90d3051c7b6a45d94
2014-06-04 07:49:14 +02:00
41a1f95abe remove whitespace
Change-Id: Iff12a4106369114eb785c0ce242c0e296a877495
2014-06-04 07:49:14 +02:00
5f743ea308 remove whitespace
Change-Id: I08a89e40d24bc6f4b106c5063c197fe201f32bf6
2014-06-04 07:49:13 +02:00
57217e1e9f fdo#68849: Add header guards to all include files
Added header guards to files in directories stoc/, and svtools/

Change-Id: Ib6691b0e3fa09d71696ab947d357e489eb35df66
Reviewed-on: https://gerrit.libreoffice.org/9584
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:13:05 +00:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
a325ce63db fix-includes.pl: svtools
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
b7d30cb50e svtools: sal_Bool->bool
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
93f5d5a919 The opaque PostUserEvent IDs are actually pointers
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
9124f7e8bc Move headers included only in svtools to svtools
Change-Id: I66e443b5b641aaf16e1918f139a6b6a173ef7d4c
2014-05-06 15:30:05 +03:00
cbb9efa642 Related: fdo#72142 lighter ruler default color
Change-Id: Iadb8bb134e3ecda974b8a9d8589fdc5ed02907f0
2014-04-30 17:11:31 +01:00
6f59894afc WaE: implicit conversion from bool to 'long'
Change-Id: Ibe8bf3070fb64b447315b280c7c06a7851f7a7ed
2014-04-28 19:13:26 +03:00
2554d0ab4e remove unused code from TabBar
Change-Id: I9f975d99893135b414c749c4fe86912362375c4e
Reviewed-on: https://gerrit.libreoffice.org/9162
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-28 12:01:04 +00:00
883481fd20 Improve TabBar return types
DeactivatePage() goes from returning long to returning bool.
StartRenaming goes from returning long to returning bool.
AllowRenaming goes from returning long to returning a
constant from a new enum.

Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca
Reviewed-on: https://gerrit.libreoffice.org/9161
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-28 11:37:37 +00:00
b8315b1c2f fdo#72006 Populate "Load URL" dropdown from picklist.
f7feb4227d83f4f095597a44826277aaae2bc0df stopped any newly opened documents
from being added to the "History" list (and instead adds them to the picklist),
since the history list is not used anywhere else, and since the picklist performs
an equivalent function, it makes most sense just to use the picklist to populate
the list of URLs.

Change-Id: I5a06e7fefe3dc1fbe266f3191de4fbac03601858
Reviewed-on: https://gerrit.libreoffice.org/9104
Tested-by: Andrzej Hunt <andrzej.hunt@collabora.com>
Reviewed-by: Andrzej Hunt <andrzej.hunt@collabora.com>
2014-04-26 07:42:37 +00:00
371046c6a3 add missing modelines to cxx and hxx files
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-24 11:58:15 +02:00
0b7f82d7cb add missing modelines to hrc and src files
Change-Id: I82d9727c4f991c606a19b9eba27732e7e2397db6
2014-04-24 11:58:14 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
9ea483e8a9 svtools: valueset.cxx - use scoped_ptr and clean-up
Change-Id: I91528f55af39faccfe1bf95999ac29669ead0aad
2014-04-18 21:07:02 +02:00
6b6bf85661 Cleanup valueset.cxx
Change-Id: Ib0a27d8d3a3e974f73e7873ad8baae4721f6fb87
2014-04-18 21:07:01 +02:00
902cafe656 coverity#1202783 Division or modulo by zero
Change-Id: I183416ad3db39108e52c1e69b60fb547448b21a8
2014-04-18 12:21:43 +01:00
516a22afa5 coverity#704807 Dereference after null check
Change-Id: Ifbfdbc016cde790a2027a0036294b3be9e37a85c
2014-04-17 18:33:37 +01:00
cfddda092b sal_Bool to bool in SvtRulerAccessible
Change-Id: Ib5f451fadb9eedc49d6bded0cbd92cfbbde71bae
2014-04-15 09:02:32 +02:00
fa72a0e94d Remove unused code
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
0d46e05cf2 coverity#704828 Explicit null dereferenced
Change-Id: I5e27241334cfeb4dffecbbf1d010abe94fbc52df
2014-04-04 20:58:27 +01:00
f19ca44a04 callcatcher: update unused code
Change-Id: I23ad8bcbef9a0ef17aaa5d401d111c40a6560ee2
2014-04-04 09:35:19 +01:00
aa16ca7326 Resolves: fdo#76905 long delay when changing font size from % to pt
Change-Id: I33d72b51536ab96653ccda64c6e058c497289327
2014-04-02 13:47:54 +01:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
2591ed293e coverity#984148 Uninitialized pointer field
Change-Id: I17a4a4e1c5aa1b5481e283f1c232e6483c135e84
2014-04-01 10:38:24 +01:00