Commit Graph

623 Commits

Author SHA1 Message Date
150df3c020 star* -> css::*
Change-Id: I156d40badb1a11727d1320600a9d3af2b8b24e4a
2014-08-21 09:03:22 +02:00
85cf4881fc drop FixedLines from wizards to be consistent with the rest of the ui
and two virtual methods don't need to exist after that

Change-Id: I50ea8eaa99fddfed7e0c61e99e76631aa595f2dc
2014-08-15 08:26:02 +01:00
226fbf44eb warning C4242: 'initializing' : conversion from 'size_t' to 'const sal_uInt16'
Change-Id: I80336164803a494bdabaa5e142ac91c2e6d26911
2014-08-13 10:10:38 +02:00
24f28634fa Todo -> TODO
Change-Id: I13e2351c182065be1a849b944e892f0072ce358a
2014-07-14 11:07:47 +02:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
9263b101c3 Activate the "suspicious cast to sal_Bool" parts of loplugin:salbool
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
2014-07-01 17:49:10 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
30069114fe loplugin:staticcall
Change-Id: If7b285a2214bc878e8464a986538d0445078fcb3
2014-06-13 17:54:34 +02:00
0f2824b117 remove more unnecessary use of OUString constructor
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
227af32d8c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18
Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225
2014-05-20 23:29:53 +02:00
3558f9c059 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part17
Change-Id: Ie6dbe87599c9cf53c7b9cc6becb9438e62cdb537
2014-05-18 01:14:29 +02:00
a325ce63db fix-includes.pl: svtools
Change-Id: I509299306ab6cd97c96e9a26d4674f983bbffbec
2014-05-11 01:55:40 +02:00
940ac1e52e WaE: -Werror=maybe-uninitialized
Change-Id: I8f63bc51c48d69eaa81bf080b05747c026871f08
2014-05-08 16:18:15 +01:00
b7d30cb50e svtools: sal_Bool->bool
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
9124f7e8bc Move headers included only in svtools to svtools
Change-Id: I66e443b5b641aaf16e1918f139a6b6a173ef7d4c
2014-05-06 15:30:05 +03:00
532acfde02 make SvDetachedEventDescriptor::hasByName return bool
Also, since this is a utility method, and it does not override
a method from an UNO interface, it does not need to be virtual.

Change-Id: I2dd90331e8ff49572bdfcb6ea2e2e3ed2fd95051
2014-04-24 14:17:24 +02:00
78d015849c Resolves: #i124629# UNO Wizard - avoid crash by removing unneeded reference
(cherry picked from commit 6a820f13a5cadc3d6d8c7bac1e4042adcee379ac)

Conflicts:
	svtools/source/uno/wizard/wizardshell.cxx

Change-Id: I2d67451c6fb536149603777a84d9b73494b6ed84
2014-04-11 09:44:05 +01:00
fa72a0e94d Remove unused code
Change-Id: Ifaab2aecec65ec6e81056e5fca430df8ca3af908
2014-04-09 10:15:47 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
80ef0dfedc svtools: sal_Bool->bool
Change-Id: I42a341b5805e0b2a7d619ba552700db35815afd5
2014-03-25 14:32:57 +02:00
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
c849d750eb svtools: sal_Bool->bool
Change-Id: I05dd992f332ab2f3dbcc65aed6dac909872168d4
2014-03-25 14:32:55 +02:00
2d3a1d2a46 svtools: sal_Bool->bool
Change-Id: I6c57a52b4fc3ecb993af4526fefcca352ad269b5
2014-03-25 14:32:55 +02:00
f7074d8de5 svtools: sal_Bool->bool
Change-Id: I2044e6c1f15579b6051fad5d36fcfa8795f88953
2014-03-24 08:12:10 +02:00
554e54429c svtools: sal_Bool->bool
Change-Id: Ic9b4838c4d1b4d2d2ea4665811dd396bdbec31b7
2014-03-24 08:12:09 +02:00
9604eb8758 svtools: sal_Bool->bool
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
98666e8625 No need for a virtual OPropertyContainer::getTypes
(and rename to getBaseTypes for clarity)

Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
41776e53c5 svtools,svx: prefer passing OUString and OString by reference
Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6
2014-03-13 13:13:38 +02:00
62fae8bda8 svtools: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I2534ad4a720dd5d13324ac6fb19b8676ae50ff4e
2014-03-10 17:39:58 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
0feaf45541 SVTOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: I83e39d69deaf2aa1c5ca455c92d070a2d33def3f
Reviewed-on: https://gerrit.libreoffice.org/8421
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:19:11 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
bee1cc83ec Remove visual noise from svtools
Change-Id: I7c2b74a449fb20aae5bc643e24a22cf6f732136d
Reviewed-on: https://gerrit.libreoffice.org/8320
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:14:09 +00:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
146c7c5c89 toolkit: sal_Bool -> bool
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24 11:13:42 +01:00
ad73967e99 Remove unnecessary extractInterface
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
aeb6073980 coverity#738866 Uninitialized scalar field
Change-Id: I2ab29fb267055f70c0d42970abd4e4d944ab7006
2014-02-19 11:07:12 +00:00
307684b2c7 Clean-up svt::ToolboxController inheritance
...and fix its XTypeProvider::getTypes

Change-Id: Ic36b17b14da21a29ca5530dd5e2ad03ee3da0782
2014-02-12 12:03:29 +01:00
435a5e7071 Remove pointless "shizhoubo" comments
Change-Id: I50521b0dab7325313ed5a3303f09a0692d76d19d
2014-02-12 12:03:29 +01:00
f139c10fd3 fdo#54938 Convert oox, sc, vcl, svtools... to cppu::supportsService
Change-Id: I6268bc57417d53b9810c81071fbcd604e2a19507
Reviewed-on: https://gerrit.libreoffice.org/7886
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-06 15:47:54 +00:00
19e16083c6 Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30 10:48:25 +01:00
bd9581d46d bool improvements
Change-Id: I23e29995bc7af791067de4996923b6279f7f8892
2014-01-28 20:24:40 +01:00
ba8413d262 Introduce com.sun.star.frame.theUICommandDescription singleton.
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
2014-01-28 18:52:22 +01:00
c2c530da69 Introduce static inline cppu::acquire(), and make use of that.
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.

Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
2014-01-22 15:09:28 +01:00
f278397787 Change _get_implementation()'s not to do initialization directly.
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.

As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.

Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
2014-01-21 21:25:22 +01:00