Commit Graph

8177 Commits

Author SHA1 Message Date
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
ebdb4a00fa coverity#1202783 Division or modulo by zero
Change-Id: Ida169195697d3976500a16e3cced40b25664a02e
2014-07-18 15:36:17 +01:00
f9b22d7c7a coverity#1226481 Dereference after null check
Change-Id: I93f9bfb7a360b2851d179f6c4535b416fff339bc
2014-07-18 15:36:13 +01:00
60de576a29 use same swap stategy on all platforms
Change-Id: I565dfd9233088feae69de6261d1081fc51f10806
2014-07-15 16:15:17 +01:00
0ca0202a09 Resolves: #i125111# limit mem footprint for GraphicObjects...
in 32Bit environments

Conflicts:
	svtools/inc/svtools/grfmgr.hxx
	svtools/source/graphic/grfmgr.cxx
	svtools/source/graphic/grfmgr2.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/graphic/ndgrf.cxx

"commit 62b0eaf37c08dd27244e77b8bc90c691b000ebd6
 Related: fdo#50697 reset the cache timeout on GetGraphic

 so the graphic gets swapped out Xms after the last use and not Xms after
 initial creation regardless of if it got used a moment earlier."

corrected place for stl sort function for linux

(cherry picked from commit a48414a396f7de4e00510e82e3744c097ce3d5d6)

Conflicts:
	svtools/source/graphic/grfmgr2.cxx

Change-Id: I79158b7d42629f8dec2bc5565540701bcd3ef6f4
6f21c7fd4d2681446fc1a6d9607366a1e69165a1
2014-07-15 16:15:17 +01:00
65ecb0d8f4 Related: fdo#80633 we can retain cached size for visibility change
we still need to invalidate the layout of our parents, but we can
keep the cached optimal size

Change-Id: I8e77366bd61ff45d34f9d411c7f501a3a9ccbd4e
2014-07-15 11:56:09 +01:00
415ae83522 Convert 3 dialogs to .ui
I converted RID_DLG_LISTCOMBOWIZARD, RID_DLG_GROUPBOXWIZARD and
RID_DLG_GRIDWIZARD to .ui

Change-Id: I221f22edbe4c638bfa80065d7775f78af24590cc
Reviewed-on: https://gerrit.libreoffice.org/10277
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-14 15:37:16 +00:00
24f28634fa Todo -> TODO
Change-Id: I13e2351c182065be1a849b944e892f0072ce358a
2014-07-14 11:07:47 +02:00
b43fdc54e5 cid#1194925 Resource leak
add an assert so that coverity knows the leak can't happen

Change-Id: I0109309ccc53b1b22420cbf9ac497d8d677a4ea7
2014-07-14 11:07:47 +02:00
dd9a1bae7c coverity#983902 Uncaught exception
Change-Id: Ic4e7413ac0c4c6c8eda9808e88572926e6b00be5
2014-07-14 09:21:01 +01:00
6a393f7843 pass by reference
Change-Id: I44e8f40935a19f8023bb23f53c5fb458eb28a3dc
2014-07-12 14:25:04 +02:00
bfdacadec9 Convert DLG_TEMPLATE_INFORMATION to .ui
Change-Id: I66469c17a46c1157b8e3801c0dc2b252c569a4bd
Reviewed-on: https://gerrit.libreoffice.org/10213
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11 15:05:36 +00:00
5eb408a3bb fdo#81044 detect UTF-8 BOM too
Change-Id: I6fd041780b889e2125b916964ba27d032667dcd6
2014-07-10 16:35:45 +02:00
482f97926e use SimpleReferenceObject in svtools module
to replace hand-rolled version

Change-Id: I7a1048ff1ea335c3934fe7e91a09489a4d7aeb96
2014-07-08 15:16:47 +02:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
55aa83da68 coverity#706073 Unintended sign extension
Change-Id: I13272490bf8a08cbfb1ffc37828fb30fb92f9139
2014-07-06 15:15:12 +01:00
d9f585b89b coverity#706065 Unintended sign extension
Change-Id: If482c75af5128778a176c40e38000b78f2087131
2014-07-06 15:15:12 +01:00
c414389e87 Avoid possible memory leaks in case of exceptions
Change-Id: I46d49b515f5212a34612e80a82a3330a041b956c
2014-07-05 22:49:42 +09:00
6a9d51b24b Drop an empty header
Change-Id: I34904af6da8f37459ef96071caa53230ad02a8e7
2014-07-05 22:49:42 +09:00
1edd367928 Avoid possible memory leaks in case of exceptions
Change-Id: I957c0662c56e7cad3d10c8bcc1d6b22352da688f
2014-07-05 20:19:42 +09:00
8c95c0e71a first delete, then nullify
Otherwise an unreachable can happen.

Change-Id: I04f03fc97aa73eb0bf75ad71ca8a1cf2d3729c08
Reviewed-on: https://gerrit.libreoffice.org/10047
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-04 18:54:04 +00:00
f38bf4c6c2 Avoid possible memory leaks in case of exceptions
Change-Id: I04a0a2c296206f155ee4916b15b853a7f10c2c2a
2014-07-04 10:49:10 +09:00
c061cb94c0 Drop unused #includes
Change-Id: Ief545db58a0dbb26ba293aa71debc816a8925b6c
2014-07-04 10:49:10 +09:00
d1f9507ff8 coverity#706077 Unintended sign extension
Change-Id: I3a5d8a946b5134b4cd58694283bea0fac59a043a
2014-07-03 14:52:28 +01:00
cfdf9a6c5a coverity#706081 Unintended sign extension
and

coverity#706080 Unintended sign extension

Change-Id: Ieb5bd639567767b4c6b2957a9e628eb841713198
2014-07-03 14:52:27 +01:00
bca68c4a34 coverity#736898 Unintended sign extension
Change-Id: Ie09d25b2f9993435ebffc52c7257cd9396672c8f
2014-07-03 14:52:24 +01:00
a5cc3ce566 Convert DLG_COLLECTION_VIEW to .ui
Conflicts:
	include/svtools/fileview.hxx
	svtools/source/contnr/fileview.cxx

Change-Id: I78b590410ec4e55eeecd2da8ab79738f05e403b5
Reviewed-on: https://gerrit.libreoffice.org/9981
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-02 08:47:13 +00:00
9263b101c3 Activate the "suspicious cast to sal_Bool" parts of loplugin:salbool
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
2014-07-01 17:49:10 +02:00
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
f90eb33a26 DLG_FPICKER_EXPLORERFILE conversion to .ui
Change-Id: I5d8f5d0182fb6af5111b60caa29912d313c2efa0
2014-06-30 16:31:47 +01:00
4523dd0544 Called C++ object pointer is null
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
78bea877ff OSL_ENSURE->assert where guaranteed deref follows
Change-Id: I6e007cc3a9fd222c1c1381c8b4f890966c05cbab
2014-06-27 17:22:09 +01:00
daa6898578 clang: Dead initialization
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
2014-06-26 16:29:15 +01:00
6162191b4a fdo#51763 - make title of dialog localisable
Following the bug report the title is currently not correctly
localisable for Catalan language due format issues.

Change-Id: I09107acb3f4acd7acf5a614216265373c59938b2
Reviewed-on: https://gerrit.libreoffice.org/9883
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-25 10:05:02 +00:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
9191f44fed coverity#706069 Unintended sign extension
Change-Id: I605adc70d054fe3d5aea3bf1984348aae0e7fc28
2014-06-19 10:26:50 +01:00
3daec14fd6 sizeof(bool) is not required to be 1
Change-Id: I19ba4e27a4403d2c17d0bbf3f29c42e4745e4c41
2014-06-19 10:26:49 +01:00
6194080c53 coverity#706067 Unintended sign extension
Change-Id: I7b1ace9726c38eafd063e7bd87f463b23fe9d74a
2014-06-19 10:26:49 +01:00
358c1fa7fa coverity#736899 Unintended sign extension
Change-Id: I4fcd7df318cec8dccd1516c6d52b7d0c67885a6c
2014-06-18 11:12:09 +01:00
54f52a53ae coverity#1210044 Uncaught exception
Change-Id: I3837f316a4b73eb508bfd4fca97fa741080df8c0
2014-06-17 10:58:02 +01:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7eceffef49 Resolve fdo#79913 by checking index bounds
Change-Id: I023a625d73724332245d612a61cb786acefc4cf2
Reviewed-on: https://gerrit.libreoffice.org/9791
Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-16 10:54:37 +00:00
30069114fe loplugin:staticcall
Change-Id: If7b285a2214bc878e8464a986538d0445078fcb3
2014-06-13 17:54:34 +02:00
94e2459cd8 coverity#705245 Missing break in switch, assuming intentional
Change-Id: I2ac6acde603c89c5b7736ec7f1a1b42b28726827
2014-06-05 21:14:21 +01:00
0017cafc9d coverity#705243 Missing break in switch, assuming intentional
Change-Id: I4882ba5028e45528cafc1170bc4de6c3a2ea7a12
2014-06-05 21:14:20 +01:00
a2d2c6d6bd coverity#1103688 Missing break in switch, assuming its intentional
Change-Id: I9b619e4896d811c2fbb20e229f65bfa01bd05731
2014-06-05 13:35:53 +01:00
6f2edd4514 new loplugin: inlinesimpleaccessmethods
Create a rewriting plugin for finding methods that simply return
object fields, and should therefore be declared in the header,
so that the compiler can reduce method calls into a simple
fixed-offset load instruction.

Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-04 14:49:08 +02:00
c24aa2139f coverity#705247 Missing break in switch
Change-Id: Idc647ef41b3a01d89216c3fe74e3fa5af02f7525
2014-06-04 12:48:04 +01:00
cc25f70ef1 compareTo -> equals
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00