Commit Graph

248 Commits

Author SHA1 Message Date
7b33dbb253 svx: Cleanup ASCII art and useless comments
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71
Reviewed-on: https://gerrit.libreoffice.org/11011
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-19 01:28:24 -05:00
8a822b86b3 remove unused Control
Change-Id: I4f6dfe478ba6dd009153d77af26507e0e1795262
2014-08-18 05:33:27 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
7659d1b633 WaE: C4245: signed/unsigned mismatch
Change-Id: I070123efc658484a54800743cdd447a1cd2f89d3
2014-08-13 20:37:26 +03:00
1e6ff8f7f8 XFillStyle -> css::drawing::FillStyle
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-19 00:30:37 +02:00
65ecb0d8f4 Related: fdo#80633 we can retain cached size for visibility change
we still need to invalidate the layout of our parents, but we can
keep the cached optimal size

Change-Id: I8e77366bd61ff45d34f9d411c7f501a3a9ccbd4e
2014-07-15 11:56:09 +01:00
7d9bb549d4 Related: #i124638# Second step of DrawingLayer FillAttributes...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes

(cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b)

Conflicts:
	cui/source/factory/dlgfact.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/bbdlg.hxx
	cui/source/inc/cuires.hrc
	cui/source/tabpages/bbdlg.cxx
	cui/source/tabpages/bbdlg.src
	cui/source/tabpages/page.cxx
	cui/source/tabpages/tparea.cxx
	include/svx/pagectrl.hxx
	include/svx/svxdlg.hxx
	include/svx/svxids.hrc
	include/xmloff/PageMasterStyleMap.hxx
	include/xmloff/prstylei.hxx
	include/xmloff/txtprmap.hxx
	svx/Package_inc.mk
	svx/inc/svx/hdft.hxx
	svx/source/dialog/hdft.cxx
	svx/source/dialog/pagectrl.cxx
	svx/source/tbxctrls/tbxcolorupdate.cxx
	svx/source/unodraw/unobrushitemhelper.cxx
	sw/Library_sw.mk
	sw/inc/fillattributes.hxx
	sw/inc/format.hxx
	sw/inc/frmatr.hxx
	sw/inc/frmfmt.hxx
	sw/inc/hintids.hxx
	sw/inc/hints.hxx
	sw/inc/ndtxt.hxx
	sw/inc/node.hxx
	sw/inc/swunohelper.hxx
	sw/inc/unobrushitemhelper.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/hints.cxx
	sw/source/core/doc/docdesc.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfmt.cxx
	sw/source/core/doc/docnew.cxx
	sw/source/core/doc/docredln.cxx
	sw/source/core/doc/poolfmt.cxx
	sw/source/core/doc/visiturl.cxx
	sw/source/core/docnode/node.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/inc/rolbck.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/fillattributes.cxx
	sw/source/core/layout/findfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/txtnode/ndtxt.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/undo/rolbck.cxx
	sw/source/core/unocore/swunohelper.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoparagraph.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/chrdlg/paradlg.src
	sw/source/ui/chrdlg/pardlg.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/uibase/app/docst.cxx
	sw/source/uibase/app/docstyle.cxx
	sw/source/uibase/frmdlg/colex.cxx
	sw/source/uibase/shells/basesh.cxx
	sw/source/uibase/shells/textsh1.cxx
	sw/source/uibase/uiview/viewstat.cxx
	sw/source/uibase/utlui/uitool.cxx
	xmloff/inc/PageMasterImportContext.hxx
	xmloff/inc/xmloff/XMLShapeStyleContext.hxx
	xmloff/source/draw/XMLShapeStyleContext.cxx
	xmloff/source/draw/sdpropls.hxx
	xmloff/source/style/PageMasterExportPropMapper.cxx
	xmloff/source/style/PageMasterImportContext.cxx
	xmloff/source/style/PageMasterPropHdlFactory.cxx
	xmloff/source/style/PageMasterStyleMap.cxx
	xmloff/source/style/prstylei.cxx
	xmloff/source/text/txtexppr.cxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx
	xmloff/source/text/txtstyli.cxx

Conflicts:
	svx/source/dialog/hdft.cxx
	sw/source/core/doc/visiturl.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtatr2.cxx
	sw/source/core/unocore/unostyle.cxx

Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01 13:30:09 +02:00
5fdcab9412 Avoid possible memory leaks in case of exceptions
Change-Id: Icff534ac96e0a595d71bc34b6055caf8cd096ad8
2014-06-28 18:56:05 +09:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
a41e5ef986 Sidebar: fix some typos in function naming.
Mostly found by:	Noel Grandin
Reviewed by:		Andre Fischer

(cherry picked from commit 1ad216c0b831fc10ff4e73392dbcc9832463a7bc)

Conflicts:
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx

Change-Id: I662a262d2cd920b54338c16bf688181b95e2f863
2014-06-16 09:32:10 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
35c31f5f40 convert document recovery dialog to .ui
and move sidebar global resource defines up to the toplevel so its harder to
collide with them and adjust the define to indicate the next free resource
id.

and simplify the dialog down a good bit and remove intermediate classes
etc.

Change-Id: I8d6db17fcdfc86457368d7f432bd96f6f3aa182d
2014-06-04 15:07:36 +01:00
f634cda2a2 avoid problems with poppler's and vcl's FontInfo during runtime
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04 07:49:15 +02:00
75ea03d842 fix indentation
Change-Id: Ie4609df2ae19c92d844c0f0ecf7c67d23c8baeba
2014-06-04 07:49:14 +02:00
59371dfca3 fix spelling of field name mbColseByEdit->mbCloseByEdit
Change-Id: I640491dff8378e89d37596c5fcd9e9281c6e7874
2014-06-03 14:13:22 +02:00
e15732bc96 fdo#68849: Add header guards to all include files
Added header guards to files in directory svx/

Change-Id: I1c2006bccf03c3057daf6ea2711c52a8c1f455f3
Reviewed-on: https://gerrit.libreoffice.org/9586
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:13:39 +00:00
ceb7ea5091 fdo#78920: Number %NUMBERSTRING in tooltip
Fixed string in Bullets and Numbering and changed sidebar to use the same set of strings.

Change-Id: Ib8a103e203cf66c979216175d4047bca518290ce
Reviewed-on: https://gerrit.libreoffice.org/9492
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2014-05-27 02:47:50 -05:00
9b791f9c31 remove unnecessary use of OUString constructor when throwing
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27 08:20:11 +02:00
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
8e304f80bb coverity#1027650 Unchecked dynamic_cast
Change-Id: Ic1973463e4c6d85bbfacc077f58f7d1fe16de73a
2014-05-24 13:03:46 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
e4ce7d286a fdo#46839 Convert line color picker to split button
Change-Id: I4987cc9ffba675009f2d2ae9f6b12ed4ee02fe13
2014-05-18 14:50:58 +03:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
bf30c8b16d use new VCL IsValueChangedFromSaved method
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963
"RFC: add IsValueChangedFromSaved to VCL button and listbox"

Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08 14:55:12 +02:00
290ecbca8d remove some useless lines
As those classes don't exist.

Change-Id: I1e9015e1654e6d261709ab0b1dcf9784a0849e92
2014-05-06 18:12:25 +02:00
1a0cdabf1d remove some commented out lines from src files
Change-Id: If872737d2a7db5d9053a256f7e3d57007c24230e
2014-05-05 19:42:28 +02:00
e0be1a7444 Use the show method directly
Change-Id: If4e11ae1fda86b612aeeed94b1cde4a5711c6359
2014-04-25 01:09:37 +03:00
371046c6a3 add missing modelines to cxx and hxx files
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-24 11:58:15 +02:00
0b7f82d7cb add missing modelines to hrc and src files
Change-Id: I82d9727c4f991c606a19b9eba27732e7e2397db6
2014-04-24 11:58:14 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
c89cafb192 cppcheck: duplicate branch
Change-Id: I1731b60036d94791a39290957d6c4d3b345c077f
2014-04-16 20:26:41 +01:00
eff36c994e coverity#1027390 Logically dead code
Change-Id: Ie2d375093828cc2b0f9ca20b360a8fe8a5032dcf
2014-04-16 16:41:58 +01:00
be88947bac svx: sal_Bool->bool
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-04-15 09:02:33 +02:00
0ca45881df unused include
Change-Id: I41c043d5651c24a270b54ff9647b1151873b0550
2014-04-09 13:56:35 +03:00
333282478a Related: fdo#75307 use the unique auto help id to identify tabpages
and dialogs that are loaded from the .ui format

Change-Id: I37aea52a3973d8d8f6a2ce8dabf80bb1e64db43f
2014-04-03 12:18:26 +01:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
36be3d94c2 Resolves: #i124409# use slot SID_ATTR_METRIC...
to retrive the UI unit, not GetModuleFieldUnit

(cherry picked from commit 34279ea85c33e3efd21971ab692a3de4bdd91817)

Conflicts:
	svx/source/sidebar/possize/PosSizePropertyPanel.cxx

Change-Id: Id81847bf7e989a3e49fbe8adaad23048956067df
2014-03-20 16:49:46 +00:00
8578aabbc4 "prefix" and "postfix" are single words
Change-Id: I32824c614d070cd4649e18da4a0b91b03bccfaba
2014-03-14 07:57:18 +02:00
c2324940d3 sfx2: sal_Bool->bool
Change-Id: If960d94f867a1988ace83975cf16441c6f8866b0
2014-03-14 07:50:33 +02:00
13bc4094da svx: sal_Bool->bool
Change-Id: I673d022c01b7d076120c026b236a37735b5043b0
2014-03-14 07:50:32 +02:00
41776e53c5 svtools,svx: prefer passing OUString and OString by reference
Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6
2014-03-13 13:13:38 +02:00
58fae0f715 remove osolete ifdef
now that the ScaleDPI is forced to 1 on mac there is no need
for these ifdef

Change-Id: I0ca3bc301b63f5f4c7d1eb36f27bc9b6ab41af29
2014-03-11 15:44:26 -05:00
729c93c12f svx: sal_Bool->bool
Change-Id: Ieb21d01fef7b25fc3b6326108d451fe239c9b461
2014-03-11 08:18:18 +02:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
cd56e54df1 I guess const was intended here.
Change-Id: Iba157cca516add9403e8eace64430ed7008f4f2c
2014-02-28 10:10:40 +01:00
c16e4b1019 remove unused code PanelLayout::dispatch
full signature:
PanelLayout::dispatch(
    rtl::OUString const&,
    css::uno::Sequence<css:🫘:PropertyValue> const&)

Change-Id: Ib16c32d69e62ccf000de05da7c6f25e993a5be90
2014-02-28 08:32:01 +02:00
ef16d954c2 editeng: sal_Bool->bool
Change-Id: Ic3d9fe45d3242d3da147067d3c388e9d7305ee61
2014-02-27 12:30:25 +02:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00