Commit Graph

52 Commits

Author SHA1 Message Date
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
e0be1a7444 Use the show method directly
Change-Id: If4e11ae1fda86b612aeeed94b1cde4a5711c6359
2014-04-25 01:09:37 +03:00
371046c6a3 add missing modelines to cxx and hxx files
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
2014-04-24 11:58:15 +02:00
0b7f82d7cb add missing modelines to hrc and src files
Change-Id: I82d9727c4f991c606a19b9eba27732e7e2397db6
2014-04-24 11:58:14 +02:00
0ca45881df unused include
Change-Id: I41c043d5651c24a270b54ff9647b1151873b0550
2014-04-09 13:56:35 +03:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
5024ce2a2c sidebar: even more cleanup of text panel
Contains the following changes:
- Kill SvxSBFontNameBox.
- Remove ToolboxFontSelectHandler.
- Move .uno:Color to a separate toolbox. It allows to
  remove some hardcoded uno commands from the code, and
  also solves a redrawing issue.
- General cleanup.

Change-Id: I6fb797aa95d1a73dca0003ad1a40aee55e27e163
Reviewed-on: https://gerrit.libreoffice.org/7893
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-07 14:28:23 +00:00
4c97c6a18f sidebar: more cleanup of text panel
Change-Id: Iad9b619d599ed13e3d783ca174e7ad5f0053c622
Reviewed-on: https://gerrit.libreoffice.org/7826
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04 13:29:03 +00:00
53351ad617 svx: fix presumed C++11ism
Change-Id: I4d6e7ec99ea889ae45ca12c3470b9f5d9e3c134b
2014-01-30 17:05:40 +01:00
bc46764f12 Sidebar Text panel cleanup
Change-Id: I6cbf5a9e5ad9d61df2abbcc835ba60d45768deeb
Reviewed-on: https://gerrit.libreoffice.org/7687
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30 11:56:01 +00:00
ab50bc9d4a Resolves: #i56998# add a space separater between value and unit...
and remove separator between value and percent to match with ISO 31-0

(cherry picked from commit 0cea884e3f417e4b58d2fdcfc7b0111f3bfc6f30)

Conflicts:
	chart2/source/controller/dialogs/tp_SeriesToAxis.src
	cui/source/dialogs/colorpicker.cxx
	cui/source/dialogs/colorpicker.src
	cui/source/dialogs/grfflt.src
	cui/source/dialogs/zoom.src
	cui/source/tabpages/tabline.src
	editeng/source/items/frmitems.cxx
	editeng/source/items/textitem.cxx
	sd/source/ui/animations/CustomAnimationDialog.src
	sd/source/ui/animations/SlideTransitionPane.src
	svx/source/dialog/bmpmask.src
	svx/source/engine3d/float3d.src
	svx/source/items/algitem.cxx
	svx/source/sidebar/text/TextCharacterSpacingControl.cxx
	svx/source/xoutdev/xattr.cxx
	sw/source/ui/utlui/attrdesc.cxx
	sw/source/ui/utlui/uiitems.cxx

Change-Id: I554309cb72dd8956077c5ca6866a982cdd6529aa
2014-01-20 12:08:54 +00:00
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
a0fdc73984 Related: fdo#73414 use frame::XDispatch::dispatch directly
This hopefully is a model which we can build in further
to remove the rest of the direct SID... stuff and the fragile
mapping from the known .uno: commands to SIDS to dispatch, and
instead just dispatch the .uno: command directly

Change-Id: Iec0f92123fa4c2dae15e0ac716d5ef687e67da79
2014-01-16 20:38:23 +00:00
75043c23c7 fdo#73414 Remove Increase Font limits for Writer
and re-use the same code in sidebar.

Change-Id: Ic342be479f6f5b23ea2dd79b7cf6c77897b27dc1
Reviewed-on: https://gerrit.libreoffice.org/7398
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16 20:37:23 +00:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
9c5a91efdb expand out the A2S macro
Which is not doing anything useful anymore.

Change-Id: I83422e811d52a77b65655924c07b55dd7229449c
2013-11-13 09:08:08 +02:00
e9fdc84698 Typo
Change-Id: Ifb3b9c7a33b7faccbf7dad1886d953d845de3196
2013-11-09 00:29:32 +01:00
a4fc939e82 fixincludeguards.sh: svx
Change-Id: I885bbc431322ee233f8e67ec2bb5701af909046c
2013-10-28 15:16:19 +01:00
9dc41e228d convert remnants of String in SVX to String
Change-Id: I66fd6387c3fcd33c6ae0b431810abf6679345767
2013-10-01 10:08:36 +02:00
71622632e6 convert svx/source/sidebar/*.cxx from String to OUString
Change-Id: I57bd0ade23a17cd2c8edfd2549ae131d80ab7592
2013-09-05 08:55:07 +02:00
5ddc4cc6c5 convert svx/.../sidebar/*.hxx from String to OUString
Change-Id: Id50f78d33608d76bf5142597d9cf2434ab03702d
2013-09-05 08:54:57 +02:00
11a3430c21 convert svx/.../TextCharacterSpacingControl.hxx from String to OUString
Change-Id: I3430848f9c978c65066b9f326aeec3ee60694488
2013-09-05 08:54:56 +02:00
6b2cc1eb6c XubString->OUString
Change-Id: I1db6254b23c5203c20c168989656d320f86a3bb9
2013-08-13 09:22:29 +01:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
6b0ea72453 Remove some unused code form unusedcode.easy
Change-Id: Ib9f0bc7416c7f05684802ba2bb5f014a340fb2e8
Reviewed-on: https://gerrit.libreoffice.org/5068
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-25 07:20:34 +00:00
c54f77b718 callcatcher: update unused code
All FontSizeBoxs and SmFontPickListBoxs are now .ui loaded, .res ctors unused

Change-Id: I50aa8606fefacab0b15b6795a7ba90dff8109802
2013-07-15 09:07:49 +01:00
3c29fdd21e accidental push of merge in progress, sigh
This reverts commit c61c5a240314f1899a2160a97e00e2108104e4bd.
2013-07-05 13:59:06 +01:00
c61c5a2403 Related: #i122635# Add layouting to some sidebar panels.
(cherry picked from commit 4f9ac2af7157786ee6fba46551bd6782730d8b55)

Conflicts:
	sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx
	sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
	sfx2/Package_inc.mk
	sfx2/inc/sfx2/sidebar/SidebarToolBox.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.cxx
	svx/source/sidebar/text/TextPropertyPanel.hrc
	svx/source/sidebar/text/TextPropertyPanel.src
	sw/source/ui/sidebar/PagePropertyPanel.cxx

Change-Id: I94bfc87c9eeddd0c39bd979dd26b11c95b1e3c72
2013-07-05 13:07:30 +01:00
7a61efe422 add missing VclBuilder::stringmap argument to some builder functions
Change-Id: I57e13920b4707ebe5b6a7149dbdbfc45593c0d9d
2013-06-27 16:45:11 +01:00
153bdc99b1 coverity#1027391 : Dead default in switch
Change-Id: I7ef70be9f5230eb3fb586962a1581efa38c239f0
Reviewed-on: https://gerrit.libreoffice.org/4526
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-27 14:52:25 +00:00
415b700610 sidebar: Convert TextPropertyPanel to .ui + adapt code.
Change-Id: I1e446ca520b10f0fba4f79d2e840d10835850f66
2013-06-02 04:54:55 +02:00
21747cae6a Resolves: #i122387# Use the right tool box for font color in text sidebar
(cherry picked from commit 08159967126946849906827ceadd802053d132c0)

Conflicts:
	sfx2/inc/sfx2/sidebar/EnumContext.hxx

Change-Id: If40d3dee7c11e4ea6b01d40d713280e1dc19484d

Unname unused argument to prevent compiler warnings.

(cherry picked from commit f68dfc2cc8754d9cf72ae1b09f119e683ad44124)

Change-Id: I6450c6e46d5971abc871ed378d2ad6307e8f7a3e
2013-05-28 17:03:22 +01:00
f160e4935c WaE: unused function 'GetAutomaticColor'
Change-Id: I247d8e0fbfa8c050806a08d2e387d9bc761de534
2013-05-20 14:30:50 +03:00
d7f93b544d WaE: private field 'bInput' is not used
Change-Id: I0a220120e312b901549f7243c0d1bf750a1227a1
2013-05-20 14:19:17 +03:00
a9626f143a Resolves: #i122302# Use tool bar controls for color controls...
in text property panel

(cherry picked from commit 3b252796e1126b5ec1216082f55b8d12017eaeb1)

Conflicts:
	sfx2/Package_inc.mk
	sfx2/inc/sfx2/sidebar/ControlFactory.hxx
	sfx2/inc/sfx2/sidebar/ControllerFactory.hxx
	sfx2/inc/sfx2/sidebar/EnumContext.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/text/TextPropertyPanel.cxx

Change-Id: Ifa1947c9e9bfdc3635dbb5b0c7a79f8ead613a90
2013-05-20 11:33:35 +01:00
b97fb5ca15 Related: #i122082# Disable controls of text property sidebar...
panel for disabled document parts

(cherry picked from commit ffcc8c326640dfbc6b765cd25875adf9e0ab66ad)

Conflicts:
	sfx2/inc/sfx2/sidebar/ControllerItem.hxx
	svx/source/sidebar/text/TextPropertyPanel.cxx

Change-Id: I9f38c71c6415f3d255b5607a67a110bca47358b0

Related: #i122082# Remove temporary change

(cherry picked from commit f213ea43fac43326a643f30ff13abd9d77f6aed7)

Change-Id: I157542fd5dbbda17b63900be9a41782ee581309c
2013-05-20 11:33:31 +01:00
d0d5b97d28 Resolves: #i122230# Fixed focus traveling in the sidebar
(cherry picked from commit bab3ddce4b3d5330835494f54b68406335821b76)

Conflicts:
	sfx2/source/sidebar/FocusManager.cxx

Change-Id: I8853a92da3c4fe41a0110c630cc6af556ffc2ce4
2013-05-20 11:33:29 +01:00
c6f163600e Related: #i122140# add 'None' entry to underline style...
drop-down-list in text property panel

(cherry picked from commit 3c4045722f20bddddef9143c4f393e6f251f6d2d)

Change-Id: Ieffbd19318742dd133fce1b96d7cad2d7c457975
2013-05-20 11:33:28 +01:00
256be01805 Resolves: #i122105# text property panel, underline style control
correct application of chosen underline style in Calc cells and Drawing objects
in Writer

(cherry picked from commit fd23db16149eb517de9b2b403ff28ed0d31c83d6)

Change-Id: Id77299c173eef99ea2eea0c0896e9bfd0bd9d1eb
2013-05-20 11:33:27 +01:00
862395f6a1 Resolves: #i122182# TextPropertyPanel
- add missing <break> in handling click to character attribute controls
- remove superfluous code and comments
- adapt code formatting
(cherry picked from commit a1111d73afe974a9d466a2b1678bfe5ddb5e7f34)

Conflicts:
	svx/source/sidebar/text/TextUnderlineControl.cxx

Change-Id: I1aea184523f74dda78218a631a64ea192765e9d5
2013-05-20 11:33:26 +01:00
304494a20b Resolved: #i122186# Rearranged controls in text property panel...
to make font selection box wider.

(cherry picked from commit 4484a62e0365fc36cc2a9e3ad1c71749d260d4d0)

Change-Id: I4a189c106b497da36e3ad0d13a8e6087b95e73c2
2013-05-20 11:33:24 +01:00
998a399166 Resolves: #i122093# Don't show Impress layouts panel for master pages
(cherry picked from commit 573490c7240fc02dcf82bf0ba262863612e53187)

Conflicts:
	sd/source/ui/sidebar/LayoutMenu.cxx

Change-Id: Ie5c0a1e15ea8db2d2b033efb1234492bd438658d

Related: #i122093# WaE in DrawController::BroadcastContextChenge()

(cherry picked from commit 26e4fcdbb8594696b45d0600e1b7a5e5946cd2aa)

Change-Id: I416215077643f3eb4d43eb761e457d0893bcc429
2013-05-20 11:33:20 +01:00
db334fb729 Related: #i121960# Fixed typo that made the superscript button...
look like the subscript button.

(cherry picked from commit eac056c47b2bf233ff36436136463cb3f3eb9e23)

Change-Id: I1ba1a609954cd88aa38f76c8e329f35152951ae5
2013-05-20 11:33:19 +01:00
799e382d02 Related: #i122051# Sidebar handles more Writer variants.
(cherry picked from commit dc36f82362dc1fb159668937cde7cedbc3fad503)

Conflicts:
	sfx2/inc/sfx2/sidebar/EnumContext.hxx

Change-Id: I230b6dd3a68d2a17d0433f7919e74f1fcfae8d01
2013-05-20 11:33:18 +01:00
0b2c09a180 Resolves: #i121960# Extend the sidebar::ControllerItem to check Disabled state
Converted TextPropertyPanel to use this new functionality.

(cherry picked from commit 5e32abe48b0833e4e370507a1e74fbb1ba98b5e3)

Conflicts:
	officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
	sfx2/inc/sfx2/sidebar/ControllerItem.hxx
	sfx2/source/sidebar/ControllerItem.cxx
	sfx2/source/sidebar/FocusManager.cxx
	sfx2/source/sidebar/SidebarChildWindow.cxx
	svx/Library_svx.mk
	svx/source/sidebar/text/TextPropertyPanel.cxx
	svx/source/sidebar/text/TextPropertyPanel.hrc
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/text/TextPropertyPanel.src
	svx/source/sidebar/text/TextUnderlineControl.hxx

Change-Id: I3a25bb0a02e6165ceeb6dbd9e6ecd3e94051f594
2013-05-20 11:33:16 +01:00