wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
359,769 Commits 5 Branches 0 Tags
67cba3af55e94debe8eb6392bc8d0b2f00a7a199
Commit Graph

3017 Commits

Author SHA1 Message Date
Stephan Bergmann
148aea32a3 Consistency around SvxB3DVectorItem in svx/svx3ditems.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I7f2348d82c76f6f231e34f0dfc4b6ee6fddffe55
 2014-09-01 16:46:59 +02:00
Stephan Bergmann
e5d6ae0c2e Consistency around SvxColorItem in svx/svx3ditems.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: If26ab3229871d2d6a7e4e7e8f79f4cb927b96930
 2014-09-01 16:16:49 +02:00
Stephan Bergmann
edf7c73d45 Consistency around SfxUInt16Item in svx/svx3ditems.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I2e467df03a34d694214e0560476cb7fd76ef0735
 2014-09-01 15:18:17 +02:00
Stephan Bergmann
9f6018bb64 Consistency around SfxBoolItem in svx/svx3ditems.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3253b4cc5657a7d6b960ee892584109d373eed3d
 2014-09-01 14:46:50 +02:00
Stephan Bergmann
bebe30e917 Consistency around SfxUInt32Item in svx/svx3ditems.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3
 2014-09-01 13:37:27 +02:00
Zolnai Tamás
9991b50ccc Make opengl chart window always active 
Fortunately there is a special ole object group with
the MS_EMBED_ACTIVATEWHENVISIBLE flag which define this
behaviour.
Problem is that both Aspect and EmbedMisc are MS specific
enums so we can't use them directly for non-MS objects. But we
can handle opengl charts the same as this ole object group.

Change-Id: I49abeffce319cbb775709a72ba198a1f76b65374
 2014-08-29 17:40:27 +02:00
Zolnai Tamás
bd9a4e1922 ChartHelper::IsChart is useless 
EmbeddedObjectRef has an own IsChart method with the same
behavior.

Change-Id: Ib06699186466bf3da2bd67d7c631a5216463fb14
 2014-08-29 17:40:27 +02:00
Stephan Bergmann
27eb09662d Avoid unnecessary, potentially invalid downcasts from SdrObject to SdrObjGroup 
Change-Id: If00b4a11ce5e568b9e4ff00038dc9e1f068cfd79
 2014-08-28 15:50:12 +02:00
Caolán McNamara
8d8e8942b2 Resolves: fdo#83062 infinite recursion 
regression from

commit 7c03fc2fe77f9b1f910f4ab395923e52648c32b5
Date:   Mon Sep 2 14:30:09 2013 +0000
Related: #i123048# Corrected connector layout after reload

verified that #i123048# continues to work

Change-Id: If5fce4b7a88d4d0972f52705334e4b9b48425cca
 2014-08-27 16:41:06 +01:00
Stephan Bergmann
e0c2ea6bde Consistency around SdrMetricItem in svx/sderitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I4a0715b18bc3aa032779252cad2450c905a467a4
 2014-08-25 17:25:40 +02:00
Michael Stahl
57a4337e25 set names on a bunch more threads... 
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
 2014-08-25 13:21:59 +02:00
Stephan Bergmann
fe04ce92cd Consistency around SdrAngleItem in svx/inc/sxraitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: If88f88cfe0144b83b3228650a34d9bf2c468b936
 2014-08-25 09:34:43 +02:00
Tor Lillqvist
30ae83c268 fdo#82577: Handle KeyCode 
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
 2014-08-23 22:33:30 +03:00
Tor Lillqvist
708fc1c187 fdo#82577, fdo#82579: Handle Cursor 
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
 2014-08-23 19:20:03 +03:00
Stephan Bergmann
720ee90929 Point and Rectangle coordinates are long, not sal_Int32 
Change-Id: I0f97d12f55e506af699976bf81f4dcf956195aab
 2014-08-22 17:17:52 +02:00
Stephan Bergmann
e426e448ce Consistency around SfxStringItem in svx/inc/sxonitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I694c42a53cb9041b51ef876416f0f61963b89f86
 2014-08-22 15:40:43 +02:00
Stephan Bergmann
9a6d1c6e16 Consistency around SdrYesNoItem in svx/sxmspitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: If7a3c3834f63bd0b358da4d05e9510c3f695c5d0
 2014-08-22 14:46:16 +02:00
Stephan Bergmann
0073c78eaf Rectangle coordinates are long, not sal_Int32 
Change-Id: I2f4bd53bbf94ea439e774ea85e61adcdb920c497
 2014-08-22 14:21:05 +02:00
Stephan Bergmann
3584d4b47c Avoid invalid downcasts 
Change-Id: Iea1688213cc0ebb8fcb3d3e3c862fd31275b9b38
 2014-08-22 11:55:42 +02:00
Chris Laplante
7b33dbb253 svx: Cleanup ASCII art and useless comments 
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71
Reviewed-on: https://gerrit.libreoffice.org/11011
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-19 01:28:24 -05:00
Stephan Bergmann
759f5d24b0 Consistency around XColorItem in svx/sdshcitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
 2014-08-18 18:18:08 +02:00
Stephan Bergmann
69dd9c669a Consistency around SdrPercentItem in svx/sdshtitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I4e98c362f811c19f03766d0c78f10c795d3ac79d
 2014-08-18 17:38:08 +02:00
Stephan Bergmann
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
 2014-08-18 14:56:55 +02:00
Stephan Bergmann
a51c423743 Consistency around SdrMetricItem in svx/sdsxyitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
 2014-08-18 10:55:36 +02:00
Matteo Casalin
a7e2d3280f Simplify by early bail-out 
Change-Id: Id3789fd994b54813b6f72857a625b496c7a6eef0
 2014-08-16 21:52:32 +02:00
Matteo Casalin
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE 
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
 2014-08-16 21:52:32 +02:00
Matteo Casalin
3fd369d93a Remove repeated check 
Change-Id: I2ed6326f97bf6c0eefb3d309405261ffd30681b9
 2014-08-16 21:52:30 +02:00
Matteo Casalin
bfa5e2f276 Just copy the boolean value 
Change-Id: I158f4e9eddf7ea666613d56a79d014dd3cbf9931
 2014-08-16 21:52:29 +02:00
Matteo Casalin
74bccf73fd Remove pnMarkNum parameter: either NULL or pointed data is not read 
Change-Id: I213a097616275765478a5f21a5f8e9645470a1e8
 2014-08-16 21:52:29 +02:00
Matteo Casalin
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE 
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
 2014-08-16 21:52:28 +02:00
Jan Holesovsky
8e8383612e Go even further in the scope reduction, we are 100% sure mpClone is NULL. 
Change-Id: Id5facbc817ecc0b89689dcba30672a6538e70945
 2014-08-14 22:25:52 +02:00
Kohei Yoshida
b732ba336a Massive scope level reduction by early bail-out. 
Change-Id: Ie620208f02bf74844f9b7cb904f9c5abbb10ca07
 2014-08-14 14:21:36 -04:00
Stephan Bergmann
0765c16b6a Consistency around SdrOnOffItem in svx/sxcaitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I1a88c73c8e4c764a6beadb8bb54910d868a12d93
 2014-08-12 17:36:06 +02:00
Stephan Bergmann
81bf87fec4 Fix apparent SdrCaptionAngleItem vs. SdrCaptionFixedAngleItem mismatch 
...though it was like that ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import"

Change-Id: Ib3efe7bf7a559ede52966f4763a9f9e748b6ba6a
 2014-08-12 17:36:06 +02:00
Stephan Bergmann
7fb48e7e3a Consistency around SdrMetricItem in svx/sxmlhitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I65c36bde166c5f78db8c76364fd057017982fed6
 2014-08-07 11:53:42 +02:00
Stephan Bergmann
5ecec388bb Consistency around SdrYesNoItem in svx/sxmsuitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I25002e5b6043baa8c93b180a03f475bea5906e4f
 2014-08-07 11:27:26 +02:00
Stephan Bergmann
14ac70c74a Consistency around SdrMetricItem in svx/sxelditm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

(SdrEdgeLine1DeltaItem::Clone had been recently---and in retrospect needlessly
---introduced in 596ec6f52fe3a8d56d5c20df568633cfbcadc74d "Missing
SdrEdgeLine1DeltaItem::Clone override" before
3efa3ad7b6de78c291f49858e50e6bedbd6a2173 "SdrEdgreLine*DeltaItem::Put/QueryValue
are same as underlying" revealed that SdrEdgeLine1DeltaItem was a needless
derivation of SdrMetricItem.)

Change-Id: I154d32d46a7c01c792aa4e812cf576d4d749e0c9
 2014-08-06 12:54:53 +02:00
Stephan Bergmann
3efa3ad7b6 SdrEdgreLine*DeltaItem::Put/QueryValue are same as underlying 
...CntInt32Item::Put/QueryValue

Change-Id: I21602be0f4ba9d9e34a379a86d524b05976b0c8f
 2014-08-06 12:15:38 +02:00
Stephan Bergmann
596ec6f52f Missing SdrEdgeLine1DeltaItem::Clone override 
Change-Id: Id0fde0a76fbcb63c13c943a0caec0d715886f039
 2014-08-06 11:10:03 +02:00
Stephan Bergmann
43856800f0 Consistency around SdrOnOffItem in svx/sdasitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
 2014-08-06 10:20:53 +02:00
Stephan Bergmann
42172ea647 Let GetObjectItemPool return a reference 
Change-Id: Ibbcfa3452afcf88dbb6050765e081a1be2381334
 2014-08-05 23:04:07 +02:00
Stephan Bergmann
91573182c8 Fine to let GetObjectItemPool return just SfxItemPool* 
Change-Id: Id461dea979c394add57cbc4b1a50bc1a4c183d1b
 2014-08-05 19:14:52 +02:00
Stephan Bergmann
8d023edc18 Consistency around SdrOnOffItem in svx/sdshitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
 2014-08-05 08:59:37 +02:00
Stephan Bergmann
151fbebf8c Consistency around SdrOnOffItem in svx/sdtagitm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
 2014-08-04 19:22:55 +02:00
Markus Mohrhard
02f0102b8b prevent memory leak 
Found by Lsan.

Returning this or a heap allocated object asks for trouble. Let the
caller handle it and return null instead of this.

Change-Id: I7586e103bef5a8c2727adfe214b052d6962d4467
Reviewed-on: https://gerrit.libreoffice.org/10716
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-08-04 12:49:59 +00:00
Stephan Bergmann
768d32cf5b Consistency around SdrMetricItem in svx/sdtditm.hxx 
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
 2014-08-04 11:29:51 +02:00
Stephan Bergmann
68969cc61a Consistency around SdrMetricItem 
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
 2014-07-31 15:57:12 +02:00
Stephan Bergmann
91f7e828f8 typo 
Change-Id: Ic8795d05f66b45bd43e3444f0f368a2e6352aa2c
 2014-07-31 12:57:37 +02:00
Noel Grandin
9d140ccdb3 drop use of SFX_ITEM_PRESENTATION_NONE 
since none of the call sites specify it

Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
 2014-07-29 12:26:17 +02:00
Noel Grandin
7e018afaf7 simplify return argument of SfxPoolItem::GetPresentation 
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.

Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
 2014-07-29 11:04:01 +02:00