e62ec6d049
fdo#75757: remove inheritance to std::vector
...
from SwLayCacheImpl.
Change-Id: I77520495aab1d6a572b25433396202b11e478636
Reviewed-on: https://gerrit.libreoffice.org/11158
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-09-01 08:19:05 -05:00
a2336d20a5
coverity#1233487 Unchecked dynamic_cast
...
Change-Id: If6955ba90f2838cfe0b4954b31a760e067518dc6
2014-08-31 12:32:27 +01:00
9991b50ccc
Make opengl chart window always active
...
Fortunately there is a special ole object group with
the MS_EMBED_ACTIVATEWHENVISIBLE flag which define this
behaviour.
Problem is that both Aspect and EmbedMisc are MS specific
enums so we can't use them directly for non-MS objects. But we
can handle opengl charts the same as this ole object group.
Change-Id: I49abeffce319cbb775709a72ba198a1f76b65374
2014-08-29 17:40:27 +02:00
bd9a4e1922
ChartHelper::IsChart is useless
...
EmbeddedObjectRef has an own IsChart method with the same
behavior.
Change-Id: Ib06699186466bf3da2bd67d7c631a5216463fb14
2014-08-29 17:40:27 +02:00
2ffaaf6b59
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: I343335b56fcbac570c0000e1216dc4d16b9a05b9
2014-08-28 17:24:24 +02:00
75028bd82a
fdo#75757: remove inheritance to std::vector
...
Change-Id: I1874b5b4a059ef5fc8818b3b49ff10f2917b20ca
Reviewed-on: https://gerrit.libreoffice.org/11135
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-08-27 05:29:42 -05:00
2f5e266e97
Refactor NumRule handling in CopyImpl
...
The bug fix for i#86492 added a lot of duplicated code. This moves
the code into their own functions and uses macros to make the
resulting code even more readable.
Change-Id: Ifa0ece26f3152f1f8d8c65173b459e8c14c5b43a
Reviewed-on: https://gerrit.libreoffice.org/10968
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-08-26 07:43:36 -05:00
2d66f9dc47
Better variable naming in SwViewImp::NotifySizeChg
...
Make it obvious, which variable contains the document boundaries and
which the draw / fly object boundaries.
Change-Id: I0bc2bcb5515e317c7a204b3458b92c61482e1a5c
Reviewed-on: https://gerrit.libreoffice.org/10974
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-08-26 07:29:45 -05:00
7fc5207ebe
Refactor a tiny bit of SwLayAction::IsShortCut
...
Change-Id: I13d4fbebec02bddaa27e8929188d497dde715730
Reviewed-on: https://gerrit.libreoffice.org/10980
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-08-26 06:54:46 -05:00
8ad8d87832
SwXServiceProvider::MakeInstance() requires a SwDoc
...
Change-Id: I2522e43100baa691baeb55947bb47ce7ccabb5b4
2014-08-25 21:49:36 +02:00
f50a367738
convert MSG_COMCORE_ASKSEARCH with custom buttons to .ui
...
Change-Id: I5066c850a22a9dcf0778878a160bbedee6fba81d
2014-08-25 16:45:28 +01:00
0dd209b081
Properly downcast to any type of SwFlowFrm, not just SwCntntFrm
...
Change-Id: I6b3ade33c282823f4868c1fea5906d71eaeb5568
2014-08-25 15:58:09 +02:00
d66159c61a
Remove unnecessary invalid downcast
...
Change-Id: I53a9e864f01782cef10f2995ba90335f5c81077a
2014-08-25 15:37:13 +02:00
39380c04a5
Avoid unnecessary dereferencing of potential null pointers
...
That pDoc can be null here and in previous
2406562733f62b96dd8e6537e1bf4bef147ef50c is somewhat fishy, but probably related
to "NOTE: the sw.SwXAutoTextEntry unoapi test depends on pDoc = 0" from
"fdo#72695: avoid double-free race condition for SwXTextField." As mstahl puts
it: "hmm... theres some stupid unoapi test that inserts a field into an
SwXAutoTextEntry which is a horribly odd class that doesn't have any way of
creating SwXanything of its own SwDoc... so probably your commit is required
after all."
Change-Id: I2da77e1180e205eca274ce0330ee2a4d5aab29ac
2014-08-25 15:26:59 +02:00
2406562733
Avoid unnecessary dereferencing of potential null pointers
...
Change-Id: Iba21dd394010a162a52bb576400cbbb9a9aad537
2014-08-25 14:30:12 +02:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
a00778f9d3
Dump table attributes and page description items
...
Adds the SwPageDesc name to the dumpAsXml output of the
SwFmtPageDesc / RES_PAGEDESC SfxPoolItem and dumps the tables
attibutes.
Adtittionally this renames the unknown field name, so it doesn't
produce wrong XML output (blamed by "xmllint --format") and adds
the hex node type to the start and end node XML output.
Reviewed on:
https://gerrit.libreoffice.org/11091
Change-Id: I3cde39d423e17909243675efdd39557a6bfffbd7
2014-08-25 09:27:09 +02:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
130fc2f995
Avoid undef member function call with this == nullptr
...
(in which case SwFrm::FindPageFrm, sw/source/core/layout/findfrm.cxx, happened
to return nullptr, so all used to go well; but still...)
Change-Id: Ib513d9a157d0135ca234930bbcbeeacf814bb80e
2014-08-22 18:38:15 +02:00
4970d562b6
Prevent downcast to SwTxtFrm when already in ~SwFrm superclass dtor
...
...as done in SwAnchoredObject::FindAnchorCharFrm
(sw/source/core/layout/anchoredobject.cxx) during CppunitTest_sw_ooxmlexport5:
SwAnchoredObject::FindAnchorCharFrm
SwAnchoredObject::GetAnchorFrmContainingAnchPos
SwAnchoredObject::FindPageFrmOfAnchor
lcl_NotifyBackgroundOfObj
SwDrawContact::DisconnectFromLayout
SwDrawContact::DisconnectObjFromLayout
SwFrm::Destroy
SwFrm::~SwFrm
SwCntntFrm::~SwCntntFrm
SwTxtFrm::~SwTxtFrm
SwTxtFrm::~SwTxtFrm
SwLayoutFrm::Destroy
SwLayoutFrm::~SwLayoutFrm
SwCellFrm::~SwCellFrm
SwCellFrm::~SwCellFrm
SwLayoutFrm::Destroy
SwLayoutFrm::~SwLayoutFrm
SwRowFrm::~SwRowFrm
SwRowFrm::~SwRowFrm
SwLayoutFrm::Destroy
SwLayoutFrm::~SwLayoutFrm
SwTabFrm::~SwTabFrm
SwTabFrm::~SwTabFrm
SwFlyFrm::DeleteCnt
SwFlyFrm::~SwFlyFrm
SwFlyFreeFrm::~SwFlyFreeFrm
SwFlyAtCntFrm::~SwFlyAtCntFrm
SwFlyAtCntFrm::~SwFlyAtCntFrm
SwLayoutFrm::Destroy
SwLayoutFrm::~SwLayoutFrm
SwBodyFrm::~SwBodyFrm
SwBodyFrm::~SwBodyFrm
SwLayoutFrm::Destroy
SwLayoutFrm::~SwLayoutFrm
SwFtnBossFrm::~SwFtnBossFrm
SwPageFrm::~SwPageFrm
SwPageFrm::~SwPageFrm
SwLayoutFrm::Destroy
SwRootFrm::~SwRootFrm
SwRootFrm::~SwRootFrm
boost::checked_delete<SwRootFrm>
boost::detail::sp_counted_impl_p<SwRootFrm>::dispose
boost::detail::sp_counted_base::release
boost::detail::shared_count::~shared_count
boost::shared_ptr<SwRootFrm>::~shared_ptr
SwViewShell::~SwViewShell
SwCrsrShell::~SwCrsrShell
SwEditShell::~SwEditShell
SwFEShell::~SwFEShell
SwWrtShell::~SwWrtShell
SwWrtShell::~SwWrtShell
SwView::~SwView
SwView::~SwView
SfxViewFrame::ReleaseObjectShell_Impl
SfxViewFrame::~SfxViewFrame
SfxViewFrame::~SfxViewFrame
SfxViewFrame::Close
SfxFrame::DoClose_Impl
SfxBaseController::dispose
(anonymous namespace)::Frame::setComponent
(anonymous namespace)::Frame::close
SfxFrame::DoClose
SfxViewFrame::Notify
SfxBroadcaster::Broadcast
SfxModelListener_Impl::notifyClosing
SfxBaseModel::close
SwXTextDocument::close
SfxBaseModel::dispose
SwXTextDocument::dispose
SwModelTestBase::tearDown
...
Change-Id: I4c00fa8eebf0346a2bad81a9e362cd901555bbf0
2014-08-22 17:37:15 +02:00
dd1c49d172
Simplify autocorrect loading - removing redundant parameter.
...
Change-Id: Idc1ebba8d859ec79b6744228cfe3ef1f0992e41d
2014-08-22 16:22:12 +01:00
53ce805b43
Avoid unnecessary invalid downcasts
...
...to SwFmtFtnAtTxtEnd instead of SwFmtEndAtTxtEnd, both derived from
SwFmtFtnEndAtTxtEnd
Change-Id: I4b909f136268058bedeacd6b47d3f4cd88522ad5
2014-08-22 17:01:51 +02:00
2a029e5f4e
SwXParagraph::Impl::GetTxtNode: fix indenetation
...
Change-Id: Iac9e2883067b6cf4fdc259110642002b4ef6e48c
2014-08-22 14:13:30 +02:00
39a84ef78a
The comment apparently pertained to the following line
...
...cf. 75400111a50ce0b4026e7eb73a896ac3c28d6155 "INTEGRATION: CWS
swqbf64: #i65250# <SwFrm::mnFrmId> now in general available," but is rather
useless nowadays anyway
Change-Id: I1e9d6c289fad021764f7e1b1af0d7b9dca67bf53
2014-08-22 13:46:53 +02:00
de6fd1b90f
Avoid invalid downcasts to SwFmtHeader instead of SwFmtFooter
...
...which only happened to work because the two classes have very similar layout
Change-Id: Ie4bde807a2442a95ff515b065d4f45f257a32f34
2014-08-21 15:06:48 +02:00
98fba3ab36
Check pTmpFrm->GetType(), not nFrmType, for FRM_FLY
...
...as nFrmType need not match pTmpFrm->GetType() exactly, but can e.g. be
USHORT_MAX when GetFrmOfModify is called from SwFrmFmt::FindLayoutRect
(sw/source/core/layout/atrfrm.cxx). It is probably good luck that the two
comparisons against FAR_AWAY made it too unlikely for the if's true branch to
ever be taken for a pTmpFrm that is not actually a SwFlyFrm. Found the bug when
running CppunitTest_sw_ooxmlexport2 under -fsanitize=undefined, where
((SwFlyFrm*)pTmpFrm)->GetAnchorFrm()
was called for a pTmpFrm of type SwTabFrm.
Change-Id: Ia886a809bdb82488c3f410be66cf827b3f723c55
2014-08-21 13:35:06 +02:00
c310523a5f
C++ name lookup is hard, especially for clang tinderbox
...
Change-Id: I50a25e5cfa219bbdcf0a23c03b8e6a2cff72c3d6
2014-08-20 17:12:13 +02:00
9f01ba1b78
i#107771: sw: burn, UnoCallBack, burn!
...
Change-Id: Ifdb6d4b2e404bd160e6fcec3229691e750bdf698
2014-08-20 16:40:18 +02:00
bd6f0559af
fdo#72695: avoid double-free race condition for SwXFootnote
...
Change-Id: Id7832d8e65723ae30ad2b5ce95d145def53998f0
2014-08-20 16:40:18 +02:00
2c057a59e8
i#107771: sw: implement thread-safe instance caching for SwXFootnote
...
Change-Id: I3fffb321877168dfa9844b4ad75a9a9efc9602a6
2014-08-20 16:40:18 +02:00
e54015d06f
i#107771: sw: make SwXFootnote a client of its format poolitem
...
In other words, stop registering at SwDoc's "UnoCallBack".
Change-Id: Ie73c707b0f43559cc78717c0879d5e9a9335a7ac
2014-08-20 16:40:17 +02:00
eee8b6eed6
SwWrtShell::StartInputFldDlg() can be called with RES_SETEXPFLD too
...
... and there's no way to get the SwFmtFld from a SwSetExpField, so add
a member for it like SwInputField has. That's still better than the
UnoCallBack nonsense.
Change-Id: I59c82e95414dbae284432b8a318a6ce1a34256c7
2014-08-20 16:40:17 +02:00
bbd97fe57d
i#107771: sw: make SwXTextField a client of its format poolitem
...
In other words, stop registering at SwDoc's "UnoCallBack"
Change-Id: Ieb2639497fe5e8d71aa1c47952c007da76fcee84
2014-08-20 16:40:17 +02:00
b8a28f81ec
better error handing in SwXTextField::attach()
...
Change-Id: I4b8b4ef1f34ba5662bd56bfbb335b87fb5aa4b51
2014-08-20 16:40:17 +02:00
eb09b803aa
fdo#72695: avoid double-free race condition for SwXReferenceMark
...
Change-Id: I66a988f17adebba72a71af5b770abbebfa4e12b2
2014-08-20 16:40:16 +02:00
14eb485c5c
i#107771: sw: implement thread-safe instance caching for SwXReferenceMark
...
Change-Id: I4f3b6789dde053ca913e12233b20d45dfe50c7ec
2014-08-20 16:40:16 +02:00
1e28d7901d
SwXReferenceMarks::GetObject() has no need for a mutex guard
...
Change-Id: Icc6b0eebf57b07f06bccc9a57036f0611a67c4a3
2014-08-20 16:40:16 +02:00
e7c96f3e8f
i#107771: sw: make SwXReferenceMark a client of its format poolitem
...
In other words, stop registering at SwDoc's "UnoCallBack"
Change-Id: I9e08966cf8e2d2a373867d81549c8887f73993c8
2014-08-20 16:40:15 +02:00
b684cd4b07
sw: RES_TOXMARK_DELETED is unused since swunolocking1
...
Change-Id: I98b21573ebbc8543609bd63eee30bc5b4cbdfb2c
2014-08-20 16:40:15 +02:00
c5390b3ee9
SwXDocumentIndexMark::CreateXDocumentIndexMark does not need SwTOXType
...
... passed in as parameter since it's always the one from pMark.
Change-Id: Ia5981b0f281c8cac70cbb305c82bb6785918168a
2014-08-20 16:40:15 +02:00
57b29dc9d4
RegisterToTOXType has a silly parameter name
...
Change-Id: I1cfd5c077f4b1ac809ace91fe76308f0e1892e09
2014-08-20 16:40:14 +02:00
f05273aa47
fdo#72695: avoid double-free race condition for SwXParagraph
...
Change-Id: Ie207d9400bc3a55e17497b309dfbc263e7b12e30
2014-08-20 16:40:14 +02:00
7a3716bd7b
fdo#72695: avoid double-free race condition for SwXTextSection
...
Change-Id: I6a4cd076deef63f172c42dcc22cc44c47a4aa293
2014-08-20 16:40:13 +02:00
7fa2a36333
fdo#72695: avoid double-free race condition for SwXDocumentIndex
...
Change-Id: I9264ea023ee12b24561e86d893b1f7abb2765621
2014-08-20 16:40:13 +02:00
939edde802
fdo#72695: avoid double-free race condition for SwXDocumentIndexMark
...
Change-Id: I08fef7f1de4cce468a4936e33d3684f847e1aa5b
2014-08-20 16:40:13 +02:00
c71c1b2bb3
fdo#72695: avoid double-free race condition for SwXFieldMaster
...
Change-Id: Id3dfe1c68f00964200ad53922a0f41ebdbc4c3f8
2014-08-20 16:40:12 +02:00
8deeb0d538
fdo#72695: avoid double-free race condition for SwXTextField
...
Change-Id: I6adfcb1bdd5e8e1525568a4bcd93a8e0e97359be
2014-08-20 16:40:12 +02:00
624198efe4
SwXBookmark: m_rThis now unused
...
Change-Id: I686a5383a6b42872bd6945780c661d1a2a49cad7
2014-08-20 16:40:12 +02:00
0a1256a9d7
fdo#72695: avoid double-free race condition for SwXBookmark/SwXFieldmark
...
Change-Id: I92838d75f5573e4b626b94ef446f464be1b39b67
2014-08-20 16:40:11 +02:00
778fc411d1
SwXMetaText::GetXMeta() now unused
...
Change-Id: I832b4b544050c2105ed40fb6421318e8b59313d1
2014-08-20 16:40:11 +02:00
