Commit Graph

660 Commits

Author SHA1 Message Date
eee8b6eed6 SwWrtShell::StartInputFldDlg() can be called with RES_SETEXPFLD too
... and there's no way to get the SwFmtFld from a SwSetExpField, so add
a member for it like SwInputField has.  That's still better than the
UnoCallBack nonsense.

Change-Id: I59c82e95414dbae284432b8a318a6ce1a34256c7
2014-08-20 16:40:17 +02:00
15295ab6db Refactored SwDoc::GetEditShell .
Removed its output paramater as GetCurrentViewShell should be
used instead and added a const version.

Change-Id: Iad8b57553b6e93e3472ce8c6905d08e8d49af770
2014-08-19 21:57:06 +02:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
535971f3a1 Refactored IDocumentStylePoolAccess out of SwDoc.
Added non const SwDoc::GetDfltTxtFmtColl and SwDoc::GetTxtFmtColls
and SwDoc::GetCharFmts.
Had to make the manager friend of SwTxtFmtColl and SwConditionTxtFmtColl
Had to make SwDoc::_MakeCharFmt and SwDoc::_MakeFrmFmt public.

Change-Id: I19a36d91f92b3781a6c4313ec12eb8f7d4dfacc3
2014-08-12 23:26:38 +02:00
5494954b26 Refactored IDocumentLayoutAccess out of SwDoc.
Into the new class DocumentLayoutManager.

Change-Id: I02d0cfcc63633d0bdab380508b2ef563187fd269
2014-08-12 23:26:38 +02:00
64e13a1456 Refactored IDocumentState out of SwDoc.
Into the new class DocumentStateManager.

Change-Id: I91c9097b091ff6118d58fd15fff2a4cefe0171fd
2014-08-12 23:26:38 +02:00
9cc617afcd Refactored IDocumentStatistics our of SwDoc.
Into the new class DocumentStatisticsManager.

Change-Id: I281232dc09dbd79c2faf3c2a78ae49625bbe88ee
2014-08-12 23:26:37 +02:00
69e5f335ab Refactored IDocumentFieldsAccess out of SwDoc.
Into the new class DocumentFieldsManager.
Removed SwDoc::_MakeFldList because it is not defined anywhere.
Also moved a few non interface methods that belong to the manager.

Change-Id: Icefd7ca7adcbb05a18d6fae0529fc54150b862fd
2014-08-12 23:26:36 +02:00
3dafed2ede -Werror,-Wundefined-bool-conversion
Change-Id: Iff8db4c82abeeed0789d7012223a846f1058c353
2014-08-12 12:19:43 +02:00
b38b124b64 fdo#81341 : DOCX: EditTime is not geting preserved after RT
Issue :
	- LO was not able to Import EditTime field in "HH:MM:SS" format.
	- LO was Importing it as "HH:MM" format.
	- In getTime() third parameter is passed as "false" which is bSec.
          Because of which LO was not able to Import EditTime in seconds.

	Implementation :
	- Added code to check value of Seconds > 0.
	- Added code at Export side to write "EDITTIME" field.
	- Added Unit test case at Export side.

Because of which LO was not able to Import EditTime in seconds.

Reviewed on:
	https://gerrit.libreoffice.org/10655

Change-Id: Ic740dc30d79be594dec9a0a05e407a7cb1a5941e
2014-08-01 13:32:20 +02:00
3e7004c3ac sal_uInt16 to size_t/bool in SwInputFieldList
Change-Id: Ib54e747abaf4e7a911dd3986d27f21a96eaa6120
2014-07-26 14:25:25 +02:00
54ca3a6efa Refactored IDocumentLinksAdministration out of SwDoc.
To the new class DocumentLinksAdministrationManager.
Additional to the Interface methods SwDoc::SelectServerObj was also moved
and sw/source/core/doc/docdde.cxx was deleted as it became empty.
Also fixed OUString usage in IDocumentLinksAdministration.hxx .

Change-Id: I1f2bf0881a7d4add9c657b6441851ae14ad8d161
2014-07-15 15:44:03 +02:00
e465f0f474 Resolves: #i125228# correct consideration of InputFields...
in table cells are part of table formulas

(cherry picked from commit b384441c10475c9784eae3ea501afb22e0317468)

Conflicts:
	sw/source/core/fields/cellfml.cxx

Change-Id: I4780ce0c1ac9ac911b654f61aa12938d7b225139
2014-07-14 15:57:18 +01:00
6fe539ceee fdo#39468: Translate German comments in sw/source/core/
Change-Id: Ib48b281feccd4684571768ca2be6ecca23afbf55
2014-07-13 17:55:08 +02:00
f021524aad fdo#76279 Invalid Citation on RoundTrip
Reviewed on:
	https://gerrit.libreoffice.org/9898

Change-Id: Idfe39761180ae1eeb0066ae3aac13de6ac6df0b9
2014-07-11 10:12:42 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
887b3a3562 loplugin:staticcall
Change-Id: I26e1e0f66dad5ed4e8351fc7509449b312559166
2014-06-13 17:54:35 +02:00
2da8a60702 Revert "Change sw::mark::IMark::GetOtherMarkPos return type from ref
... to pointer"

CrossRefBookmark::GetOtherMarkPos() is apparently not supposed to be
called, so just replace the undefined null-reference with a call to
abort().

This reverts commit dcf0ac048ce745774f401ada72b051757298c559.

Change-Id: I55b4accb4f42031df5671e8a30897e3aff9b56f9
2014-06-11 16:08:34 +02:00
dcf0ac048c Change sw::mark::IMark::GetOtherMarkPos return type from ref to pointer
...so CrossRefBookmark::GetOtherMarkPos can legitimately return a null pointer

Change-Id: I88774cf0d139d017d67d6727ee01214997a73636
2014-06-10 19:44:04 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
0ed60a9737 fdo#76281: Fix wrong square brackets in exported citations
There was a pair of unbalanced ifs in the code to write the opening
and the closing bracket, they should have the same condition.

Change-Id: I9b3e64486d1b87a8df65d351f01eb4cc9a8b8c44
2014-06-06 20:19:49 +02:00
86075a3f0f Split out IDocumentDrawModelAccess from SwDoc.
To the new class DocumentDrawModelManager.
All moved methods and members have the same in thew new class.

Change-Id: I89ad0e0c4a42885d5810e834983ea8e8e6c0a2d2
2014-06-03 19:12:05 +02:00
4161070eb2 Removed IDocumentSettingAccess.hxx include in SwDoc.hxx
Because it is not needed there anymore with IDocumentSettingManager.

Change-Id: Iad5e0a03f2628c9d26698d23e691b3e6228eee0b
2014-06-03 19:12:02 +02:00
eea173edaa coverity#704885 Unchecked dynamic_cast
Change-Id: I748a73523b6b1908d89663e90f7cab378920110d
2014-06-02 17:00:00 +01:00
747bcdc143 fdo#78332: sw: fix separators in SwDDEFieldType::PutValue()
Setting 3 separators instead of 2 does not work.

(regression from 263153842741d7ce21cc0bf1c5296a55a1138024)

Change-Id: Id0b4649404b8a49a7f89a237c46106bce4e146ff
2014-05-27 20:52:53 +02:00
0a3fe4c281 Remove ASCII art and useless comments from sw module
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2
Reviewed-on: https://gerrit.libreoffice.org/9494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:46:44 -05:00
745a094a37 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part15
Change-Id: I38e855966598342eb2352e70e04f7a5e09e54f83
2014-05-17 23:33:02 +02:00
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-10 06:19:42 +02:00
76e8779787 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part6
Change-Id: Ib523206d67ad13416557be1b37a58ba7a9791ca5
2014-05-08 18:12:58 +02:00
cc0a7699bb fdo#75519: fix chapter cross references
It would be possible to modify the condition in
SwChapterField::ChangeExpansion() to check for rTxtNd.GetNumRule() as
well and make the bugdoc work again, but do we really want to use
"chapter reference" to refer to plain numbering?  Perhaps it would be
better to add a "numbering reference" field type; without investigating
what Word actually does here and what the actual problem is that was
supposedly fixed here (which is not possible given there's no reproducer
document) it's best for now to just revert it.

(regression from commit 6319803762d051c4aa645692cde7245a1bbcf7ee)

Change-Id: I7eb9ea46e42729c53c350ff450d49a1eb84ee8eb
2014-05-07 15:07:19 +02:00
af10cb2c9c Rename SwDBMgr -> SwDBManager.
We were renaming it recently from SwNewDBMgr, let's use the full name to make
it more readable.

Change-Id: I2ceb3f1790321b70d5936c35e13870439969e64d
2014-05-02 21:32:23 +02:00
6aa35db393 sw: sal_Bool->bool
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-30 08:44:42 +02:00
043bbbf198 There is nothing "new" with SwNewDBMgr any more
Change-Id: Icbf3d5663a358bf31b58ab8086ffe9160c26bf8f
2014-04-22 10:06:41 +03:00
e152235827 More hacking on --disable-database-connectivity
Work in progress, still lots of undefineds when attempting to link
TiledLibreOffice.

Change-Id: I80fa330768d9f9fa9ef65e3693f1d777c0713210
2014-04-22 09:43:44 +03:00
b166e7af2b There is nothing "new" with SwNewDBMgr any more
Change-Id: I28c48be099ba680a5d6ea91981a1e1bfadff3f84
2014-04-22 08:07:17 +03:00
cbfcb837fb fdo#77342: sw: fix copy/paste of footnote cross references
The fix for sequence fields broke the footnote references some more;
simplify it by handling the footnotes in the same way as the sequence
fields, and not remapping GetExp fields for which the corresponding
SetExp field / footnote is missing.

Also, don't do any remapping when the target is a clipboard document, to
prevent modifying the source document.

(regression from bb665affbd8870652ade3951d626d76e99143f67)

Change-Id: If1be1e1d9742182a4085bbbff53e26a8fa8665b8
2014-04-17 15:30:10 +02:00
2afe4c170d Clean up function declarations and some unused functions
Change-Id: I58c425ab9d2c01f8844226aff820dd56d88ec09c
2014-04-15 13:56:21 +02:00
b8239ac2f9 typo: noone -> no one 2014-04-14 12:32:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
769a6c20c4 sw: prefer passing OUString by reference
Change-Id: Iaa846ec8f19567f0a9f30154d74cc53df93eff16
2014-03-17 13:30:51 +02:00
55a5e890ef sal_Bool to bool + make a local function static
Change-Id: I8285f69e175dd10f6128a1d9b39bdc646c51df43
2014-03-16 09:51:13 +01:00
2e26e6fd91 sal_Bool to bool
Change-Id: I3548bdc15cf779495a966b4b36bb6d209fd3ee8f
2014-03-16 09:39:14 +01:00
06f7d1a96e fdo#74775: Preseved Citation after round trip.
Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
	https://gerrit.libreoffice.org/8473

Change-Id: Ie1b0ac3cb4d4b9bf305323599d5e4b63f913fb1b
2014-03-14 10:45:33 +01:00
45d09ea271 "overflow" is one word
Change-Id: Ib36c2c5d55f86aff27081a0da554f6e8a81474ee
2014-03-11 17:17:39 +02:00
7af06afee4 fdo#75492: table names can start the same way and still be different
Change-Id: Icc5a6fb7cf3ed3c2171e628d22918af7038f8127
2014-03-07 12:51:37 +01:00
0e887093a5 remove unused code in SW module
SwAccessibleParagraph::GetTOCLevel()
SwAccessiblePortionData::GetAttrFldType(int)
SwAccessibleTable::SetTableData(SwAccessibleTableData_Impl*)
SwCntntFrm::DelFrms(SwCntntNode const&)
SwExtraRedlineTbl::Contains(SwExtraRedline const*) const
SwExtraRedlineTbl::Remove(SwExtraRedline const*)
SwPostItField::GetByName(SwDoc*, rtl::OUString const&)
SwViewImp::FireColumnChangeEvent(unsigned short, unsigned short)
SwViewImp::FirePageChangeEvent(unsigned short, unsigned short)
SwViewImp::FireSectionChangeEvent(unsigned short, unsigned short)

Change-Id: Id385122a54970ed944e6dfc4c2b264da4f936255
2014-03-05 09:17:47 +02:00
ded5965ce8 editeng: sal_Bool->bool
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03 08:59:38 +02:00
2630874bcc coverity#705422 Improper use of negative value
Change-Id: I28feee353b75d3810358f70dcafb8763918f86fe
2014-03-02 20:08:24 +00:00
a27462189d Remove visual noise from sw
Conflicts:
	sw/inc/unodraw.hxx
	sw/inc/unoframe.hxx
	sw/sdi/swriter.sdi
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unoparagraph.cxx
	sw/source/filter/ww8/rtfexportfilter.cxx
	sw/source/ui/inc/unotxvw.hxx
	sw/source/ui/lingu/hyp.cxx
	sw/source/ui/lingu/sdrhhcwrap.cxx
	sw/source/ui/uno/swdetect.hxx

Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908
Reviewed-on: https://gerrit.libreoffice.org/8322
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 09:41:00 -06:00