Commit Graph

933 Commits

Author SHA1 Message Date
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
887b3a3562 loplugin:staticcall
Change-Id: I26e1e0f66dad5ed4e8351fc7509449b312559166
2014-06-13 17:54:35 +02:00
8e6eb6fb21 DLG_MM_ASSIGNFIELDS conversion to .ui
Change-Id: Ia625de9edd46c185c2712c0c5a7154ba1abb2894
Reviewed-on: https://gerrit.libreoffice.org/9726
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-12 08:49:19 +00:00
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
a92e973b6d Change SfxTabPage::Reset param from ref to pointer
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)

Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
4dbeadb9c1 Change SfxTabPage::FillItemSet param from ref to pointer
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)

Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
f634cda2a2 avoid problems with poppler's and vcl's FontInfo during runtime
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-06-04 07:49:15 +02:00
4269e3a743 Changed DocumentDeviceManager includes to IDocumentDeviceAccess.
In places other than sw/core/

Change-Id: Ie1b67f58cf7777240d9db6a867cd33a7a1cbbcaf
2014-06-03 19:12:03 +02:00
6f77ce5870 Removed DocumentSettingManager methods from SwDoc.
And moved all calls to those methods to GetDocumentSettingManager().

Change-Id: I9b6cc8c3aa9b57bbc0c39f39499dfb4f5f254ad9
2014-06-03 19:12:02 +02:00
0a3fe4c281 Remove ASCII art and useless comments from sw module
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2
Reviewed-on: https://gerrit.libreoffice.org/9494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:46:44 -05:00
1122d513ef loplugin:implicitboolconversion,literaltoboolconversion
Change-Id: Ib783fd0557361286ce7b913a429c9ab8fc101c75
2014-05-20 17:59:56 +02:00
43cd2f79da Displaying the number of standardized pages in the Word count window
The number of standardized pages (unit defined in the options)
for the entire document and the selected area is displayed
(if enabled in options) in the Word count window.
The number of pages of size P for an area containing N characters equals P/N.
This value is a float with one decimal place precision.
The default size of the standardized page is 1800 characters
(including whitespace characters).

The configuration can be altered in Options->Writer->General.

Conflicts:
	sw/source/ui/config/optload.cxx

Change-Id: If13e87c73cb7706ff6618fa0352ba29c7c670aec
Reviewed-on: https://gerrit.libreoffice.org/7642
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-20 09:29:53 -05:00
8d54796bf1 enhance pass-by-ref plugin to detect large arguments
Detect arguments larger than 64 chars passed by value.

Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-20 11:17:22 +02:00
618106a191 Misspelled property in SwAuthenticationSettingsDialog (seperate => separate)
Change-Id: I0cf29711459e5ec185b43cf28716729e659b00b4
Reviewed-on: https://gerrit.libreoffice.org/9357
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-15 06:46:43 +00:00
bf30c8b16d use new VCL IsValueChangedFromSaved method
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963
"RFC: add IsValueChangedFromSaved to VCL button and listbox"

Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08 14:55:12 +02:00
6aa35db393 sw: sal_Bool->bool
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-30 08:44:42 +02:00
5253b04c93 OUString: constify, avoid temporaries and concatenated appends
Change-Id: I0282183ab961784623b537a3f0531dd793d05f81
2014-04-27 14:00:39 +02:00
a106a847cf Reduce scope
Change-Id: I4f02a812a75a44084b3f492dc675bed24716d121
2014-04-27 14:00:38 +02:00
8825085052 sal_uInt16 to sal_Int32 and constification
Change-Id: I17120ae11a1e55bdddba5706e2c36661df2c307f
2014-04-27 14:00:38 +02:00
11b14c3639 Minor optimizations on OUStrings
Change-Id: I9e56b08206cccf824c6437a22cdd6a6b2a6ceffb
2014-04-27 14:00:38 +02:00
795fde846b That header was needed in .hxx, remove it from .cxx
Change-Id: I53d8bbb059ecc5a768b0f794c39a1d0e63edf65f
2014-04-27 14:00:37 +02:00
a911f86662 sal_uInt16 to sal_Int32/sal_uLong
Change-Id: Ic7c8b26e7064c1cee9bc861279c0a278895fc0c8
2014-04-27 14:00:37 +02:00
40064f479b clean up hrc files
and remove some unused stuff

Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
17196e613b OUString: constify and remove a temporary
Change-Id: Iac24bd0de87dd97e752760ee54f40433bda1db41
2014-04-18 07:36:53 +02:00
eb011eea8b Use SAL_N_ELEMENTS() for array size
Change-Id: Ifcdeb47b5481ca6c16cd5eb6eb35858e7b2261c5
2014-04-18 07:36:52 +02:00
6618a52c1b Use more proper integer types and constify
Change-Id: Ia1da4606c9c159741d5bb5f0e85750737ad7486d
2014-04-18 07:36:51 +02:00
eb1c048005 Resolves: fdo#36815 enable printing WYSIWYG sidewindow comments
in order for that to happen the document has to be scaled down
so that the comments outside the border of the sheet of paper
can be brought inside the printable area

Change-Id: Ifafb8eec10a4ea3ea0014097728888603e61e5a4
2014-04-16 11:16:05 +01:00
2df39f400d sw: clean up inter-module includes
Change-Id: I812842e76ae0b7bc252530d2b4aaa2b452c2babf
2014-04-15 21:22:04 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
34002c4e5c sfx2: sal_Bool->bool
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-27 13:45:09 +02:00
5e36e2cb7b svx: sal_Bool->bool
Change-Id: Ifd9279e7ccc671395caa1e6f3723e86062d2fb08
2014-03-11 08:18:14 +02:00
a652ea0fc4 fdo#70422 Moved the linked files from sw/source/ui to a new core/uibase dir
Moved the files linked in sw/Library_sw.mk from sw/source/ui to
sw/source/core/uibase and modified the make files as per the new
directory location.

Reviewed on:
	https://gerrit.libreoffice.org/8447

Change-Id: I05f6ccdeee5e76fb0ae477d16721d9ddc6eaff32
2014-03-09 21:53:34 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
a27462189d Remove visual noise from sw
Conflicts:
	sw/inc/unodraw.hxx
	sw/inc/unoframe.hxx
	sw/sdi/swriter.sdi
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unoparagraph.cxx
	sw/source/filter/ww8/rtfexportfilter.cxx
	sw/source/ui/inc/unotxvw.hxx
	sw/source/ui/lingu/hyp.cxx
	sw/source/ui/lingu/sdrhhcwrap.cxx
	sw/source/ui/uno/swdetect.hxx

Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908
Reviewed-on: https://gerrit.libreoffice.org/8322
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 09:41:00 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
973b47a336 unotools: sal_Bool -> bool
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19 12:47:07 +01:00
aad580af92 coverity#738900 Uninitialized scalar field
Change-Id: I71eef3a4ffddac418b79866c0080c2d2d58a8226
2014-02-19 09:41:49 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
8bc3751ea3 bool improvements
Change-Id: Ibeb658e73b588f90242c95d23149f2ef45a7a815
2014-01-28 20:26:21 +01:00
e3133ae237 Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
ebf5e613a5 SfxNoLayoutSingleTabDialog not needed anymore
all single tab dialogs are .ui enabled now.

So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog
and ~SfxNoLayoutSingleTabDialogBase together

Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23 16:02:10 +00:00
d803483f6a convert more SvStream::operator<< calls
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
7cb3e55bf0 bool improvements
Change-Id: Ib65a1e987ad6511e90fd66a36c0105593a1df27c
2014-01-22 11:39:21 +01:00
d1043892df SfxPoolItem::operator ==, != should return bool
...and SfxEnumItemInterface::HasBoolValue, too.

Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10 17:11:51 +01:00
d61a27f278 use SfxSingleTabDialogBase here now
Change-Id: Ibd5d82f93fb94db3e8d53acc9df05f2459807bb4
2013-12-27 13:49:52 +00:00
2e4360815b fix caption dialog
Change-Id: I499f47b116ff6957bbbc20b91224fe95593d1da1
2013-12-17 10:24:07 +00:00