30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
302cb1d031
QueryBox DLG_CHANGE_AUTH_ENTRY -> MessageDialog + string
...
Change-Id: I836381f710e4f36b977284f6996bb135fc328049
2014-08-22 14:23:56 +01:00
20f6cf0377
Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'
...
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-26 14:25:33 +02:00
d92aa2f445
remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
...
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
887b3a3562
loplugin:staticcall
...
Change-Id: I26e1e0f66dad5ed4e8351fc7509449b312559166
2014-06-13 17:54:35 +02:00
bb761be472
Change SfxTabPage ctor SfxItemSet param from ref to pointer
...
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
a92e973b6d
Change SfxTabPage::Reset param from ref to pointer
...
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
4dbeadb9c1
Change SfxTabPage::FillItemSet param from ref to pointer
...
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
7883992dd5
Avoid possible memory leaks in case of exceptions
...
Change-Id: I45929aae52fa106b5f5c0199f8ce8b60c0ac5438
2014-06-04 04:17:18 +09:00
0a3fe4c281
Remove ASCII art and useless comments from sw module
...
Change-Id: I3ba4ac78fd4810e006b1034bbe7c28b1803895d2
Reviewed-on: https://gerrit.libreoffice.org/9494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-27 01:46:44 -05:00
745a094a37
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part15
...
Change-Id: I38e855966598342eb2352e70e04f7a5e09e54f83
2014-05-17 23:33:02 +02:00
6aa35db393
sw: sal_Bool->bool
...
Change-Id: I324a0ffde2ddcca105451c19e7aadcfad15211d8
2014-04-30 08:44:42 +02:00
1a18c27bfb
sw: actually why does this not simply call FlatIndex()?
...
Change-Id: I74f5e25a05ca3c4c0259dd7f33da57a9e0790caa
2014-04-29 16:22:43 +02:00
ccfbc9e179
fdo#76696: CurTOXType::GetFlatIndex(): fix inverted conditional
...
(regression from 6af1e845baa0ec63ce16f25868e5e3313bd647bb)
Change-Id: I22dd77fe9bb03f2cf4ce4518ef12c566aad66785
2014-04-29 16:22:43 +02:00
a30fc66dd2
remove unused hrc files
...
Change-Id: I7ce04c206250db40076bed699bee892bdfbf19b6
2014-04-22 13:03:19 +02:00
40064f479b
clean up hrc files
...
and remove some unused stuff
Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
80915b8f21
cppcheck: Prefer prefix ++/-- operators for non-primitive types
...
Change-Id: Ic24715d86b3f822babd236ac73c041f3a5c1d92b
2014-04-20 22:54:56 +02:00
2df39f400d
sw: clean up inter-module includes
...
Change-Id: I812842e76ae0b7bc252530d2b4aaa2b452c2babf
2014-04-15 21:22:04 +02:00
2afe4c170d
Clean up function declarations and some unused functions
...
Change-Id: I58c425ab9d2c01f8844226aff820dd56d88ec09c
2014-04-15 13:56:21 +02:00
fa1f7d27c1
typo: attribut -> attribute
2014-04-14 12:32:59 +02:00
75f5d9d214
typo: postion -> position
2014-04-14 12:32:40 +02:00
84272d115d
Introduce twip/mm100 conversion functions instead of duplicated macros
...
Change-Id: Ib689e35b417e0e9016cd6a239c986e0603a99d62
Reviewed-on: https://gerrit.libreoffice.org/8837
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-04-11 10:19:05 +00:00
d2a73cf323
SwMultiTOXTabDialog: fortunately the bogus SetTemplatePath call
...
... fails with exception and does not modify the configuration.
(regression from 1b0f7ee1e04d7b0fe81f7458ae2116615e0f6889)
Change-Id: I0e12cf0b531bc68147cf2be22c28c75c0f05f3ff
2014-04-08 21:51:49 +02:00
97b20c9dee
SwMultiTOXTabDialog: the file we ship is called idxexample.odt
...
Change-Id: Ib62f992814ec83f3bb25a0197b50b0b85979d0bb
2014-04-04 18:16:10 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
fe41e4ba11
Bin pointless INET_HEX_ESCAPE
...
Change-Id: I72238e511c2fca4a4aba0be60b0f2d3b1f46e5c2
2014-04-01 12:14:45 +03:00
55b4c22d5b
sal_uInt16: to sal_Int32 and rework initialization
...
Change-Id: Ifd5d7a8fd792da9931995ae4982504b68afe8303
2014-03-30 16:37:44 +02:00
4a387e155f
Remove one more OUString concatenated append
...
Change-Id: I7d4d000560c6774ffb691c47f951a191f9a92fa9
2014-03-30 16:37:43 +02:00
0ef07edc59
Remove empty branch in if statement
...
Change-Id: Ifa2713638369f8c77e58f4945570fd3faf137d93
2014-03-30 16:37:43 +02:00
8d62f62566
Fix alignment
...
Change-Id: I8a1ba77649c862eab1f381c678689c435420140e
2014-03-30 16:37:42 +02:00
367d3c9b53
Use getToken instead of indexOf and re-assignment
...
Change-Id: If91343c2334f03cd35f95b79b8e341c6ee355f62
2014-03-30 16:37:42 +02:00
c8f4095e56
OUString optimizations
...
* Remove temporaries
* Remove concatenated appends
* Constify
Change-Id: I94db8071c69568818c94670a4b9c71ab31660ac9
2014-03-30 16:37:40 +02:00
567ef6d578
Second batch of adding SAL_OVERRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
34002c4e5c
sfx2: sal_Bool->bool
...
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-27 13:45:09 +02:00
ee84eb9678
Do not compare the same OUString twice
...
Change-Id: Id915a41e3cc50720d36955da9aa2c7efa6c9034c
2014-03-24 23:22:12 +01:00
d6fea2034f
OUString* to const OUString* as constructor argument
...
Change-Id: I54e3b086c57b9b727ffdd5d3aa0c38c2c2ea2954
2014-03-24 23:22:11 +01:00
6af1e845ba
sal_uInt16 to sal_(u)Int32 + some constifications
...
Change-Id: I60a552f14c4c4735f702581be18231e658cb30e7
2014-03-24 23:22:11 +01:00
5131a9d086
Remove temporary OUString by bailing out early
...
Change-Id: I58e63b11c684d686e0e0830bb4e0e3b7fc9bbc32
2014-03-24 23:22:11 +01:00
1e7e296eae
Remove temporary OUStrings
...
Change-Id: I328eb08b719b5fdd51e1ca7c5c6fa3546ac90adb
2014-03-24 23:22:10 +01:00
56de142fff
sal_uInt16 to sal_Int32/int and remove some temporaries
...
Change-Id: I2ab4bb2f57c95d2d4b1029fd6e324ebbe0ff7148
2014-03-24 23:22:10 +01:00
f661ac03e0
svtools: sal_Bool->bool
...
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
2014-03-24 08:12:09 +02:00
1a1fe47731
svtools: sal_Bool->bool
...
Change-Id: I0c2e9314d85860831b29db76c89c8776c1b071b9
2014-03-24 08:12:08 +02:00
94319e31f0
coverity#705953 Dereference before null check
...
Change-Id: Ia9d6af4d601b76dfb9e950fdb4bdaf283f3e985c
2014-03-21 15:52:25 +00:00
16752a8a77
sfx2: sal_Bool->bool
...
Change-Id: Ief810c49b821e2e60ee2c8b14187dd8d7d81c461
2014-03-19 09:21:24 +02:00
06f7d1a96e
fdo#74775: Preseved Citation after round trip.
...
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/8473
Change-Id: Ie1b0ac3cb4d4b9bf305323599d5e4b63f913fb1b
2014-03-14 10:45:33 +01:00
c72ce293de
svx: sal_Bool->bool
...
Change-Id: I5a6a57f708a3a5ce1f065e341ae9da24e0c91499
2014-03-11 08:18:18 +02:00
a652ea0fc4
fdo#70422 Moved the linked files from sw/source/ui to a new core/uibase dir
...
Moved the files linked in sw/Library_sw.mk from sw/source/ui to
sw/source/core/uibase and modified the make files as per the new
directory location.
Reviewed on:
https://gerrit.libreoffice.org/8447
Change-Id: I05f6ccdeee5e76fb0ae477d16721d9ddc6eaff32
2014-03-09 21:53:34 +01:00
68ec95b3f8
made ListBox handle more than 64k elements, fdo#61520 related
...
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.
Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2014-03-05 07:31:19 -06:00
a27462189d
Remove visual noise from sw
...
Conflicts:
sw/inc/unodraw.hxx
sw/inc/unoframe.hxx
sw/sdi/swriter.sdi
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unoparagraph.cxx
sw/source/filter/ww8/rtfexportfilter.cxx
sw/source/ui/inc/unotxvw.hxx
sw/source/ui/lingu/hyp.cxx
sw/source/ui/lingu/sdrhhcwrap.cxx
sw/source/ui/uno/swdetect.hxx
Change-Id: Ic0a3fb2392187c277c9b36915ffb10dcf0317908
Reviewed-on: https://gerrit.libreoffice.org/8322
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 09:41:00 -06:00
