6045c38f86
Avoid crash when no args specified
...
Change-Id: Id3d10566af674f02f3734f981e6b4b45b528ed92
2014-08-29 09:53:03 +03:00
65f70e0d57
Remove these intermediate variables
...
...and pointless subsequent null check.
Change-Id: I50721a17eeec2f9ee0b515507cdda4ed05ddcae5
2014-08-29 00:53:24 +03:00
4d32244437
Avoid possible memory leaks in case of exceptions
...
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
2014-08-26 19:47:14 +09:00
ae71b8305c
reduce nesting at SID_CHINESE_CONVERSION
...
Change-Id: I9ebf5f39b58839b79bdef9a93a2113d7566d05da
2014-08-25 21:34:48 +02:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
d15d7b7bba
Open the right tab for the More... command
...
Partially fixed by Caolán in
3ac80237f310366afef0f7b6c427889d652bd369.
Remaining issues are the paragraph submenu, and the top
menu for both selection and paragraph. Also fixed for
the drawing text and annotations shells (including the
regression created by the above commit, that the dialog
didn't show at all).
Change-Id: I1ba4c825ad48af23ad5c07c8c5f25380952c0be1
2014-08-22 14:33:28 +03:00
08edafa656
Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."
Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
d21d5a7261
drop unnecessary shl.hxx includes
...
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
ff25eed68d
include app.hrc
...
Change-Id: Ib0db01179ed56f39d5e3986e7302b2bf914b06e9
2014-08-18 06:56:24 +02:00
b99e3c5c73
InfoBox MSG_WRONG_TABLENAME and MSG_ERR_TABLE_MERGE to String
...
Change-Id: I36fc0ed4f67c0af467a8dc593950a9c53a5ec53b
2014-08-18 03:23:37 +02:00
3f26ab24e0
fdo#76565 Allow pasting into input fields
...
Change-Id: If996284aeea4b430cceaaf264035aa9e4ec0f2f0
Reviewed-on: https://gerrit.libreoffice.org/10835
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-08-17 16:23:05 -05:00
1120312c83
Hyperlink dialog: Don't close if it's already open
...
Steps to reproduce:
1) Writer. Insert -> Hyperlink. Leave the dialog open.
2) Click into the writer document and type a link "http://google.de/ ", this
will get converted to a hyperlink.
3) Now right-click on the hyperlink and choose "Edit Hyperlink" from the
context menu. The Hyperlink dialog will close.
The Hyperlink dialog should stay open and not close, if you want to
edit the hyperlink.
This commit fixes this.
Change-Id: I125c12733790632008cad1a9fc2d13bf16487381
2014-08-17 13:42:28 +02:00
f53878770a
Missing ; (unsuccessful merge)
...
Change-Id: I3a1ab8936021e0b310afa799b1c257040bf78be3
2014-08-16 22:18:55 +02:00
384cb5ff7b
Consistently use size_t and SAL_MAX_SIZE
...
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.
Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
7e605f124f
sal_uInt16 to size_t, avoid temporaries and hardcoded constants
...
Change-Id: I21bd116ec39ba865a881a5866d4227b094d3a249
2014-08-16 21:52:27 +02:00
97067f73b3
Fix indentation/format
...
Change-Id: Ic1dbc6ba261da23be2a0a6f715cd79e68b168c6c
2014-08-16 21:52:27 +02:00
0976d2764f
Use more proper integer types, avoid temporaries and constify
...
Change-Id: Ia2b591641ab7c954f3b1c7d5f58b42927d974a58
2014-08-16 21:52:27 +02:00
df3b138055
Fix indentation/format
...
Change-Id: I8544a1a84f4812cdfae6a6aa5db7ea5576c956c2
2014-08-16 21:52:26 +02:00
7ecebd6655
sal_uInt16 to sal_uInt16, constify
...
Change-Id: Iabb5662cfe135728ca77244032a93762cd7e1c93
2014-08-16 21:38:50 +02:00
9f5711e755
This array can be static
...
Change-Id: Ide0f5df3430f246d5998637166e4e44e83566774
2014-08-16 21:38:49 +02:00
5dfb3365dd
Group more code in local helper function and simplify it
...
Change-Id: I1d5c07bd9c67243cf22405fb4f6edb9202291091
2014-08-16 21:38:49 +02:00
69e5f335ab
Refactored IDocumentFieldsAccess out of SwDoc.
...
Into the new class DocumentFieldsManager.
Removed SwDoc::_MakeFldList because it is not defined anywhere.
Also moved a few non interface methods that belong to the manager.
Change-Id: Icefd7ca7adcbb05a18d6fae0529fc54150b862fd
2014-08-12 23:26:36 +02:00
3dafed2ede
-Werror,-Wundefined-bool-conversion
...
Change-Id: Iff8db4c82abeeed0789d7012223a846f1058c353
2014-08-12 12:19:43 +02:00
3ac80237f3
Resolves: fdo#81795 open the font tab via More... languages
...
a) FontDialog doesn't take a Language argument, so drop that
b) Give FontDialog a Page argument and set it to "font" when
called from the status bar More... menu entry
Change-Id: Ibaf4d5e51d47794b8b0e3c3e06a6d8e00a7d2896
2014-08-11 16:56:46 +01:00
20f6cf0377
Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'
...
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-26 14:25:33 +02:00
044159d82d
sal_uInt16 to short, constify
...
Change-Id: Id7f6e69aeec4f3ed20611d798214777ca0966a7c
2014-07-26 14:25:33 +02:00
b9f27c0529
sal_uInt16: avoid temporaries, simplify, constify, use USHRT_MAX
...
Change-Id: Ibfa44aa10d08ac1b19b7d34790f76effc9de0c9c
2014-07-26 14:25:32 +02:00
62391d5178
sal_uInt16: constify and avoid temporaries
...
Change-Id: I27a9b1c9aed70b8b16fd74bf76f5ce1941de0221
2014-07-26 14:25:32 +02:00
07c0067144
Simplify code path
...
Change-Id: I7280736e9dc590df7151294d70eb7fd201bfcf4a
2014-07-26 14:25:32 +02:00
64ea6d59fa
Do not repeat tests and make code more readable
...
Change-Id: I2e920debb108794c3873708dd198cb2c9cebece7
2014-07-26 14:25:32 +02:00
9837f23c20
More proper integer types, constify
...
Change-Id: I52733936d2d38c5c22c054cf6e0bc323a74344ae
2014-07-26 14:25:31 +02:00
485d29d071
Remove temporaries and constify
...
Change-Id: I632a8b58ecff17fbc172335cb1186c822edc2827
2014-07-26 14:25:31 +02:00
88a874fcb3
convert SfxItemState constants to a proper enum
...
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants
Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
1e6ff8f7f8
XFillStyle -> css::drawing::FillStyle
...
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-19 00:30:37 +02:00
c88a3d3e8c
Refactored IDocumentChartDataProviderAccess in SwDoc.
...
Into the new class DocumentChartDataProviderManager.
Change-Id: I3be038ba276642546223c0c2fba3bea21980b33d
2014-07-15 15:44:02 +02:00
cdfd24fe2a
fdo#81231 Make this macro work again
...
Change-Id: If655b5ef94657b2771d4e05dd6a2c494aa0e587d
2014-07-14 17:58:19 +03:00
06053398c3
clang scan-build: Dead initialization
...
Change-Id: I74cd9086f949a0a964347d4e96911ceaaf812245
2014-07-03 12:49:38 +01:00
378dc6ef20
Related: #i124638# Corrected relationship between DrawModel and...
...
DocShell in Writer, made SwDrawModel and handling more known
(includes suspicious removal of setting SID_ATTR_LINEEND_WIDTH_DEFAULT)
(cherry picked from commit a7ccadbf3b1ac378ca15d3630d48f48734700e5c)
Conflicts:
sw/inc/IDocumentDrawModelAccess.hxx
sw/inc/doc.hxx
sw/inc/docsh.hxx
sw/inc/dpage.hxx
sw/inc/drawdoc.hxx
sw/source/core/access/accmap.cxx
sw/source/core/doc/doc.cxx
sw/source/core/doc/docdesc.cxx
sw/source/core/doc/docdraw.cxx
sw/source/core/doc/docfly.cxx
sw/source/core/doc/doclay.cxx
sw/source/core/doc/docnew.cxx
sw/source/core/draw/dcontact.cxx
sw/source/core/draw/dpage.cxx
sw/source/core/draw/drawdoc.cxx
sw/source/core/frmedt/feshview.cxx
sw/source/core/layout/fly.cxx
sw/source/core/layout/frmtool.cxx
sw/source/core/layout/newfrm.cxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/undo/docundo.cxx
sw/source/core/undo/unattr.cxx
sw/source/core/unocore/unodraw.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/view/vdraw.cxx
sw/source/core/view/viewimp.cxx
sw/source/core/view/viewsh.cxx
sw/source/filter/html/htmldrawreader.cxx
sw/source/filter/rtf/rtffly.cxx
sw/source/filter/rtf/swparrtf.cxx
sw/source/filter/ww8/docxattributeoutput.cxx
sw/source/filter/ww8/rtfattributeoutput.cxx
sw/source/filter/ww8/wrtw8esh.cxx
sw/source/filter/ww8/wrtww8.cxx
sw/source/filter/ww8/ww8graf.cxx
sw/source/filter/xml/swxml.cxx
sw/source/filter/xml/xmlexp.cxx
sw/source/filter/xml/xmlimp.cxx
sw/source/ui/app/docshdrw.cxx
sw/source/ui/uiview/view.cxx
sw/source/ui/uno/unodefaults.cxx
sw/source/uibase/app/docst.cxx
sw/source/uibase/app/docstyle.cxx
sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
sw/source/uibase/lingu/sdrhhcwrap.cxx
sw/source/uibase/shells/drwbassh.cxx
sw/source/uibase/shells/frmsh.cxx
sw/source/uibase/shells/grfsh.cxx
sw/source/uibase/shells/textsh1.cxx
sw/source/uibase/uno/unotxdoc.cxx
sw/source/uibase/utlui/content.cxx
Conflicts:
sw/source/uibase/app/docshdrw.cxx
Change-Id: Icb99eaa7bfb1eb8922a9fd928b5e4149821130dd
2014-07-01 13:30:10 +02:00
7d9bb549d4
Related: #i124638# Second step of DrawingLayer FillAttributes...
...
for Writer objects, now added support for Paragraph and PageStyle (including
Header and Footer) for direct attributes and style attributes
(cherry picked from commit cc25c58f7052827bfebdc9fbeec668c8fa29ed1b)
Conflicts:
cui/source/factory/dlgfact.cxx
cui/source/factory/dlgfact.hxx
cui/source/inc/bbdlg.hxx
cui/source/inc/cuires.hrc
cui/source/tabpages/bbdlg.cxx
cui/source/tabpages/bbdlg.src
cui/source/tabpages/page.cxx
cui/source/tabpages/tparea.cxx
include/svx/pagectrl.hxx
include/svx/svxdlg.hxx
include/svx/svxids.hrc
include/xmloff/PageMasterStyleMap.hxx
include/xmloff/prstylei.hxx
include/xmloff/txtprmap.hxx
svx/Package_inc.mk
svx/inc/svx/hdft.hxx
svx/source/dialog/hdft.cxx
svx/source/dialog/pagectrl.cxx
svx/source/tbxctrls/tbxcolorupdate.cxx
svx/source/unodraw/unobrushitemhelper.cxx
sw/Library_sw.mk
sw/inc/fillattributes.hxx
sw/inc/format.hxx
sw/inc/frmatr.hxx
sw/inc/frmfmt.hxx
sw/inc/hintids.hxx
sw/inc/hints.hxx
sw/inc/ndtxt.hxx
sw/inc/node.hxx
sw/inc/swunohelper.hxx
sw/inc/unobrushitemhelper.hxx
sw/inc/unoprnms.hxx
sw/source/core/attr/format.cxx
sw/source/core/attr/hints.cxx
sw/source/core/doc/docdesc.cxx
sw/source/core/doc/docdraw.cxx
sw/source/core/doc/docfmt.cxx
sw/source/core/doc/docnew.cxx
sw/source/core/doc/docredln.cxx
sw/source/core/doc/poolfmt.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/docnode/node.cxx
sw/source/core/inc/frame.hxx
sw/source/core/inc/frmtool.hxx
sw/source/core/inc/rolbck.hxx
sw/source/core/layout/atrfrm.cxx
sw/source/core/layout/fillattributes.cxx
sw/source/core/layout/findfrm.cxx
sw/source/core/layout/paintfrm.cxx
sw/source/core/txtnode/ndtxt.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtedt.cxx
sw/source/core/undo/rolbck.cxx
sw/source/core/unocore/swunohelper.cxx
sw/source/core/unocore/unoframe.cxx
sw/source/core/unocore/unomap.cxx
sw/source/core/unocore/unoparagraph.cxx
sw/source/core/unocore/unoprnms.cxx
sw/source/core/unocore/unostyle.cxx
sw/source/ui/chrdlg/paradlg.src
sw/source/ui/chrdlg/pardlg.cxx
sw/source/ui/fmtui/tmpdlg.cxx
sw/source/ui/fmtui/tmpdlg.src
sw/source/uibase/app/docst.cxx
sw/source/uibase/app/docstyle.cxx
sw/source/uibase/frmdlg/colex.cxx
sw/source/uibase/shells/basesh.cxx
sw/source/uibase/shells/textsh1.cxx
sw/source/uibase/uiview/viewstat.cxx
sw/source/uibase/utlui/uitool.cxx
xmloff/inc/PageMasterImportContext.hxx
xmloff/inc/xmloff/XMLShapeStyleContext.hxx
xmloff/source/draw/XMLShapeStyleContext.cxx
xmloff/source/draw/sdpropls.hxx
xmloff/source/style/PageMasterExportPropMapper.cxx
xmloff/source/style/PageMasterImportContext.cxx
xmloff/source/style/PageMasterPropHdlFactory.cxx
xmloff/source/style/PageMasterStyleMap.cxx
xmloff/source/style/prstylei.cxx
xmloff/source/text/txtexppr.cxx
xmloff/source/text/txtprhdl.cxx
xmloff/source/text/txtprmap.cxx
xmloff/source/text/txtstyli.cxx
Conflicts:
svx/source/dialog/hdft.cxx
sw/source/core/doc/visiturl.cxx
sw/source/core/txtnode/thints.cxx
sw/source/core/txtnode/txtatr2.cxx
sw/source/core/unocore/unostyle.cxx
Change-Id: I7e8779db6c0cbd1e242b63eab888f468f2de509a
2014-07-01 13:30:09 +02:00
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
540eba7556
sal_uInt16 to SwTwips and delay downcasts
...
Change-Id: I4a8a05905a779bb8c7fad830c049d1e403d79711
2014-06-28 11:17:57 +02:00
d92aa2f445
remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
...
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
a8b32cc97a
OSL_ENSURE->assert
...
Change-Id: Ib8ba49e89d03eaf3b3aae94dbbf121898ba9e8de
2014-06-26 16:29:14 +01:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
d8d18c3cc7
sw: Fix SID_CHAR_DLG_EFFECT behavior
...
A regression from commit f41e7c70. The wrong tab is
opened (used in the sidebar underline popup). The
correct id is "fonteffects" not "fonteffect".
Change-Id: Ic06fb3f93a033bcfe24b97eb124ceea082b4087f
2014-06-22 13:09:02 +03:00
692ea03e1d
sw: add UI for removing the textbox of a draw shape
...
Change-Id: Ib95573228d3dc98c88cd4af19995c99433c84ae6
2014-06-19 11:29:31 +02:00
7f77b8a689
sw: add UI for adding a textbox for a draw shape
...
Change-Id: Icc4ff083431635f1769dba5907f26e7dc6b08d02
2014-06-19 11:29:31 +02:00
67820a9037
coverity#705037 Unchecked dynamic_cast
...
Change-Id: I9f6c8ceafd09b4a5d4e951e01e1a06b2b5265181
2014-06-19 10:26:50 +01:00
57b5632733
Avoid possible memory leaks in case of exceptions
...
Change-Id: I32d1e15cb9f050e3cd05babbd2f21c57f3ccb5e7
2014-06-14 17:20:56 +09:00
887b3a3562
loplugin:staticcall
...
Change-Id: I26e1e0f66dad5ed4e8351fc7509449b312559166
2014-06-13 17:54:35 +02:00
