Commit Graph

2829 Commits

Author SHA1 Message Date
91853c8264 toolkit: fix javadoc errors
Change-Id: I6d2268786d22f967be2d5e0dbcda14a074af4475
Reviewed-on: https://gerrit.libreoffice.org/11248
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:08:40 -05:00
57a4337e25 set names on a bunch more threads...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
34352e7f1b fix exception not caught
Change-Id: Idf1942d76f3c13e207f2e54494557ee01013c833
2014-08-20 11:45:28 +02:00
ccbb51ad96 use correct loop index variable
Change-Id: I92531f8fc96c0cb0ca944a7dd50c4fe4ea740b37
2014-08-20 10:35:52 +02:00
619dc5d4c8 remove some dead Java code
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20 10:35:52 +02:00
252ed1708a double-checked locking is not thread-safe in Java
found by PMD

Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
2014-08-20 10:35:51 +02:00
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
cc4f4e2054 catch UnknownPropertyException
Change-Id: I3134c574a124a2359c40b139eb5b41198b0e4611
2014-08-17 19:20:55 +01:00
0d916bb240 java: remove unused imports
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
34bcf9b498 java: remove dead methods
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
68cd011c90 java: reduce scope, make some methods private
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f java: reduce scope, make member classes private
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4 java: reduce scope, make constructors private
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
5656fe58a0 java: fix broken javadoc tags
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
1c496506bc java: remove useless javadoc tags
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
e2e55a7c49 java: remove unused parameters
Change-Id: I25b1976295b736fe3929c481bf9d2d81b523271d
2014-08-12 09:41:27 +02:00
76c1092016 java: remove unused parameters
Change-Id: I9ae22afc27ac0d2051f06885f363845e9b4ce2ff
2014-08-11 12:33:03 +02:00
d5a31b2215 java: remove unused parameters
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
8f020a45fa java: redundant assignment, variable can only be null
Change-Id: I91209c5c185cf097a1609244419d73d4757d7d18
2014-08-08 09:48:19 +02:00
b58c053fed java: remove unnecessary semi-colons
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08 09:48:18 +02:00
2d700944b5 java: remove unused imports
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
2014-08-08 09:48:17 +02:00
27459c71ef java: remove unused fields
Change-Id: I25fef9590a34ec8d9aab182b3d267ae3cd649a87
2014-08-08 09:48:16 +02:00
8d6cf7a147 java: remove dead methods
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
1579d8ed79 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I536353b86ee023eb630ea89786d2205a628d95e3
2014-08-07 18:42:35 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05 java: remove unused fields
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
f124688cfd java: remove various unused variables
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-08-05 11:31:49 +02:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
bce99945d8 coverity#736076 Missing break in switch, its got to be wrong
Change-Id: I21a3b2b794a431d07df8a1bc250e8f0aacaf3059
2014-07-11 16:40:30 +01:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
ea91310384 use SimpleReferenceObject in accessibility
to replace hand-rolled version

Change-Id: I9dd8d02024702972722b43f2654db91eb3da3794
2014-07-08 08:56:18 +02:00
4228f08d60 use assert when followed by deref
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
7dda48d56f Related: fdo#80633 cache optimal size
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01 16:43:05 +01:00
95dca00a91 coverity#707416 Uncaught exception
Change-Id: I7c67c62622e2b46bc565ae148c1605f4954ffa39
2014-07-01 10:56:15 +01:00
4523dd0544 Called C++ object pointer is null
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30 09:46:16 +01:00
9a741fcad4 loplugin:unreffun: also warn about unused function templates
Change-Id: I4a6280f47ca3c4a77b4e42fe05d79ded7fc30ef1
2014-06-27 07:51:51 +02:00
0de1e3a015 remove spurious com::sun::chaos
Apparently some time before inital CVS import a global
search-and-replace went horribly wrong and added spurious namespace
prefixes everywhere.

Change-Id: I4009bc3ab4b1d4c80412f75ad0e4628a382f99f0
2014-06-25 15:04:46 +02:00
22357c172f coverity#705322 Missing break in switch, assuming incorrect
especially because the setProperty logic now matches the getPropery one

Change-Id: I7ebeabc9defed00d1853c3b91fbbf592e1940aa8
2014-06-24 14:28:27 +01:00
47088ac9a0 Missing SolarMutexGuards
...as can be seen e.g. with CppunitTest_dbaccess_dialog_save:

vcl::DisplayConnection::start
Application::GetDisplayConnection
Window::GetDragSource
Window::GetDropTarget
(anonymous namespace)::VCLXToolkit::getDropTarget
(anonymous namespace)::Frame::implts_startWindowListening
(anonymous namespace)::Frame::initialize
(anonymous namespace)::TaskCreatorService::implts_createFrame
(anonymous namespace)::TaskCreatorService::createInstanceWithArguments
framework::TaskCreator::createTask
framework::Desktop::findFrame
framework::LoadEnv::impl_loadContent
framework::LoadEnv::startLoading
framework::LoadEnv::loadComponentFromURL
framework::Desktop::loadComponentFromURL
unotest::MacrosTest::loadFromDesktop
DialogSaveTest::test
...

Change-Id: I9523ea47cab23d1f23f73a37d2d44453aa7d56a3
2014-06-18 15:51:27 +02:00