Commit Graph

1759 Commits

Author SHA1 Message Date
a718b02f8e vcl: sal_Bool->bool and cleanup
- remove unused PFilterDlgCall typedef
- remove bool parameter from PFilterCall typedef - it was always being

  called with false, and nothing was reading it

Change-Id: Ic56127e7d55254a7b9b65849a21cb286f52344d1
2014-04-03 09:17:55 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
4f9b072072 Remove remaining DBG_CTOR etc. remnants from toolkit
Change-Id: Ia6219ebd5fb2d2644135ec20a986158b68b771fc
2014-03-28 16:12:33 +01:00
10787356d9 coverity#736157 Dereference null return value
Change-Id: Ibc6e17e4d916ae9e1664e8c9149a978072dae0ac
2014-03-28 13:13:59 +00:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
a79afdaa11 coverity#736158 Dereference null return value
Change-Id: Ia3afc3989d1c9a5d9c70b167186fd81a263550fb
2014-03-25 12:33:20 +00:00
98666e8625 No need for a virtual OPropertyContainer::getTypes
(and rename to getBaseTypes for clarity)

Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
6e469f76bb Remove unused VCLXWindowImpl parts
Change-Id: I6b26243e9669c791fdf1bd68193675ca780d41ee
2014-03-13 12:50:13 +01:00
d47ca30f1c No need for implGetBounds to be SAL_CALL
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11 15:35:52 +01:00
2b0cfed33f toolkit: simplify deprecated XTypeProvider.getImplementationId
Change-Id: Ibe481aebad026f8c182052f1327bed8a1054cf7a
2014-03-10 17:39:59 +01:00
ecc6239f5b coverity#708535 Uninitialized scalar field
Change-Id: Ife2acd5dd5193edd0ca34d85370885ee6865fadd
2014-03-10 14:43:27 +00:00
1f81c41573 coverity#708534 Uninitialized pointer field
Change-Id: Id2e70f46b4ae249403ca68f3a45c86b13fa1ca16
2014-03-10 14:43:27 +00:00
496c538436 coverity#708531 Uninitialized pointer field
Change-Id: I4519cf5b3ecf53c678621a4b8f6267dd4a41fcad
2014-03-10 14:43:26 +00:00
a463234e88 Remove unused VCLXTabPageModel
Unused since 265043a935781633f204b1ddfede5f454b8555fe "tabcontrol: #i113362#
impl tabcontrol in awt" and not even built since
0a966b904bd6fd570d2fb09825810aceed4e00e8 "tabcontrol: fix some compile errors."

Change-Id: Ida6fde85207288a0b4e09cee767bd004f9384d99
2014-02-27 10:24:53 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e90c27f5e1 Remove visual noise from toolkit
Change-Id: I1704d6ac497f2e47a813813640ead14c5fa480d9
Reviewed-on: https://gerrit.libreoffice.org/8326
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:51:48 -06:00
d5c59404be Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I773524536c0ed7bc34eb08cd35cfc77e83f722ba
2014-02-26 17:21:20 +09:00
c47496fdf9 Add config_libraries.h definitions to get library names easily.
Works for libmerged too, so we can get rid of LIBO_MERGELIBS.
And remove few more #defines in vcl.

It's generated by gbuild, so probably abusing config_host directory.
Open to improvements.

Change-Id: I87ab109bf109e42751766011daf076e9cdf8f5ee
2014-02-25 09:05:09 +01:00
130a2baa83 error: enumeral and non-enumeral type in conditional expression
Change-Id: I30293ac22fb26e0f7c9bfd335ccaa9a2d263d02f
2014-02-24 12:28:18 +01:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
146c7c5c89 toolkit: sal_Bool -> bool
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24 11:13:42 +01:00
b7259532d8 Remove unnecessary bool2any
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
7a7ecf164a coverity#705963 Dereference before null check
Change-Id: I6371ef5e838d1e66ea9aeba75f554eea93426139
2014-02-21 15:30:25 +00:00
b6662967ab coverity#708532 Uninitialized scalar field
Change-Id: I9de7a5b3f42f1810639663c25965b196a8959f3e
2014-02-21 12:40:37 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
02c17c1dd3 coverity#738917 Uninitialized scalar field
Change-Id: I6d1b6e201f3ec57c727e93ff69a212c8138998d6
2014-02-18 15:18:10 +00:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
2d72cfb502 coverity#737151 Uncaught exception
Change-Id: I133012cf88020e38eb0fc0932979347b996943fe
2014-02-13 14:56:20 +00:00
cf2a6c290d coverity#707416 Uncaught exception
Change-Id: Ib2f8dee2214bc3f53edae5c7c20c4924f1fec568
2014-02-13 14:56:17 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
d2564a4a10 Remove needless SAL_DLLPRIVATE annotation
Change-Id: Id322e7ca57205083a5585081df86bfac933b7bb6
2014-02-03 16:05:12 +01:00
612dac063a bool improvements
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
5b70503620 bool improvements
Change-Id: I27174aeadb37e56c701c46fe7f97853b98ba7333
2014-01-28 20:26:17 +01:00
478ec0126b This has always only converted the condition of ?: to long
...not the resulting value, and seems unnecessary anyway.

Change-Id: I8c58b180af2bd36f2c3dbcad888c3dd0b9e4c87d
2014-01-28 18:31:05 +01:00
7b52b96a6f coverity#440874 Dereference before null check
Change-Id: I542da40fe1209198ea784cf52372cd6d83292f33
2014-01-28 11:29:20 +00:00
03cc76aad3 fdo#54938 Convert toolkit to cppu::supportsService
Change-Id: I3a35a86d9ad9419011f0305fdc41c8484ae63a04
Reviewed-on: https://gerrit.libreoffice.org/7646
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-01-25 16:14:15 +00:00
e24605a72f Include boost/ptr_container/ptr_vector.hpp at the beginning again.
This might fix
"workdir/UnpackedTarball/boost/boost/ptr_container/detail/static_move_ptr.hpp:154:46:
error: macro "check" passed 2 arguments, but takes just 1" ?

Change-Id: Ie8504149f7d2853a631b47186f5ca46cdf96b79e
2014-01-24 16:41:22 +01:00
b667caafd7 Remove unneeded include to hopefully fix the tinderboxes.
Change-Id: I991bb1049556d3d19726ecd36b8e1aad7207814c
2014-01-24 12:33:36 +01:00
e515b8b121 tk: Constructor feature for last tk_ implementations.
Change-Id: I55fee30e64cdb591d73cfcadfd7a9efb10485ba9
2014-01-24 12:21:25 +01:00
b7e51c2077 tk: Ctor feature for the rest of dialogcontrol.cxx classes.
Change-Id: Ic96abfe99112b78244e4318aed5b36b5af1dd679
2014-01-24 12:21:24 +01:00
c1fa1962ec tk: Ctor feature for VCLX classes.
Change-Id: I717638a3df4d6ed71d19f7bf4c2e574b37260739
2014-01-24 12:21:23 +01:00
cbdc2cfc1a tk: Ctor feature for UnoControlContainer(Model).
Change-Id: I7f0e457eaf5057d325226633936e544ace1f1620
2014-01-24 12:21:23 +01:00
60ec73ddea tk: Ctor feature for UnoScrollBarControl(Model).
Change-Id: Ie37b81de21764186ab2ee9b19ac04d801880d2f9
2014-01-24 12:21:22 +01:00
68694f360f tk: Ctor feature for StdTabController(Model).
Change-Id: I3792b8b4d240c212d332c676d53eaa1f5dca3902
2014-01-24 12:21:22 +01:00
472b283666 tk: Ctor feature for toolkit::(UnoControlRoadmapModel|UnoRoadmapControl).
Change-Id: Ic748e90e96285c394a3a2ac30ad1090b91ede160
2014-01-24 12:21:22 +01:00
e626b730df tk: Constructor feature for MutableTreeDataModel.
Change-Id: I9cd12e3bdfc20d4305e3daec6d0a6cffa599e000
2014-01-24 12:21:21 +01:00