Commit Graph

2787 Commits

Author SHA1 Message Date
ca68971f0a ModalDialogs no longer loaded from resource files
Change-Id: I2d208c7cc5ff9bf26bff5ab2aa40e0bf57373342
2014-08-26 17:00:21 +01:00
10d14a94d1 tools: make some variable names more clear
Change-Id: I5eb2428f4c71e5aa9bfc0bf71c06d87be039ad3b
2014-08-24 16:15:51 +10:00
3f89eccf7e Do not cripple intermediate values to sal_uInt16
Change-Id: I5d39bebbd55cc3170ff52459731fad333a2e92f9
2014-08-22 17:30:03 +02:00
afa5d63e2a TabPages are no longer loaded from resource files
Change-Id: I009e0f388cfe1861cef89d2148a02380dd47c1ff
2014-08-20 16:35:09 +01:00
b3d9852309 Remove more useless includes of tools/debug.hxx
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 09:10:01 -05:00
1c13f9c2b6 RSC_TRISTATEBOX is no longer used
Change-Id: Ib3f43db131cf5562ad011538873c2ee51839665c
2014-08-16 18:36:24 +01:00
b0da096c61 RSC_MULTILINEEDIT no longer used
Change-Id: If56233b5226cec9516d5e2f8992e1b0beae733bf
2014-08-16 18:33:04 +01:00
924dda90a9 RSC_MENUBUTTON is not in use anymore
Change-Id: I853b6b1cfcd4847603d9920a47298d1b9105b46f
2014-08-16 18:31:04 +01:00
92240691d1 fdo#82644 write sal_Unicode chars as Unicode
Regression from commit de84529b55f5b295b089043a7119d6b0d8b92408.

Change-Id: I8f0b148ec7df4f676341f588c04780a705c80a5c
2014-08-15 20:29:02 +02:00
748ed65ffb drop TabControl resource loader
Change-Id: Idb909c205dfadaadeb8b98ce08fe2f4286cfce26
2014-08-15 17:02:59 +01:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
933bcfd2fe various ids not loaded from .res anymore
Change-Id: Id2fab3e4b7a8feed3107e66d02cdf2a278ae9ef7
2014-08-11 10:22:12 +01:00
666f8651b1 simplify "no delete" logic in SvRefBase
by converting the bit munging to use bitfields.
Remove unused return values.
Add asserts to check that AddRef() is not called after the object
is deleted.
Fix the code in SfxObjectShell to not call AddRef() after
SfxObjectShell is deleted.

Change-Id: I3a3565a0bc45fc9d1d086222265ab8b8175818a7
2014-07-29 17:56:51 +02:00
faca271fdf Include <algorithm> for std::min
Change-Id: Id1321766532eab6ee49e418b0597e62d14b5b33c
2014-07-29 18:21:01 +03:00
34cabe837d loplugin:unreffun
Change-Id: Idc0f3ef53f48b2e77e4cecbcdbbc44a115c6ec2e
2014-07-14 13:27:30 +02:00
a2b44216f1 fdo#66507 - accelerate common datum date conversion to days.
Saves ~40bn cycles, 10% of calculation for the bug document.

Change-Id: I9d48706ad2cfe290965b648306d95b4d66e5fc63
2014-07-08 14:33:42 +01:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
d6817ba7a7 Mac OS X does provide localtime_r
Change-Id: I0a8860f2b0ea053cdfe9504dc266be36cdb0043e
2014-06-26 17:40:44 +02:00
cd29cab883 check for self-assign
Change-Id: I6ffaaa36f2e594a2e8155589a4d7000db21ab30b
2014-06-26 16:29:13 +01:00
f97009d79f clang: Assigned value is garbage or undefined
Change-Id: Ida7a6ab077e1f0436f8b775956d30c82c4ad5338
2014-06-26 16:29:12 +01:00
9ede5cd987 Remove unused INetURLObject::PART_* values
Change-Id: Icebdf0cad5306ae42a30de0b4f997e3b611675eb
2014-06-23 11:52:14 +02:00
8d373129e9 callcatcher: update unused code
and strip away some stuff in rsc that should now be dead

Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
2014-06-15 20:30:39 +01:00
0e7ca4fad0 cut out the rsc loading support for stuff thats now .ui only
Change-Id: I54880de44ee10d4f71c8a514f905e8e00774fde7
2014-06-11 10:47:30 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
805b57cd5b Various INetURLObject::getData() fixes
Change-Id: I5eafd6250bbde7227dcc0447a4280b7741c320de
2014-06-06 11:13:07 +02:00
8b46d5c849 new method INetURLObject::getData() for data urls
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>

Conflicts:
	tools/source/fsys/urlobj.cxx

Change-Id: I59b5b95cf9b65920ec04922fdb25e4228fd22995
2014-06-06 11:13:07 +02:00
e6ff6f9a71 use namespace css instead of com::sun
Change-Id: I47582b072bb939cf270a76e430a9f7908b5c1d93
2014-05-27 14:00:28 +02:00
9dd8a62147 cppcheck: add missing braket
Change-Id: I1e542455ad3e4ab1a445366517c92b102471840a
2014-05-22 12:50:48 +02:00
6e3394a6ab update_pch: add tools
Change-Id: Icb95d60a7f786ee75ea1904cfb7292e51eb607cc
2014-05-22 12:50:45 +02:00
d3041640a0 tools: just generate the complete reversemap.cxx
This makes tools pch ready.

Change-Id: I8d5d5fcbb417f3790749aeb9d9c947f739ecb30f
2014-05-22 12:50:45 +02:00
8449225508 fix-includes.pl: tools
Change-Id: I66b3dc79998de018eae1c7eff8ce23f95e3c3f33
2014-05-22 12:50:45 +02:00
8f97326bdd So ZCodec::ReadAsynchron was wrong in using a persistent mpIStm after all
The fun thing is that with the (only) call-site to ReadAsynchron in
PNGReaderImpl::ImplReadIDAT (vcl/source/gdi/pngread.cxx) passing in rIStm
references to stack-allocated SvMemoryStream instances, mpIStm could point to an
old, destroyed instance from a previous call, but which would have been located
at exactly the same stack address as the currently passed in rIStm, so the wrong
mpIStm->Read call would effectively behaved exactly the same as a correct
rIStm.Read call.

This went unnoticed "since the beginning" until AddressSanitizer's
UseAfterReturn check came along...

Change-Id: I7c75ed2d36a4c24c111d88eff647816bd2c5dbca
2014-05-21 18:29:57 +02:00
c5a603ce24 ZCodec::mpIStm is apparently(?) effectively only used by ReadAsynchron
...(which can be called multiple times in a row).  But which actually looks
wrong...

Change-Id: I2e4914e6fed8ced383e430699dd462add9da8c08
2014-05-21 18:29:57 +02:00
66351a678e Split ZCodec::ImplInitBuf into InitCompress, InitDecompress
Change-Id: I2714b1f1dadc74f8501203bc8b0722c56c9c5fb9
2014-05-21 17:35:56 +02:00
4f1cf09c8a Add assertion
Change-Id: Ibe2f5f4ad52510247fb4134f433bba4b737d9c33
2014-05-21 17:35:56 +02:00
1c92fbf4fd Replace ZCodec::mbInit with sane enum
...and document how the member functions are supposed to be called from client
code.

Change-Id: Ia4847945e4a361c43a0ed001e3e78e901c9abcad
2014-05-21 17:03:41 +02:00
4d2113250f ZCodec::UpdateCRC is private
Change-Id: I2103f8a323d0454bdd1c779aadb99889ae1cf6e5
2014-05-21 15:30:18 +02:00
200d530f47 Split ZCodec::BeginCompression param into its 3 independent components
Change-Id: I275abafe81c8bb617c70646244b14f6cecc33854
2014-05-21 15:30:16 +02:00
201d429ad0 Remove unnecessary ZCODEC_DEFAULT_STRATEGY macro
...and directly use zlib.h's Z_DEFAULT_STRATEGY

Change-Id: Ibf528cbc32afec4d442656aa2963f50c0875d6a5
2014-05-21 15:30:15 +02:00
5271e5b01b nMemUsage is always MAX_MEM_USAGE
...so just use zlib.h's MAX_MEM_LEVEL directly.

Change-Id: I76d73f665df242bfb180b76aa7054cf8ddbe9e67
2014-05-21 15:30:14 +02:00
fe1e1d1292 A single ZCodec ctor suffices
Change-Id: Ib831b80afcdde98928a2759616810923348f65e8
2014-05-21 15:30:13 +02:00
faac2327e9 Clean-up C-style (void) parameter lists
Change-Id: I41da8920e33dfdd0f1483ea2d7cf67111224b441
2014-05-21 15:30:13 +02:00
8d54796bf1 enhance pass-by-ref plugin to detect large arguments
Detect arguments larger than 64 chars passed by value.

Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-20 11:17:22 +02:00
599328b0a9 tools: add AsRGBHexString to Color + unit test
AsRGBHexString returns the Color as a RGB hex string. For example
"00ff00" for green color.

Change-Id: Ia95c7f9eb6d9aefc3ca989046fa8d76b7b7f9e8f
2014-05-15 19:51:06 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
fec6711974 coverity#708544 Uninitialized scalar field
Change-Id: If5813e0321ff68ddf2cdbce3cdd216fda2830849
2014-05-10 21:12:57 +01:00
b34267cea1 coverity#708545 Uninitialized scalar field
Change-Id: I97efb9c1f3bb6554dfded43129a13f93d1cdd4be
2014-05-10 21:12:57 +01:00
0b2c8a8b2b added ResStringArray::AddItem()
Change-Id: I361cd4256c0816a46ea6e37dd9fd2680d3dba9fb
2014-05-10 00:39:43 +02:00
2c9d68ff56 move INetContentTypes::scan() to INetMIME::scanContentType()
to avoid circular dependencies between svl and tools when using
INetContentType::scan functionality for future handling of data urls in
urlobj.cxx

Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-09 16:01:30 +02:00