Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.
Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
"warning: suggest a space before ';' or explicit braces around empty body"
Change-Id: I71a55cc888d3480217621491ecace7d0af3dca6e
Reviewed-on: https://gerrit.libreoffice.org/9441
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
...so that utl::TempFile can pass osl_File_OpenFlag_Private and doesn't have to
resort to umask (the calls to umask around Directory::create had somewhat
erroneously been removed recently with 1d72a0262c4570631d0aa8f98e34e21fb9d6ae42
"Related fdo#60338: Create missing temp file dir with user's original umask,"
mistaking this for creation of intermediate directories in the hierarchy).
On Windows, the flags argument to osl_createDirectoryWithFlags is ignored
completely for now.
Change-Id: Iac56a5049d579be729a3f338aa62105123edb6cb
Detect arguments larger than 64 chars passed by value.
Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
This is a follow-up to fcf455d4efde077bb2b092b607de12ebfc350275 "Consolidate
CreateTempName_Impl and lcl_createName," which apparently lead to hard-to-
diagnose sporadic "make check" failures on some machines. Hope is that bLock
now more carefully tracking the behavior of the original two functions fixes
that.
Change-Id: I37ba00545f5921fd603ff9f1ea46927c42e88899
...introduced with 2d8c990f8790be43cf4dda4bc871a917b9dcc974 "INTEGRATION:
CWS reportdesign01: #i79214# new method to allow to start not with zero."
Change-Id: Id141b2913ceb47c0c54f4449bdcdf5130c6f355b
For one, that is consistent with how ensuredir (in the same .cxx) has always
worked, and for another saves us from trouble with umask, cf.
034d4c111976f337877e5954c6cc95ed9f90a343 "Related fdo#60338: Setting umask for
osl::Directory::open is useless."
Change-Id: Ic3fb5bb29ca3031d257067a514cb9f5bccfbfe4f
Maybe 39c58e416252571a04b8ebbb56c9fa012b117993 "INTEGRATION: CWS
olefix: #i46469# use correct umask on unix" had intended to put it around the
osl::Directory::create call instead, but given the trouble of calling umask(3)
in a MT program at all, it is probably better to keep creating any missing
directories with the user's original umask anyway.
Change-Id: Idfddfdab05373a3c395daba635fddcc054f3f215
Makes some SmartArt render better, some a bit worse, and some much
worse. Life is hard.
This reverts commit f66d64ab2e85f574a4b9f644ef709ff981483836.
Change-Id: I18b31deea8c14b401134551e74ba7ba208af3ad9
