Commit Graph

168 Commits

Author SHA1 Message Date
f5d33e5e70 Resolves: coverity#706171 Untrusted value as argument
limit nBytesToRead to remaining size of file

also zero last byte of alloced block, seeing as the
block is size+1 and we only read size into it

Change-Id: I2729ec7bb9de20731531f32da864c572fa83ce58
2014-07-21 09:13:43 +01:00
b51883f021 migt->might
Change-Id: I44f47ffd52b69208766242b8fc4faa2a4d32155f
2014-07-19 21:26:04 +01:00
e38307c4c0 coverity#708898 Unused pointer value
Change-Id: I2097507b223d45c880c25d51c47f1d347055db40
2014-07-10 13:39:16 +01:00
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
e77a2cb2f8 coverity#1222236 Resource leak
Change-Id: Iadd6621cebe9426c7c54c81f584b9c6766157f56
2014-06-10 10:48:40 +01:00
4d33acbfbd coverity#708896 Unused pointer value
Change-Id: I8cb1d720a8fb22ba2153c5f556e4bd538f5ea8af
2014-06-06 14:11:12 +01:00
4c4901893f coverity#708898 Unused pointer value
Change-Id: Ida87450bda99260d9e153bb9e48d8867f53d42ca
2014-06-06 14:11:12 +01:00
6407a1bd80 coverity#708901 Unused pointer value
Change-Id: Idb9be9f594b9ab3d1837c003d4a748f9693f5ceb
2014-06-06 14:11:11 +01:00
6c3245fc69 fdo#68849: Add header guards to all include files
Added header guards to files in directory vcl/

Change-Id: I76ad0c34f2b107d56e92c5a6a8f4c61554c93e2f
Reviewed-on: https://gerrit.libreoffice.org/9597
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:15:36 +00:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
820a29950b Many spelling fixes: directories r* - z*.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.

(cherry picked from commit 28206a7cb43aff5adb10f8235ad1680c3941ee3e)

Conflicts:
	include/osl/file.hxx
	include/osl/pipe_decl.hxx
	include/osl/socket.h
	include/osl/socket_decl.hxx
	include/sal/main.h
	include/svx/dbaexchange.hxx
	include/svx/dlgctrl.hxx
	include/svx/msdffdef.hxx
	include/svx/sdr/contact/objectcontactofpageview.hxx
	include/svx/svdpntv.hxx
	include/ucbhelper/content.hxx
	include/ucbhelper/interceptedinteraction.hxx
	include/ucbhelper/resultsethelper.hxx
	include/unotools/sharedunocomponent.hxx
	include/unotools/viewoptions.hxx
	include/vcl/pdfwriter.hxx
	include/xmloff/txtparae.hxx
	include/xmloff/uniref.hxx
	rhino/rhino1_7R3.patch
	rsc/inc/rscrsc.hxx
	sal/inc/osl/conditn.h
	sal/inc/osl/security.h
	sal/inc/osl/semaphor.h
	sal/inc/osl/semaphor.hxx
	sal/inc/rtl/string.hxx
	sal/inc/rtl/tres.h
	sal/inc/systools/win32/StrConvert.h
	sal/osl/os2/file_path_helper.h
	sal/osl/os2/file_path_helper.hxx
	sal/osl/os2/file_url.cxx
	sal/osl/os2/file_url.h
	sal/osl/os2/makefile.mk
	sal/osl/os2/pipe.cxx
	sal/osl/os2/process.c
	sal/osl/os2/profile.c
	sal/osl/os2/socket.c
	sal/osl/os2/system.h
	sal/osl/unx/asm/interlck_sparc.s
	sal/osl/unx/file_url.cxx
	sal/osl/unx/signal.c
	sal/osl/unx/system.h
	sal/osl/w32/MAKEFILE.MK
	sal/osl/w32/interlck.c
	sal/osl/w32/module.cxx
	sal/osl/w32/security.c
	sal/qa/buildall.pl
	sal/qa/osl/file/osl_File.cxx
	sal/qa/osl/module/osl_Module_Const.h
	sal/qa/osl/mutex/osl_Mutex.cxx
	sal/qa/osl/pipe/osl_Pipe.cxx
	sal/qa/osl/process/osl_Thread.cxx
	sal/qa/osl/socket/osl_StreamSocket.cxx
	sal/qa/osl/socket/sockethelper.cxx
	sal/qa/rtl_strings/rtl_OUString.cxx
	sal/rtl/source/unload.cxx
	sal/systools/win32/kill/kill.cxx
	sal/systools/win32/uwinapi/MoveFileExA.cpp
	sal/test/bootstrap.pl
	sal/typesconfig/typesconfig.c
	sal/workben/tgetpwnam.cxx
	sax/inc/sax/parser/saxparser.hxx
	sc/addin/datefunc/dfa.cl
	sc/addin/datefunc/dfa.src
	sc/addin/rot13/rot13.cl
	sc/addin/rot13/rot13.src
	sc/inc/attarray.hxx
	sc/inc/chgtrack.hxx
	sc/inc/column.hxx
	sc/inc/compressedarray.hxx
	sc/inc/document.hxx
	sc/inc/table.hxx
	sc/source/core/data/column.cxx
	sc/source/core/data/dptablecache.cxx
	sc/source/core/data/dptabres.cxx
	sc/source/core/data/dptabsrc.cxx
	sc/source/core/data/global.cxx
	sc/source/core/tool/chgtrack.cxx
	sc/source/core/tool/compiler.cxx
	sc/source/filter/excel/xestyle.cxx
	sc/source/filter/excel/xichart.cxx
	sc/source/filter/inc/fapihelper.hxx
	sc/source/filter/inc/xistyle.hxx
	sc/source/filter/xml/xmlsubti.cxx
	sc/source/ui/Accessibility/AccessibleCell.cxx
	sc/source/ui/Accessibility/AccessibleContextBase.cxx
	sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx
	sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
	sc/source/ui/Accessibility/AccessibleEditObject.cxx
	sc/source/ui/Accessibility/AccessiblePreviewCell.cxx
	sc/source/ui/app/inputwin.cxx
	sc/source/ui/docshell/docfunc.cxx
	sc/source/ui/drawfunc/fupoor.cxx
	sc/source/ui/miscdlgs/linkarea.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	sc/source/ui/unoobj/nameuno.cxx
	sc/source/ui/vba/vbacharacters.hxx
	sc/source/ui/vba/vbarange.cxx
	sc/source/ui/vba/vbawindow.cxx
	scaddins/source/analysis/analysishelper.cxx
	scaddins/source/analysis/analysishelper.hxx
	scaddins/source/datefunc/datefunc.cxx
	scripting/examples/python/Capitalise.py
	scripting/source/pyprov/officehelper.py
	sd/source/filter/eppt/eppt.cxx
	sd/source/filter/eppt/epptso.cxx
	sd/source/ui/dlg/prltempl.cxx
	sd/source/ui/dlg/tpoption.cxx
	sd/source/ui/func/fuediglu.cxx
	sd/source/ui/func/fupoor.cxx
	sd/source/ui/func/fusel.cxx
	sd/source/ui/func/smarttag.cxx
	sd/source/ui/inc/OutlinerIteratorImpl.hxx
	sd/source/ui/inc/SlideViewShell.hxx
	sd/source/ui/inc/fuediglu.hxx
	sd/source/ui/inc/fusel.hxx
	sd/source/ui/slideshow/slideshowimpl.cxx
	sd/source/ui/slidesorter/cache/SlsQueueProcessorThread.hxx
	sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx
	sd/source/ui/slidesorter/controller/SlsSelectionCommand.hxx
	sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
	sd/source/ui/slidesorter/view/SlsButtonBar.cxx
	sd/source/ui/view/Outliner.cxx
	sd/source/ui/view/drviewsh.cxx
	sd/source/ui/view/frmview.cxx
	sdext/source/presenter/PresenterFrameworkObserver.hxx
	sdext/source/presenter/PresenterSlideShowView.cxx
	setup_native/scripts/deregister_extensions
	setup_native/scripts/register_extensions
	setup_native/source/opensolaris/bundledextensions/README
	setup_native/source/opensolaris/bundledextensions/svc-ooo_bundled_extensions
	setup_native/source/win32/customactions/patch/swappatchfiles.cxx
	setup_native/source/win32/customactions/reg4msdoc/registrar.cxx
	setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx
	sfx2/inc/sfx2/sfxbasemodel.hxx
	sfx2/qa/complex/sfx2/DocumentProperties.java
	sfx2/source/appl/appopen.cxx
	sfx2/source/appl/appquit.cxx
	sfx2/source/appl/appserv.cxx
	sfx2/source/bastyp/sfxhtml.cxx
	sfx2/source/dialog/dockwin.cxx
	sfx2/source/doc/docfile.cxx
	sfx2/source/doc/docvor.cxx
	sfx2/source/doc/graphhelp.cxx
	sfx2/source/doc/objcont.cxx
	sfx2/source/doc/objserv.cxx
	sfx2/source/doc/objstor.cxx
	sfx2/source/doc/objuno.cxx
	sfx2/source/doc/objxtor.cxx
	sfx2/source/doc/printhelper.cxx
	sfx2/source/doc/sfxbasemodel.cxx
	sfx2/source/notify/eventsupplier.cxx
	sfx2/source/view/frmload.cxx
	sfx2/source/view/sfxbasecontroller.cxx
	shell/qa/zip/ziptest.cxx
	shell/source/backends/wininetbe/wininetbackend.cxx
	shell/source/win32/shlxthandler/util/utilities.cxx
	solenv/bin/build.pl
	solenv/bin/build_release.pl
	solenv/bin/cws.pl
	solenv/bin/download_external_dependencies.pl
	solenv/bin/make_download.pl
	solenv/bin/make_installer.pl
	solenv/bin/modules/Cws.pm
	solenv/bin/modules/ExtensionsLst.pm
	solenv/bin/modules/installer/control.pm
	solenv/bin/modules/installer/downloadsigner.pm
	solenv/bin/modules/installer/javainstaller.pm
	solenv/bin/modules/installer/packagepool.pm
	solenv/bin/modules/installer/patch/InstallationSet.pm
	solenv/bin/modules/installer/scriptitems.pm
	solenv/bin/modules/installer/windows/feature.pm
	solenv/bin/modules/installer/windows/msiglobal.pm
	solenv/bin/modules/installer/windows/sign.pm
	solenv/bin/modules/installer/worker.pm
	solenv/bin/modules/installer/xpdinstaller.pm
	solenv/bin/modules/osarch.pm
	solenv/bin/modules/packager/work.pm
	solenv/bin/modules/pre2par/parameter.pm
	solenv/bin/patch_tool.pl
	solenv/bin/transform_description.pl
	solenv/doc/gbuild/doxygen.cfg
	solenv/gbuild/LinkTarget.mk
	solenv/gbuild/gbuild.mk
	solenv/inc/os2gcci.mk
	solenv/inc/settings.mk
	solenv/inc/startup/Readme
	solenv/inc/target.mk
	solenv/inc/tg_compv.mk
	solenv/inc/tg_javav.mk
	solenv/inc/unitools.mk
	solenv/inc/unxbsdi.mk
	solenv/inc/unxbsdi2.mk
	solenv/inc/unxbsds.mk
	solenv/inc/unxfbsd.mk
	solenv/inc/unxlng.mk
	sot/source/sdstor/stg.cxx
	sot/source/sdstor/stgelem.cxx
	sot/source/sdstor/ucbstorage.cxx
	starmath/inc/toolbox.hxx
	starmath/source/mathmlexport.cxx
	starmath/source/node.cxx
	starmath/source/toolbox.cxx
	starmath/source/view.cxx
	stoc/source/bootstrap/bootstrap.xml
	stoc/source/corereflection/criface.cxx
	stoc/source/invocation/invocation.cxx
	stoc/source/security/access_controller.cxx
	stoc/source/servicemanager/servicemanager.cxx
	stoc/source/tdmanager/tdmgr.cxx
	stoc/test/javavm/testjavavm.cxx
	stoc/test/testconv.cxx
	stoc/test/testcorefl.cxx
	stoc/test/testintrosp.cxx
	svl/inc/svl/inettype.hxx
	svl/inc/svl/urihelper.hxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.cxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.hxx
	svl/source/config/itemholder2.hxx
	svl/source/items/itemset.cxx
	svl/source/numbers/zforlist.cxx
	svl/source/numbers/zformat.cxx
	svl/source/numbers/zforscan.cxx
	svtools/bmpmaker/bmp.cxx
	svtools/inc/svtools/helpagentwindow.hxx
	svtools/inc/svtools/menuoptions.hxx
	svtools/inc/svtools/miscopt.hxx
	svtools/inc/svtools/optionsdrawinglayer.hxx
	svtools/inc/svtools/stringtransfer.hxx
	svtools/inc/svtools/svlbitm.hxx
	svtools/inc/svtools/svtdata.hxx
	svtools/inc/svtools/valueset.hxx
	svtools/source/brwbox/editbrowsebox.cxx
	svtools/source/config/itemholder2.hxx
	svtools/source/contnr/contentenumeration.hxx
	svx/inc/svx/fmsrcimp.hxx
	svx/inc/svx/svdobj.hxx
	svx/inc/svx/xtable.hxx
	svx/source/accessibility/DGColorNameLookUp.cxx
	svx/source/accessibility/svxrectctaccessiblecontext.cxx
	svx/source/dialog/pfiledlg.cxx
	svx/source/fmcomp/fmgridcl.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/fmcomp/gridctrl.cxx
	svx/source/form/filtnav.cxx
	svx/source/form/fmPropBrw.cxx
	svx/source/form/fmshimp.cxx
	svx/source/form/fmsrcimp.cxx
	svx/source/gallery2/galtheme.cxx
	svx/source/inc/docrecovery.hxx
	svx/source/sdr/event/eventhandler.cxx
	svx/source/svdraw/svdedtv2.cxx
	svx/source/svdraw/svdedxv.cxx
	svx/source/svdraw/svdhdl.cxx
	svx/source/svdraw/svdobj.cxx
	svx/source/svdraw/svdograf.cxx
	svx/source/svdraw/svdoole2.cxx
	svx/source/svdraw/svdotxtr.cxx
	svx/source/svdraw/svdundo.cxx
	svx/source/svdraw/svdxcgv.cxx
	svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
	sw/inc/SwNumberTree.hxx
	sw/inc/ndnotxt.hxx
	sw/source/core/access/acccell.cxx
	sw/source/core/access/acccell.hxx
	sw/source/core/access/accframebase.cxx
	sw/source/core/access/accframebase.hxx
	sw/source/core/access/accmap.cxx
	sw/source/core/access/accpage.cxx
	sw/source/core/access/accpage.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/access/accpara.hxx
	sw/source/core/bastyp/swrect.cxx
	sw/source/core/crsr/findtxt.cxx
	sw/source/core/doc/docdde.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/docnode/section.cxx
	sw/source/core/draw/dcontact.cxx
	sw/source/core/edit/edlingu.cxx
	sw/source/core/inc/anchoredobjectposition.hxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/layout/tabfrm.cxx
	sw/source/core/layout/trvlfrm.cxx
	sw/source/core/ole/ndole.cxx
	sw/source/core/text/atrstck.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/itratr.cxx
	sw/source/core/text/itrform2.cxx
	sw/source/core/text/itrform2.hxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/uibase/dochdl/swdtflvr.cxx
	sw/source/core/uibase/docvw/PostItMgr.cxx
	sw/source/core/uibase/docvw/SidebarWin.cxx
	sw/source/core/uibase/docvw/edtwin.cxx
	sw/source/core/uibase/envelp/labimg.cxx
	sw/source/core/uibase/uiview/pview.cxx
	sw/source/core/uibase/uno/unomailmerge.cxx
	sw/source/core/undo/unattr.cxx
	sw/source/core/undo/untbl.cxx
	sw/source/core/unocore/unochart.cxx
	sw/source/core/view/vdraw.cxx
	sw/source/core/view/vnew.cxx
	sw/source/filter/basflt/fltini.cxx
	sw/source/filter/html/wrthtml.cxx
	sw/source/filter/inc/wwstyles.hxx
	sw/source/filter/rtf/rtffly.cxx
	sw/source/filter/rtf/swparrtf.cxx
	sw/source/filter/ww8/docxattributeoutput.cxx
	sw/source/filter/ww8/dump/msvbasic.cxx
	sw/source/filter/ww8/dump/ww8scan.cxx
	sw/source/filter/ww8/dump/ww8scan.hxx
	sw/source/filter/ww8/dump/ww8struc.hxx
	sw/source/filter/ww8/wrtww8.cxx
	sw/source/filter/ww8/ww8graf.cxx
	sw/source/filter/ww8/ww8par.cxx
	sw/source/filter/ww8/ww8par2.cxx
	sw/source/filter/ww8/ww8par2.hxx
	sw/source/filter/ww8/ww8par3.cxx
	sw/source/filter/ww8/ww8par6.cxx
	sw/source/filter/ww8/ww8scan.cxx
	sw/source/filter/ww8/ww8scan.hxx
	sw/source/ui/dbui/dbinsdlg.cxx
	sw/source/ui/inc/tablemgr.hxx
	sw/source/ui/inc/uitool.hxx
	sw/source/ui/lingu/olmenu.cxx
	sw/source/ui/uiview/viewport.cxx
	sysui/desktop/productversion.mk
	sysui/desktop/slackware/makefile.mk
	testgraphical/source/CallExternals.pm
	testgraphical/source/fill_documents_loop.pl
	testgraphical/ui/java/ConvwatchGUIProject/src/IniFile.java
	toolkit/doc/layout/notes.txt
	toolkit/doc/layout/oldnotes.txt
	toolkit/source/awt/vclxtabcontrol.cxx
	toolkit/src2xml/source/srcparser.py
	toolkit/workben/layout/editor.cxx
	tools/inc/tools/simplerm.hxx
	tools/inc/tools/solar.h
	tools/source/communi/geninfo.cxx
	tools/source/fsys/dirent.cxx
	tools/source/fsys/filecopy.cxx
	tools/source/fsys/os2.cxx
	tools/source/inet/inetmime.cxx
	tools/source/rc/resmgr.cxx
	ucb/source/core/ucbcmds.cxx
	ucb/source/ucp/file/filglob.cxx
	ucb/source/ucp/odma/odma_content.cxx
	ucb/source/ucp/tdoc/ucptdoc.xml
	ucb/source/ucp/webdav/makefile.mk
	ucbhelper/inc/ucbhelper/simplecertificatevalidationrequest.hxx
	ucbhelper/source/client/content.cxx
	ucbhelper/source/client/interceptedinteraction.cxx
	udkapi/com/sun/star/beans/XPropertiesChangeListener.idl
	udkapi/com/sun/star/io/ObjectOutputStream.idl
	udkapi/com/sun/star/io/XMarkableStream.idl
	udkapi/com/sun/star/io/XTextOutputStream.idl
	udkapi/com/sun/star/reflection/CoreReflection.idl
	udkapi/com/sun/star/reflection/XTypeDescriptionEnumerationAccess.idl
	udkapi/com/sun/star/test/XSimpleTest.idl
	unodevtools/source/skeletonmaker/skeletoncommon.cxx
	unodevtools/source/skeletonmaker/skeletoncommon.hxx
	unotools/inc/unotools/cacheoptions.hxx
	unotools/inc/unotools/cmdoptions.hxx
	unotools/inc/unotools/dynamicmenuoptions.hxx
	unotools/inc/unotools/extendedsecurityoptions.hxx
	unotools/inc/unotools/fontoptions.hxx
	unotools/inc/unotools/historyoptions.hxx
	unotools/inc/unotools/idhelper.hxx
	unotools/inc/unotools/internaloptions.hxx
	unotools/inc/unotools/localisationoptions.hxx
	unotools/inc/unotools/moduleoptions.hxx
	unotools/inc/unotools/printwarningoptions.hxx
	unotools/inc/unotools/securityoptions.hxx
	unotools/inc/unotools/startoptions.hxx
	unotools/inc/unotools/workingsetoptions.hxx
	unotools/source/config/cmdoptions.cxx
	unotools/source/config/compatibility.cxx
	unotools/source/config/configitem.cxx
	unotools/source/config/configmgr.cxx
	unotools/source/config/dynamicmenuoptions.cxx
	unotools/source/config/fontcfg.cxx
	unotools/source/config/itemholder1.hxx
	unotools/source/config/moduleoptions.cxx
	unotools/source/config/pathoptions.cxx
	unotools/source/config/viewoptions.cxx
	unotools/source/misc/sharedunocomponent.cxx
	uui/source/fltdlg.cxx
	uui/source/iahndl-filter.cxx
	vbahelper/inc/vbahelper/collectionbase.hxx
	vbahelper/source/msforms/vbacontrol.cxx
	vbahelper/source/vbahelper/collectionbase.cxx
	vcl/aqua/source/gdi/atsfonts.cxx
	vcl/inc/aqua/salmathutils.hxx
	vcl/inc/graphite_cache.hxx
	vcl/inc/jobset.h
	vcl/inc/os2/salgdi.h
	vcl/inc/osx/saldata.hxx
	vcl/inc/salgdi.hxx
	vcl/inc/salwtype.hxx
	vcl/inc/unx/wmadaptor.hxx
	vcl/inc/vcl/print.hxx
	vcl/inc/vcl/strhelper.hxx
	vcl/os2/source/app/salinst.cxx
	vcl/os2/source/app/saltimer.cxx
	vcl/os2/source/gdi/salgdi2.cxx
	vcl/osx/salframeview.mm
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/dndtest.cxx
	vcl/source/app/dbggui.cxx
	vcl/source/control/ilstbox.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/outdev4.cxx
	vcl/source/gdi/outdev6.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/pdfwriter_impl2.cxx
	vcl/source/gdi/print.cxx
	vcl/source/gdi/print2.cxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/source/window/printdlg.cxx
	vcl/source/window/tabdlg.cxx
	vcl/source/window/window.cxx
	vcl/source/window/winproc.cxx
	vcl/unx/generic/app/saldisp.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/gtk/app/gtkdata.cxx
	vcl/win/source/gdi/salgdi2.cxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/window/salframe.cxx
	vos/inc/vos/pipe.hxx
	vos/inc/vos/process.hxx
	vos/inc/vos/signal.hxx
	vos/inc/vos/socket.hxx
	vos/inc/vos/thread.hxx
	vos/source/pipe.cxx
	vos/source/socket.cxx
	wizards/com/sun/star/wizards/agenda/AgendaTemplate.java
	wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java
	wizards/com/sun/star/wizards/agenda/TopicsControl.java
	wizards/com/sun/star/wizards/web/FTPDialog.java
	wizards/com/sun/star/wizards/web/ImageListDialog.java
	wizards/com/sun/star/wizards/web/Process.java
	wizards/com/sun/star/wizards/web/ProcessStatusRenderer.java
	wizards/com/sun/star/wizards/web/TOCPreview.java
	wizards/com/sun/star/wizards/web/WWD_Startup.java
	wizards/com/sun/star/wizards/web/data/TypeDetection.java
	wizards/com/sun/star/wizards/web/export/ImpressHTMLExporter.java
	writerfilter/inc/doctok/WW8Document.hxx
	writerfilter/source/dmapper/DomainMapper.cxx
	writerfilter/source/dmapper/NumberingManager.cxx
	writerfilter/source/dmapper/PropertyMap.cxx
	writerfilter/source/dmapper/StyleSheetTable.cxx
	writerfilter/source/doctok/WW8StructBase.hxx
	writerfilter/source/doctok/resources.xmi
	writerfilter/source/ooxml/README.efforts
	xmerge/source/activesync/XMergeFilter.cpp
	xmerge/source/minicalc/java/org/openoffice/xmerge/converter/xml/sxc/minicalc/SxcDocumentDeserializerImpl.java
	xmerge/source/palmtests/qa/comparator/pdbcomparison.java
	xmerge/source/palmtests/qa/test_spec/convertor_test_spec.html
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java
	xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDescriptor.java
	xmerge/workben/jstyle.pl
	xmlhelp/source/cxxhelp/provider/databases.hxx
	xmlhelp/source/cxxhelp/provider/provider.cxx
	xmlhelp/source/treeview/tvread.cxx
	xmloff/inc/txtfldi.hxx
	xmloff/inc/xmloff/xmlmultiimagehelper.hxx
	xmloff/inc/xmloff/xmluconv.hxx
	xmloff/source/core/xmlexp.cxx
	xmloff/source/draw/shapeexport2.cxx
	xmloff/source/draw/shapeexport3.cxx
	xmloff/source/meta/xmlversion.cxx
	xmloff/source/style/impastp4.cxx
	xmloff/source/style/xmlaustp.cxx
	xmloff/source/text/XMLSectionExport.cxx
	xmloff/source/text/txtflde.cxx
	xmloff/source/text/txtimp.cxx
	xmloff/source/text/txtparae.cxx
	xmloff/source/text/txtparai.cxx
	xmloff/source/text/txtvfldi.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx

Change-Id: Ie072e7c3a60c5dae16a67ac36d1f372c5065c99c
2014-05-01 08:59:14 +01:00
213bc71f84 Clean up function declarations and some unused functions
Change-Id: I382289c7188dfdc9839ff9e6362b6e039ffc5f9e
2014-04-08 08:39:36 +02:00
50bf123ddb Kill superfluous vertical whitespace
Change-Id: I81ce8fd7022bf283db668705efdfb0666f87bde9
2014-04-02 16:54:18 +03:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
7260bcd687 cosmetic: split PhysicalFontFamily/Collection out of outdev3.cxx
Change-Id: Iae8eb15413c0c069c14edd92c94ecb0113d9d371
2014-03-20 16:11:58 -05:00
5971a040f9 rename ImplDevFontList to PhysicalFontCollection
again, convergence of teh naming with what is normally
used in the underlying native API,
where FontFace ) FontFamily ) FontCollection

Change-Id: Ieb098b782ea828a3365f00d07914b9566278caba
2014-03-20 16:11:57 -05:00
1e539dbf0f Resolves: fdo#50855 Nimbus Sans L missing styles
Change-Id: Ie8cdcf4ad0ffe52024fd5cfe33073abfc6aadca8
2014-03-12 16:03:46 +00:00
59b428189d Avoid possible resource leaks by boost::scoped_array
Change-Id: I3a9131d75690e18caec4c328934735a9ca19e7ca
2014-03-11 09:30:49 +09:00
2f41b934e5 coverity#708896 Unused pointer value
Change-Id: Id2a4e43c1f32d997ee2656ef2e55a1951ce60f9d
2014-03-06 16:35:53 +00:00
a61d15e0c4 coverity#708897 Unused pointer value
Change-Id: Iab37796be5c9d6fef3e68e9ec9b6828c643b822d
2014-03-06 16:35:53 +00:00
f3770d0d04 coverity#708898 Unused pointer value
Change-Id: I3190fa5c49de84319bf08f286c1511d2b23e4922
2014-03-06 16:35:53 +00:00
827d9168ee coverity#708899 Unused pointer value
Change-Id: I7b8c2a01a59f939805d09612968d8f90acf1849a
2014-03-06 16:35:52 +00:00
7e5fdb00f9 coverity#708900 Unused pointer value
Change-Id: I2b644bf795bcfe2978aac25696cf362d7505c9a5
2014-03-06 16:35:52 +00:00
8770c1de8d coverity#708901 Unused pointer value
Change-Id: Ie12718b9de452ccd5b8031694d6e70792b438d89
2014-03-06 16:35:52 +00:00
a163062793 coverity#708902 Unused pointer value
Change-Id: Ia8e140da22d67013a1485445a6359aa001a14826
2014-03-06 16:35:52 +00:00
be9c3a83b2 coverity#708903 Unused pointer value
Change-Id: I86bf2361e06bc9beac20b76894b247c46c265b1a
2014-03-06 16:35:51 +00:00
581ffdd286 coverity#1187675 Dereference null return value
Change-Id: I313772d7382c303990f7333990e340803678be79
2014-02-27 12:58:44 +00:00
3a1671b351 coverity#1187674 Dereference null return value
Change-Id: I4fdf0e324463285d086c1503214e2aee0c0537e8
2014-02-27 12:58:44 +00:00
d9f0af83b7 Remove visual noise from vcl
Conflicts:
	vcl/source/app/settings.cxx
	vcl/source/window/dockmgr.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/floatwin.cxx
	vcl/source/window/toolbox2.cxx

Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:56:16 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
fe7a4bccfd Adapt vcl to various loplugin warnings on Mac OS X
Change-Id: I4553ce218fbcf2ac681b284c71e7d558a451511c
2014-02-21 23:47:23 +01:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
973b47a336 unotools: sal_Bool -> bool
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19 12:47:07 +01:00
0d3082dbf2 callcatcher: update unused code
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12 13:03:50 +00:00
c1d37365c4 bool improvements
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-28 20:26:19 +01:00
5169abbac9 bool improvements
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
2014-01-17 18:45:14 +01:00
7d432a9e67 Remove defines now that fontconfig baseline has been updated
Change-Id: Ia97ab24e60785be36f475f6bf275a0ae336e9408
Reviewed-on: https://gerrit.libreoffice.org/7461
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16 15:39:09 +00:00
a16aacd647 Resolves: #i123840# add and use the sal_GlyphId type
Using the central definition adds consistency and cleans up many ad hoc
declarations. The type sal_GlyphId will become a class in the future so
that its bitfield operations etc. can then be isolated into nice methods.

(cherry picked from commit c0a84ad10964fb7a65b6239cbe1cef8698b5d17b)

Conflicts:
	vcl/aqua/source/gdi/salatslayout.cxx
	vcl/aqua/source/gdi/salgdi.cxx
	vcl/generic/glyphs/gcach_ftyp.cxx
	vcl/generic/print/genpspgraphics.cxx
	vcl/generic/print/glyphset.cxx
	vcl/generic/print/glyphset.hxx
	vcl/headless/svptext.cxx
	vcl/inc/generic/genpspgraphics.h
	vcl/inc/generic/glyphcache.hxx
	vcl/inc/os2/salgdi.h
	vcl/inc/quartz/salgdi.h
	vcl/inc/salgdi.hxx
	vcl/inc/sallayout.hxx
	vcl/inc/unx/salgdi.h
	vcl/inc/vcl/fontmanager.hxx
	vcl/inc/win/salgdi.h
	vcl/os2/source/gdi/os2layout.cxx
	vcl/os2/source/gdi/salgdi3.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/sallayout.cxx
	vcl/source/glyphs/gcach_ftyp.hxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/unx/generic/fontmanager/fontmanager.cxx
	vcl/unx/generic/gdi/gcach_xpeer.cxx
	vcl/unx/generic/gdi/gcach_xpeer.hxx
	vcl/unx/generic/gdi/salgdi3.cxx
	vcl/unx/generic/gdi/xrender_peer.hxx
	vcl/unx/headless/svpgdi.hxx
	vcl/unx/headless/svppspgraphics.cxx
	vcl/unx/headless/svppspgraphics.hxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/gdi/winlayout.cxx

Change-Id: Ic629131950360e2df4c15db30d6a5362193c6330
2014-01-06 14:32:30 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
a0e8a1b691 fontmanager.hxx is private to vcl
Change-Id: Iec1d1539db0b44d2ddc420cf500585098d4793fc
2013-12-11 10:30:02 +02:00
003a3d7a55 No more uses of printer built in fonts
Less parsing of AFM files at startup.

Change-Id: I62d4c81d6e892f2356df22b53bb35c0f9f7bc344
Reviewed-on: https://gerrit.libreoffice.org/6860
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-04 05:04:04 -06:00
ed913215e3 Make TTC fonts work again
osl::File::getFileURLFromSystemPath() does not return a boolean. I
wonder how this worked before, if it worked at all.

Change-Id: Iadc0e06236f43c24cbcd42e4fd79ac9116a58c13
2013-11-23 13:45:00 +02:00
ec5b894ef8 Simplify this code a bit
Change-Id: I591484788c5bcb9b9cde9696b149ede7298015a5
2013-11-23 13:44:59 +02:00
3cabbf37b9 remove unnecessary sal_Unicode casts in VCL module
Change-Id: I79da72097e8bc86891075d1484a59b5599a063d0
2013-11-14 08:17:30 +02:00
ef90021abe convert OUString !compareToAscii to equalsAscii
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11 12:58:12 +02:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00