Commit Graph

2544 Commits

Author SHA1 Message Date
e111caa906 remove unused method
Change-Id: I17d3e3fa4671d0004e2d7918ea3bcad1a7bcd2b5
2014-09-02 01:08:54 +02:00
e65acd2ebb use SystemWindowData to request a NSOpenGLWindow
Change-Id: Ief50a2fc533846cd61be66b1ea166a992942083b
2014-09-02 01:08:52 +02:00
a5346d7f3d switch to a NSOpenGLView implementation
Change-Id: Ifed59a9e899abc900ddf27378eec6b641be061d3
2014-09-02 01:08:52 +02:00
6b50f11faf fix nasty memory leak on shutdown
This makes the output of Lsan so much more useful.

Change-Id: I6c7624d4f6f767454c125c00ce037f5d2ec3cd61
2014-08-26 13:34:05 +02:00
d0c3c16c87 convert SV_EDIT_WARNING_BOX to MessageDialog + string
Change-Id: Ie3ceba0e3fa54b6aac7aca844588ed69063af02e
2014-08-25 16:45:30 +01:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
e2adbfc33c vcl: factor out font name lookup for future re-use.
Change-Id: I35f80610862528d7525fa61135604468271ca37a
2014-08-22 16:22:13 +01:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
6d51e258b9 warning C4800: 'int' : forcing value to bool 'true' or 'false'
Change-Id: I9f77b85eb9ccaa4defa3dea571b375c0e480caa2
2014-08-17 05:15:24 +02:00
32a92502fd GetTextBreak takes a DeviceCoordinate as width
Change-Id: Ie03732a0966eedf6c0226beed83356ae4886a016
2014-08-14 22:42:16 +02:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
d9d16df299 vcl quartz: draw 'bullet' manually for better control
Change-Id: If0f6bd93adc5d39fd421bb482833619f85f7a461
2014-07-20 22:11:00 +02:00
6ca2d0d664 vcl use DeviceCoordinate got GetNextGlyphs
Change-Id: I0b03973b2d09a0ce51a6ee7dcca5a310a544c3a9
2014-07-20 22:11:00 +02:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
2b8528a274 Use DeviceCorrdinate for DXArray in FillDXArray and ImplLayoutArgs
Change-Id: Ifba7104a13cf737200c81d1a1bd5ece9a29da60e
2014-07-20 22:10:58 +02:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
7a8fcfca98 fdo#79673 quartz: draw 'bullet' for 'space' directly in one pass
the current implementation of CoreText simply dropped the proper
implementation of DrawTextArray, by ignoring DXArray
this very visibly borked the show-non-displayable character
feature of writer.. the bullet representing the 'spaces'
was quite misplaced.
This solve specifically this problem.
More work is needed to bring proper support of DXArray back to CoreText


Conflicts:
	vcl/inc/sallayout.hxx
	vcl/source/outdev/text.cxx

Change-Id: Idb2cc90d5ffaa8b83f79241cee2d512112d1c3be
2014-07-15 21:45:11 +02:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
4789eab61c use SimpleReferenceObject in vcl/osx module
to replace hand-rolled version

Change-Id: Idf3f2dd20bacd3cb3de64931027ef62d9116200f
2014-07-10 11:06:03 +02:00
7dda48d56f Related: fdo#80633 cache optimal size
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01 16:43:05 +01:00
5f50d9593d Mark WindowImpl as noncopyable
Change-Id: I80f981216067a03578cfc812b006e6b68b77068e
2014-06-30 14:57:57 +02:00
4c6e54a194 loplugin:unreffun: redundant function redeclaration
Change-Id: I6c9b85ab587f6fb9f585c9714c3a1076f627c7d3
2014-06-27 18:08:25 +02:00
56fea375b9 Allow passing in external buffers to svp's VirtualDevice.
We also want to be able to set whether or not the buffers
should be painted to top down, so add that parameter
as necessary (default seems to be false, however e.g. gtk
requires this to be true, i.e. needed for tiled rendering).

Change-Id: Id98882e4c7f62508ae5a976c0d8df743460a4ab2
2014-06-25 13:04:29 +01:00
e82d491263 svp: deduplicate bitcount->colourspace mapping and allow overriding.
Although svp defaults to BGR, we might want to use alternative
formats (e.g. for tiled rendering to bitmap buffers which are
to be used in e.g. gtk), it is probably safest to keep the current
defaults but allow the user to change to whatever format they may
require. (This currently only makes sense for the 32-bit
RGBA/ARGB/etc. formats. However the 23 bit formats could potentially
be expanded to allow a similar RGB/BGR choice.)

Change-Id: I70bd3d6e7d297faef163b910f576655efee4cb3f
2014-06-25 13:04:29 +01:00
0434043aed Return a bitmap buffer for tiled rendering from LibLO.
We still need some way of managing the buffers properly rather
than just keeping a static reference to the last buffer
that was rendered.

Change-Id: I17940c758948aa9418f4e0216ecd253d128cd04f
2014-06-25 13:04:28 +01:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
a2ee38ef7a fix keyboard input on OS X < 10.6
Since commit e4dc93f5, LibreOffice just beeps on any key press:
it's impossible to add symbols by using keyboard. This patch
fixes that.

conditionally reverts e4dc93f5d8d0df50f1a8b4594220d0c57703e03d

Change-ID: Id30e30775c0d0224954b8a1f05fd0d8d5f39cd4e
Reviewed-on: https://gerrit.libreoffice.org/9793
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-16 12:30:38 +00:00
1817366cb5 gbuild: remove config_libraries.h and gb_Helper_generate_config_libraries
This much ugly complexity, generating a header on every gbuild startup
etc. is really not warranted for 6 callers of the generated macros.
Also, the Win32 make has problems with the quoting.

Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
2014-06-09 17:05:50 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
c2034f3993 fixincludeguards: fix include guards
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06 19:16:40 +00:00
369d95931f DeInitVCL at end of tests
This required some changes to the framework:

* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
  once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
  the exisiting unobootstrapprotector).  CppunitTests that need VCL now need to
  declare gb_CppunitTest_use_vcl.

* For things to work properly, the UNO component context needs to be disposed
  from within DeInitVCL (cf. Desktop's Application::DeInit called from
  DeInitVCL).  The easiest solution was to introduce an
  Application::setDeInitHook (where the hook is called from DeInitVCL)
  specifically for vclbootstrapprotector to call.

* PythonTests don't (yet) call DeInitVCL; they still hook into
  BootstrapFixture's original test_init functionality (to call InitVCL), and do
  not make use of the vclbootstrapprotector.

Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04 08:55:12 +02:00
dacab84536 Avoid accessing freed memory and freeing already freed resources
Seen in smoketest in a 4.2-based branch, but might perhaps happen in master
too. Should not hurt in any case to be more careful. ImplFreeSalGDI() is
called both from SalAbort() and from DestroySalInstance().

Change-Id: Ifac37e8ecfb432848bd3451dbda8634c59a06fba
2014-06-04 07:05:23 +03:00
e4dc93f5d8 Initial attempt at implementing NSTextInputClient instead of NSTextInput
NSTextInput was deprecated in 10.6.

Change-Id: I6bce9e91a68014a6ca28bff6a820c27817f9baaf
2014-06-03 21:29:04 +03:00
6c3245fc69 fdo#68849: Add header guards to all include files
Added header guards to files in directory vcl/

Change-Id: I76ad0c34f2b107d56e92c5a6a8f4c61554c93e2f
Reviewed-on: https://gerrit.libreoffice.org/9597
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01 16:15:36 +00:00
f1d38f2a92 vcl: cleanup window.h
Change-Id: Iea8323382f889705681236e364a9ef8b744fa9f2
2014-06-01 16:12:13 +10:00
909a76c7da New loplugin:inlinevisible to flag inline functions marked DLLEXPORT
...which does not make sense.  On Linux and Mac OS X, they potentially end up
exported from multiple libs (weakly, though), while on Windows the potentially
even end up not emitted at all, which could cause link errors.

Change-Id: I092c9ba39e686c17b6e91581cdd4753f1c4d582f
2014-05-30 14:12:31 +02:00
507efabe8b Resolves: #i124922# allow late setting of the font color...
for CoreText-layouted text

(cherry picked from commit 42f9768f771457c53a9f1e6a3581b2df9856401f)

Conflicts:
	vcl/aqua/source/gdi/ctfonts.cxx
	vcl/aqua/source/gdi/ctfonts.hxx
	vcl/aqua/source/gdi/ctlayout.cxx
	vcl/source/gdi/outdev3.cxx

Change-Id: Ie2685ab80ca87ea72e25f18d02f883fb36c24a36
2014-05-29 16:13:51 +01:00
5e62d30fa2 update_pch
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28 15:53:10 +02:00
16a6207901 Oops, this reference can't be const.
It's used in ImplFontCache::GetGlyphFallbackFont.

This is fix for commit a6b00d16eb27a5e7e31c721671001a909ecef960,
which caused huge performance regression for document in fdo#59882,
fortunately immediately detected by loperf.

Change-Id: I475742b5249f106d34c4f6c43b1e39e9bb7b897a
2014-05-28 15:25:52 +02:00
a6b00d16eb Related bnc#822625: Cache FontEntry with the original FontSelectPattern.
Otherwise we never hit cache directly, only after expensive call to
ImplFindByFont.

Change-Id: If15b368feeba94c8fff8ee7cbe049fc4a2069768
2014-05-27 19:38:23 +02:00
7b545001a1 vcl: move functionality from window2.cxx
Change-Id: I68d1c7bb32df9024ea57a07d7d3b051efc08b2ed
2014-05-27 08:13:02 +10:00
231050ddcc No need for these fields for iOS
Change-Id: I3fff002919a1f15ae370c7d0c7f65e67108a6232
2014-05-26 16:11:55 +03:00
3c84ee9cce cppcheck: unusedFunction
Change-Id: I81f2a4be65bbc9359e51accccb746f1e8ea48c4f
2014-05-25 21:55:34 +02:00
aa453de65b try harder to fix windows build
This reverts commit 3b26995b8e704438fc3f2cd5bb4c224d75f64b95.

Change-Id: I756e1730f8d9e87484710699177349166b87baaf
2014-05-24 14:44:48 +01:00
6e38357d5d Cosmetics
Change-Id: I4ad71bd3538b1d5b033802469b16dd35df5b9724
2014-05-21 16:53:21 +03:00
0f836296ea Don't use two separate names for the same thing
Change-Id: Iad76d452d5dbaa03099c1a649d7f278b0151f340
2014-05-20 23:37:04 +03:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00