Commit Graph

97 Commits

Author SHA1 Message Date
d931eb2a93 WaE: Unreferenced function declarations
Change-Id: I86087bac83de9756a1645fef6f0d74306f8d010d
2014-08-22 15:28:05 +03:00
cf2c056bf0 remove special casing for default theme in vcl
Change-Id: I4d7a37ab9b31fcce7704f07d883d6f7806f066ec
2014-08-22 14:09:16 +02:00
ddc178e07d valgrind + bff: don't add 0xffff oldcode
Invalid read of size 1
   at 0x9DC6247: GIFLZWDecompressor::AddToTable(unsigned short, unsigned short) (decode.cxx:117)

Change-Id: I9cea8dcd4a5eeaa1e793b9be96f82854b9d088af
2014-08-13 09:16:09 +01:00
6ca69fc429 bnc#881024 test font size at world transform
Change-Id: If9b09b69ccd890e45d963422ccedb711585f6434
2014-07-20 21:02:51 +02:00
2a649539b7 MetafileXmlDump: No need to specify the stream, simplify the API.
Change-Id: Ia08f67e359bbd26cefdba8661f0b0c4ae2147382
2014-06-10 19:33:12 +02:00
90f0af7a9c WMF record size < 3 is clearly broken
...so we should not attempt to (mis-)interpret such broken input.

Change-Id: I97f4f46fdfc0dfe6f9aff42917d23634b844c7f0
2014-06-05 17:36:52 +02:00
3bb1051a27 mark QA file non-translatable
Change-Id: I19f10c40151ebfea9b02bfe5df7c31b157188351
2014-05-27 09:53:32 +02:00
ec1c2c566d cppcheck: redundantAssignment
Change-Id: Ia53ac439c785e83de380fddd201ad4159f729cb2
2014-05-24 15:46:42 +02:00
b5f45a5163 Argh, *this* is what the compiler tried to tell me
Change-Id: Id5716bf6f9c86e7fa0d64b1bae9b69b4a5dadfe5
2014-05-19 09:10:58 +03:00
1b529df25f Fix 'non-const lvalue reference cannot bind to a temporary'
Change-Id: Ic308a281f7b16c8924658be792216d3aba4444c5
2014-05-19 09:04:47 +03:00
6a21c29fc6 WaE: passing OUString by value, rather pass by reference
Change-Id: I6a7331ab3d87cc04021e92283db938c92b066e6b
2014-05-19 08:46:07 +03:00
9a4a48d213 vcl emf test: test clip region is correct for problematic files
Change-Id: I60caf9ebcff417e0f87bae9c6b5d308b5e2f0b37
2014-05-19 00:01:15 +02:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
fd70beaccb vcl wmf test: null terminate stream
Change-Id: I10342262cacbe3e3d978fee652cdbc4692f46dc4
2014-05-15 23:50:58 +02:00
a470fe1ea0 loplugin:unreffun
Change-Id: I10ca928ce30631b531a2549985b54ca071efb79c
2014-05-15 22:49:41 +02:00
f9e81786f4 wmf: test that non-placeable WMF uses correct sizes
Change-Id: I546d654726483b40ce4d981bc66377c8a3df6194
2014-05-15 19:51:08 +02:00
c288b17cc5 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-14 23:18:57 +02:00
4008c66082 add some jpeg format tests
Change-Id: I17347c638b5c6c72e740aaa995339a8ff33609bc
2014-04-18 14:18:09 +01:00
e404080a60 add a testcase for CVE-2008-1097 bmp
Change-Id: I3b1b315654fbb2a35785a87540f7da03d2d7301c
2014-04-18 10:09:55 +01:00
42b3064025 add more bmp test cases
Change-Id: I42e4d9c708e4c4c833f58fec7ce2b324ceec6496
2014-04-17 15:51:49 +01:00
c79a5f87b1 remove executable bit
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-17 15:11:14 +02:00
ce07a9f643 Remove unused function
Change-Id: I83193d77832a97147fe0fe2768039c0b101c65a3
2014-04-09 11:24:59 +02:00
9984807f17 WMF import: restore support for the ImplReadDIB(bFileHeader=false) version
Regression from commit f7799c9317cc3187ae8aaedc36f829d478a59e77
(Resolves: #i124467# add check for image data offset..., 2014-03-28).

Change-Id: I71e78aefca2ca5b07f763ec798226b9bb39a5254
2014-04-04 18:01:07 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
50bf123ddb Kill superfluous vertical whitespace
Change-Id: I81ce8fd7022bf283db668705efdfb0666f87bde9
2014-04-02 16:54:18 +03:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
78a2020846 vcl: prefer passing OUString and OString by reference
Change-Id: I6c2c6f597ca62c004ad7dc606cef3a3b10e810b6
2014-03-13 08:39:26 +02:00
35fb9ca387 bool clean-up fixup
Change-Id: I0a302d7f91ef07992f95a8ccd48efec862519ab1
2014-02-28 12:15:32 +01:00
c28e4af6fe WaE: implicit conversion (IntegralCast) from bool to 'int'
Change-Id: I3431d256bde60a2b3fa8de9a0ef43d1a0f1dc3df
2014-02-28 13:03:25 +02:00
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
9a8200e229 Restore jpg
This reverts the jpg part of d9f0af83b7f0abe7119eefca62cbbca7eff818ef.

Change-Id: Idcba2e16cc3f2fce9c04a225a5754841b4f39380
Reviewed-on: https://gerrit.libreoffice.org/8358
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:18:07 -06:00
d9f0af83b7 Remove visual noise from vcl
Conflicts:
	vcl/source/app/settings.cxx
	vcl/source/window/dockmgr.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/floatwin.cxx
	vcl/source/window/toolbox2.cxx

Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:56:16 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
887931b5f9 C++11'ism
Change-Id: If2e3f4f7cd78d37fb4bbc35c62742f56da662765
2014-02-22 00:53:12 +01:00
f392ef868c c++11ism
Change-Id: I0838eafa47aaed222aca30d234300f2c05697175
2014-02-21 23:10:26 +00:00
6bc639523f WaE: implicit conversion of literal of type 'const char *' to 'bool'
Change-Id: Ia0c05b93bbb5a399257d0e1ab8670aa95be01fd7
2014-02-21 22:24:15 +02:00
ae993046a9 WaE: unused variables
Change-Id: Ia5bdfd7db7ed2769b34e8dbd7e0ed7dbe5499d34
2014-02-21 22:24:15 +02:00
87dc2bfecf Include <stdexcept> for std::runtime_error
Change-Id: I6ef2036f075c2992b692d9a227db257edc4a6955
2014-02-21 22:24:15 +02:00
076a7eacca Bug #63962 Dynamically scan the config directory for icon themes
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory

Conflicts:
	include/vcl/settings.hxx
	vcl/source/app/settings.cxx
	vcl/source/window/window.cxx

Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21 17:23:50 +00:00
f6fef3a970 coverity#1130457 Uncaught exception
Change-Id: Ie65cdb00ec8823db329d2330ed142f4d841b095a
2014-02-21 15:30:27 +00:00
ea89446d5d coverity#1130458 Uncaught exception
Change-Id: I2fd30daef6df18d0ef25132f9c0e445f613da10f
2014-02-21 15:30:27 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
26914637e0 CVE-2014-1947: add testcase
Change-Id: I71b1fa7cfb536e49801752ae8ba48428918b6a36
2014-02-17 12:28:07 +00:00
4adf4379aa coverity#1130447 Uncaught exception
Change-Id: Icb55ad131c9e69264b3cf1ed4d7220002816036d
2014-02-10 11:21:07 +00:00
5852f34717 coverity#1130448 Uncaught exception
Change-Id: Ie0b0418191a47e89c9535d6f13c09e15e634a4b9
2014-02-10 11:21:06 +00:00
a00f5c0131 coverity#1130449 Uncaught exception
Change-Id: I3d357d1346da173f0ee40b6b316e26d7f75bd4d5
2014-02-10 11:21:06 +00:00
6165535dc9 coverity#1130450 Uncaught exception
Change-Id: I0155c6baafc302984a9af17434ec23b37606aa22
2014-02-10 11:21:06 +00:00
2ce3912cab coverity#1130451 Uncaught exception
Change-Id: Id26567c2f2aceca2b681dfbc6a4de493fa331f3d
2014-02-10 11:21:05 +00:00
517613241d coverity#1130452 Uncaught exception
Change-Id: I700a73af9f25ea92a45c0f9218c4267fc885773e
2014-02-10 11:21:05 +00:00