Commit Graph

3020 Commits

Author SHA1 Message Date
3101a60751 coverity#1233506 Use of untrusted scalar value
Change-Id: I843f688b47489db90edcdb75a15403c66aad55af
2014-09-02 12:14:45 +01:00
200dd78946 fix crash when creating chart
Change-Id: Ie6e38a0461a10cc33ff3d85cbf3b35ffab0efd59
2014-09-02 01:08:55 +02:00
835ca0a10d add capability to load FloatingWindows from .ui
in theory anyway

Change-Id: I8230462bdb05e4a71e366c1a92ba388a8ea12c82
2014-08-30 20:56:03 +01:00
e8fb86134c move layout from dialog to systemwindow
*distant sounds of hammering in basement*

so we can get Floating Windows layout aware
as well without duplicate of dialog layout logic

Change-Id: I063375f2f7d4e5c3bfbfedf55649078d4dbe4139
2014-08-30 17:22:37 +01:00
6802dc06de Dialogs no longer loaded from resource files
Change-Id: I55295009f474dbac15be792049fa5c6c95c1ec07
2014-08-26 17:00:21 +01:00
ca68971f0a ModalDialogs no longer loaded from resource files
Change-Id: I2d208c7cc5ff9bf26bff5ab2aa40e0bf57373342
2014-08-26 17:00:21 +01:00
d8e976e365 name offending dialog
Change-Id: I678627177dd81b422a66370cbc4ef7d7e740714b
2014-08-26 13:34:45 +01:00
bc16ad7c8d connect gtk-yes and gtk-no up
Change-Id: I5c17e633b9a638ed99d1129447f628155dd043cd
2014-08-25 20:53:34 +01:00
07244947b5 MessBox not loaded from resource files anymore
Change-Id: I12378a1c80e1070763cd2bd0539d74f4cc270a30
2014-08-25 16:45:32 +01:00
bddd6d823d WarningBox are no longer loaded from resource files
Change-Id: Ib05a9876c0b1d3425dd1629f8a0fe3d16a57cc30
2014-08-25 16:45:31 +01:00
fd345ccfaf queryboxes cannot be loaded from resource files anymore
Change-Id: I2ee03b2f8f34d9ecf8a762e7845410fd9a31590f
2014-08-25 16:45:28 +01:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
50fffcaa05 Infoboxen are no longer loaded from resource files
Change-Id: If387291e9e145ee36338b1e560f18889c3b62674
2014-08-20 20:22:24 +01:00
d4a615bf62 ErrorBoxen are no longer loaded from resource files
Change-Id: I099258e449d0155154d60a839f9495236cb48cbb
2014-08-20 20:22:24 +01:00
afa5d63e2a TabPages are no longer loaded from resource files
Change-Id: I009e0f388cfe1861cef89d2148a02380dd47c1ff
2014-08-20 16:35:09 +01:00
4b339818bb add a VclViewport
like GtkViewport so that the scrolled region will be clipped,
which also has the side-effect of stopping glade clobbering
the non view-port scrolled .ui files on editing

Change-Id: Ic64174b3a35b77f068e0085cdc7721aeb33f1d82
2014-08-20 14:00:58 +01:00
749f7548b4 only subtract height of hscroll if visible
otherwise infinite loop in extensions update check

Change-Id: I0dbf4f34208f1bf0854e365006a79470b26571f3
2014-08-19 17:20:34 +01:00
36490fff3f facepalm: nAvailHeight is not derived from allocation Width
Change-Id: Ic99c6519b02c546e0d3574cb756e3fb172d1ff52
2014-08-19 16:14:23 +01:00
28447075ea warning C4245: 'return' : conversion from 'int' to 'sal_uInt16'...
...signed/unsigned mismatch

Change-Id: I24b853330321a6849dc662d1702efc26642dd0b2
2014-08-13 10:10:46 +02:00
e1683c2d13 callcatcher: update unused code
lots of ResID stuff going away now

Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
13807fbf9f Related: fdo#81457 skip setting an empty allocation
if the dimension is 0, don't bother calculating
a bunch of <= 0 sizes, rely on the parents clipping
to hide the lot instead

Change-Id: I5b593a5b6b6c3614beb7f9bf3328fa469b700972
2014-07-22 14:37:39 +01:00
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
09c95aba4a convert HITTEST #define to enum
Change-Id: I2a4066c66894e0bd9c349a7c5b8db3a8398451d2
2014-07-18 09:37:35 +02:00
65ecb0d8f4 Related: fdo#80633 we can retain cached size for visibility change
we still need to invalidate the layout of our parents, but we can
keep the cached optimal size

Change-Id: I8e77366bd61ff45d34f9d411c7f501a3a9ccbd4e
2014-07-15 11:56:09 +01:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
6363e1e373 vcl/source/window/wrkwin.cxx: drop unused svsys.h header
Change-Id: Iad99721f6026512584c6e1cb763b81ffc6d1a625
Reviewed-on: https://gerrit.libreoffice.org/10152
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10 16:09:52 +00:00
8e0520acc7 setting WB_SCROLL on a toolbar only works from ctor
Change-Id: Iafd4d132abb63d698f8907c4aa71bd09c35babde
2014-07-10 13:39:20 +01:00
81a8f537d6 Related: fdo#80633 dialog size cache has to be invalidated too
otherwise the VclExpander will have no effect

Change-Id: I039fa361d7088dfe4a6ff849623e34b27e2be26b
2014-07-08 16:14:45 +01:00
d3c3ba075c coverity#736163 Dereference Null return
Change-Id: I62046a619315d53dbeefbe0ebd26d24917adca14
2014-07-04 13:31:37 +02:00
5a83b31aca expose a way to drop ownership of a window from builder tree
Change-Id: I6f6bff32271ed1d6c328ba211a6b1249fda039dd
2014-07-02 11:57:08 +01:00
7dda48d56f Related: fdo#80633 cache optimal size
Change-Id: Ic2c3aefebd3061d294f339c6d262a3c3e381fbe4
2014-07-01 16:43:05 +01:00
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
eb8c56127a rework resize into a custom widget
so that the order of resizing will happen in the right sequence
to work correctly every time

Change-Id: I1adffe276db3fb80eb34ca74c2ceb51a6ee28526
2014-06-30 16:31:48 +01:00
f8e34ea78a ...and ~SystemWindow can recursively destroy its child windows
...so when the pMyParent vs. pMySysWin typos in the asserts (thanks Matteo and
Micheal for spotting) were fixed, they would fire in such scenarios.  So just
hope that it is fine to effectively skip those safety checks in these cases,
too.

Change-Id: Ib925e57b68643c75a5d4db67fd64692015482179
2014-06-30 16:42:43 +02:00
0223eb2c64 Once ~SystemWindow calls ~Window, this is no longer a SystemWindow
...and hopefully it is just as fine to start this safety check at the paren,
anyway.

Change-Id: Ie3d7a1e233b9e3076a6603f2c6312d57b42b0f77
2014-06-30 14:57:57 +02:00
c403286de5 use VCL_HIDE_WINDOWS env on Mac to 'simulate' headless mode on Mac
Building, and running the unit/subsequent test on Mac cause massive amount
of flashing windows creation/destruction that make building with test
very annoying on a box used for other purposes.
This patch prevent the windows to be actually displayed hence mitigating
the problem

Change-Id: Ied2a36699b50856e0c4e6b618212481796ec99d3
2014-06-30 11:14:12 +01:00
641154c259 Resolves: fdo#65634 improve wheel-scrolling sidebar panels
Change-Id: I213d85a1e2bbd2377f6f0326433ddd57dc346721
2014-06-27 14:42:19 +01:00
2b9ad2ef6b do what I mean, not what I say
Change-Id: I1c86ff5713401771d6002de0a26bad4430d271fd
2014-06-27 13:31:58 +01:00
d1a185f3af send wheel scroll events of disabled widgets to its enabled parent first
on scrolling with the wheel scroll if the pointer ends up over a disabled
widget then the event doesn't go to its parent and so the scrolling
halts unless the window happens to be the focus window

Change-Id: I57566b5c6e395e0f62d6b928f28e47a0c3486d65
2014-06-27 13:24:38 +01:00
7af733d9ef tweak assert so comment appears in abort message
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
2014-06-27 08:55:56 +01:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
17b1cf0a03 loplugin:staticcall
Change-Id: I16195f2278ae67f17db55e02bb38fe3c5cd063be
2014-06-13 17:54:36 +02:00
f188c982d5 Convert RID_SANE_DIALOG to .ui
Change-Id: I1f08493cdc18f4c0691a8436368432fe4e94dec3
Reviewed-on: https://gerrit.libreoffice.org/9696
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-11 13:27:30 +00:00
c8d8bcf3fd callcatcher: update unused code
Change-Id: Iee19af81c648cb82074d8cabc13716b0d38c7ff6
2014-06-11 10:47:30 +01:00
1817366cb5 gbuild: remove config_libraries.h and gb_Helper_generate_config_libraries
This much ugly complexity, generating a header on every gbuild startup
etc. is really not warranted for 6 callers of the generated macros.
Also, the Win32 make has problems with the quoting.

Change-Id: If945e09c1730e52174a6084677842dc611d66b2f
2014-06-09 17:05:50 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
baf7b38e38 fix Werror 2014-06-07 07:14:39 +02:00
af8ebb607c remove debug output
Change-Id: I7c56adf0cd91f6474145708d91988c974e1ea854
2014-06-07 04:48:16 +02:00