Commit Graph

60 Commits

Author SHA1 Message Date
6e4ab42cd0 Oops, partial revert of 5ba86251c08ea9a9297afd2c1d8f57adaecc3d03
Change-Id: I180aa42ff2d97bad921603c20a0834aa3315526b
2014-08-13 16:23:18 +03:00
5ba86251c0 WaE: C4189: 'isTRUE' : local variable is initialized but not referenced
Change-Id: I84859c105c5f91ec66f075dd96be865ddeb71e33
2014-08-13 16:02:16 +03:00
e094863117 warning C4189: local variable is initialized but not referenced
Change-Id: I255c1e9accad3c48f4151ceda6cec55c6cac4218
2014-08-13 10:10:41 +02:00
c2034f3993 fixincludeguards: fix include guards
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06 19:16:40 +00:00
cc25f70ef1 compareTo -> equals
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
ea6eae7aa1 cppcheck: Variable 'dChildIndex,...' is assigned a value that is never used
Change-Id: Ifa4ea7faa4bcf6580f10c8ece15a01d72f2903f3
2014-05-22 12:50:50 +02:00
a7eae9c280 fix some header guards
Change-Id: Id2c15eba3f70cd8f1ae8869bc0838aef13cd96ee
2014-05-18 14:31:12 +02:00
e9d40e29d1 remove some more external header guards
Change-Id: Ic9efae442fef33c620fbdb1e1c3daef4b64d9780
2014-05-18 12:13:46 +02:00
7249ba6877 remove external header guards
that's the problem with those: none of them was actually defined...

Change-Id: I496140e43cf8ff8a5712394023d98516aaf21adc
2014-05-14 18:12:57 +02:00
820a29950b Many spelling fixes: directories r* - z*.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.

(cherry picked from commit 28206a7cb43aff5adb10f8235ad1680c3941ee3e)

Conflicts:
	include/osl/file.hxx
	include/osl/pipe_decl.hxx
	include/osl/socket.h
	include/osl/socket_decl.hxx
	include/sal/main.h
	include/svx/dbaexchange.hxx
	include/svx/dlgctrl.hxx
	include/svx/msdffdef.hxx
	include/svx/sdr/contact/objectcontactofpageview.hxx
	include/svx/svdpntv.hxx
	include/ucbhelper/content.hxx
	include/ucbhelper/interceptedinteraction.hxx
	include/ucbhelper/resultsethelper.hxx
	include/unotools/sharedunocomponent.hxx
	include/unotools/viewoptions.hxx
	include/vcl/pdfwriter.hxx
	include/xmloff/txtparae.hxx
	include/xmloff/uniref.hxx
	rhino/rhino1_7R3.patch
	rsc/inc/rscrsc.hxx
	sal/inc/osl/conditn.h
	sal/inc/osl/security.h
	sal/inc/osl/semaphor.h
	sal/inc/osl/semaphor.hxx
	sal/inc/rtl/string.hxx
	sal/inc/rtl/tres.h
	sal/inc/systools/win32/StrConvert.h
	sal/osl/os2/file_path_helper.h
	sal/osl/os2/file_path_helper.hxx
	sal/osl/os2/file_url.cxx
	sal/osl/os2/file_url.h
	sal/osl/os2/makefile.mk
	sal/osl/os2/pipe.cxx
	sal/osl/os2/process.c
	sal/osl/os2/profile.c
	sal/osl/os2/socket.c
	sal/osl/os2/system.h
	sal/osl/unx/asm/interlck_sparc.s
	sal/osl/unx/file_url.cxx
	sal/osl/unx/signal.c
	sal/osl/unx/system.h
	sal/osl/w32/MAKEFILE.MK
	sal/osl/w32/interlck.c
	sal/osl/w32/module.cxx
	sal/osl/w32/security.c
	sal/qa/buildall.pl
	sal/qa/osl/file/osl_File.cxx
	sal/qa/osl/module/osl_Module_Const.h
	sal/qa/osl/mutex/osl_Mutex.cxx
	sal/qa/osl/pipe/osl_Pipe.cxx
	sal/qa/osl/process/osl_Thread.cxx
	sal/qa/osl/socket/osl_StreamSocket.cxx
	sal/qa/osl/socket/sockethelper.cxx
	sal/qa/rtl_strings/rtl_OUString.cxx
	sal/rtl/source/unload.cxx
	sal/systools/win32/kill/kill.cxx
	sal/systools/win32/uwinapi/MoveFileExA.cpp
	sal/test/bootstrap.pl
	sal/typesconfig/typesconfig.c
	sal/workben/tgetpwnam.cxx
	sax/inc/sax/parser/saxparser.hxx
	sc/addin/datefunc/dfa.cl
	sc/addin/datefunc/dfa.src
	sc/addin/rot13/rot13.cl
	sc/addin/rot13/rot13.src
	sc/inc/attarray.hxx
	sc/inc/chgtrack.hxx
	sc/inc/column.hxx
	sc/inc/compressedarray.hxx
	sc/inc/document.hxx
	sc/inc/table.hxx
	sc/source/core/data/column.cxx
	sc/source/core/data/dptablecache.cxx
	sc/source/core/data/dptabres.cxx
	sc/source/core/data/dptabsrc.cxx
	sc/source/core/data/global.cxx
	sc/source/core/tool/chgtrack.cxx
	sc/source/core/tool/compiler.cxx
	sc/source/filter/excel/xestyle.cxx
	sc/source/filter/excel/xichart.cxx
	sc/source/filter/inc/fapihelper.hxx
	sc/source/filter/inc/xistyle.hxx
	sc/source/filter/xml/xmlsubti.cxx
	sc/source/ui/Accessibility/AccessibleCell.cxx
	sc/source/ui/Accessibility/AccessibleContextBase.cxx
	sc/source/ui/Accessibility/AccessibleDataPilotControl.cxx
	sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
	sc/source/ui/Accessibility/AccessibleEditObject.cxx
	sc/source/ui/Accessibility/AccessiblePreviewCell.cxx
	sc/source/ui/app/inputwin.cxx
	sc/source/ui/docshell/docfunc.cxx
	sc/source/ui/drawfunc/fupoor.cxx
	sc/source/ui/miscdlgs/linkarea.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	sc/source/ui/unoobj/nameuno.cxx
	sc/source/ui/vba/vbacharacters.hxx
	sc/source/ui/vba/vbarange.cxx
	sc/source/ui/vba/vbawindow.cxx
	scaddins/source/analysis/analysishelper.cxx
	scaddins/source/analysis/analysishelper.hxx
	scaddins/source/datefunc/datefunc.cxx
	scripting/examples/python/Capitalise.py
	scripting/source/pyprov/officehelper.py
	sd/source/filter/eppt/eppt.cxx
	sd/source/filter/eppt/epptso.cxx
	sd/source/ui/dlg/prltempl.cxx
	sd/source/ui/dlg/tpoption.cxx
	sd/source/ui/func/fuediglu.cxx
	sd/source/ui/func/fupoor.cxx
	sd/source/ui/func/fusel.cxx
	sd/source/ui/func/smarttag.cxx
	sd/source/ui/inc/OutlinerIteratorImpl.hxx
	sd/source/ui/inc/SlideViewShell.hxx
	sd/source/ui/inc/fuediglu.hxx
	sd/source/ui/inc/fusel.hxx
	sd/source/ui/slideshow/slideshowimpl.cxx
	sd/source/ui/slidesorter/cache/SlsQueueProcessorThread.hxx
	sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx
	sd/source/ui/slidesorter/controller/SlsSelectionCommand.hxx
	sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx
	sd/source/ui/slidesorter/view/SlsButtonBar.cxx
	sd/source/ui/view/Outliner.cxx
	sd/source/ui/view/drviewsh.cxx
	sd/source/ui/view/frmview.cxx
	sdext/source/presenter/PresenterFrameworkObserver.hxx
	sdext/source/presenter/PresenterSlideShowView.cxx
	setup_native/scripts/deregister_extensions
	setup_native/scripts/register_extensions
	setup_native/source/opensolaris/bundledextensions/README
	setup_native/source/opensolaris/bundledextensions/svc-ooo_bundled_extensions
	setup_native/source/win32/customactions/patch/swappatchfiles.cxx
	setup_native/source/win32/customactions/reg4msdoc/registrar.cxx
	setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx
	sfx2/inc/sfx2/sfxbasemodel.hxx
	sfx2/qa/complex/sfx2/DocumentProperties.java
	sfx2/source/appl/appopen.cxx
	sfx2/source/appl/appquit.cxx
	sfx2/source/appl/appserv.cxx
	sfx2/source/bastyp/sfxhtml.cxx
	sfx2/source/dialog/dockwin.cxx
	sfx2/source/doc/docfile.cxx
	sfx2/source/doc/docvor.cxx
	sfx2/source/doc/graphhelp.cxx
	sfx2/source/doc/objcont.cxx
	sfx2/source/doc/objserv.cxx
	sfx2/source/doc/objstor.cxx
	sfx2/source/doc/objuno.cxx
	sfx2/source/doc/objxtor.cxx
	sfx2/source/doc/printhelper.cxx
	sfx2/source/doc/sfxbasemodel.cxx
	sfx2/source/notify/eventsupplier.cxx
	sfx2/source/view/frmload.cxx
	sfx2/source/view/sfxbasecontroller.cxx
	shell/qa/zip/ziptest.cxx
	shell/source/backends/wininetbe/wininetbackend.cxx
	shell/source/win32/shlxthandler/util/utilities.cxx
	solenv/bin/build.pl
	solenv/bin/build_release.pl
	solenv/bin/cws.pl
	solenv/bin/download_external_dependencies.pl
	solenv/bin/make_download.pl
	solenv/bin/make_installer.pl
	solenv/bin/modules/Cws.pm
	solenv/bin/modules/ExtensionsLst.pm
	solenv/bin/modules/installer/control.pm
	solenv/bin/modules/installer/downloadsigner.pm
	solenv/bin/modules/installer/javainstaller.pm
	solenv/bin/modules/installer/packagepool.pm
	solenv/bin/modules/installer/patch/InstallationSet.pm
	solenv/bin/modules/installer/scriptitems.pm
	solenv/bin/modules/installer/windows/feature.pm
	solenv/bin/modules/installer/windows/msiglobal.pm
	solenv/bin/modules/installer/windows/sign.pm
	solenv/bin/modules/installer/worker.pm
	solenv/bin/modules/installer/xpdinstaller.pm
	solenv/bin/modules/osarch.pm
	solenv/bin/modules/packager/work.pm
	solenv/bin/modules/pre2par/parameter.pm
	solenv/bin/patch_tool.pl
	solenv/bin/transform_description.pl
	solenv/doc/gbuild/doxygen.cfg
	solenv/gbuild/LinkTarget.mk
	solenv/gbuild/gbuild.mk
	solenv/inc/os2gcci.mk
	solenv/inc/settings.mk
	solenv/inc/startup/Readme
	solenv/inc/target.mk
	solenv/inc/tg_compv.mk
	solenv/inc/tg_javav.mk
	solenv/inc/unitools.mk
	solenv/inc/unxbsdi.mk
	solenv/inc/unxbsdi2.mk
	solenv/inc/unxbsds.mk
	solenv/inc/unxfbsd.mk
	solenv/inc/unxlng.mk
	sot/source/sdstor/stg.cxx
	sot/source/sdstor/stgelem.cxx
	sot/source/sdstor/ucbstorage.cxx
	starmath/inc/toolbox.hxx
	starmath/source/mathmlexport.cxx
	starmath/source/node.cxx
	starmath/source/toolbox.cxx
	starmath/source/view.cxx
	stoc/source/bootstrap/bootstrap.xml
	stoc/source/corereflection/criface.cxx
	stoc/source/invocation/invocation.cxx
	stoc/source/security/access_controller.cxx
	stoc/source/servicemanager/servicemanager.cxx
	stoc/source/tdmanager/tdmgr.cxx
	stoc/test/javavm/testjavavm.cxx
	stoc/test/testconv.cxx
	stoc/test/testcorefl.cxx
	stoc/test/testintrosp.cxx
	svl/inc/svl/inettype.hxx
	svl/inc/svl/urihelper.hxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.cxx
	svl/qa/complex/ConfigItems/helper/HistoryOptTest.hxx
	svl/source/config/itemholder2.hxx
	svl/source/items/itemset.cxx
	svl/source/numbers/zforlist.cxx
	svl/source/numbers/zformat.cxx
	svl/source/numbers/zforscan.cxx
	svtools/bmpmaker/bmp.cxx
	svtools/inc/svtools/helpagentwindow.hxx
	svtools/inc/svtools/menuoptions.hxx
	svtools/inc/svtools/miscopt.hxx
	svtools/inc/svtools/optionsdrawinglayer.hxx
	svtools/inc/svtools/stringtransfer.hxx
	svtools/inc/svtools/svlbitm.hxx
	svtools/inc/svtools/svtdata.hxx
	svtools/inc/svtools/valueset.hxx
	svtools/source/brwbox/editbrowsebox.cxx
	svtools/source/config/itemholder2.hxx
	svtools/source/contnr/contentenumeration.hxx
	svx/inc/svx/fmsrcimp.hxx
	svx/inc/svx/svdobj.hxx
	svx/inc/svx/xtable.hxx
	svx/source/accessibility/DGColorNameLookUp.cxx
	svx/source/accessibility/svxrectctaccessiblecontext.cxx
	svx/source/dialog/pfiledlg.cxx
	svx/source/fmcomp/fmgridcl.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/fmcomp/gridctrl.cxx
	svx/source/form/filtnav.cxx
	svx/source/form/fmPropBrw.cxx
	svx/source/form/fmshimp.cxx
	svx/source/form/fmsrcimp.cxx
	svx/source/gallery2/galtheme.cxx
	svx/source/inc/docrecovery.hxx
	svx/source/sdr/event/eventhandler.cxx
	svx/source/svdraw/svdedtv2.cxx
	svx/source/svdraw/svdedxv.cxx
	svx/source/svdraw/svdhdl.cxx
	svx/source/svdraw/svdobj.cxx
	svx/source/svdraw/svdograf.cxx
	svx/source/svdraw/svdoole2.cxx
	svx/source/svdraw/svdotxtr.cxx
	svx/source/svdraw/svdundo.cxx
	svx/source/svdraw/svdxcgv.cxx
	svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx
	sw/inc/SwNumberTree.hxx
	sw/inc/ndnotxt.hxx
	sw/source/core/access/acccell.cxx
	sw/source/core/access/acccell.hxx
	sw/source/core/access/accframebase.cxx
	sw/source/core/access/accframebase.hxx
	sw/source/core/access/accmap.cxx
	sw/source/core/access/accpage.cxx
	sw/source/core/access/accpage.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/access/accpara.hxx
	sw/source/core/bastyp/swrect.cxx
	sw/source/core/crsr/findtxt.cxx
	sw/source/core/doc/docdde.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/docnode/section.cxx
	sw/source/core/draw/dcontact.cxx
	sw/source/core/edit/edlingu.cxx
	sw/source/core/inc/anchoredobjectposition.hxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/layout/tabfrm.cxx
	sw/source/core/layout/trvlfrm.cxx
	sw/source/core/ole/ndole.cxx
	sw/source/core/text/atrstck.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/itratr.cxx
	sw/source/core/text/itrform2.cxx
	sw/source/core/text/itrform2.hxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/thints.cxx
	sw/source/core/txtnode/txtedt.cxx
	sw/source/core/uibase/dochdl/swdtflvr.cxx
	sw/source/core/uibase/docvw/PostItMgr.cxx
	sw/source/core/uibase/docvw/SidebarWin.cxx
	sw/source/core/uibase/docvw/edtwin.cxx
	sw/source/core/uibase/envelp/labimg.cxx
	sw/source/core/uibase/uiview/pview.cxx
	sw/source/core/uibase/uno/unomailmerge.cxx
	sw/source/core/undo/unattr.cxx
	sw/source/core/undo/untbl.cxx
	sw/source/core/unocore/unochart.cxx
	sw/source/core/view/vdraw.cxx
	sw/source/core/view/vnew.cxx
	sw/source/filter/basflt/fltini.cxx
	sw/source/filter/html/wrthtml.cxx
	sw/source/filter/inc/wwstyles.hxx
	sw/source/filter/rtf/rtffly.cxx
	sw/source/filter/rtf/swparrtf.cxx
	sw/source/filter/ww8/docxattributeoutput.cxx
	sw/source/filter/ww8/dump/msvbasic.cxx
	sw/source/filter/ww8/dump/ww8scan.cxx
	sw/source/filter/ww8/dump/ww8scan.hxx
	sw/source/filter/ww8/dump/ww8struc.hxx
	sw/source/filter/ww8/wrtww8.cxx
	sw/source/filter/ww8/ww8graf.cxx
	sw/source/filter/ww8/ww8par.cxx
	sw/source/filter/ww8/ww8par2.cxx
	sw/source/filter/ww8/ww8par2.hxx
	sw/source/filter/ww8/ww8par3.cxx
	sw/source/filter/ww8/ww8par6.cxx
	sw/source/filter/ww8/ww8scan.cxx
	sw/source/filter/ww8/ww8scan.hxx
	sw/source/ui/dbui/dbinsdlg.cxx
	sw/source/ui/inc/tablemgr.hxx
	sw/source/ui/inc/uitool.hxx
	sw/source/ui/lingu/olmenu.cxx
	sw/source/ui/uiview/viewport.cxx
	sysui/desktop/productversion.mk
	sysui/desktop/slackware/makefile.mk
	testgraphical/source/CallExternals.pm
	testgraphical/source/fill_documents_loop.pl
	testgraphical/ui/java/ConvwatchGUIProject/src/IniFile.java
	toolkit/doc/layout/notes.txt
	toolkit/doc/layout/oldnotes.txt
	toolkit/source/awt/vclxtabcontrol.cxx
	toolkit/src2xml/source/srcparser.py
	toolkit/workben/layout/editor.cxx
	tools/inc/tools/simplerm.hxx
	tools/inc/tools/solar.h
	tools/source/communi/geninfo.cxx
	tools/source/fsys/dirent.cxx
	tools/source/fsys/filecopy.cxx
	tools/source/fsys/os2.cxx
	tools/source/inet/inetmime.cxx
	tools/source/rc/resmgr.cxx
	ucb/source/core/ucbcmds.cxx
	ucb/source/ucp/file/filglob.cxx
	ucb/source/ucp/odma/odma_content.cxx
	ucb/source/ucp/tdoc/ucptdoc.xml
	ucb/source/ucp/webdav/makefile.mk
	ucbhelper/inc/ucbhelper/simplecertificatevalidationrequest.hxx
	ucbhelper/source/client/content.cxx
	ucbhelper/source/client/interceptedinteraction.cxx
	udkapi/com/sun/star/beans/XPropertiesChangeListener.idl
	udkapi/com/sun/star/io/ObjectOutputStream.idl
	udkapi/com/sun/star/io/XMarkableStream.idl
	udkapi/com/sun/star/io/XTextOutputStream.idl
	udkapi/com/sun/star/reflection/CoreReflection.idl
	udkapi/com/sun/star/reflection/XTypeDescriptionEnumerationAccess.idl
	udkapi/com/sun/star/test/XSimpleTest.idl
	unodevtools/source/skeletonmaker/skeletoncommon.cxx
	unodevtools/source/skeletonmaker/skeletoncommon.hxx
	unotools/inc/unotools/cacheoptions.hxx
	unotools/inc/unotools/cmdoptions.hxx
	unotools/inc/unotools/dynamicmenuoptions.hxx
	unotools/inc/unotools/extendedsecurityoptions.hxx
	unotools/inc/unotools/fontoptions.hxx
	unotools/inc/unotools/historyoptions.hxx
	unotools/inc/unotools/idhelper.hxx
	unotools/inc/unotools/internaloptions.hxx
	unotools/inc/unotools/localisationoptions.hxx
	unotools/inc/unotools/moduleoptions.hxx
	unotools/inc/unotools/printwarningoptions.hxx
	unotools/inc/unotools/securityoptions.hxx
	unotools/inc/unotools/startoptions.hxx
	unotools/inc/unotools/workingsetoptions.hxx
	unotools/source/config/cmdoptions.cxx
	unotools/source/config/compatibility.cxx
	unotools/source/config/configitem.cxx
	unotools/source/config/configmgr.cxx
	unotools/source/config/dynamicmenuoptions.cxx
	unotools/source/config/fontcfg.cxx
	unotools/source/config/itemholder1.hxx
	unotools/source/config/moduleoptions.cxx
	unotools/source/config/pathoptions.cxx
	unotools/source/config/viewoptions.cxx
	unotools/source/misc/sharedunocomponent.cxx
	uui/source/fltdlg.cxx
	uui/source/iahndl-filter.cxx
	vbahelper/inc/vbahelper/collectionbase.hxx
	vbahelper/source/msforms/vbacontrol.cxx
	vbahelper/source/vbahelper/collectionbase.cxx
	vcl/aqua/source/gdi/atsfonts.cxx
	vcl/inc/aqua/salmathutils.hxx
	vcl/inc/graphite_cache.hxx
	vcl/inc/jobset.h
	vcl/inc/os2/salgdi.h
	vcl/inc/osx/saldata.hxx
	vcl/inc/salgdi.hxx
	vcl/inc/salwtype.hxx
	vcl/inc/unx/wmadaptor.hxx
	vcl/inc/vcl/print.hxx
	vcl/inc/vcl/strhelper.hxx
	vcl/os2/source/app/salinst.cxx
	vcl/os2/source/app/saltimer.cxx
	vcl/os2/source/gdi/salgdi2.cxx
	vcl/osx/salframeview.mm
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/dndtest.cxx
	vcl/source/app/dbggui.cxx
	vcl/source/control/ilstbox.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/outdev4.cxx
	vcl/source/gdi/outdev6.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/pdfwriter_impl2.cxx
	vcl/source/gdi/print.cxx
	vcl/source/gdi/print2.cxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/source/window/printdlg.cxx
	vcl/source/window/tabdlg.cxx
	vcl/source/window/window.cxx
	vcl/source/window/winproc.cxx
	vcl/unx/generic/app/saldisp.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/gtk/app/gtkdata.cxx
	vcl/win/source/gdi/salgdi2.cxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/window/salframe.cxx
	vos/inc/vos/pipe.hxx
	vos/inc/vos/process.hxx
	vos/inc/vos/signal.hxx
	vos/inc/vos/socket.hxx
	vos/inc/vos/thread.hxx
	vos/source/pipe.cxx
	vos/source/socket.cxx
	wizards/com/sun/star/wizards/agenda/AgendaTemplate.java
	wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java
	wizards/com/sun/star/wizards/agenda/TopicsControl.java
	wizards/com/sun/star/wizards/web/FTPDialog.java
	wizards/com/sun/star/wizards/web/ImageListDialog.java
	wizards/com/sun/star/wizards/web/Process.java
	wizards/com/sun/star/wizards/web/ProcessStatusRenderer.java
	wizards/com/sun/star/wizards/web/TOCPreview.java
	wizards/com/sun/star/wizards/web/WWD_Startup.java
	wizards/com/sun/star/wizards/web/data/TypeDetection.java
	wizards/com/sun/star/wizards/web/export/ImpressHTMLExporter.java
	writerfilter/inc/doctok/WW8Document.hxx
	writerfilter/source/dmapper/DomainMapper.cxx
	writerfilter/source/dmapper/NumberingManager.cxx
	writerfilter/source/dmapper/PropertyMap.cxx
	writerfilter/source/dmapper/StyleSheetTable.cxx
	writerfilter/source/doctok/WW8StructBase.hxx
	writerfilter/source/doctok/resources.xmi
	writerfilter/source/ooxml/README.efforts
	xmerge/source/activesync/XMergeFilter.cpp
	xmerge/source/minicalc/java/org/openoffice/xmerge/converter/xml/sxc/minicalc/SxcDocumentDeserializerImpl.java
	xmerge/source/palmtests/qa/comparator/pdbcomparison.java
	xmerge/source/palmtests/qa/test_spec/convertor_test_spec.html
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java
	xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java
	xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDescriptor.java
	xmerge/workben/jstyle.pl
	xmlhelp/source/cxxhelp/provider/databases.hxx
	xmlhelp/source/cxxhelp/provider/provider.cxx
	xmlhelp/source/treeview/tvread.cxx
	xmloff/inc/txtfldi.hxx
	xmloff/inc/xmloff/xmlmultiimagehelper.hxx
	xmloff/inc/xmloff/xmluconv.hxx
	xmloff/source/core/xmlexp.cxx
	xmloff/source/draw/shapeexport2.cxx
	xmloff/source/draw/shapeexport3.cxx
	xmloff/source/meta/xmlversion.cxx
	xmloff/source/style/impastp4.cxx
	xmloff/source/style/xmlaustp.cxx
	xmloff/source/text/XMLSectionExport.cxx
	xmloff/source/text/txtflde.cxx
	xmloff/source/text/txtimp.cxx
	xmloff/source/text/txtparae.cxx
	xmloff/source/text/txtparai.cxx
	xmloff/source/text/txtvfldi.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx

Change-Id: Ie072e7c3a60c5dae16a67ac36d1f372c5065c99c
2014-05-01 08:59:14 +01:00
b25c29389e Remove visual noise from winaccessibility
Change-Id: If8ac2543e3dca393e14380a85547cafbb68ab8c6
Reviewed-on: https://gerrit.libreoffice.org/8340
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05 08:22:13 -06:00
09155190d8 Variable not used but remove some wrong characters
Change-Id: I2206225309becff134e8f719959d976f71fcde27
2014-03-01 23:17:02 +01:00
2bb87dd659 fdo#39944: Add DOCUMENT_* accessibility UNO roles
Added a set of UNO accessibility roles for specific kinds of
documents:
 * DOCUMENT_PRESENTATION for Impress
 * DOCUMENT_SPREADSHEET for Calc
 * DOCUMENT_TEXT for Writer

The other applications still use the existing DOCUMENT role.

These roles translates directly to ATK but in the other toolkits we
keep using the same association that DOCUMENT role had.

Change-Id: Ibac47527e5effdecb28d2314cde8558cf4fb010a
Reviewed-on: https://gerrit.libreoffice.org/7847
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-02-04 13:08:57 +00:00
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
c1503da35d Typo decendant => descendant in winaccessibility/MAccessible
Change-Id: I2e49ab149b2bbdad623f8694221b6169cdfd2d9a
2014-01-27 23:47:24 +01:00
7f2a2d2b05 fdo#73464 - get relation BSTR allocation right.
Change-Id: I270bc9c8e0507f44d2c27639e86002c60f4e2e6d
2014-01-27 18:01:05 +00:00
44064d1a34 fdo#73464 - guard against NULL / unset m_xAccessible.
Change-Id: I3351acf18d334447336ee98761190fdff32d5b85
2014-01-27 12:15:20 +00:00
ff8cb18e21 Resolves: #i124095# Multiple IAccessible and IAccessible2...
interface methods do not check for NULL pointer access, nor do they trap
exceptions

Fixed by Michael Curran
(cherry picked from commit 113171f2a5d726af6c5266e98e8e790ac6729d2d)

Conflicts:
	winaccessibility/source/UAccCOM/MAccessible.cxx

Change-Id: I28d4b885a6c2db487c2754c2ca11290b3844570b
2014-01-27 11:44:40 +00:00
bcfd016c88 some notes about COM threading in LO generally and winaccessibility
- document general COM threading architecture in vcl README
- document winaccessiblitiy locking in README
- define _ATL_APARTMENT_THREADED for UAccCOM

Change-Id: I7c3fd952f2cdee7d245a818bf33c477e7ea20fc2
2014-01-09 13:44:24 +01:00
6242f8262f Initialize m_containedObjects
(cherry picked from commit 795b3bb9e59c9bf049d27538c860cd66633dddcf)

Change-Id: I45e495ad8b3513613102b7ce7777803303980fbe
2014-01-06 09:25:38 +00:00
fdd76463b4 winaccessibility: remove some noise from not-implemented methods
Change-Id: I8046ae37cba87f0e5df550de831229345df1c6f8
2013-12-12 20:06:27 +01:00
57acb3d068 winaccessibility: out-line those COM methods
Change-Id: I7e9a94898c6bc8142b46a05ffba56fc41eb125c2
2013-12-12 20:06:27 +01:00
506bab8f62 winaccessibility: GetChildInterface may return 0
Change-Id: I950072d22cd315d1898b76a2c345121d31d432c4
2013-12-12 20:06:26 +01:00
b6664d0649 winaccessibility: nobody calls get_XInterface
Change-Id: I201fc14a02c47a6c735c65f649c6b9f068d92c71
2013-12-12 20:06:26 +01:00
d28687d517 winaccessibility: fix locking in UAccCOM
The COM components will (usually? always?) be called on the main thread
via COM, and may also be called on any thread from the UNO event
listeners.  Both ways may access the global AccWinObjectManager.
So the easiest way to lock all that without introducing new deadlocks
seems to be to just use the SolarMutex.

The fact that the main thread is in a COM STA is rather irrelevant here
since we don't currently do the required manual marshalling of the COM
pointers so they can be accessed from UNO event listeners running in
threads other than the main thread anyway.

To get that to build:
- use prewin.h and postwin.h around ATL headers
- link UAccCOM against vcl
- define both UNICODE and _UNICODE to not break on mis-matching TCHAR
  nonsense

Change-Id: I1ccdf7a4a5c2b5f0b9c29ef39d126c4b8a16898a
2013-12-12 20:06:26 +01:00
dd7df93417 winaccessibility: remove CheckEnableAccessible.h and assorted noise
Change-Id: I45e1d72b1abf64a965397c50ac3b95b5bbee3206
2013-12-12 20:06:25 +01:00
cbda6da004 winaccessibility: InlineIsEqualGUID is defined by guiddef.h
Change-Id: Ia469076ec6f815133e77a14940e8afa05e177231
2013-12-12 20:06:25 +01:00
a5c7ed2158 winaccessibility: use SAL_N_ELEMENTS
Change-Id: I479117e0794375f1ec0c96b78db22b3569b456ec
2013-12-12 20:06:24 +01:00
9d71c9a442 winaccessibility: clean up the AGGMAP in CMAccessible
Replace it with a map for the new direct C++ instantiation and move this
implementation detail to the cxx file.

Change-Id: Ia961da03f8eb899481cf02f430c921aa8abd7c5c
2013-12-12 20:06:24 +01:00
a0a903892c Avoid multiple definitions of two lovingly copy-pasted functions
Multple external definitions of a symbol causes problems when linking
statically, as for Android. Just make the functions static for now, as they
are only used locally in the files where defined anyway.

Change-Id: I8ddbaf01497c171bed4e15f6183ba43461c672d1
2013-12-05 18:11:09 +02:00
a718fef094 Use our header guard convention
Using identifiers starting with underscores is questionable even if they don't
happen to clash with anything used by the language implementation.

Change-Id: I0af605d40d85ea7e47e1047572fbe180270e08ac
2013-12-03 13:37:37 +02:00
b54d441ad7 Revert "winaccessibility: let CoCreateInstance calls find the components"
This only works partially: the ClassObjects are only registered on the
main thread; CoCreateInstance on other threads still fails.

This reverts commit 29c6216af8c502f220bb84857d3dda901ddfd234.
2013-12-02 13:18:03 +01:00
d0e8e6e3cd winaccessibility: fix my stupid mistake in createAggInstance
Change-Id: I7701021befcf1dbad85557c2095fe4bf0b4e0ff1
2013-12-02 13:18:03 +01:00
455c39645e winaccessibility: remove all Registry content/registration code
There is no need to register UAccCOM.

Change-Id: I37f5c4030abefbd18b6686652a348bc20a05a9db
2013-11-28 00:59:46 +01:00
5e7b29e642 winaccessibility: remove obsolete act.hxx
... obsoleted by 732ec36edfd09d2091d70c4d71b5f182fe279c45

Change-Id: I7f7a9becac2430a7ed4d096be741b610462a8a00
2013-11-28 00:52:21 +01:00
3b86569fcb winaccessibility: replace CoCreateInstance with direct instantiation
This is an alternative (to 732ec36edfd09d2091d70c4d71b5f182fe279c45)
solution to the "CoCreateInstance does not work" problem:
replace all CoCreateInstance calls with equivalent calls to create
the components directly.

Since the only reason why this COM stuff needs to be registered
at all is that AccObject uses CoCreateInstance() to create its
COM objects, another possible solution appears to be to simply link
the libraries and instantiate the COM objects directly, without COM.

The only difference appears to be that CoCreateInstance would
automatically add proxy objects in case the COM objects reside in a
single-threaded appartment; not sure if that is relevant here.

Change-Id: I8ffb8af501f6084f3145fa4d4f53366a070e1691
Reviewed-on: https://gerrit.libreoffice.org/6792
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2013-11-25 03:21:30 -06:00
732ec36edf winaccessibility: let CoCreateInstance calls find the components
The COM services are not found because they are not registered in the
registry via regsvr32 (doing that is unnecessary since the components
are only instantiated by winaccessibility code and undesirable since
that would likely register the IAccessible2 types too, breaking A11y
tools) and the special manifest resource #97 that ActivateActContext()
tries to load does not exist in UAccCOM.dll; this would need to be a
XML manifest, the *.rgs and *.tlb that are already included as
individual resources won't work.

After reading ATL headers for hours it is immediately obvious that the
COM components can simply be registered by a call to
CComModule::RegisterClassObjects() from DllMain; this just requires
actually loading the UAccCOM library from somewhere so the DllMain runs.

Change-Id: Id58b754835cd2f1bcada37e5639a6b6042a42fd5
2013-11-24 01:02:46 +01:00
d04c970e8f winaccessibility: fix some error handling in CAccTable
Change-Id: I3c8bc6a476a6254a4ddc3a7cb0585544f3f78431
2013-11-24 01:00:53 +01:00
a5e281ff04 winaccessibility: make XAccessibleAction member Reference
Maybe it would be kept alive by AccObject::m_AccActionRef but why not
play it safe.

Change-Id: I03c2be04e97dcde8a177ef8dfd0d75595ab13a53
2013-11-24 01:00:53 +01:00
58ab523986 winaccessibility: CMAccessible needs only one XAccessibleContext
Merge aliases pRContextInterface (unused) and pRContext; this is
exacerbated by countless local variables pRContext that shadow the
member...

Change-Id: I6bc71911fb41a2ce2590d614020ecea36d6ab4f8
2013-11-24 01:00:53 +01:00
fd2877ee09 winaccessibility: CMAccessible needs only one member for XAccessible
Merge aliases pUNOInterface and pRef; also pAchorUNOInterface is never
used.

Change-Id: I1b3841a9aca9d2438b25c66c7f67d09ce13b41f9
2013-11-24 01:00:53 +01:00
89633c6da1 remove unnecessary use of OUString::createFromAscii
Convert code like this:
    OUString aStrSpacing(OUString::createFromAscii("spacing"));
to:
    OUString aStrSpacing("spacing");

Change-Id: Ia2b7d6b42f35d33cfe587a0d6668030f3537fa6d
2013-11-21 13:29:29 +02:00
a36d446591 winaccessibility: fix even more pointless HWND to long casting
Change-Id: I16a39a0dde27b17f1467a9605a4566b05f53a485
2013-11-21 00:41:09 +01:00
77f94ded7a winaccessibility: pass pointers as "hyper" in the COM IDL
Change-Id: I083589fd57540e3b4ec488aeb84bc92dddc02d36
2013-11-21 00:41:09 +01:00
72365491e3 Use <windows.h> with a lower-case 'w' for cross-compilation goodness
Change-Id: Ia7ec6c4e9808a379e955a013264e1f92a7f6a358
2013-11-20 18:40:49 +02:00
996a993556 winaccessibility: CHILDID_SELF already defined by some windows header
... so no need to define it ourselves, much less 3 times.

Change-Id: I92c05849452fa2516ec09bc5789617df3b743f8d
2013-11-20 01:33:41 +01:00
3af0afba65 winaccessibility: remove UAccCOM2.h
At least with MSVC2012 there is no warning C4917 here.

Change-Id: I8de6cfc33791b1bb5e2b7808e306f733cf8cfcb5
2013-11-20 01:33:41 +01:00
753b3cbb8b winaccessibility: remove "using" from headers
Change-Id: I212c1f3449416ff3629a677112fc5a4702e89eb0
2013-11-20 01:33:41 +01:00