Commit Graph

3009 Commits

Author SHA1 Message Date
670f472e13 wizards: fix javadoc error: bad use of '>'
Change-Id: Ide61f9ed907e8896ccb64b6c69b3a43068658ace
Reviewed-on: https://gerrit.libreoffice.org/11237
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:17:50 -05:00
f09d060b1b wizards: fix javadoc error: self-closing element not allowed
Change-Id: I1ffe498da5fa1410832312b38343aae7bca77203
Reviewed-on: https://gerrit.libreoffice.org/11236
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:14:25 -05:00
ee82777c74 wizards: fix javadoc error: text not allowed in <ul> element
Change-Id: Ic50f9618c2649fe3e0fbbf2db6a09ea2e1d4c810
Reviewed-on: https://gerrit.libreoffice.org/11239
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:07:05 -05:00
a4a6153e25 wizards: fix javadoc error: unknown tag: returns
Change-Id: I3d10c48a5fac2683f76cf21ef5c746377ca9a8c4
Reviewed-on: https://gerrit.libreoffice.org/11238
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:06:27 -05:00
219ee12ffa wizards: fix javadoc error: unknown tag: list
Change-Id: I293b4fc2c2e0ff4fd591389419f36f04e87c59a1
Reviewed-on: https://gerrit.libreoffice.org/11235
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:05:36 -05:00
610cfb3771 java: fix reportbuilder and wizard
which I broke in commits
70f56bc22fe95 "java: reduce scope, make member classes private"
and
34bcf9b498b "java: remove dead methods"

Change-Id: Id21482782bbc102e60f346a2bf51096af2fcbe22
2014-08-29 13:14:58 +02:00
dfb48f77ba increment SBCOUNTRYCOUNT again, we have 19 currencies 0..18
Apparently this seems to have been forgotten at one occasion.

Change-Id: I1436e412c1308f451d9d953f432a9887cfc99b59
2014-08-26 23:53:30 +02:00
99e1b398f2 ditch unused sCurrUNKNOWN and sCurrSYSUNKNOWN strings
Apart from that they weren't currencies and only in the way when adding
a new currency.

Change-Id: If8ca3ab3b37f3617c3f73a01428c0c30dd3481d7
2014-08-26 23:53:29 +02:00
375228c2c8 adapt SBCOUNTRYCOUNT
Change-Id: Iadf4ae9a569388528f1083c22d6ff197d6479ba9
2014-08-26 23:53:28 +02:00
0b3e1d9b22 added LTL Lithuanian Litas to Euro Converter
Change-Id: Id4eeb42bbbaec979f60b57ddab2794b38f1e3157
Reviewed-on: https://gerrit.libreoffice.org/11090
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:29:42 -05:00
fbbd7045a8 Access2Base - Removal of Property Set constructions
The workaround to bug https://www.libreoffice.org/bugzilla/show_bug.cgi?id=60752 has been removed.
Bug corrected in LO 4.0.2
End of support of Access2Base under LO 4.0.0 and 4.0.1

Change-Id: Ide5046ce4a44096bca42eaf14c4dc96c59958e16
2014-08-23 12:42:57 +02:00
9e8b930b13 Dispose() method for all objects
An implicit (Terminate_Class) and an explicit (Dispose) method have been created
to stimulate better memory management.

Change-Id: I240e5117db6bf0d1fcf268e3ddf6d67e0bc1b8eb
2014-08-23 12:16:53 +02:00
1cbd9f7fbe Access2Base - Remove _This in Form and SubForm objects
The construction in Basic
	Set a._This = a
is useful to export the address of an object to Subs or Functions.
It increases however the risk of memory leaks.
Avoid when avoidable.

Change-Id: I81bf01badf00687526a358eda117a55b12f5d72b
2014-08-22 15:34:58 +02:00
d14a4dc996 wizards: Enhancements in JavaTools.java
Change-Id: Ie25b4772b34170b8ea200f1bfe6884feac49a414
Reviewed-on: https://gerrit.libreoffice.org/11049
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-21 08:05:56 -05:00
e189fa400e wizards: EffectiveMax & EffectiveMin of TINYINT
http://docs.oracle.com/javase/1.5.0/docs/api/constant-values.html#java.lang.Byte.MIN_VALUE

Change-Id: I702f1354eaddc37e6321c3cdc0126a78945d0754
Reviewed-on: https://gerrit.libreoffice.org/11044
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-21 01:52:11 -05:00
e5070e0cc2 wizards: Number parsing
Change-Id: If81db8cf10556dbb79458258a70760e3f12a5524
Reviewed-on: https://gerrit.libreoffice.org/11041
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 09:09:21 -05:00
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
2922a967a1 java: Avoid naming non-fields with the prefix m_
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
c552aac9f8 java: use 'Byte.valueOf' instead of 'new Byte'
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19 14:57:18 +02:00
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
1e6f0b2d8b simplify CallFormWizard
Change-Id: I0dfdc1acb0b550c1eeed16498f3e791e0123c4eb
2014-08-19 14:57:16 +02:00
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
f8ce2e049c coverity#983635 Uncaught exception
Change-Id: I4be3600af6ee97ba9f962edf9723c04d89b161e4
2014-08-17 16:39:21 +01:00
8393014898 Access2Base - non-Base components
So far the first call to the API was a call to the OpenConnection method.
Without an OpenConnection some methods issued a cryptic "Object variable not set" Basic run-time message.
It is now intercepted to make it clearer.

A number of features are not database related: error handling, events handling, windows move/resize, dialogs, ...
They have been identified and adapted to be callable without database connection.
As such they are callable from any LO component, not only Base.

Change-Id: I99f408c8404a6192149747228b2b8493b9df5ae3
Reviewed-on: https://gerrit.libreoffice.org/10883
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
2014-08-17 06:18:45 -05:00
0d916bb240 java: remove unused imports
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
5ce80c9728 remove dead java constants
found by UCDetector

Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13 13:34:43 +02:00
4a4127d2c4 make some java methods private
found by UCDetector

Change-Id: Ic2edbc85194731116aac34064238d11ef1926a98
2014-08-13 13:34:43 +02:00
5ca7fa8db2 make some java fields private
found by UCDetector

Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13 13:34:42 +02:00
34bcf9b498 java: remove dead methods
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
d01a7e7440 java: remove unused member class
found by UCDetector

Change-Id: Id02478d3d151bd01cea50aeb454c02c2bc4d1baf
2014-08-13 09:44:17 +02:00
4155c28ae1 java: remove unused interfaces
found by UCDetector

Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
2014-08-13 09:44:17 +02:00
8583da1e93 java: remove unused fields
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
68cd011c90 java: reduce scope, make some methods private
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f java: reduce scope, make member classes private
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
2b3a801014 java: reduce scope, make some interfaces private
found by UCDetector

Change-Id: I4e1051c041e62b8317b10a5d7d990c77b1acddf9
2014-08-13 08:49:23 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4 java: reduce scope, make constructors private
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
e701b3f732 java: reduce scope, make constants private
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00
1c496506bc java: remove useless javadoc tags
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
76c1092016 java: remove unused parameters
Change-Id: I9ae22afc27ac0d2051f06885f363845e9b4ce2ff
2014-08-11 12:33:03 +02:00
ebe8dbe0fd java: remove unused methods
Change-Id: I1abc51f66bc7d7f7135bf5cdee4fae653b2837ec
2014-08-11 12:33:03 +02:00
d5a31b2215 java: remove unused parameters
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
41709cc268 java: remove unused parameters
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00