Commit Graph

1383 Commits

Author SHA1 Message Date
62962557ba coverity#1215310 Uncaught exception
Change-Id: Ie08163875b1190532b9892c60829bb0ade56cbd7
2014-09-02 12:14:47 +01:00
7bac68d79e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Id03c16337cb637c7f63fb789697c8bceec905bda
2014-08-28 16:17:35 +02:00
5f07347061 convert RID_XMLSECWB_NO_MOZILLA_PROFILE to MessageDialog + string
Change-Id: I7e02dc9db8c6a3195a4b2adccea3d0f4e260c661
2014-08-25 16:45:30 +01:00
b13936abe9 QueryBox MSG_XMLSECDLG_QUERY_REMOVEDOCSIGNBEFORESIGN -> MessageDialog + string
Change-Id: I9dcbc271dac9a2395bf2a7adb160c965627a0277
2014-08-22 08:54:32 +01:00
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
0771823d80 fix build
Change-Id: If2f35d4ce68f604db1789e1535c341908628838d
2014-08-16 00:52:41 +02:00
0494f0029f ErrorBox RID_XMLSECDLG_OLD_ODF_FORMAT to String
Change-Id: I474efcf128b990d148584292422cefa71a3c3c76
2014-08-15 23:30:19 +02:00
8848f4e8c2 xmlsecurity: remove NSS cert.h from PCH
nssrenam.h is another horror...

Change-Id: I166ac2ab1414e89d5cd4beae543670fdfa389adb
2014-08-14 18:55:18 +02:00
13d4f7b800 Grid and separarate "valid from/to" for CertificateViewer
Change-Id: I32661d0ec57c9f855806a44349d20c8fe651f293
2014-08-12 18:25:24 +02:00
3442b004e6 Now that we build NSS, we can build libxmlsec and libxsec_xmlsec for iOS, too
Change-Id: I65ab8aad0744a2aa254fefc7732cd8130bb249fb
2014-08-12 17:03:31 +03:00
595e446aff Get rid of xmlsec_trace() and use SAL_INFO("xmlsecurity.xmlsec")
Change-Id: I3e1db89de2019285ce313f9bae1375a5b82f6383
2014-08-12 17:02:15 +03:00
d24df3fc66 callcatcher: another round of ResId removals
Change-Id: Ia3acdb3501b7735820258cb090e731f5814bc07f
2014-08-12 09:02:03 +01:00
e1683c2d13 callcatcher: update unused code
lots of ResID stuff going away now

Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
ffa78fe20d xmlsec: clean up resource file dialogs.hrc
now unused after ui conversion

Change-Id: Ic3e4f9fdd3f84c3890c6d9a33c11e372ab5b3bd0
2014-08-09 18:12:05 +02:00
b6da6a887a WaE: unused function 'ShinkToFit'
Change-Id: I01643b7f121dcafaf3cba3bb43d7339855f25d8d
2014-08-09 08:24:22 +02:00
ab1892d0cd Converted RID_XMLSECTP_GENERAL to Widget Layout.
Change-Id: I52a7f857715dc9cba7aa7748cea5b30b91ed9011
Reviewed-on: https://gerrit.libreoffice.org/10842
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-09 06:14:10 +00:00
e7a474b29a java: remove unused variables
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
f124688cfd java: remove various unused variables
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-08-05 11:31:49 +02:00
5717de74f5 create OUString from literal
Change-Id: I8198fbad20daa7262e42a452c8d81fcfa3331680
2014-08-04 15:59:06 +02:00
ec960ba032 remove unused resource id
leftover from e2b0e7571a8b082a2cb532e34b9770060128452b

Change-Id: I1e2e634e6cdfbc81f5d068136c9099de170dc1ef
2014-08-04 15:59:05 +02:00
a246cad28a Delete RID_XMLSECTP_MACROWARN dialog
I deleted unused RID_XMLSECTP_MACROWARN and MacroWarning class.

Change-Id: Iaf0a99eae53b08a8a8869696ba19ae2023ede52a
Reviewed-on: https://gerrit.libreoffice.org/10718
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-04 12:08:08 +00:00
e2b0e7571a Converted RID_XMLSECTP_DETAILS to Widget Layout.
Change-Id: Ie284f5902879093f882a1f69b481df4a1a319a35
Reviewed-on: https://gerrit.libreoffice.org/10693
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-03 07:30:20 +00:00
4991fa0965 drop defines for noexistent strings
Change-Id: Id04ca66ffd2710561571812c9185907cdfab6416
2014-08-02 19:10:31 +02:00
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 09:01:25 +00:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
b312a38797 update_pch: add a bunch of pch files
desktop:    1m51s ->   54s
 framework:  1m55s -> 1m04s
 package:      32s ->   16s
 sdext:      1m31s ->   47s
 svgio:        32s ->   15s
 uui:          49s ->   20s
 vbahelper:  1m44s ->   27s
 xmlscript:    15s ->   10s
 xmlsecurity:  45s ->   23s

Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04 21:18:37 +02:00
626a428367 fdo#68849: Add header guards to all include files
Added header guards to files in directories xml*/*

Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922
Reviewed-on: https://gerrit.libreoffice.org/9539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-29 09:02:51 -05:00
9af0abebfd remove unnecessary use of Reference constructor in throw
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
2ed32f7afa cppcheck: Prefer prefix ++/-- operators
Change-Id: I290ccba1487e59ea6f86bfb0382671ca4ed50831
2014-05-24 11:32:43 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
f1b030949b coverity#1215310 Uncaught exception
Change-Id: I8d9663f8dedda8e7006e7ac6545cb15188a1ec2d
2014-05-23 08:54:38 +01:00
4671e7b8a4 fix-includes.pl: xmlsecurity
Change-Id: Ie3dd8674e1fa927d15eeb6a64a0cad24b8825262
2014-05-19 20:04:27 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
248145f99e Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14 08:10:22 +00:00
f3e519d424 coverity#982735 Negative loop bound
xmlSecBase64Decode returns int

Change-Id: I5bfb273141e62f1355033c669c49af5c645da900
2014-05-11 21:05:54 +01:00
c029a81a79 coverity#1209500 Explicit null dereferenced
Change-Id: I11aa7ecfa52054085aaca70b165a831b5ec8577b
2014-05-07 15:47:23 +01:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
541761d7b8 prefer makefile-gmake-mode
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-04-28 23:35:42 +09:00
946c7b03f4 coverity#707484 Uncaught exception
Change-Id: I1881add525365feaf25ce61b2be027f6ea1bcce7
2014-04-24 10:37:11 +01:00
a089a4e27a coverity#707488 Uncaught exception
Change-Id: I568de20d26cff7742529a93f5a86b10ee2ac630c
2014-04-24 10:37:11 +01:00
f4a760025b coverity#707489 Uncaught exception
Change-Id: Ia15d9c6761b1b7990586b766a4f8c385c04edc0a
2014-04-24 10:37:11 +01:00
8821c0698c coverity#707490 Uncaught exception
Change-Id: I8aeff7a5e3513d316202d40b953435238c1bf714
2014-04-24 10:37:11 +01:00
e4e654e405 xmlsecurity: sal_Bool->bool
Change-Id: I4f32fe3b5133e13dab88ca1c9acd021d84dc59a9
2014-04-24 10:53:16 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
aa39d21107 clean up hrc files
Change-Id: I76756fe539589d2ab086fd1f1aeec50a9f39af37
2014-04-22 13:03:18 +02:00
40064f479b clean up hrc files
and remove some unused stuff

Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
2014-04-22 13:03:17 +02:00
c9e2ce548b WaE: Unreferenced function definition [loplugin:unreffun]
Change-Id: Ibac16b109d9024a75fc6045d5d55fb5d21eee70a
2014-04-19 22:24:04 +03:00
55c70634b8 fixincludeguards.sh: xmlsecurity 2014-04-19 11:10:08 +02:00