e6534a6099
com::sun::star->css in embeddedobj/
...
Change-Id: Ia04fc28ce8e1d70f86520edf2df8c98f7b455465
Reviewed-on: https://gerrit.libreoffice.org/19024
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 08:03:29 +00:00
35fd0cf311
cppcheck: noExplicitConstructor
...
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-09-13 22:42:35 +01:00
faed29cac9
for now show chart sidebar
...
This is a hack that needs to be cleaned up later.
Change-Id: I2772fe6ff8a4792d746a29653635d3eca4088e68
2015-07-16 08:15:17 +02:00
4ecd67b7ed
fix indentation
...
Change-Id: I4bceb79ed4adda085727dfcee1ba3573811e53b3
2015-07-16 08:15:16 +02:00
8992def7c0
More helpful exception message
...
Change-Id: I63dcc98667ebfc94cc16407d283e65e1514d89fb
2015-06-17 14:37:45 +02:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
d5dde72908
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: Ie55f464ef2eca344d3c1292713ded2710c47cc53
2015-06-08 16:24:55 +02:00
ed85e11a1b
embeddedobj: allow creating objects lacking a FileFormatVersion=6800 filter
...
dbaccess::ODatabaseDocument::loadFromStorage() is still not implemented,
though.
Change-Id: I1be11f2a2274f67dd0a11f96a718394d5f72605f
2015-05-04 16:12:14 +02:00
309574394b
callcatcher: large newly detected unused methods post de-virtualization
...
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com >
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29 23:42:26 +00:00
9f806fcad2
embeddedobj: Use appropriate OUString functions on string constants
...
Change-Id: I149dd1abf03437bb58829a5f16a8c2aef5eec092
2014-12-18 14:12:25 +01:00
aba7f4c0a3
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I026999d6e995185c42df6770a1a700094540d08a
Reviewed-on: https://gerrit.libreoffice.org/13454
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-15 06:43:25 +00:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
e27ac011c3
loplugin: cstylecast
...
Change-Id: I9fca98995131358b3b112b11e0b28feb1a3267d1
2014-10-01 13:08:43 +02:00
f4528a1ba6
Add a border to opengl chart to make it easier to handle.
...
Change-Id: I74bc636dc0a37d70f45fe2eac0b8b60e3f6318bb
2014-08-29 17:40:29 +02:00
9991b50ccc
Make opengl chart window always active
...
Fortunately there is a special ole object group with
the MS_EMBED_ACTIVATEWHENVISIBLE flag which define this
behaviour.
Problem is that both Aspect and EmbedMisc are MS specific
enums so we can't use them directly for non-MS objects. But we
can handle opengl charts the same as this ole object group.
Change-Id: I49abeffce319cbb775709a72ba198a1f76b65374
2014-08-29 17:40:27 +02:00
9af0abebfd
remove unnecessary use of Reference constructor in throw
...
Convert code like this:
throw IOException("xx",
Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
throw IOException("xx",
static_cast<OWeakObject*>(this) );
Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
9b791f9c31
remove unnecessary use of OUString constructor when throwing
...
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27 08:20:11 +02:00
3c1e30b77d
Correct common misspellings, and remove some ASCII art along the way.
...
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
2014-05-17 12:38:38 +00:00
dd33f91581
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part14
...
Change-Id: Ibccaa2138426c22cd63d273a1b6cdc927ebe80dc
2014-05-17 00:24:22 +02:00
142ecb8b36
embeddedobj: remove SAL_INFO's that only mark function entry
...
Change-Id: I06b344504e6052c25578f0bc4c3598d45d544003
2014-05-14 16:54:24 +02:00
584e8c8c3c
embeddedobj: sal_Bool->bool
...
Change-Id: Ie3465a34963c768945b1ee7f5939ea1f233d3528
2014-04-22 09:53:13 +02:00
fa0ffdbeb5
cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).
Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
3140af0a32
coverity#706508 Uncaught exception
...
and coverity#706509, coverity#706510
Change-Id: Ib160cc65ed50073f9302ac071b2e8970a7316a54
2014-04-04 20:58:30 +01:00
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
e4f6ba5e3c
Remove visual noise from embeddedobj
...
Change-Id: I63ce6896e2f82160ffedb9f6123ca765f49698c5
Reviewed-on: https://gerrit.libreoffice.org/8256
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 15:02:45 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
19e16083c6
Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton.
...
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
2014-01-30 10:48:25 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
0fa31bed9a
Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter
...
...and assorted OUStringHash clean up
Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-12-06 12:03:59 +01:00
3af99e4d59
convert equalsAsciiL calls to startsWith calls
...
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-20 10:07:31 +02:00
484819a235
remove unnecessary use of OUString constructor in EMBEDDEDOBJ module
...
Change-Id: I60bbdd2a2592a1e5333abe50711aa227786ce935
2013-11-11 11:21:23 +02:00
7235d23267
fdo#54938: Adapt supportsService implementations to cppu::supportsService
...
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316
Reviewed-on: https://gerrit.libreoffice.org/6035
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-07 17:01:33 +00:00
ab5eaec098
remove Application::GetWorkAreaPosSizePixel
...
This internal API has always been problematic because we cannot
support it under the Linux toolkits, where it has in fact always
just returned the size of the screen.
Change-Id: I406bcbca8a4161b4261ef46940823bb07c6ad18b
Reviewed-on: https://gerrit.libreoffice.org/4976
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@suse.com >
Tested-by: Michael Meeks <michael.meeks@suse.com >
2013-07-19 11:18:21 +00:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
660b67a413
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: Id4e90b83a7275bfd30914f7514a609cebbfbf4ac
Reviewed-on: https://gerrit.libreoffice.org/4044
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-05-31 18:08:02 +00:00
e2e2cc6114
remove usage of RTL_CONSTASCII_USTRINGPARAM
...
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
e1f6dac689
Replace compareTo(...) == 0 with ==
...
Proposed patch for the following issue:
https://bugs.freedesktop.org/show_bug.cgi?id=62096
Change-Id: Ib83a9051ea12c53642f781e5427a6ca728049a7f
Reviewed-on: https://gerrit.libreoffice.org/3198
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Miklos Vajna <vmiklos@suse.cz >
2013-04-05 08:57:28 +00:00
39d45390f4
removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
...
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 10:48:30 +00:00
8b27d78b4a
automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
...
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 09:00:26 +00:00
26e37ca4c7
doubled includes
...
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
c13802e009
Fix typo "persistant" -> "persistant"
...
Change-Id: I639afec2508d189c10a180fd8f824e634afbd14a
Reviewed-on: https://gerrit.libreoffice.org/2347
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-02-28 16:05:17 +00:00
dd3e879cfd
remove some trivial duplicates
...
Change-Id: Ie736cb6d5ff7f4d1998338f4a3a3a3b0a67c79ad
2013-02-25 19:34:36 +01:00
5c89214a80
fdo#39674: Rename menues to menu
...
Change-Id: Idc22167d1a0dc518b3f9e96884213140d07b565b
Reviewed-on: https://gerrit.libreoffice.org/2316
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-02-22 11:55:29 +00:00
abcbababca
fdo#46808, Convert comphelper::MimeConfigurationHelper to XComponentContext
...
Change-Id: I74b4f0c4a84f02b218102405eaba24cf47f654ce
2013-01-15 09:56:03 +02:00
251f1b0b38
fdo#46808, Adapt embed::*EmbeddedObjectCreator UNO services to new style
...
The services already existed, it just did not have an IDL file.
Adapts
com.sun.star.embed.OOoEmbeddedObjectFactory
com.sun.star.embed.OLEEmbeddedObjectFactory
com.sun.star.embed.EmbeddedObjectCreator
Change-Id: I8ba01c7fd956a46c87d02dc7d61bdd5fcdf21ab8
2013-01-15 09:56:03 +02:00
92f14ced5e
fdo#46808, Adapt frame::TaskCreator UNO service to new style
...
The service already existed, it just did not have an IDL file.
Change-Id: I157c53d09b612da0178432100b8928013f811706
2013-01-15 09:56:00 +02:00
42adbfccad
fdo#46808, Adapt embed::HatchWindowFactory UNO service to new style
...
The service already existed, it just did not have an IDL file.
Change-Id: If00396effd92ed72ea942da5eb1fe60b6380c665
2013-01-09 08:08:09 +02:00
