Commit Graph

7160 Commits

Author SHA1 Message Date
c7e8f21a53 loplugin:unusedmethods
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30 05:58:41 +00:00
93e2e45e49 Too much copy pasta is not good for you
Change-Id: Ie5a3cddd6fcf9d1a763284c1aea0fca579da4f8d
2015-10-29 15:41:21 +02:00
a346dfccd7 tdf#70833: IDNA support when exporing hyperlinks to PDF
Any URLs using non-ASCII IDNA syntax need to be resolved to ASCII-only, as PDF
URI Action's URI needs to be "encoded in 7-bit ASCII."

Introduce URIHelper::resolveIdnaHost (svl/urihelper.hxx), which internally uses
icu::IDNA, which requires to bump the minimal --with-system-icu requirement from
4.2 to 4.6, which means ICU_RECLASSIFIED_CLOSE_PARENTHESIS is always true now.

Change-Id: I0e20d9a20ed2b869fba0cc7c969721411db590b3
Reviewed-on: https://gerrit.libreoffice.org/19669
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-29 13:02:40 +00:00
5d5c4686ba remove boost::noncopyable from /include
Change-Id: I9fa22b06fabf79043ebc68be7afebc6e810f4db1
2015-10-29 08:51:55 +02:00
a3de32acc0 Rename (private) Date::init and reuse it
Change-Id: I3123876860cf6cce1e16c8f516f3d08fa7e15d83
2015-10-28 14:08:34 +01:00
bfd79be417 vcl: getWindow() -> setClipboard() in ITiledRenderable
It's cleaner to let the apps do this themselves than exposing their
underlying vcl::Window.

Change-Id: Iff2442dd325fa65a0cf3ad4aa7f918542dab1e4c
2015-10-28 09:45:11 +01:00
623f5b26ff don't allocate rtl::Reference or SvRef on the heap
There is no point, since it's the size of a pointer anyway

Found by temporarily making their 'operator new' methods
deleted.

Change-Id: I265e40ce93ad4bad08b4f0bd49db08929e44b7d6
Reviewed-on: https://gerrit.libreoffice.org/19628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-10-27 15:35:36 +00:00
d00d5f6fe8 Move member definition back into .cxx
Change-Id: Ie0698792c8785e0caee0e78222051451e5ebc65c
2015-10-27 16:12:02 +01:00
20635ed90b Reduce scope of #include <tools/stream.hxx>
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27 13:59:10 +01:00
7e89e28274 sal_uIntPtr to sal_uInt64, sal_uLong to sal_Size for streams
Change-Id: I062f1f6c5b20ca47734a9a3cd1a229d51763a206
2015-10-27 13:59:09 +01:00
9962877513 sal_uLong to ErrCode
Change-Id: I2b4b2673aa27de664f6c6780e67c70559ec61971
2015-10-27 13:59:09 +01:00
d1eb389d70 sal_uLong/long to ErrCode
Change-Id: I2ba2d867785765e4850c60070e86419f66e25f57
2015-10-27 13:59:09 +01:00
f8dac0391c Use mutable instead of const_cast'ing this
Change-Id: I790cd140166bf0041abebbe0c4d9c15e931628f1
2015-10-27 13:59:08 +01:00
e25669fced don't allocate uno::Reference on the heap
There is no point, since it's the size of a pointer anyway

(found by temporarily making the new operator in uno::Reference
deleted).

Change-Id: I62a8b957fef9184f65d705600acfdab4116dcb34
Reviewed-on: https://gerrit.libreoffice.org/19603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27 12:48:50 +00:00
f8d0dc09e1 tdf#94022 Print dialog: hide Installable Options
Options specified in PPD files can be grouped using the
keywords "OpenGroup" and "CloseGroup".
The keyword "InstallableOptions" is used as a group name
for a group containing options that define
optional hardware features of the printer that can
be present or not (s. section 5.4 in version 4.3 of
the PPD specification).

As they are not print job specific, it is recommended
not to show them in the print dialog.

To be able to distinguish those options, the
PPD group name was added as an attribute to the PPDKey
class.

Change-Id: I4a3abf23a711ad98556c0b608a07ef0a91e77e2b
Reviewed-on: https://gerrit.libreoffice.org/19623
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-10-27 12:25:21 +00:00
bf98ea200f Missing include
Change-Id: Icbffa2973b3cb803950ffe280b95194795f8861c
2015-10-27 11:22:12 +01:00
4299f621d5 Missing include
Change-Id: I55595fdbc6ae5a51f402201cdc5f4adbdd86b984
2015-10-27 11:16:30 +01:00
43dcc3eddf Missing include
Change-Id: Id57c9dded321b870002792056e9734ac3074a606
2015-10-27 10:47:32 +01:00
834cbda1ec move SvRefMemberList into idl
since it's only usage is there

Change-Id: I882ddd3e08ab37cf7b3cca8121463598ea3d3bc4
2015-10-27 11:25:34 +02:00
644487a115 loplugin:unusedmethods
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27 08:20:43 +00:00
271c6b3605 inline SvBaseLinkRef typedef
Change-Id: I0684db21c260e38d1d2e32eb5924cf7e25212b4d
2015-10-27 08:56:38 +02:00
c22ec49de4 inline SfxMediumRef typedef
Change-Id: Id6dc03a5957adf657d12db7941273593a9f7c10f
2015-10-27 08:56:38 +02:00
3ce9af420a loplugin:unusedmethods
Change-Id: I73180266c0af98dbd8d29bd3b11850996b94def9
Reviewed-on: https://gerrit.libreoffice.org/19195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-10-27 02:33:18 +00:00
fd9d9976bf fix includes that are not stand-alone
includes should be able to be included on their own
fix some of the ones that do not respect
that rule.

Change-Id: Id161224a1978461d3cea43252f232f18888a4f61
Reviewed-on: https://gerrit.libreoffice.org/19612
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-10-26 21:04:30 +00:00
5ec304d3f2 ImplImageTree ctor/dtor can be private now
Change-Id: Idf43ef98ea41345595ffcfae8c74a50120107978
2015-10-26 20:24:16 +01:00
7bac2a210d TBBase::indent_printf() only #if OSL_DEBUG_LEVEL > 1
... so the next unusedcode round doesn't remove it again.

Change-Id: I3bcbafb0461f09fcfbb0e14f4f1a1713a540b5a3
2015-10-26 20:13:27 +01:00
cc2ffcad79 reintroduce TBBase::indent_printf()
This partly reverts a90c6eb99c8c2167c4b1ec75a21a30a344bfea43 which
erroneously removed the method as unused because it is used only with
OSL_DEBUG_LEVEL > 2

Change-Id: I6fa52775b6a013c0086ba9d7ae21720a9ab8aa01
2015-10-26 20:08:10 +01:00
6948c546fd tdf#75637: Resolve help images via a vnd.libreoffice.image UCP
...which uses the logic already available in VCL's ImplImageTree to locate the
image zip files and find fallbacks for incomplete themes and for localized
images.

Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472
2015-10-26 17:55:14 +01:00
5b4c29b1b1 sc: implement vcl::ITiledRenderable::isMimeTypeSupported()
Change-Id: I0b9de068ddf0f4ff92d8fbf003b7529516f1f80a
2015-10-26 13:42:02 +01:00
7efbbe98d7 lok::Document::paste: check if the given mime type is supported
Change-Id: Ib59ea43700815c53cdd4be819e2e9cf35c6f89e9
2015-10-26 13:38:33 +01:00
e531f846d7 vcl: ITiledRenderable::getWindow() can be pure-virtual now
Change-Id: I393ec4427674cd5d77d0e9a069ffe159d14e38b1
2015-10-26 10:28:11 +01:00
3d784c4af6 remove extra spaces around ::
just makes it harder to grep for methods

Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-26 09:12:05 +02:00
ec2f943975 Remove Boost Pointer Container Library related functions
...no longer used since the last boost:ptr_vector<SvLBoxItem> has been removed
in 63de1888f67dc43c30d5a102651b7c2738243efb "svtools: replace boost::ptr_vector
with std::vector<std::unique_ptr>"

Change-Id: Icd5e9671bb79b0bb2e3b12ef004ac9ec112981f8
2015-10-23 17:18:07 +02:00
1c909a13a0 com::sun::star->css in include/ucbhelper to include/xmlscript
Change-Id: Iaa7f0b8455a601d3992c08cde0943c709c417256
2015-10-23 12:05:04 +02:00
c06e2fcc2c com::sun::star->css in include/sot to include/typelib
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
2015-10-23 10:48:50 +02:00
e4acd26406 com::sun::star->css in include/linguistic to include/sfx2
Change-Id: Id69e293fda98ee6cf2cc3d3296a0cd2e06bd847e
Reviewed-on: https://gerrit.libreoffice.org/19527
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23 07:08:51 +00:00
fa22a60e71 com::sun::star->css in include/i18nlangtag,i18nutil
Change-Id: I847a5729911474e8dd72e28aea53969f7037ce9b
Reviewed-on: https://gerrit.libreoffice.org/19526
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23 07:08:34 +00:00
9a85743766 tdf#48456 : when searching for a number, consider formatting
Change-Id: I4a1e3e269a269bb37e88aa8810a46d0f4ecfc518
Reviewed-on: https://gerrit.libreoffice.org/19420
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-10-23 00:24:18 +00:00
e5c8d01b1c crashtesting+ubsan: kde170880-1.html bad cast to SdrTextAniCountItem
because a clone of SdrTextAniCountItem is a SfxUInt16Item not
a SdrTextAniCountItem

Change-Id: I7b8f99b52b1f42a6a28af4495ff25ddb6d497f61
2015-10-22 23:41:51 +01:00
6554961459 add missing SearchFiltered to SvxSearchItem slot definitions
Already since 26d5cf1ecadc17e5c6aff071b8750b9fadaa1d28 there was one
SfxTypeAttrib element less in aAttrib[n] than defined MID_SEARCH_... values in
include/svl/memberid.hrc, also SearchFiltered was missing from
sfx2/sdi/sfxitems.sdi

As a consequence the generated slot definitions
workdir/SdiTarget/sc/sdi/scslots.hxx lacked that item.

Change-Id: Ic901b3a85fb5242037d713f3642971e7073e684d
2015-10-22 21:27:29 +02:00
73ffc462b9 coverity#1326120 try and silence Constant expression result
Change-Id: Iafd034dd51135ad99f56279ceee1c770f91436b0
2015-10-22 16:45:11 +01:00
6552767aa5 LOK: add Document::paste()
Change-Id: I34998229e7f5cac4c62c859861783be3c161f9bf
2015-10-22 13:34:20 +02:00
981a974824 vcl: add ITiledRenderable::getWindow() and implement in sw
Change-Id: I9d0fad3904e74b44b0b126974ace4025f7a4fc5b
2015-10-22 13:34:20 +02:00
98cdb563c1 vcl: add Window::SetClipboard()
Change-Id: I385f64b7d5015c9a34f34a436b0ee2ce6b3a83d3
2015-10-22 13:34:19 +02:00
1b3f81bd58 com::sun::star->css in include/framework
Change-Id: I60874ab8d3cc9adaea8757d6888e341accce2083
Reviewed-on: https://gerrit.libreoffice.org/19494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22 07:26:49 +00:00
41b923e76d com::sun::star->css in include/formula
Change-Id: Ib217c24614d09817e4d7f8c545bd75345250a874
Reviewed-on: https://gerrit.libreoffice.org/19493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22 07:26:35 +00:00
dc9e72df8e com::sun::star->css in include/filter
Change-Id: I05c314b6eb460cfcbaa7d13cae21360ce6824624
Reviewed-on: https://gerrit.libreoffice.org/19492
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22 07:26:05 +00:00
f80d42876a drop unused stuff scheduled to be removed 'before the next major'
Change-Id: I2162618d430cf8dc6bb8d20d9a5dd9af543fa934
2015-10-21 15:52:41 +01:00
3303f43a6e afl-eventtesting + VclPtr: only current context decks getting disposed
but they all have to go, not just the current one

Change-Id: I84819c2a74042ad028fbdd8acba5d925c7fdedab
2015-10-21 15:52:40 +01:00
a673713bb3 more removal of com::sun::star typedefs
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21 15:10:24 +02:00