This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at
<http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re:
fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd
change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get
CreateUnoDialog() work again" appears to fix things again:
The problem is that the implementation of the css.awt.UnoControlDialogModel
involves UNO aggregation
(IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in
toolkit/soruce/helper/registerservices.cxx creating a
OGeometryControlModel<UnoControlDialogModel> instance that aggregates a
UnoControlDialogModel instance). That means that queryInterface can return a
reference to something that is technically a different object, and that's
what's happening here, and explains why calling setPropertyValue in two
different ways on what logically appears to be a single object can end up
calling two different implementations (of two different physical objects).
(UNO aggregation is known to be broken and should not be used. Nevertheless,
there's still code that does---code that is a horrible mess and hard to clean
up.)
That all this worked as intended in the past is just sheer luck, but any
way of substantially touching it is asking for trouble. I'm going to
revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again.
I wasn't able to revert without also reverting
be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert
awt::XUnoControlDialog to new style," as the two were tightly dependant. Also
reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431
"-Werror,-Wuninitialized" (sans the const-ness fix in
UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452
"Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix
awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086
"scripting: get CreateUnoDialog() work again."
Conflicts:
basctl/source/dlged/dlged.cxx
filter/source/t602/t602filter.cxx
xmlscript/test/imexp.cxx
Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998
API-CHANGE:
Removed the following interfaces from the IDL because no-one was
using them:
interface com::sun:⭐🫘:XFastPropertySet;
interface com::sun:⭐:lang::XComponent;
But the service still implements them, so old code should keep on
working.
Change-Id: Iab058fb42bd1a54e0b9632e99e564fdc0869fe6e
- nanosecond precision
- signed (allowed negative) year
Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.
Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
The implementation in Writer has Value property read-only since initial
CVS import, and NumberingType property never existed, so adapt
com.sun.star.text.textfield.GetExpression to implementation.
Thanks to the really cool David Ostrovsky for finding these.
Change-Id: I3b12a8103d0d6de7dbf644f30db3f192b0331f0a
SERVICE: /UCR/com/sun/star/text/textfield/GetExpression
SERVICE1 contains 1 more properties as SERVICE2
incompatible change: Field 3 ('NumberingType') of r1 is not longer a property of this SERVICE in r2
incompatible change: Field 6 ('Value') of r1 is not longer a property of this SERVICE in r2
incompatible change: Field 5 ('Value') of r2 is a new property compared to this SERVICE in r1 and is not 'optional'
...does not make sense. Adapted some old-style services accordingly, where the
inherited service had been changed to new-style after the fact.
Change-Id: I5f3e4ddf99160778a319062a6c84f83529ff177b
The implementation in Writer has been read-only since initial CVS
import, so adapt com.sun.star.text.textfield.SetExpression to
implementation.
Change-Id: I70cdd5d0a44cb86426f533c00f86874e8dde8b87
SERVICE: /UCR/com/sun/star/text/textfield/SetExpression
incompatible change: Field 11 ('VariableName') of r1 is not longer a
property of this SERVICE in r2
incompatible change: Field 11 ('VariableName') of r2 is a new
property compared to this SERVICE in r1 and is not 'optional'
This is a service that basically describes the properties passed to
loadComponentFromURL and possibly other load/save related APIs. As
some properties get deprecated (some already have), new ones added as
the loading processs gets re-worked (including the type detection
process), we need the flexibility to change its property set.
Since all properties described here are optional, leaving it published
would make little sense.
Change-Id: I59384e62c7b6ab5c599141c8fc73a37c8bfe56e7
Change-Id: I2e957f174bcafadf4f2cbad7ba3b2e40d22be4e4
STRUCT: /UCR/com/sun/star/sheet/DataResult
published in 1 but unpublished in 2
CONSTANTS: /UCR/com/sun/star/sheet/DataResultFlags
published in 1 but unpublished in 2
STRUCT: /UCR/com/sun/star/sheet/MemberResult
published in 1 but unpublished in 2
CONSTANTS: /UCR/com/sun/star/sheet/MemberResultFlags
published in 1 but unpublished in 2
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).
Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.
I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.
I dropped the optional interfaces
XStatusIndicatorFactory
XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.
I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.
Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
...so that regmerge fails for bad regfile arguments. Add -v to the regmerge
calls in update-rdb.sh so that an error message is printed in case of failure.
Change-Id: I6613b9756b4e5628772541580938f6c80fd9bc9e
Change-Id: Ic7547e48f6b00409ed9fe5bf7c3e6921529c9598
SERVICE: /UCR/com/sun/star/sheet/DataPilotSource
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceDimension
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceDimensions
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceHierarchies
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceHierarchy
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceLevel
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceLevels
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceMember
published in 1 but unpublished in 2
SERVICE: /UCR/com/sun/star/sheet/DataPilotSourceMembers
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XDataPilotMemberResults
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XDataPilotResults
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XDimensionsSupplier
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XHierarchiesSupplier
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XLevelsSupplier
published in 1 but unpublished in 2
INTERFACE: /UCR/com/sun/star/sheet/XMembersSupplier
published in 1 but unpublished in 2
This service is deprecated and has never been implemented.
EXISTENCE: published key "/UCR/com/sun/star/text/DocumentIndexFormat"
exists only in registry 1
Change-Id: I55777a2ded54ecc19afced6deb191fb3437b2ca4
The service is deprecated and was never implemented.
EXISTENCE: published key "/UCR/com/sun/star/text/LineNumberingSettings"
exists only in registry 1
Change-Id: Id720f8685eba6c78ed7f57c2365db6ab3c7ba8a4
This interface has been deprecated since OpenOffice.org initial CVS
import.
EXISTENCE: published key "/UCR/com/sun/star/util/XSimpleErrorHandler"
exists only in registry 1
Change-Id: I28b2a9dd0180994c077d960bf932fbdea0f282c4
This interface has been deprecated since OpenOffice.org initial CVS
import.
EXISTENCE: published key "/UCR/com/sun/star/util/XCancelManager" exists
only in registry 1
Change-Id: Ibc67f79b4664f8ff9aadacdd36cd8e80c9ff477c
This interface has been deprecated since OpenOffice.org initial CVS
import, and there does not appear to have been an implementation of it,
though strangely there was client code using it until 2007.
EXISTENCE: published key "/UCR/com/sun/star/util/XArchiver" exists only
in registry 1
Change-Id: I8efa29a3d375d7c5c77ae47592b23bec4072d7a0
This interface has been deprecated since OpenOffice.org initial CVS
import.
EXISTENCE: published key "/UCR/com/sun/star/view/XPrintPreview" exists
only in registry 1
Change-Id: I995b7b4fbbdac5582e015daf11d4c644abc53b73
... and derived com.sun.star.util.DiskFullException. These exceptions
have never been used since the initial OpenOffice.org CVS import.
EXISTENCE: published key "/UCR/com/sun/star/util/DiskFullException"
exists only in registry 1
EXISTENCE: published key "/UCR/com/sun/star/util/FileIOException" exists
only in registry 1
Change-Id: Id3a1b9e43350b15b90864628dc2dbf77027d64a8
