b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
9e4c87be31
Fix typos
...
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 05:53:57 +00:00
d3c7c9ea81
tdf#94559: first step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff
Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-29 12:26:20 +00:00
3fb50fbe2b
basic: remove over-engineered XEnumeration service
...
... that was causing duplicate WeakImplHelper symbols now.
Change-Id: Ibbf84a2059f30bfeb5c265adcafb4b56d2534dc8
2015-09-03 16:31:59 +02:00
4f87e9da41
loplugin: defaultparams
...
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-08-11 09:48:17 +02:00
50097a8bb2
basic,basctl: inline some use-once typedefs
...
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
2015-08-04 08:55:56 +02:00
9072c5c855
convert SbxFlagsBits to scoped enum
...
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-28 08:35:34 +02:00
b4ee16da65
com::sun::star->css in basic
...
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 09:39:36 +00:00
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
7640e244db
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, in basic.
Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-06 07:28:21 +00:00
ffa8892c5a
Fix typos
...
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:23:17 +00:00
761e0ae0a7
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-08 16:23:17 +02:00
8e22cd40ec
cppcheck: noExplicitConstructor
...
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-06-02 08:57:56 +01:00
4d9595637c
Wrong comment since 642cfe8ac206af4fe82bc695d38b5c7f0edf7dc7
...
nEndPos is in fact sal_uInt32 type
Change-Id: I434564eebff2138709807676ae855a8f487f4c09
2015-05-23 16:53:57 +02:00
5b1337f7b2
tdf#62475: partial handmade fixes
...
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2015-05-15 17:55:15 +00:00
ef6877c167
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: I1e4363f917a978434fb11368918435da12531dc6
2015-05-11 12:49:03 +02:00
0241519f32
Unwind SotStorageStreamRef typedef
...
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07 11:05:04 +02:00
dc47b2e513
Unwind SotStorageRef typedef
...
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07 11:05:04 +02:00
4950c579d1
callcatcher: update unusedcode
...
Change-Id: I4b2a7ea03aafbfbf1fece1533da801a4326d80f9
2015-04-19 13:03:01 +01:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
4e0d2fcdda
BASIC: Merge BasicLibs with BasicManagerImpl and use boost::ptr_vector.
...
Change-Id: I36fc3ce26b129b11fc2d6d2829a146b3fa57b783
Reviewed-on: https://gerrit.libreoffice.org/15267
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-04-13 06:19:23 +00:00
54e87df11f
Change INetProtocol enumerators to CamelCase
...
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4
Change INetProtocol to scoped enumeration
...
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
c3fb36ed26
Clean up C-style casts from pointers to void
...
Change-Id: I6dd7c7fbaf0d4b22abba0a7b1f5e37f0a46d0747
2015-03-28 19:09:17 +01:00
0511c86791
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
2015-03-26 15:33:28 +01:00
b2d2d72a7e
loplugin:constantfunction: basic
...
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
2015-03-24 10:31:17 +02:00
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
f8922b67a4
Remove unnecessary comphelper::string::getToken
...
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2015-01-02 14:22:21 +01:00
898c414700
basic: Use appropriate OUString functions on string constants
...
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
2014-12-12 10:21:45 +01:00
57fe576778
fdo#84938 replace BASERR_REASON_ constants -> enum
...
Change-Id: I80fe0108c2d27b72d2fadc23032cf2b52c3193a6
Reviewed-on: https://gerrit.libreoffice.org/13268
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-03 08:25:02 +00:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
7d6c07fa2b
coverity#1242689 Untrusted loop bound
...
Change-Id: Ie226805ef8d430eb3f7b3abaa54ac3af31f72f7b
2014-11-05 21:03:25 +00:00
26b79470ca
basic::ImplRepository: use SolarMutex instead of own mutex
...
The locking strategy in the basic module is totally unclear to me, there
does not appear to be a dedicated mutex for the core stuff callable via
StarBASIC, just a bunch of SolarMutexGuards at random locations;
let's try to use SolarMutex at the UNO entry points...
Change-Id: Ia9c45fdcfb5ffd0a4acc77ef5d2fabfb8743ad38
2014-10-08 15:46:05 +02:00
fa537124ac
loplugin: cstylecast
...
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01 13:08:41 +02:00
03043589c3
Clean up StorageMode parameter of SotStorage::OpenSotStorage
...
...which was only used to transport either STORAGE_TRANSACTED or sal_False
(i.e., 0, meaning "not STORAGE_TRANSACTED").
Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-15 18:22:37 +02:00
c319ccfc37
Revert "Simplify ImplRepository::impl_getLocationForModel return type"
...
This reverts commit 72305ed49d4c9ba968d7bf6d8d5ae564bb92147d, which was bogus,
cf. the comment in ImplRepository::getDocumentBasicManager about recursive
calls.
2014-08-22 09:10:40 +02:00
73b2ea1dfa
Remove BasicManagerCleaner
...
Change-Id: I55eccc6367cf3255af05c075631945f47417d682
2014-08-22 09:06:55 +02:00
72305ed49d
Simplify ImplRepository::impl_getLocationForModel return type
...
Change-Id: I937f96457347195ed18ddcdc75b1106840f0522e
2014-08-22 09:03:27 +02:00
8c5834d5cb
Remove trivial typedef, to make code more obvious
...
Change-Id: I70017a5c6f9403520ee79e9d0864352eb1c8e100
2014-08-22 08:59:01 +02:00
d9baa2b06e
-Werror,-Wundefined-bool-conversion
...
Change-Id: I81edff750eab6bbeef75fbd1a5fcca0f01379daa
2014-08-11 16:00:46 +02:00
533c6cb6ba
fixes for up-casting to Reference<XInterface>
...
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-25 17:10:43 +02:00
136a2bc384
coverity#1210096 Uncaught exception
...
Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0
2014-06-17 10:58:01 +01:00
66f98136fd
coverity#1210098 Uncaught exception
...
Change-Id: I531891fa1cce10a331dd651ee9ce52d1f8d0c169
2014-06-17 10:58:01 +01:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
68741d0055
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13
...
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
2014-05-15 22:52:22 +02:00
b2096deaff
various loplugin:passsequencebyref
...
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-14 16:54:27 +02:00
97bfac4861
coverity#1213529 Uncaught exception
...
and a gadzillion more, e.g. coverity#1213526, coverity#1213527
Change-Id: I08a9cb078963b4adf0ea6e201e31ae7eefbf92d9
2014-05-10 21:12:54 +01:00
cc725643fd
Clean up function declarations and some unused functions
...
Change-Id: I63c4c61847fea4500b667a5ea9f2b32207692033
2014-04-09 10:12:02 +02:00
1eee88dd6b
basic: sal_Bool->bool
...
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
2014-04-07 13:53:50 +02:00
