0e8a40e8b8
calling IsSet() before Call() on Link<> is unnecessary
...
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
af77042f62
disable arrow heads in chart sidebar, tdf#94971
...
Change-Id: I631f34faf2befeb7cc61027c8fd59ef7b3543785
2015-10-12 23:54:14 +02:00
01cc898aac
update the line panel for data points, related tdf#94969
...
Change-Id: Ieffdfd1cc0d6b5cc0dd8394896aeb49838096a6b
2015-10-12 23:54:14 +02:00
2753cd3087
update area panel for data points, tdf#94969
...
Change-Id: I700ae8ff591ef1ea82887b1ec2cd7b4be04978db
2015-10-12 23:54:14 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-12 10:48:13 +00:00
0f88736128
loplugin:mergeclasses
...
Change-Id: Icd01de71fe87e0bf17eba39f5b00fc9a46765509
2015-10-12 09:13:33 +02:00
82cf6c6737
also update line panel for axis, related tdf#94933
...
Change-Id: Ie280fa01dbe25287d01b7f36d152ee55ce5dbe07
2015-10-10 16:54:43 +02:00
3ddad211de
also update line panel for average and trend line, tdf#94933
...
Change-Id: I7ab991e94005665809ec52b8d4310209eb6ef75b
2015-10-10 16:44:51 +02:00
5f73eae61e
we need to take the SolarMutex when we change the UI
...
Change-Id: I6347a1466038afd625cf59ae2ee87cb4e2014aa0
2015-10-10 16:21:29 +02:00
14237c1678
use trendline context for trendlines, tdf#94931, tdf#94934
...
Change-Id: I0cb9cdec33924e560b24744cc78d632025a189fc
2015-10-10 15:24:50 +02:00
33972dea7d
correctly dispose the chart sidebar when leaving chart, tdf#94292
...
This is a much better approach than my old one that tried to use the
correct XModel with the chart sidebar. Now everytime we leave the chart
edit mdoe we destroy the chart sidebar panels and recreate them when we
go back to chart edit mode.
As a result we no longer need to have worry that much about using the
correct ChartModel and about the lifecycle of the ChartModel.
Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9
2015-10-09 20:42:11 +02:00
bfa0c4c998
remove whitespace
...
Change-Id: I6390f16a6c2346c4c903a34d702277b931bc0079
2015-10-09 20:42:10 +02:00
391f181c9f
chart2: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I6f3d8488a63a5bed271ab70ad6f024e9869906cc
Reviewed-on: https://gerrit.libreoffice.org/19143
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-08 09:06:46 +00:00
d52d448e7b
tdf#88154 workaround and unit test
...
Fixed 45-degree layout for axis labels, too.
Change-Id: I9764e281aeee0a439fa9eec1e3b0df840221b72f
Reviewed-on: https://gerrit.libreoffice.org/18889
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2015-10-07 09:07:48 +00:00
05e61719e2
loplugin:mergeclasses
...
Change-Id: If918532fcc860e3deacd9c86dd7a2d554e4f748d
2015-10-07 08:27:25 +02:00
2b57de8bb0
remove another custom refcounting base class
...
Change-Id: Icd8a8d79da0ada68e9ee869c3c2a7b93db5b2733
2015-10-07 08:27:25 +02:00
9887118e19
tdf#90839: follow-up work
...
- Removed the data-label-wrap token and related code in xmloff module.
- Using the already present `fo:wrap-option` seems to be the preferred
solution: investigated to see how the token is imported exported: the
class `XMLWordWrapPropertyHdl` takes care of that, luckily it converts
the token to a boolean property.
- Fixed a minor issue in the code for the data label dialog.
Change-Id: Id050fdfeedd3af7fb79be96bfe157c61c4b44191
Reviewed-on: https://gerrit.libreoffice.org/19197
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-10-07 06:12:10 +00:00
cc75567406
Return rtl::Reference from ShapeTypeHandler::CreateAccessibleObject
...
...and handle related fallout
Change-Id: Ie82d853a9bf28b359d5aab9d0af01b728d68ed70
2015-10-05 16:55:15 +02:00
d7748842e9
hide grid and axes options in chart elements if not supported, tdf#94297
...
Change-Id: I358340bd1b17f0e2eb5a119a60b623e489044dd3
2015-10-03 16:22:02 +02:00
749a084550
don't show area and line panel in pie chart Chart selection, tdf#94320
...
Change-Id: I0eacedbb3d96a059278bab0ef98a66ed49b827fc
2015-10-03 16:00:21 +02:00
2957be02c5
Fix typos
...
Change-Id: I776c517ba87838c0c3391f79010a30fa7fe2abd3
Reviewed-on: https://gerrit.libreoffice.org/18939
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-10-02 08:54:51 +00:00
ac9671f948
tdf#94559: second step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
chart2, connectivity, editeng, extensions, filter, forms, framework, idl
Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-09-30 06:07:57 +00:00
a6e622480f
Fix typos
...
Change-Id: Icf15b5ea2e5b9cd62645bab2f9ccaada948322a7
Reviewed-on: https://gerrit.libreoffice.org/18940
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 06:00:42 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
9d31c61103
enable z axis objects when changing chart type, tdf#94290
...
Change-Id: I4c1e3ff061692a9457557a4fecea55371f2aadb5
2015-09-27 07:54:45 +02:00
dfbf877856
gcc3 is not supported anymore, so remove that
...
Change-Id: Iddc481e13d40a6399a4a23a45c812b34a3a109f6
2015-09-27 07:54:45 +02:00
f8a7c031f1
convert Link<> to typed
...
Change-Id: Ic39135b39f1389fdf94fb16746100209ee63f492
Reviewed-on: https://gerrit.libreoffice.org/18856
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-25 18:21:31 +00:00
e85b2333bc
convert Link<> to typed
...
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-24 16:19:37 +00:00
92c8d74c54
CppCheck : reduce variables scope
...
Change-Id: Ief402017b693a4337f330fb07bb7a6dc6e749f72
Reviewed-on: https://gerrit.libreoffice.org/18753
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-23 07:29:33 +00:00
f78216d15d
fix regression with chart sidebar list position
...
regression from 66f1e65fde85168ae582ea75f72ebb290caa0a08
Change-Id: I92a5d6926ee912d4802f074d1e4aae63cf672ab1
2015-09-20 21:57:28 +02:00
85eb1e5148
use localized string for title text, tdf#94294
...
Change-Id: Id27e5c3794b728ce79d63b6c7d552df0cc1ba239
2015-09-20 21:33:58 +02:00
e1afea91e9
remove unnecessary base class
...
Change-Id: Iaa1890d11f9bfba7a8b0996b9adf79b781bcd8bf
2015-09-20 21:33:58 +02:00
99bfc363a6
convert Link<> to typed
...
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-20 06:37:36 +00:00
e0714ae393
convert Link<> to typed
...
Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
2015-09-15 09:37:31 +02:00
ee7da352b8
Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a
Reviewed-on: https://gerrit.libreoffice.org/18580
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-15 06:19:28 +00:00
4248e89e4b
remove chart sidebar when leaving chart edit mode
...
Change-Id: Ie6fc01b2a610fb861ddade996ebb8480be217085
2015-09-15 01:54:05 +02:00
33cddeea13
boost->std
...
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-14 19:32:42 +00:00
2a4ccc0c1e
convert Link<> to typed
...
Change-Id: I1c501671d72edd5b998e80c7fa1e91dbeb507af8
2015-09-14 10:00:44 +02:00
c5909e2518
Update many ListBox users to its sal_Int32 interface
...
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-09-12 14:18:50 +02:00
f4e951a61a
convert Link<> to typed
...
Change-Id: I603463d0486d4d0f21ebbdc6eca900db58bb090f
2015-09-10 11:38:30 +02:00
f9f3e97ca8
SdrObjEditView::IsTextEditHit effectively ignores its nTol argument
...
...ever since
nTol=0; // Joe am 6.3.1997: Keine Hittoleranz mehr hier
had been added into it sometime prior to
fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import." So lets assume Joe
meant that as a permanent fix rather than a temporal hack (which would have
survived for longer than 18 years anyway).
Change-Id: Ib30ac8d578f70c861d4c0f5f71bf4c13e9281db8
2015-09-09 14:01:18 +02:00
6f4e11a95b
convert Link<> to typed
...
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-09-09 10:06:12 +02:00
9ed1dd01be
tdf#90839: support for wrapped text in data labels and for centered data value
...
Now in a pie chart the text of a label can be wrapped, the wrapping is
automatic and the maximum text width is fixed to almost half the pie
radius. This feature is used to import correctly the relative text
wrapping property provided by MSO.
Moreover the data value and percent value of a label are now centered
horizontally, respect with the label text.
Conflicts:
chart2/qa/extras/xshape/chart2xshape.cxx
Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b
Reviewed-on: https://gerrit.libreoffice.org/17193
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-09-09 07:41:51 +00:00
a7fde38aae
convert Link<> to typed
...
Change-Id: I46e3f994d134f519258046f56263b4a42c1d97c2
2015-09-08 08:16:47 +02:00
8d927d3f82
convert Link<> to typed
...
Change-Id: Ia2706c308c6297d05b2862e9f86fc0f2ee90e4f0
2015-09-08 08:16:46 +02:00
61623d5b90
convert Link<> to typed
...
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
2015-09-08 08:16:46 +02:00
267f401e2a
cppcheck: noExplicitConstructor
...
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
