f61dbc3029
followup code removal after changing virtual methods to non-virtual
...
This cleanups up indentation and removes dead classes.
This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"
Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26 08:42:29 +02:00
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
3ad6e328a7
Some more loplugin:cstylecast: forms
...
Change-Id: I39325fccdadcc57df32fe5821eef0d8477018b59
2015-01-20 09:06:47 +01:00
4efa9604cf
Revert "ListBox: refuse to give values before we are loaded"
...
This reverts commit 1cc29a04adb721205655091854f5ea828bb8eb11, as it caused
JunitTest_forms_unoapi trigger the
assert( m_nConvertedBoundValuesType == getValueType())
at forms/source/component/ListBox.cxx:1189.
2015-01-14 08:35:33 +01:00
7ca657e5ee
css.form.component.{CheckBox,RadioButton} DefaultState property values
...
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.
Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
2015-01-13 15:17:18 +01:00
0331fa6a90
ListBox with value list: consider first empty value as NULL
...
Change-Id: I15c040b481b7f03720d0227ba5d2fcd2ccc78386
2015-01-13 14:59:04 +01:00
1cc29a04ad
ListBox: refuse to give values before we are loaded
...
If we are not loaded,
we don't know our field type,
so cannot give values with the right type
Change-Id: I372b77647ec8ff7428b67cca72fdd89e5e147a32
2015-01-13 14:59:03 +01:00
5cd4ab7f5c
janitorial
...
Change-Id: If0fcad97538556ef7be5fe5f8405ca171696502d
2015-01-13 14:59:03 +01:00
2f69e16c72
override the overloading of "overload" to decrease cognitive (over-)load
...
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
45ec1d9b56
brute-force find-and-remove of unused #define constants.
...
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
54942f0d09
spelling: attachement -> attachment
...
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
2015-01-05 12:57:18 +02:00
fd1372ba8b
boost::unordered_map->std::unordered_map
...
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
9e3ced1956
forms: Use appropriate OUString functions on string constants
...
Change-Id: I1bcd815663c29025da6b3ce50bdf767eef74fe94
2014-12-18 14:12:26 +01:00
afb5143639
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762
Reviewed-on: https://gerrit.libreoffice.org/13494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-17 07:31:17 +00:00
0c1b8516cb
forms: Use appropriate OUString functions on string constants
...
Change-Id: I196e847e2f63d1bac6ed0f520cba67508aec1a5d
2014-12-15 10:12:09 +01:00
ea6399b837
changed timers to idles
...
Change-Id: Ic0d7730f7880dfe2e83c84e773b8cc420249b269
2014-12-09 12:34:57 +00:00
09186fceb0
unotools: Internalize ucblockbytes.hxx header
...
Change-Id: I1a9b795eda832673a83a426c8bf10d5bb9c28581
2014-11-24 23:14:54 +01:00
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
275eb9c78e
coverity#706540 Uncaught exception
...
Change-Id: I9dabd74824ec7cffe5371ed8be202ad27fecc80d
2014-11-14 12:02:47 +00:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
5771bde234
Try to fix ambiguity error
...
Change-Id: I93cf7497e52d065d00f762f61f79a4e8f8609bfc
2014-11-07 16:54:58 +01:00
705c48d32e
fdo#38835 strip out OUString globals
...
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
cd6e6712a1
coverity#706543 uncaught exception
...
Change-Id: I65932932712dad87f8e21dcd09f477744cc33763
2014-11-04 19:52:51 +01:00
c70f1545e2
Removed duplicated includes
...
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-10-31 16:18:30 +00:00
8fbbb94a39
coverity#706537 Uncaught exception
...
Change-Id: I687948ef04e4ffdce51a7ac20854d6ebe96f1f25
2014-10-27 14:34:22 +00:00
e2548315bf
loplugin: cstylecast
...
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
2014-10-23 12:36:15 +02:00
ae218f4895
tweak CaughtException
...
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
2014-10-20 16:17:58 +01:00
66da64c748
Missing include
...
...and only use getCaughtException as first statement in catch block.
Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
2014-10-20 15:42:36 +02:00
9e8a88b6da
coverity#706540 Uncaught exception
...
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
2014-10-20 10:57:19 +01:00
4fd65ac329
coverity#706538 Uncaught exception
...
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
2014-10-20 10:57:18 +01:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
3b206d4818
forms: std::auto_ptr -> std::unique_ptr
...
Change-Id: Ia8f045715a508de77c8ce86cf224a3038162faac
2014-09-30 12:28:52 +02:00
0f8ed32913
fdo#39468 Translate German comments, clean some ws
...
Conflicts:
forms/source/component/FormComponent.cxx
forms/source/component/FormattedField.cxx
Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb
Reviewed-on: https://gerrit.libreoffice.org/11622
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-09-25 08:49:03 +00:00
0e55cc95df
fdo#39468 Translated German to English
...
Change-Id: I7405b8251b977f8e5c1b95c37fbab6ae6cb120e7
Reviewed-on: https://gerrit.libreoffice.org/11461
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-24 18:02:12 +00:00
778dcbc53e
fdo#39468 Translate German comments, clean some ws
...
Change-Id: I4a9b3b3e0d0fefb18808b0b045ffcf3531f4ea28
Reviewed-on: https://gerrit.libreoffice.org/11524
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-19 06:35:35 +00:00
7cd65eef14
Simplify expression to fix bool/sal_Bool ambiguity
...
Change-Id: I249262779519934c3dacc9df76028a994187e3d6
2014-09-15 15:52:30 +02:00
f5e617a6e4
forms: sal_Bool -> bool
...
Change-Id: If69785c37c6c9cd175e149f10bd5497de26a120c
2014-09-15 15:06:45 +02:00
57a4337e25
set names on a bunch more threads...
...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
26e9e22268
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: I79422149fd25b1531673a517e2a340dbeab43b1a
2014-08-25 13:03:08 +02:00
f7a65a1096
Remove useless include tools/debug.hxx from forms and extensions
...
Change-Id: Idc8ecbb65c7c4c63950d8b249e0d0d91788d6d3b
Reviewed-on: https://gerrit.libreoffice.org/11012
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2014-08-21 07:09:21 -05:00
150df3c020
star* -> css::*
...
Change-Id: I156d40badb1a11727d1320600a9d3af2b8b24e4a
2014-08-21 09:03:22 +02:00
892f4c2ad8
stario -> css::io
...
Change-Id: I4e82694399e72ce17172ac3d3c3cd9f9bcd30ba5
2014-08-21 09:03:17 +02:00
9d17726dcd
staruno -> css::uno
...
Change-Id: Ic82bbe5797d4f3c16096598cd566b917ee335a10
2014-08-21 09:03:16 +02:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
e50ef195bc
New loplugin:stringconcat
...
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
9489afdba6
rtl::Reference fits just fine here
...
Change-Id: Icb1ba7f7068f60c4bd5eda7002415214b3d885f3
2014-06-17 15:51:52 +02:00
