fe480d8136
remove unused typedefs
...
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-28 06:19:49 +00:00
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
58702f9a3c
Typo: syncro->synchro
...
Change-Id: I0a377f3686e0f8d8f576aacbee49a392b039d3a5
2015-01-24 18:53:37 +01:00
d2ac4c3e68
'Ownership' is one word, as is 'relationship'
...
Change-Id: I45c441f68ed5f20cfc87e34e7bfb529a30952f81
2015-01-23 16:23:26 +02:00
1dbc6d05de
Resolves: fdo#87636 New button not clickable when Templates preselected
...
regression from
commit 57207cab004cb78c3fa6d9ed43cc4bf81f4e6981
Author: Ariel Constenla-Haile <arielch@apache.org >
Date: Tue May 28 10:01:32 2013 +0000
Add missing copy&paste of SfxAppToolBoxControl_Impl::Select
(cherry picked from commit 47204c74d9e52f54f6983af19b66af2a96b42e61)
Conflicts:
framework/inc/uielement/popuptoolbarcontroller.hxx
svtools/inc/svtools/toolboxcontroller.hxx
The menu shown in the ui is a copy of a menu. The original menu has UserData
set on it which contains the target for the command, but the copy doesn't, so
looking up the target always fails and ses the "_default" frame and not the
correct "_self" required for the template menu
Change-Id: Ic1887467bf15f081d27286bd284929c17a2b19ad
2015-01-21 14:49:41 +00:00
d69fb68f30
Some more loplugin:cstylecast: framework
...
Change-Id: Iebd80b596bcc1f740ff9f3b0f168472144cacbed
2015-01-20 09:06:48 +01:00
06983ef3c0
do TODO: replace ImplCallEventListeners() by CallEventListeners() in vcl
...
Change-Id: If47baad0ec31f18fcb55c7db86fb2a316dd0807f
2015-01-14 20:30:08 +00:00
a7d1292194
java: remove some dead properties
...
Change-Id: I96adb2941c483ec08c752f35e35cf9ceb941971d
2015-01-13 08:42:56 +02:00
7e1dfc0928
java: inline the CheckAPI properties
...
no need to make this configurable
Change-Id: I0ab149317f4660fc7ebc4c43342d20a386bdbc5f
2015-01-13 08:42:56 +02:00
c55f945e4b
java: move DEFAULT_SHORT_WAIT_MS to util.utils
...
so I can turn PopertyNames into an enum
Change-Id: I939a83c0962813302a3653e75976147b2300cb18
2015-01-13 08:42:55 +02:00
5333782d09
convert SETTINGS_ #defines to 'enum class'
...
and dump the ones that nothing is listening to
Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12 12:57:05 +02:00
a5b5ad9f93
fdo#84938: replace DATACHANGED_ constants with 'enum class'
...
and drop DATACHANGED_DATETIME because no-one is using it
Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-12 12:57:04 +02:00
09330056a0
java: simplify sleeping and waiting in tests
...
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-12 08:36:17 +02:00
4bf4e3d407
java: no need to instantiate the AccessibilityTools object
...
since all of it's methods and fields are static.
Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
2015-01-12 08:36:17 +02:00
3757c03fc8
java: simplify array creation
...
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-09 15:10:51 +02:00
2f69e16c72
override the overloading of "overload" to decrease cognitive (over-)load
...
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
45ec1d9b56
brute-force find-and-remove of unused #define constants.
...
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
2c71f38301
fdo#75757: Remove inheritance from std::vector.
...
In framework/inc/stdtypes.h. class OUStringList.
Removed inheritance and separated additional functionality into more general
functions. Changed to using std::vector<OUString> rather than SequenceAsVector.
The functions now work for any vector. Although they could be made more general
and support any container by altering the arguments.
Change-Id: I472267029dc69da1ad0a98d55e26e3784f6b07cd
Reviewed-on: https://gerrit.libreoffice.org/13612
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-01-07 15:47:42 +00:00
8ab4d2f29f
drop crashrep unused since start of LibreOffice
...
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-01-07 11:41:32 +00:00
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
9fd89a5952
fdo#39440 reduce scope of local variables
...
Beside scope changes, it fixes lack of initialization in a few places.
Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2
Reviewed-on: https://gerrit.libreoffice.org/13755
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-07 06:47:04 +00:00
8e94c40f13
how about scope
...
Change-Id: I4c9e5f754974b6726fc86bc87775ba81832b3984
2015-01-06 11:59:53 +01:00
549b7fad48
workaround a weird gcc optimization werror bug
...
gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1)
framework/source/fwe/classes/addonsoptions.cxx: In member function ‘void framework::AddonsOptions_Impl::ReadAndAssociateImages(const rtl::OUString&, const rtl::OUString&)’:
framework/source/fwe/classes/addonsoptions.cxx:267:16: error: array subscript is above array bounds [-Werror=array-bounds]
struct ImageEntry
^
The combination of aScaled[2]; aImage[2]; aURL[2] in sequence apparently lead
to some overoptimization and/or alignment problem, already declaring aImage[3]
helped (but not aScaled[3]), but that's not what we want.
Change-Id: I82e28d4887ab8072a17d0a9341d322c1cf61aedc
2015-01-06 11:40:23 +01:00
bae855e667
fdo#84938: replace BUTTONTYPE_ constants with 'enum class'
...
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-06 10:59:40 +02:00
566f16a2fd
java: unnecessary imports
...
found by CodePro
Change-Id: If1b75e43f81d70984422e437147048a491395b66
2015-01-05 10:15:13 +02:00
10039462df
java: remove more dead code
...
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05 09:59:03 +02:00
46540d08b1
java: these fields can become local variables
...
found by PMD
Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05 08:23:30 +02:00
43cc8ad33e
java: remove dead code
...
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
fd1372ba8b
boost::unordered_map->std::unordered_map
...
you can get debug stl this way
Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
8a009858aa
Adjust the statusbar item widths according to HiDPI scaling factor
...
Change-Id: Id697b3b799c7437d937de6534edf88083e5c4dfd
2014-12-26 20:42:12 +09:00
2d82619a52
java: static fields that should not be static
...
Found by FindBugs.
Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-19 10:41:58 +02:00
cba3956750
java: this does not need to be a Thread
...
It is just being used as a Runnable
Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
2014-12-19 10:41:54 +02:00
b98352996c
framework: Use appropriate OUString functions on string constants
...
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
2014-12-18 14:12:22 +01:00
38b8c1e880
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I57f336c6ab3c418eac82397edeadecb4c1b168a7
Reviewed-on: https://gerrit.libreoffice.org/13495
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-12-16 20:42:30 +00:00
b733f5c4f4
framework: Use appropriate OUString functions on string constants
...
Change-Id: I72bb5ff2ab8a55061072fde567fcc1c4a8e20a2f
2014-12-12 17:52:18 +01:00
7557f23b31
java: reduce visibility of fields and methods
...
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-11 06:09:03 +00:00
ffffc526e3
java: remove comment noise
...
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-10 08:06:38 +00:00
9adb820158
java: simplify the getMSF() methods
...
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-10 08:04:58 +00:00
1367e4b2af
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:35:09 +00:00
439c8eba11
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:35:07 +00:00
e4200feb14
changed timers to idle
...
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09 12:35:06 +00:00
f0a6ec25d0
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:35:03 +00:00
9f3e3923d7
changed timers to idle
...
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09 12:35:03 +00:00
d1684e16b5
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:35:03 +00:00
9cc2a28323
framework: avoid double-free in ToolBarManager()
...
The timer could run after the ToolBarManager is deleted because the
dispose() method can accidentally restart the timer somehow.
Change-Id: I86868f08f436976761e814d4cea1cd5a0e348935
2014-12-09 12:35:01 +00:00
e5f67b2e94
changed timers to idle
...
Change-Id: I05ccb8bd73070462edcc911956859aa7967b5901
2014-12-09 12:34:57 +00:00
85efe9c2f0
fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxx
...
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46
Reviewed-on: https://gerrit.libreoffice.org/12195
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-12-09 12:34:56 +00:00
18102201f4
changed some timer to idle
...
Change-Id: If137dbd80f7260d9507e48709d3f0f14b60a25f6
2014-12-09 12:34:51 +00:00
eae0dda3e2
Resolves: fdo#86820 executing toolbar menu entry can destroy menu
...
Change-Id: Ide0ea8f8ff145d487e409b0091918b59f1f83405
2014-12-08 12:11:18 +00:00
16e1fbb9aa
Avoid automatic toolbars in the non-desktop case
...
Change-Id: I9e5bff735b0035c147e10ae066da3a4873d66749
2014-12-04 23:04:24 +01:00
