b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
6347df7af9
coverity#1266458 Argument cannot be negative
...
and
coverity#1266464 Argument cannot be negative
Change-Id: I27fb7789cd37046fcdaeaaa801d6dc0547a8afa1
2015-01-25 21:25:26 +00:00
2880dfe301
Some more loplugin:cstylecast: xmlsecurity
...
Change-Id: Iceaeefc26fec2643d3fbb916ab7719a918beb496
2015-01-20 09:06:54 +01:00
bfe79b50bc
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-19 08:39:32 +00:00
07e84cae98
Fix typo comments Resouce->Resource
...
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2
Reviewed-on: https://gerrit.libreoffice.org/13985
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-19 06:13:25 +00:00
c32a5a3b8e
simplify Date/Time/DateTime conversion code
...
add constructors to Date/DateTime/Time,
that take the css::util counterparts,
to simplify code converting between these type
Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7
Reviewed-on: https://gerrit.libreoffice.org/13855
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
2015-01-13 15:24:04 +00:00
45ec1d9b56
brute-force find-and-remove of unused #define constants.
...
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
7f8f277b94
fdo#84938: convert STREAM_ #defines to 'enum class'
...
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
43cc8ad33e
java: remove dead code
...
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
8d487ceba1
xmlsecurity: Use appropriate OUString functions on string constants
...
Change-Id: I18370f6203455cf7568e48e49b7093d114656619
2014-12-18 14:12:39 +01:00
2f925e8590
xmlsecurity: HIG fixes
...
Change-Id: I1472a6b23d0dc3fa9047bf197e9330c06c82f544
Reviewed-on: https://gerrit.libreoffice.org/13328
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-12-09 09:18:30 +00:00
147ff66242
Typo "mehtod" -> "method"
...
Change-Id: I49f3f59c76bd4dd078f7014b6a0450241214db7f
2014-12-08 11:11:43 +01:00
71c58fce69
Bin noise comments
...
Change-Id: I084040ff90ee30aa83ac5d3ad11365768272ec65
2014-12-04 16:59:19 +02:00
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
0c0e3e7539
Fixed typos. No automatic tools (sed, and so on).
...
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-10-30 17:16:02 +00:00
0371a63365
remove unnecessary 'using namespace rtl' declarations
...
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-29 11:28:54 +00:00
0048a11521
coverity#982248 Unchecked return value
...
Change-Id: Ice8c1b3eab28fc8ef27d802f64b7dd90a0614e42
2014-10-20 10:57:17 +01:00
fb7b1f45f9
loplugin: cstylecast
...
Change-Id: I96a0d5d7ec3363076b0165f3c540c51ef01b58f3
2014-10-15 13:57:08 +02:00
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
addf55184a
loplugin: cstylecast
...
Change-Id: I37d7c3e59f1debbee8d92e76f4d08fff773000b3
2014-10-06 07:52:55 +02:00
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
83636d2c09
java: when rethrowing exceptions, store the original cause
...
so that we get a nice complete stacktrace when it hits the final
handler
Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-25 13:47:25 +02:00
827c46e7d7
fdo#82577: Handle Window
...
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
60e78fbb80
fdo#82577: Handle Font
...
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.
Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-18 08:54:37 +02:00
481cd6368b
Related #82088 : removed last css aliases in hxx
...
* Only unfixed header namespace alias in
ConnectionLog.hxx:
LogLevel = ::com::sun:⭐ :logging::LogLevel
Change-Id: I48c941a4762830f2265c8241f4c1695a43ec891a
Reviewed-on: https://gerrit.libreoffice.org/11333
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-09-08 03:02:57 -05:00
9fb82a17b1
Fix emacs modeline.
...
Change-Id: I56aa8c6e5da4d682a932af4e57404a870c13c231
2014-09-05 10:30:01 +02:00
62962557ba
coverity#1215310 Uncaught exception
...
Change-Id: Ie08163875b1190532b9892c60829bb0ade56cbd7
2014-09-02 12:14:47 +01:00
7bac68d79e
Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
...
Change-Id: Id03c16337cb637c7f63fb789697c8bceec905bda
2014-08-28 16:17:35 +02:00
5f07347061
convert RID_XMLSECWB_NO_MOZILLA_PROFILE to MessageDialog + string
...
Change-Id: I7e02dc9db8c6a3195a4b2adccea3d0f4e260c661
2014-08-25 16:45:30 +01:00
b13936abe9
QueryBox MSG_XMLSECDLG_QUERY_REMOVEDOCSIGNBEFORESIGN -> MessageDialog + string
...
Change-Id: I9dcbc271dac9a2395bf2a7adb160c965627a0277
2014-08-22 08:54:32 +01:00
4b4bff3402
java: no need to instantiate String objects directly
...
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
0771823d80
fix build
...
Change-Id: If2f35d4ce68f604db1789e1535c341908628838d
2014-08-16 00:52:41 +02:00
0494f0029f
ErrorBox RID_XMLSECDLG_OLD_ODF_FORMAT to String
...
Change-Id: I474efcf128b990d148584292422cefa71a3c3c76
2014-08-15 23:30:19 +02:00
8848f4e8c2
xmlsecurity: remove NSS cert.h from PCH
...
nssrenam.h is another horror...
Change-Id: I166ac2ab1414e89d5cd4beae543670fdfa389adb
2014-08-14 18:55:18 +02:00
13d4f7b800
Grid and separarate "valid from/to" for CertificateViewer
...
Change-Id: I32661d0ec57c9f855806a44349d20c8fe651f293
2014-08-12 18:25:24 +02:00
3442b004e6
Now that we build NSS, we can build libxmlsec and libxsec_xmlsec for iOS, too
...
Change-Id: I65ab8aad0744a2aa254fefc7732cd8130bb249fb
2014-08-12 17:03:31 +03:00
595e446aff
Get rid of xmlsec_trace() and use SAL_INFO("xmlsecurity.xmlsec")
...
Change-Id: I3e1db89de2019285ce313f9bae1375a5b82f6383
2014-08-12 17:02:15 +03:00
d24df3fc66
callcatcher: another round of ResId removals
...
Change-Id: Ia3acdb3501b7735820258cb090e731f5814bc07f
2014-08-12 09:02:03 +01:00
e1683c2d13
callcatcher: update unused code
...
lots of ResID stuff going away now
Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
ffa78fe20d
xmlsec: clean up resource file dialogs.hrc
...
now unused after ui conversion
Change-Id: Ic3e4f9fdd3f84c3890c6d9a33c11e372ab5b3bd0
2014-08-09 18:12:05 +02:00
b6da6a887a
WaE: unused function 'ShinkToFit'
...
Change-Id: I01643b7f121dcafaf3cba3bb43d7339855f25d8d
2014-08-09 08:24:22 +02:00
ab1892d0cd
Converted RID_XMLSECTP_GENERAL to Widget Layout.
...
Change-Id: I52a7f857715dc9cba7aa7748cea5b30b91ed9011
Reviewed-on: https://gerrit.libreoffice.org/10842
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-09 06:14:10 +00:00
e7a474b29a
java: remove unused variables
...
Change-Id: I1b04fbf4d4562ff8e74f6ccdb2fd989d79cc869b
2014-08-08 09:48:16 +02:00
f124688cfd
java: remove various unused variables
...
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-08-05 11:31:49 +02:00
5717de74f5
create OUString from literal
...
Change-Id: I8198fbad20daa7262e42a452c8d81fcfa3331680
2014-08-04 15:59:06 +02:00
ec960ba032
remove unused resource id
...
leftover from e2b0e7571a8b082a2cb532e34b9770060128452b
Change-Id: I1e2e634e6cdfbc81f5d068136c9099de170dc1ef
2014-08-04 15:59:05 +02:00
a246cad28a
Delete RID_XMLSECTP_MACROWARN dialog
...
I deleted unused RID_XMLSECTP_MACROWARN and MacroWarning class.
Change-Id: Iaf0a99eae53b08a8a8869696ba19ae2023ede52a
Reviewed-on: https://gerrit.libreoffice.org/10718
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-04 12:08:08 +00:00
