wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
366,505 Commits 5 Branches 0 Tags
7d70efaac360dbbd9bea2d51b1ae53b577fc6559
Commit Graph

824 Commits

Author SHA1 Message Date
Stephan Bergmann
898c414700 basic: Use appropriate OUString functions on string constants 
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
 2014-12-12 10:21:45 +01:00
Michael Weghorn
93124f7710 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Ic4bf3bd8f5982d2ea2f25a28c0dd61084c59af11
Reviewed-on: https://gerrit.libreoffice.org/13331
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-12-06 14:12:31 +00:00
David Ostrovsky
e6e51a0a90 Add missing include header 
Change-Id: I59d6f1401cdfc37c0949cc9d439cb7ff52857079
Reviewed-on: https://gerrit.libreoffice.org/13286
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2014-12-03 08:04:05 +00:00
Caolán McNamara
ecc56da366 busted loop condition 
regression from

commit 119873328acd70ca3569c21a0b1fe36277e8bf4c
Date:   Thu Oct 21 15:34:02 2010 -0500
    convert vos/process.hxx and related API

Change-Id: I36527a4f0109105b9853a79773b4c92f9bc4e902
 2014-11-21 11:55:11 +00:00
Caolán McNamara
ef076fa1c1 coverity#1255390 Resource leak 
Change-Id: I3631d6bbcf45986deb1e911fcdb0e6606a0c6d91
 2014-11-21 11:55:10 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Michael Stahl
e815987104 vcl: move the Impl class of MapMode ...uhm... out of the public header? 
And remove the tools/fract.hxx include.

grep -l -r fract.hxx workdir/Dep/*Object* |wc -l
before: 4569
after:  1851

Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3:
libvcllo.so by 473k (0.35%)
libswlo.so by ~1Mb (sadly that is just 0.2%)

Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
 2014-11-14 01:08:47 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Caolán McNamara
cb0e009a9e document array_vs_singleton dismissals 
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
 2014-10-30 10:10:09 +00:00
Michael Stahl
51906611ab basic: move SbxAppData to a BasicDLL member 
... so it is deleted by ~SfxApplication.

Change-Id: I161bd92eb9b5082d1fdeea603921d0372a4d97e6
 2014-10-23 21:30:45 +02:00
Michael Stahl
a7498603d8 basic: pimplify that 
Change-Id: I0abe66ded0fd69a2720ad64e1a1426aafc7dfffb
 2014-10-23 21:30:45 +02:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip" 
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
 2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit" 
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
 2014-10-23 18:34:34 +02:00
Marcos Paulo de Souza
2e52086aa0 fdo#60689: replace SUPD variable 
Change-Id: Iad63330f8762b595ba5ee94fc20bc2c64ac92f6b
Reviewed-on: https://gerrit.libreoffice.org/11937
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2014-10-23 14:38:27 +00:00
Tor Lillqvist
9ecac3874d Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING 
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.

Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
 2014-10-22 09:30:23 +03:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit 
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
 2014-10-16 17:44:44 +02:00
Julien Nabet
4c12951a03 Typo: compatability->compatibility 
Change-Id: If0b98a30452a9d1fcc340173deb6856755926471
 2014-10-12 13:00:46 +02:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip 
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-09 11:33:33 +00:00
Caolán McNamara
8f436d3de7 use comphelper::rng::uniform_*_distribution everywhere 
and automatically seed from time on first use

coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand

Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
 2014-10-06 14:13:27 +01:00
Noel Grandin
c625525ddc rename SvRef::AddRef to AddFirstRef 
to make it's intended purpose clearly distinguishable from AddNextRef

Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-03 05:25:41 +00:00
Noel Grandin
059f5a95b2 loplugin: cstylecast 
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
 2014-10-02 07:37:19 +02:00
Noel Grandin
fa537124ac loplugin: cstylecast 
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
 2014-10-01 13:08:41 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Noel Grandin
4e26b91568 remove unnecessary casts in misc calls to SvStream.Write* 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ib80032e8626f5476a89b958f590441994594f4e4
 2014-09-26 15:27:18 +02:00
Noel Grandin
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
 2014-09-26 15:26:48 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Michael Meeks
234b5de79f vba: calm down bool -> long casting concerns. 
Change-Id: Ib32a66d891242701d2f5c55519e5c52a6dd3df3c
 2014-09-19 20:15:09 +01:00
Michael Meeks
01e14011e5 vba: add a different variant of the same compatibility function. 
Change-Id: I92bc1dbceea2f10cbb055d97f68b33e575d9be11
 2014-09-19 15:31:07 +01:00
Michael Meeks
19ee058a21 vba: initial impl. of compatibility methods. 
Change-Id: Iebc25f1730766e96d2ad6921a8b4d2ea880c63f3
 2014-09-19 15:31:06 +01:00
Noel Grandin
60e78fbb80 fdo#82577: Handle Font 
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
 2014-09-18 08:54:37 +02:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Michael Meeks
d718c1f65f coverity#1202729 - ensure we have exactly a one dimensional array. 
Change-Id: I6db8a2fb48ed7ce134a5c45c590c2ada0e19fc85
 2014-08-21 00:39:45 +01:00
Takeshi Abe
ea5ef0a72e Drop unused #includes 
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
 2014-07-24 01:06:15 +09:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Caolán McNamara
eb9b890bc9 DBG_ASSERT->assert when followed by dereference 
Change-Id: I9390228721df1b713d8cf2e719854b74d6b639c8
 2014-07-06 21:06:06 +01:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations 
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
 2014-06-27 15:27:39 +02:00
Caolán McNamara
daa6898578 clang: Dead initialization 
Change-Id: Ieae5303e55f21044ef8e91e63c4896696cfad51c
 2014-06-26 16:29:15 +01:00
Kohei Yoshida
e14abb13dc Use boost::optional to store alias name. 
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
 2014-06-25 15:03:46 -04:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall 
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
 2014-06-13 17:54:23 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Takeshi Abe
6a53ea218c Avoid possible memory leaks in case of exceptions 
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf
 2014-05-31 00:35:27 +09:00
Takeshi Abe
a71ae24a23 Avoid possible memory leaks in case of exceptions 
Change-Id: Iac63a5d60478e5cd8e2b77c889c7b312d3d15f67
 2014-05-29 09:29:15 +09:00
Thomas Arnhold
df466d79cb fdo#70474: Random number generation weak with Rnd in BASIC 
Just reuse the rng functionality. This improves the randomness.

Initialize seed with system time if no argument for RANDOMIZE is given. As the help text
states: "If Number is omitted, the generator uses the current value of the system timer".

Change-Id: I5fa46e8344b2402dff66a8db2449d43e2ca27d6d
Reviewed-on: https://gerrit.libreoffice.org/9349
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-17 12:40:58 +00:00
Julien Nabet
68741d0055 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13 
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
 2014-05-15 22:52:22 +02:00
Thomas Arnhold
4aa690c2e4 basic: use prewin.h 
Change-Id: I49b797b170b3fd74324eede9d3b6b6ec106e62e4
 2014-05-14 17:57:32 +02:00
Michaël Lefèvre
70e744b215 fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF 
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-05-12 11:32:38 +02:00
Thomas Arnhold
569ff6727e update_pch: add a bunch of pch files 
I had to fix some source files because of macro redefinitions and such stuff.

Small modules like basic have a great win, too:

make basic.clean && time make basic:

                with    w/o
                 pch    pch
accessibility    23s  1m59s
basctl           30s  1m42s
basic            56s  1m35s
comphelper       23s    51s
editeng          48s  2m04s
forms            40s  1m40s
unotools         19s    38s
sd             3m37s  4m33s

Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-09 19:50:42 +00:00
Thomas Arnhold
9e436082af dflt -> default 
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
 2014-05-06 07:19:09 +02:00