wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
366,505 Commits 5 Branches 0 Tags
7d70efaac360dbbd9bea2d51b1ae53b577fc6559
Commit Graph

2369 Commits

Author SHA1 Message Date
Michael Weghorn
afb5143639 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762
Reviewed-on: https://gerrit.libreoffice.org/13494
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-17 07:31:17 +00:00
Stephan Bergmann
0c1b8516cb forms: Use appropriate OUString functions on string constants 
Change-Id: I196e847e2f63d1bac6ed0f520cba67508aec1a5d
 2014-12-15 10:12:09 +01:00
Tobias Madl
ea6399b837 changed timers to idles 
Change-Id: Ic0d7730f7880dfe2e83c84e773b8cc420249b269
 2014-12-09 12:34:57 +00:00
Tobias Madl
14596452e7 fdo#84938: replace EVENT_ constants with enum 
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-01 07:43:31 +00:00
Matúš Kukan
09186fceb0 unotools: Internalize ucblockbytes.hxx header 
Change-Id: I1a9b795eda832673a83a426c8bf10d5bb9c28581
 2014-11-24 23:14:54 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Caolán McNamara
275eb9c78e coverity#706540 Uncaught exception 
Change-Id: I9dabd74824ec7cffe5371ed8be202ad27fecc80d
 2014-11-14 12:02:47 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Stephan Bergmann
2a68ed19e8 Revert "Some SvxFontHeightItem clean-up" 
This reverts commit d5f93eb47ec4c27e93ad908b0199790c702491a0,
SvxFontHeightItem::SetProp was used to override "dummy" 100% nProp/ePropUnit
values that did not match the computed nHeight value with nProp/ePropUnit values
that are supposed to match the computed nHeight value.  Yuck.

Change-Id: Ic12e824054b3c5da7aca766b9b3eb076d1837d9a
 2014-11-11 19:51:22 +01:00
Stephan Bergmann
d5f93eb47e Some SvxFontHeightItem clean-up 
...and operator= shall probably copy rSize.ePropUnit...

Change-Id: I112c02b3a3b2ce23f3d03f03881136e05be29017
 2014-11-11 18:39:20 +01:00
Zolnai Tamás
5771bde234 Try to fix ambiguity error 
Change-Id: I93cf7497e52d065d00f762f61f79a4e8f8609bfc
 2014-11-07 16:54:58 +01:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Noel Grandin
5f15cc01b3 new loplugin: use more efficient find() methods 
(Original idea from Kendy)
Look for code that is calling std::find on a sorted container
(set/map/vector) and warn about it - the code should be using
the find method on the container itself, since that is considerably faster.

Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
 2014-11-05 15:59:23 +02:00
Noel Grandin
3c58f07680 fdo#84938: replace TOOLBOXITEM_ constants with enum 
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6
Reviewed-on: https://gerrit.libreoffice.org/12258
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-05 06:45:07 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
David Tardon
cd6e6712a1 coverity#706543 uncaught exception 
Change-Id: I65932932712dad87f8e21dcd09f477744cc33763
 2014-11-04 19:52:51 +01:00
Andrea Gelmini
c70f1545e2 Removed duplicated includes 
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-10-31 16:18:30 +00:00
Caolán McNamara
8fbbb94a39 coverity#706537 Uncaught exception 
Change-Id: I687948ef04e4ffdce51a7ac20854d6ebe96f1f25
 2014-10-27 14:34:22 +00:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip" 
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
 2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit" 
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
 2014-10-23 18:34:34 +02:00
Noel Grandin
e2548315bf loplugin: cstylecast 
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
 2014-10-23 12:36:15 +02:00
Noel Grandin
182fc4f184 fdo#84938: replace WINDOW_BORDER constants with enum 
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
 2014-10-21 09:06:40 +02:00
Caolán McNamara
ae218f4895 tweak CaughtException 
Change-Id: If5aac87876b139bfb394ec124136de131c3518ae
 2014-10-20 16:17:58 +01:00
Stephan Bergmann
66da64c748 Missing include 
...and only use getCaughtException as first statement in catch block.

Change-Id: Idcac073896b84fd2671b52b2315f454651dbf910
 2014-10-20 15:42:36 +02:00
Caolán McNamara
9e8a88b6da coverity#706540 Uncaught exception 
Change-Id: I175050b5ab66f4eeaa658f0aab1739b175d38d51
 2014-10-20 10:57:19 +01:00
Caolán McNamara
4fd65ac329 coverity#706538 Uncaught exception 
Change-Id: If23396c545e7add653fa9e5ac6e544aaa794120d
 2014-10-20 10:57:18 +01:00
Noel Grandin
67c9d05451 fdo#84938: replace TIB_ constants with enum 
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-20 07:16:46 +00:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit 
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
 2014-10-16 17:44:44 +02:00
Noel Grandin
af5ebbf783 create a macro library for implementing bit-flags types 
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>,
changed from a macro- to a template-based solution.  (Unfortunately MSVC 2012
does not support explicit conversion operators.  Worked around that with
explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and
SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a
baseline that requires unconditional support for them.)

Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
 2014-10-13 17:45:57 +02:00
Noel Grandin
cb7ede2d99 convert vcl StateChangedType to enum class 
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f
Reviewed-on: https://gerrit.libreoffice.org/11843
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-11 15:14:32 +00:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip 
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2014-10-09 11:33:33 +00:00
Eike Rathke
04a810cee4 back out more wrong and confusing tools::Time comment changes 
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script
to change all ...

Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
 2014-10-08 14:24:21 +02:00
Philipp Weissenbacher
0658889bcd fdo#39468 Make forms/ German comments clean 
Change-Id: Iec24928324bec1caee65ca37cbf0fb5b66e6975e
Reviewed-on: https://gerrit.libreoffice.org/11760
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-02 11:38:29 +00:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Stephan Bergmann
3b206d4818 forms: std::auto_ptr -> std::unique_ptr 
Change-Id: Ia8f045715a508de77c8ce86cf224a3038162faac
 2014-09-30 12:28:52 +02:00
Philipp Weissenbacher
0f8ed32913 fdo#39468 Translate German comments, clean some ws 
Conflicts:
	forms/source/component/FormComponent.cxx
	forms/source/component/FormattedField.cxx

Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb
Reviewed-on: https://gerrit.libreoffice.org/11622
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-09-25 08:49:03 +00:00
Tobias Madl
0e55cc95df fdo#39468 Translated German to English 
Change-Id: I7405b8251b977f8e5c1b95c37fbab6ae6cb120e7
Reviewed-on: https://gerrit.libreoffice.org/11461
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-09-24 18:02:12 +00:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Philipp Weissenbacher
778dcbc53e fdo#39468 Translate German comments, clean some ws 
Change-Id: I4a9b3b3e0d0fefb18808b0b045ffcf3531f4ea28
Reviewed-on: https://gerrit.libreoffice.org/11524
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-09-19 06:35:35 +00:00
Noel Grandin
60e78fbb80 fdo#82577: Handle Font 
Put the VCL Font class in the vcl namespace. Avoids clash with the X11
Font typedef.

Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
 2014-09-18 08:54:37 +02:00
Stephan Bergmann
7cd65eef14 Simplify expression to fix bool/sal_Bool ambiguity 
Change-Id: I249262779519934c3dacc9df76028a994187e3d6
 2014-09-15 15:52:30 +02:00
Stephan Bergmann
f5e617a6e4 forms: sal_Bool -> bool 
Change-Id: If69785c37c6c9cd175e149f10bd5497de26a120c
 2014-09-15 15:06:45 +02:00
Stephan Bergmann
8270808946 Mark template member fns that are supposed to override as SAL_OVERRIDE 
Change-Id: If940dcf7f7d2144576b4ae55578b8b7bd113295b
 2014-09-15 14:58:57 +02:00
Jennifer Liebel
86aed3ca6a fdo#39468: Translated German to English 
Change-Id: Ica935c641d3858ae875410efc7fe531835feadf8
Reviewed-on: https://gerrit.libreoffice.org/11373
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-09-12 12:09:24 +00:00
Stephan Bergmann
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration 
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2014-09-12 06:08:32 +00:00
Stephan Bergmann
ce65d21ddb Replace uses of old SFX_ITEM_ON alias with SFX_ITEM_SET 
Change-Id: I64be7ca711dcd3ea7c4d5840a30f2f701d055e1b
 2014-09-10 16:37:20 +02:00